From nobody Sat Apr 11 18:36:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1775676669; cv=none; d=zohomail.com; s=zohoarc; b=DEhxB5/sIjnUaNxn0zWAhat9ERIaxIAYGBiIo4gc8XR8S1uuVzTMRw8zQSg2phQpvPN/FoQGzeofRCkqh5KNFBsZPW2IKZAeVcEk60uRAtvS8K3odv9vqwdX33ogxVkjPEYapna2dE69CrRLpOmc0nvpWnQu/5bmPg88F7Me8MA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775676669; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oP/1GRjBSCthp+KAd33rcbtQgDmB+jnc/jSoYFA5Kjg=; b=h3sEV66DjzIEp2SwWvT87kA38IqMZ7vxaGdNo24fprjUCKc4x/jInVuK69ObZE9g13Csh12vQKxjkQNozVGvnIHZ7J+S6At/2DGUhJkR5fmdjd1m0v23LL+fKBznquojExC2GJrcpEV76WYMUhxSQEjHiH+LNxC5xJ1F2G3ZWBw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775676669429899.8977229520705; Wed, 8 Apr 2026 12:31:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAYW7-00068q-EV; Wed, 08 Apr 2026 15:24:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAY6s-0007Gt-VK for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:58:42 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wAHnG-0006Vh-O6 for qemu-devel@nongnu.org; Tue, 07 Apr 2026 21:33:25 -0400 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-3590042fa8eso4034483a91.1 for ; Tue, 07 Apr 2026 18:33:21 -0700 (PDT) Received: from stoup.. (124-150-69-109.tpgi.com.au. [124.150.69.109]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2745c480dsm238277395ad.0.2026.04.07.18.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 18:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775611999; x=1776216799; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oP/1GRjBSCthp+KAd33rcbtQgDmB+jnc/jSoYFA5Kjg=; b=VNx47wmbY0xkin4whYLB/Fs6KNwwAJFnz1IV4/ikKXPctmRRft81Lwt+BNAYzdG9eb E7z+yiqMwOPsCNmjVJluCLXIKAX9E2MdM+ocL5uLpJvrM5NEhhIIr5kB15g+Qd9Lbmbu trzP4fswoagntO+S6PN4+k7iSpk32oWiLKugR+I3kj99HB2HKCJnfaME4hQNUHeGoGgd W+uRFDDQJ4+liqB1csxihkvRMCtUhWrKHvhAdNjNYJNEbPuIvz7ew/iEaRYDclFHSdtc ampZJPiO3yucLis0ENKCN75+ygGhAKUQ7BEDzXAxg1s6eJSGq0td3itQTvCUkvGRDn1D lqkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775611999; x=1776216799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oP/1GRjBSCthp+KAd33rcbtQgDmB+jnc/jSoYFA5Kjg=; b=Q6F8TzxbBDdPpyDHoU0PKLBaSd9g3SAb4L9Tgf3QwZ+oBjSD45MW/WVeNhKLqbgNSY g19JmVsLQJA6heicd3FXE7Ye+BN9xPJO9GaFZpSwvOSI7rHZdWtg4w85tB2t7kB6xBD3 SHDMp1k1lmXAo2+itnk+7npE/zlxPrnB0PoNKB4TReGJdGMsFQIq+xqd5C5a6oruWr10 cjm3Aw8/hWeTQUPxDZlMOH02CwMums5WTvjBRH6yi4jkTr4o1xwWRm9b21yZLy4T9OMc lzJxkh4iXSDeKVWAPLLtRthkmXOqU+EasaaNDFAzU1PC/igCrOFHGWXrvXgro6gi+vlW 72fA== X-Gm-Message-State: AOJu0YxkY4tPcu/BBwCIRqcpPG00QdwAmfg3y8DsHXDbT1WB1g9IUfOb XwIbpodrdyqitnpH2KzHDteA/8NviZvcP+hXIZZCVWTQje+Jw6ktPWUxHLPDOUE9lZUI82jHdq+ PzX9lMEc= X-Gm-Gg: AeBDietN/5zdvdV1wpG4gcHAZ1Cj5gaA6jhySrKqhTdwMc0bwYVJ1UvmrWWxPR3EP/w FBzbAe6pZEsL/RziDGeNvQLOipNzbuap2kam+4wRS4VngxMZ6KwK1jBaWuAu1X+c1kxQ5hZPf/Q rWoMprJ9EgTBbQ96OBMwLEC1dsOiQZTbGh4yeOtxkKUnCqOlO3CFFl74hVCw0LZtKDWWJId11uR izlY3ajPH/bhvVamN2weyPEmEmirhsTekYSYPA1htfNJWZkTQQt/tlbmSJX5I4s9EArdJq5ROn/ g/hirhyDlPdNLOr5kLpQnfaL2mv6CMQIp69xWew6oXzVvdOodXAqvWpk6hgcTWMvTlE42adWDxY +OCWWgYy5trkSHZhJuGRJ1opwrUtKmW+P11u1JlExwzLsELEcYWvxXxd/VkGW1hy5n5EC1IsAP7 Y6wu/+gBY5KlIpQ+ErSTmZYZPz7+GZbbNp9doKisqQzYDSPF+dnt/fXidW X-Received: by 2002:a17:903:37ce:b0:2b2:481b:de5f with SMTP id d9443c01a7336-2b28163b27dmr196144595ad.5.1775611999145; Tue, 07 Apr 2026 18:33:19 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: pierrick.bouvier@linaro.org, qemu-arm@nongnu.org Subject: [PATCH 1/2] linux-user/arm: Improve get_user_code_u32 and usage Date: Wed, 8 Apr 2026 11:33:08 +1000 Message-ID: <20260408013309.56122-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260408013309.56122-1-richard.henderson@linaro.org> References: <20260408013309.56122-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1775676672514154100 Content-Type: text/plain; charset="utf-8" Force a little-endian load before applying SCTLR.B. Handle the BE32 swap correctly in thumb mode. This fixes a bug with its later usage in insn_is_linux_bkpt. Handle lock_user failure: in one case by simply falling back to the original SIGILL and the other by raising SIGSEGV. Signed-off-by: Richard Henderson Reviewed-by: Pierrick Bouvier Tested-by: Pierrick Bouvier --- linux-user/arm/cpu_loop.c | 64 ++++++++++++++++++++++++--------------- 1 file changed, 40 insertions(+), 24 deletions(-) diff --git a/linux-user/arm/cpu_loop.c b/linux-user/arm/cpu_loop.c index 19874f4c72..419136fdee 100644 --- a/linux-user/arm/cpu_loop.c +++ b/linux-user/arm/cpu_loop.c @@ -29,13 +29,34 @@ #include "user/page-protection.h" #include "target/arm/syndrome.h" =20 -#define get_user_code_u32(x, gaddr, env) \ - ({ abi_long __r =3D get_user_u32((x), (gaddr)); \ - if (!__r && bswap_code(arm_sctlr_b(env))) { \ - (x) =3D bswap32(x); \ - } \ - __r; \ - }) +static bool get_user_code_u32(uint32_t *ret, uint32_t va, CPUARMState *env) +{ + uint32_t insn, *hptr; + + hptr =3D lock_user(VERIFY_READ, va, sizeof(uint32_t), 1); + if (!hptr) { + *ret =3D 0; + return false; + } + + /* Load as little-endian by default. */ + __get_user_e(insn, hptr, le); + unlock_user(hptr, va, 0); + + /* + * Adjust the little-endian load for BE32 as required. + * In thumb mode, bswap both halfwords by bswap of word then + * swapping the halfwords again to restore the original order. + */ + if (arm_sctlr_b(env)) { + insn =3D bswap32(insn); + if (env->thumb) { + insn =3D hswap32(insn); + } + } + *ret =3D insn; + return true; +} =20 /* * Note that if we need to do data accesses here, they should do a @@ -271,7 +292,8 @@ void cpu_loop(CPUARMState *env) { CPUState *cs =3D env_cpu(env); int trapnr, si_signo, si_code; - unsigned int n, insn; + unsigned int n; + uint32_t insn; abi_ulong ret; =20 for(;;) { @@ -284,31 +306,23 @@ void cpu_loop(CPUARMState *env) case EXCP_UDEF: case EXCP_NOCP: case EXCP_INVSTATE: - { - uint32_t opcode; - - /* we handle the FPU emulation here, as Linux */ - /* we get the opcode */ - /* FIXME - what to do if get_user() fails? */ - get_user_code_u32(opcode, env->regs[15], env); - + /* we handle the FPU emulation here, as Linux */ + if (get_user_code_u32(&insn, env->regs[15], env)) { /* * The Linux kernel treats some UDF patterns specially * to use as breakpoints (instead of the architectural * bkpt insn). These should trigger a SIGTRAP rather * than SIGILL. */ - if (insn_is_linux_bkpt(opcode, env->thumb)) { + if (insn_is_linux_bkpt(insn, env->thumb)) { goto excp_debug; } =20 - if (!env->thumb && emulate_arm_fpa11(env, opcode)) { + if (!env->thumb && emulate_arm_fpa11(env, insn)) { break; } - - force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLOPN, - env->regs[15]); } + force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLOPN, env->regs[15= ]); break; case EXCP_SWI: { @@ -317,14 +331,12 @@ void cpu_loop(CPUARMState *env) if (env->thumb) { /* Thumb is always EABI style with syscall number in r= 7 */ n =3D env->regs[7]; - } else { + } else if (get_user_code_u32(&insn, env->regs[15] - 4, env= )) { /* * Equivalent of kernel CONFIG_OABI_COMPAT: read the * Arm SVC insn to extract the immediate, which is the * syscall number in OABI. */ - /* FIXME - what to do if get_user() fails? */ - get_user_code_u32(insn, env->regs[15] - 4, env); n =3D insn & 0xffffff; if (n =3D=3D 0) { /* zero immediate: EABI, syscall number in r7 */ @@ -340,6 +352,10 @@ void cpu_loop(CPUARMState *env) n ^=3D ARM_SYSCALL_BASE; env->eabi =3D false; } + } else { + /* Failed to re-load instruction. */ + force_sig_fault(TARGET_SIGSEGV, 0, env->regs[15] - 4); + break; } =20 if (n > ARM_NR_BASE) { --=20 2.43.0 From nobody Sat Apr 11 18:36:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1775673168; cv=none; d=zohomail.com; s=zohoarc; b=g/1AKW0S6ydaZEOJ3PoHRZIJMCJfgUoKXfs12iJaXdTxwK/slGo/1dTP11AMFJEzdcBgjG9WVVDC/Ak5rJ5Rjx1U/ZH0TD5HZfJlG2GJxmJFh2rduOstqsZM8mi6cPte1aWnWQlCiVCem/NzKXbvFUwh4+J7SmF4h7nJ1pElY9w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775673168; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iAhS4MlZiUixeL5RoVk+cyKrBGfLpW045m/lFXD5jrg=; b=Z2qgRD46jhpfwPj3TeqIJ7hrvMnzdcIUjvRp+NF+MH8zOwzKxEwoS6EopYuassCysTRPwg1uUQZNq9emJ1waEH8H7R40KI0VUBABSp4ftt9fvx53D+N6SKnxeZbn4xgKNIzfR/tKUeJs11lhVBx3Ek50kUYZXTQKPIKHyh0azXo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775673168693376.7650099540035; Wed, 8 Apr 2026 11:32:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAXhc-0000zA-Pc; Wed, 08 Apr 2026 14:32:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAXhH-0000Sx-Ur for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:32:17 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wAHnI-0006Ys-CC for qemu-devel@nongnu.org; Tue, 07 Apr 2026 21:33:25 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-2ad617d5b80so30553985ad.1 for ; Tue, 07 Apr 2026 18:33:23 -0700 (PDT) Received: from stoup.. (124-150-69-109.tpgi.com.au. [124.150.69.109]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2745c480dsm238277395ad.0.2026.04.07.18.33.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 18:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775612002; x=1776216802; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iAhS4MlZiUixeL5RoVk+cyKrBGfLpW045m/lFXD5jrg=; b=tV5OZ+l8A+p8T6BSUeeN22cD6OzurUz/xRfs+WSODX260JkqTgP6OTZrjR+NzeR/K1 zkmZznuUdmvM8BKJ1X2zjgMiobYi9/mDiqm0cu70bLNHgbGrcWl7weGKX4KH6/if3rUt 7VZf9HhBrAK8LuvX5I28rkNCSFS7kGd9BfZGWUTZ1hjhiC9hxGJVI2MgezpRWXmZVUcN pTg/ueoCXxv1ZsOVzSVs4qQ6o0M0X3KMxvp/VMSlAaP2iakq2Y5MtXUoSnZlWzdfI4Ho gq91RTV6HLc/fkFmJTQ55XKqF9hzMh0rEhe1nrGQbsCDHqybzFeU6p1sJbsyhcIu6th0 pvMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775612002; x=1776216802; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iAhS4MlZiUixeL5RoVk+cyKrBGfLpW045m/lFXD5jrg=; b=ETpq/0llz6/ytQjUnb6N4me0PHqIcmebQ/AgkHzTMf/UG349bonjN9Lw4nlNyz5Uxd WIt1/zAs9wgdkb1QTiATUqLy9HG5ZFwG+HFEJvrJeozZnGqDCc+wKKs09kkbLZYPjtsJ rHR7b5M14KLu71EuQZUt8HpRX6p96wiykcTcbJlz1kMVndsh7LdooG2wMZEZFookMuuo wwQ12N2ASXYVEHEhuZ/WOZF8LP4YTrr8ppK09AOIIXh4nUj073F2wM3M0UKQB1HUlv7e o8PLIJi7k5Un5gb52xyI0QRE0rvojmAHkPOk8g8KsNvn0RZ9OFryIx0UYHnHbhI8Xcw3 VXGw== X-Gm-Message-State: AOJu0YzIfXN7oSP1IRdk2xVGvPoPnQYJZ1QoPlkmTgANWWNpT0PUzW/8 170efS5L7yZe+Pgu0peRZ6uoXw8uqjd5m/dz/+Y+qeXReNBuJde1kEHIe1r1y0LtkyxXnbGbwAB mABYCfaU= X-Gm-Gg: AeBDietEhs1hY68q+cL2y9Xc5adwEI9Dw163LgaO6fVe5hbZ4RDaFCT3zQX6+MzkqSK F31+LrJdbvZ2TJnmEUK17IXu6mk0+rbuquy0wK8Q+7XAZ5tcIpCHWSYC2cO3KKrG/Boh5mhmR91 SSzxi2DWn5G6LgwZTuAFBj3gwwxLTfwjnk5R1GTL7CJ+lkJfMBz65nXx4FY9mYLEbCG3uk8n9gl rjl35RYJ9mwUIqPnX8VZ8wfMHJzkISPJNrCVtarcEGpLcDhshX/U/1rWdHTWx/rKixfIqetHMX9 oFudtAn9OGVACzD/aTbcvMXvkNOwDU19lFsNYI76u4JT6z8iEb4TyoMvIypIvSEMIqF5XM9mnzA RhzpZ9zuTyqf8qIxisgahr6S7COCD2kCHLI+k2ADEr7rS2iXGYkE3daVcMOYuZRTE+Ck6iRZeRW xDpRqGHmSNnV5QFe2aTQ+obj3rGbmnyT+Y5JAU9qG38GFswKd6fw+dsybA X-Received: by 2002:a17:903:3886:b0:2b0:c45a:bc2 with SMTP id d9443c01a7336-2b2816bd61fmr216591655ad.16.1775612001972; Tue, 07 Apr 2026 18:33:21 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: pierrick.bouvier@linaro.org, qemu-arm@nongnu.org Subject: [PATCH 2/2] target/arm: Remove bswap_code Date: Wed, 8 Apr 2026 11:33:09 +1000 Message-ID: <20260408013309.56122-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260408013309.56122-1-richard.henderson@linaro.org> References: <20260408013309.56122-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1775673170840158500 Content-Type: text/plain; charset="utf-8" This function is no loner used. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 657ff4ab20..917e9919e8 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -2568,22 +2568,6 @@ static inline int sme_vq(CPUARMState *env) return EX_TBFLAG_A64(env->hflags, SVL) + 1; } =20 -static inline bool bswap_code(bool sctlr_b) -{ -#ifdef CONFIG_USER_ONLY - /* BE8 (SCTLR.B =3D 0, TARGET_BIG_ENDIAN =3D 1) is mixed endian. - * The invalid combination SCTLR.B=3D1/CPSR.E=3D1/TARGET_BIG_ENDIAN=3D0 - * would also end up as a mixed-endian mode with BE code, LE data. - */ - return TARGET_BIG_ENDIAN ^ sctlr_b; -#else - /* All code access in ARM is little endian, and there are no loaders - * doing swaps that need to be reversed - */ - return 0; -#endif -} - enum { QEMU_PSCI_CONDUIT_DISABLED =3D 0, QEMU_PSCI_CONDUIT_SMC =3D 1, --=20 2.43.0