From nobody Sat Apr 11 18:34:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1775673714; cv=none; d=zohomail.com; s=zohoarc; b=ecqcTkaffH3AJLY/xfjLK7Vnx2tZOR0igYRTR2B6fq6P0DDVJN5W95IBmcHpFpQuJdUVCtclmM//3J7DUESyxS5ZSs+K0WvrzNz6Y9eTbfQ2wSJYnobwVxtjzazG6deBcVXIQ4ZSS0bix+yW3mfj3r2HNZQaxJOpUNg/DHECFv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775673714; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OoKaBti8hgHSAupQ577cwRGACYeQxonS3gqu7n3qfUM=; b=A9tal12UV9LIUyCQpq2ztnTaP/yzY96UC9sw+ncXUSo+fZyx/efxvRQyhcFHKtPxqn7PQx13DRybl7zF4iNVKPVMp88EEvlqHJHuexUP7Bbvlbta9fWpObh5WNe/SeIgWZQil7lwHRHi4xMmSdXu6MdZS8eK+D47/cRL9c1Un3M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 177567371447997.67785786408456; Wed, 8 Apr 2026 11:41:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAXqQ-0003on-6F; Wed, 08 Apr 2026 14:41:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAXqM-0003Pr-Gj for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:41:38 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wAERz-0005Tx-Ij for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:59:13 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso39642235e9.3 for ; Tue, 07 Apr 2026 14:59:10 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4889cb46adcsm353450785e9.4.2026.04.07.14.59.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 07 Apr 2026 14:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775599149; x=1776203949; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OoKaBti8hgHSAupQ577cwRGACYeQxonS3gqu7n3qfUM=; b=zDUs1UQvFkbX7V9ZTgxwfqGBJecJuRVrgO+4cWt/oHSbTO/Hh4Yn5EGob8aYO82th0 9TSFZ5j0IN7DhuN2/riEfEhiRbEF/DFVBaR489Q1K15d3eUOFQ7x6eeOAxfyIHNAUWXu Fz6g0/8OH/4BamHJQItwjzM0ww/+cMZpf952SiNTFEb3DN5EfGvCv89PwDMNdFanisvS UBwEZP4QRRZBAZ2NIgaKJpiUH+2yP63i+L/uf9NdVAFrlb+REJAE1fLH6dw6G5M9FDUD 6qu5CH3qDs7erTlflnN10BE9+USiQtpqjJbsLww1y3O2cIKmUjC3OT7zl1Ql9gFKrm19 iAjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775599149; x=1776203949; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OoKaBti8hgHSAupQ577cwRGACYeQxonS3gqu7n3qfUM=; b=P72yYIgMFvcytfSYD/CTJtmT74bXSDq1uFUEHyp+GTS0Yi0Wo0k4Kg+5PVNqe2hSxv DRYxA2QnbwGgosOhSuFWYtj0Nc5VpQjLibnfjJ1Kad/pNgcOlP8RSVud63lhEUI7ZpCi h6uJjOydAaXRysRdF6s1ibSfygAiy5fQnSiw8k7LwoWK6tQWAF0OUwmF949ASkzJFKoG 1YyMzCiOx6OpUIk/2nmGi4xfeXFC9MZp09H4zoLn+X+OAQ5b8DmGH1Tem5AvkgegZ31x jR/q3XfWZYzEaMgdIPDHbRqzF6RXr6M9jtRb4nGjQQir7s0Xg5WLZOfMm2aAvwFvyIcP ci7w== X-Gm-Message-State: AOJu0Yy5L5mRo5krSA4rA7ZfUsOvP/peUnVws1YNzGhWN8pGfAsjvQoe 8HL+wjHIrqAHNG5bZ+EsS7Hv5rEuZSbLV2CgFGJxPs1YtALC+qX6cUuxNmzkCFh9nT6wEBrCzcY z2j04CdA= X-Gm-Gg: AeBDiev7goc8n5APoT/oJOw6irSREFodYinJRzigQ3ta7UO0iRy32htibXzI5LUDRVd a/24TkRHoQXL/+S8P/uOwFIcPSrGivUb7sWvUETwCGZ5sJE1pqf6J3rv4LMZVzQmWaBLrApNvmG vB/ecpcnNe+7z7ReO6H+HCU8padPmX4cdoFhWMTTk95wPayLEuoKgFhk8ftSFsO7evVtsgOerbu Fb7fsL1pfQz1rwjUaY53nQqgTDozKym/afDFXguy27DLlqRwBkHznpMlLz+o8hXTNJ5+ubvtKdv pi+beK4b6lJlLoN981yKPOhWt/ymIqAu4XnVjhS48GfQx3UbeR+H3rmXhXmowUATS8kpUunZShk TgqNx45/seEfyvBYVRKo69K9jRluvmB4k3buKOAFY/c2eJdCXPVV70kUB163HfTGB6gD1ZtfSeN tZxPeqHyA1Q0GGYQ8UR0Yu4mEF/fEn/fKZE3MtyGDEf0b1r7MTkoaywps27qruZHAiHIOCKHHq0 AZOJV0MtR4= X-Received: by 2002:a05:600c:3b18:b0:488:90ac:8f71 with SMTP id 5b1f17b1804b1-488997152camr246008255e9.5.1775599149200; Tue, 07 Apr 2026 14:59:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jamin Lin , Pierrick Bouvier , Fabiano Rosas , Harsh Prateek Bora , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH-for-11.0 1/6] docs/about/removed-features: Replace 'since' -> 'removed in' Date: Tue, 7 Apr 2026 23:58:55 +0200 Message-ID: <20260407215900.63390-2-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407215900.63390-1-philmd@linaro.org> References: <20260407215900.63390-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1775673717323154100 We use "deprecated since ..." and "removed in ...". Replace "since" by "removed in" for removed features. Fixes: 762c8554394 ("vfio: Remove 'vfio-platform'") Fixes: aeb1a50d4a7 ("vfio: Remove 'vfio-amd-xgbe' device") Fixes: e50a021a451 ("hw/arm: Remove ast2700a0-evb machine") Fixes: 4af2433a81b ("docs: Mention 32-bit PPC host as removed") Fixes: 8ebc416ac17 ("vfio: Remove 'vfio-calxeda-xgmac' device") Fixes: a80151c9da1 ("hw/sd/sdcard: Remove support for spec v1.10") Fixes: 269ffaabc84 ("buildsys: Remove support for 32-bit MIPS hosts") Fixes: fc37c122fff ("migration: Drop deprecated QMP migrate argument @detac= h") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Peter Maydell Reviewed-by: Pierrick Bouvier Message-Id: <20260323151934.92880-1-philmd@linaro.org> --- docs/about/removed-features.rst | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index 557a24679a1..e75db084108 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -782,8 +782,8 @@ without reporting any destination threads, or non-multi= fd source threads). For debugging purpose, please use ``-name $VM,debug-threads=3Don`` instead. =20 -``migrate`` argument ``detach`` (since 11.0) -'''''''''''''''''''''''''''''''''''''''''''' +``migrate`` argument ``detach`` (removed in 11.0) +'''''''''''''''''''''''''''''''''''''''''''''''''' =20 This argument has always been ignored. =20 @@ -932,14 +932,14 @@ work around the atomicity issues in system mode by ru= nning all vCPUs in a single thread context; in user mode atomicity was simply broken. From 10.0, QEMU has disabled configuration of 64-bit guests on 32-bit host= s. =20 -32-bit MIPS (since 10.2) -'''''''''''''''''''''''' +32-bit MIPS (removed in 10.2) +''''''''''''''''''''''''''''' =20 Debian 12 "Bookworm" removed support for 32-bit MIPS, making it hard to maintain our cross-compilation CI tests of the architecture. =20 -32-bit PPC (since 10.2) -''''''''''''''''''''''' +32-bit PPC (removed in 10.2) +'''''''''''''''''''''''''''' =20 The QEMU project no longer supports 32-bit host builds. =20 @@ -1172,8 +1172,8 @@ Mips ``mipssim`` machine (removed in 10.2) Linux dropped support for this virtual machine type in kernel v3.7, and there was also no binary available online to use with that board. =20 -Arm ``ast2700a0-evb`` machine (since 11.0) -'''''''''''''''''''''''''''''''''''''''''' +Arm ``ast2700a0-evb`` machine (removed in 11.0) +''''''''''''''''''''''''''''''''''''''''''''''' =20 The ``ast2700a0-evb`` machine represents the first revision of the AST2700 and serves as the initial engineering sample rather than a production vers= ion. @@ -1290,8 +1290,8 @@ by using ``-machine graphics=3Doff``. =20 The 'pvrdma' device and the whole RDMA subsystem have been removed. =20 -``-device sd-card,spec_version=3D1`` (since 10.2) -''''''''''''''''''''''''''''''''''''''''''''''' +``-device sd-card,spec_version=3D1`` (removed in 10.2) +'''''''''''''''''''''''''''''''''''''''''''''''''''' =20 SD physical layer specification v2.00 supersedes the v1.10 one. =20 @@ -1396,21 +1396,21 @@ device driver such as RBD. VFIO devices ------------ =20 -``-device vfio-calxeda-xgmac`` (since 10.2) -''''''''''''''''''''''''''''''''''''''''''' +``-device vfio-calxeda-xgmac`` (removed in 10.2) +'''''''''''''''''''''''''''''''''''''''''''''''' The vfio-calxeda-xgmac device allows to assign a host Calxeda Highbank 10Gb XGMAC Ethernet controller device ("calxeda,hb-xgmac" compatibility string) to a guest. Calxeda HW has been ewasted now and there is no point keeping that device. =20 -``-device vfio-amd-xgbe`` (since 10.2) -'''''''''''''''''''''''''''''''''''''' +``-device vfio-amd-xgbe`` (removed in 10.2) +''''''''''''''''''''''''''''''''''''''''''' The vfio-amd-xgbe device allows to assign a host AMD 10GbE controller to a guest ("amd,xgbe-seattle-v1a" compatibility string). AMD "Seattle" is not supported anymore and there is no point keeping that device. =20 -``-device vfio-platform`` (since 10.2) -'''''''''''''''''''''''''''''''''''''' +``-device vfio-platform`` (removed in 10.2) +''''''''''''''''''''''''''''''''''''''''''' The vfio-platform device allows to assign a host platform device to a guest in a generic manner. Integrating a new device into the vfio-platform infrastructure requires some adaptation at --=20 2.53.0 From nobody Sat Apr 11 18:34:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1775675510; cv=none; d=zohomail.com; s=zohoarc; b=JbRufKbqAba0i3o/KzaXgi+G5oSvi+x9iZAmXgJ3TaG+Hssa/PgdlaF5kA2lc41vrR9NBH7Eg7YZ9a9pLXpu6+BxlZUqOMrID3yhaWPVRB8uNTADXVNDbVBvSm09UnY2mD9gwY9K6RXeYZTBSQtTZoLlmOz0QlU3NwFIQBCj2do= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775675510; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=W3pUSJinoIZysq/zNPRi7P/vyOGMFBYOtfasLV1MdM4=; b=BpZ1uJCgsMJJ9oalYfmsvDz8J3Wm1d1yYnWnwn4OzdVpDXLbXOXHerkIvrNHSIrlQpfFsEwycwhVN40icVP7vs/crKdzkuU8qaXJKL6gNasKW6ye0bXahFvnEnLyk+dOzBpJKoQ+uPb2norkQaKnBA53LVs6IyLx2BH7Gjz8YR4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775675510610497.94715144578913; Wed, 8 Apr 2026 12:11:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAYHE-0005Hn-69; Wed, 08 Apr 2026 15:09:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAYFz-0003Sj-Hs for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:08:11 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wAES5-0005UO-Ui for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:59:19 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso4464165e9.1 for ; Tue, 07 Apr 2026 14:59:17 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488be75215dsm83668625e9.6.2026.04.07.14.59.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 07 Apr 2026 14:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775599156; x=1776203956; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W3pUSJinoIZysq/zNPRi7P/vyOGMFBYOtfasLV1MdM4=; b=k90MApkpenfZ7OpQkuzEdHq+ztrHLSY3p2e0ZAOtYzRxVzND+06FJjnqQcdAq6t/Be bqsdXVd0fM8fcU3ZfsE9Y9p0TgD7BjsWkci7ZCJWS66KaxNcFmO6DGp63+fe98zREiGR W91dPzvTicCvt9esELgz6vSk5LLuPJteQ9/mP0Q5TE+KSRhG7Wg51lDgv+EHUvZEW21G r+ewa1XYmLexsn0kLMYInem29o8sYzbzBiD6U/uUDzSY5kIRLCPSt6atYX4JvmenqiHN AYD/vv5IaP+BMkwznkR4kKZJhy5VsE7Ml8wXqcIhsi5RcF2ZIaVwMKqauij8+x9A3dck hsBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775599156; x=1776203956; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W3pUSJinoIZysq/zNPRi7P/vyOGMFBYOtfasLV1MdM4=; b=VeldnLzqsx3HYQxgEIk12BU013cChrxWNB37O1cTH1UE2bxcJtvkeGXhtMn8hidFt8 +ml/HWXpJH2ylNtVxK2+WoNV/ciMoRsduDBPI3FfhYc4vESHvwmT4MTTHZE8kPisOQw2 l/GbUPk853AgI3KONNXy1BklzFQe42ad4W97OTOcmhc5nYHISZAUXCkt8esJPchz2c3Y K5je7rvPx64EUPfCsh3WONaQKliNsifE/zWup0HzPNcNEOpiKiAc2WaTjIjiympfafsE 806X/ZOv6rropJJ/XxE81sQmsnDRuIcL7chPC7c2xWxyHoRdHnqQdpG/uSYFF3waebkW cAoA== X-Gm-Message-State: AOJu0YxY9dbeAttzgTmOEvVq0ZT0gE7ZMET37lDHYepaGVwMg5cFOFb/ 7Vo7bd2FFqvk7z2Rk3qFZBAw0Oi65uiWm29eqiyzrUh9w95K3SndHE9W7+sh5lE8cWeA+/VeBje 1Jk7n7lM= X-Gm-Gg: AeBDiesy1hX4Xk1XuItJ6+r42eoN9UUAbjcvzu4iu6JagCb1apNPoJ6pTrplLurv0SN MfUWC8wEoY0nLi5P3vM1AgotkRmPxAqpk72PLO+arOcUkdXof5HEc304+GeniX+sYtFR6o/dcyl rgFPpTytVZPDI6F/2T7GimLWifLMsqZAxUrldfKnCiSqUCKr1j9U78iyk13p1yqrLTmPG2aDMmb xoZDaOmBzx/ynelTPqn1wfEsbNXIhm5rU0llkY42vQaGsGoWUQHJjMGXJpvZfsTyoSQlh0CLaMC kAk0Ds1e2M5V5H3TD7FyPxINPb1q8rzOCTZ5Jkpq/Qzt74N2SUUtikopo0cO4mAbx7NGGWMjUNz w09DZqAAp2EMnXU9drGAlZIPBnt1t0vZNk8JgWe3EIS8WWkrxrB1wi47uBr3RWLkm0fz90qQeXb jOlcGQ/NCVvci6QgSBsElyYUsKmkvDHVceXuQIslVJWrSG2CtPXpqlYauUbCg6bAzbLBzTJwEQ X-Received: by 2002:a05:600c:6291:b0:485:3989:b3e4 with SMTP id 5b1f17b1804b1-4889946a48fmr231709705e9.6.1775599156124; Tue, 07 Apr 2026 14:59:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jamin Lin , Pierrick Bouvier , Fabiano Rosas , Harsh Prateek Bora , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH-for-11.0 2/6] cirrus-vga: Make frame buffer endianness little endian by default Date: Tue, 7 Apr 2026 23:58:56 +0200 Message-ID: <20260407215900.63390-3-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407215900.63390-1-philmd@linaro.org> References: <20260407215900.63390-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1775675511760158500 From: BALATON Zoltan QEMU VGA defaults to target endianness but real Cirrus VGA is little endian so set it explicitly in cirrus_init_common() to fix it on big endian machines. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260401205327.914905969EC@zero.eik.bme.hu> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/cirrus_vga.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 629b34fc68d..48be3c8a932 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -2930,6 +2930,8 @@ void cirrus_init_common(CirrusVGAState *s, Object *ow= ner, s->vga.cursor_invalidate =3D cirrus_cursor_invalidate; s->vga.cursor_draw_line =3D cirrus_cursor_draw_line; =20 + s->vga.big_endian_fb =3D false; + qemu_register_reset(cirrus_reset, s); } =20 --=20 2.53.0 From nobody Sat Apr 11 18:34:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1775676110; cv=none; d=zohomail.com; s=zohoarc; b=O2BU4tL2oEXvLtKiyiwxUKeD10w0cEFf+dUDIX+8EaiHDR4iQsz2M1efeqAddX83K/kB5cYx2MHIO6td3Vkceku17OXqVaQV9fkBXOdNzIum8B2T/cdXTygIvdfji6lPPvZIMY17yXB3MNMNinIvRfvF5qPOZ+XPPVYG/D3utXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775676110; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3F2Q5EnnzT6rmGzklEM6ziQNPmaPW6cAaunkc3rGNik=; b=iz37pHboHn3KBli3PrA0uk7FEjXIsdcXLTmrQS8CSaZivvdXI9vSu1eEmAMV+8Sd1aG5Yk5oWm5QRWCFMOt4gXIaskZ5pB5UbZFnb8+g+2Uu0OjZrJ7BoOP6hU3uF6eAfXGNUPvoAd9d+exlX38+A9KaSUbe/Fd+YlYHmEOaCfA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775676110929324.3547319784433; Wed, 8 Apr 2026 12:21:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAYRl-0000g2-If; Wed, 08 Apr 2026 15:20:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAY2G-0005Yu-Kl for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:53:56 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wAESD-0005Uy-FC for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:59:26 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-488ad135063so23813495e9.0 for ; Tue, 07 Apr 2026 14:59:24 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e822227sm659482215e9.4.2026.04.07.14.59.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 07 Apr 2026 14:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775599163; x=1776203963; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3F2Q5EnnzT6rmGzklEM6ziQNPmaPW6cAaunkc3rGNik=; b=tAtOZ3WICz1A57zeiqha4Tg+JT2fkNah+wfUelJ16Sp3MeW1ZPOeNX871a+mvDihZG 7wwzxwZ2hWuHFHLEUiW9pjPw/ohWoO+iy0nnMdywlYAj2VLDGoJGfOKJ+gzVYMxmnxwm 7iC8r8Ta3UOEK3l+KW46eRlqxyNIshmBZxiiC3ydIqLGh4wB5qeaNJiDvfFVKjhCG62I uviP76QwrMAAor2yo4BScyxjvAgL4U6q7mi+ugiDOXey24vMAPv5EaYd/apba1joAuSk TUC6QdppAXcWPAIHgSgw5RyXTpWzI/I2AQTC8GE9bF0pVrU9zRDuEaWrnfRKVl8zm/2I VxgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775599163; x=1776203963; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3F2Q5EnnzT6rmGzklEM6ziQNPmaPW6cAaunkc3rGNik=; b=hSFtCzfwH5/ulbbXJnmQ5ARaGKeQ2plwtDBEfGyil31zjKZmJfCp/gY3ups88PSOec OHtYSw7DhBMQqCms5cgFuC8n5nPqFRXnL/9BE3KjyZHRP/psHx1Je4cwf789WIYoDhqi TtQFNjtUWLCPZe9Rcz9ALRaxhByuSI56FkMPy3j4BfxMPIJO1VFaB8S/kB516Zd8GcmG xhb+ZNw59RX2aWNQOXS1hg+45UW0f0/VOUqfzcbORnvn2HRn9wkrrvZ1lwts5zQhQioR H3UAJe3TjKVkwtgClmgn6cp6oT8EikJH/LgVVmlCNAsYbr3wTl0DN48lz86ZhTdaK6rA IkNg== X-Gm-Message-State: AOJu0YwQOeC93TXYawgdYlR2KwMIfdYEO9PfASe0ciFCWwzvwiRUyAUX 9wli6Oj7gnwU17l3j/WGn5c0LlNEJSzhpVJE/xO4GmqvsqYRwHw9odxZMMOWgqJdwF/sIZ3k7q1 to6Xdz3E= X-Gm-Gg: AeBDiesOgXpx1ZH3RQMbmhxOqHJMhIm+TsCGglBzRyREzPBIoxpbtYWP75MJRM/q6au N0Quj00atDcawkjmGpgDWfuJB1LucagnV1vHfHMmml3uXr/l8mR/HuhP6zxiyxSR7a6aJA8sB6O W8P1kb6fFMl9QBemHQjVW6ebwK2FtWbKd1ouXuXgrFwdTG5dN8rPseNyl4KFKU3GdntqhPxGDQt 8eeQgJAOaAJbryq+3SfWiQTwO+tO15AoJxXdDsoMP1xSAmEfm1dgnze/1T2kU921Z84UaE7b3C+ HfkLnsusSX5u+hMglYZrh9iOgDCCIDt9MV82IFZ9QIBBY4PDyITP+5dZJLinG4ke6M+kgKtCbyS jvFKQ+A7riJGEtYG3q6fZzvt+dNEZ1nvAetbumVfxtC62f/o8E61iMSjk/SPWkWHLWMsqV+M58W KuOPFLf1Idi9GjjWgY6payBT1huJt3U5NkpUD2gPghVl7+5gzyB5y4qq76B+Qz1+ClMKzNK0KB X-Received: by 2002:a05:600c:8b75:b0:486:f634:ef1 with SMTP id 5b1f17b1804b1-4889978c516mr275818025e9.17.1775599163067; Tue, 07 Apr 2026 14:59:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jamin Lin , Pierrick Bouvier , Fabiano Rosas , Harsh Prateek Bora , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH-for-11.0 3/6] hw/arm/omap_sx1: map CS3 at the correct base Date: Tue, 7 Apr 2026 23:58:57 +0200 Message-ID: <20260407215900.63390-4-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407215900.63390-1-philmd@linaro.org> References: <20260407215900.63390-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1775676113622154100 From: GuoHan Zhao omap_sx1 wires the "sx1.cs3" region to OMAP_CS2_BASE instead of OMAP_CS3_BASE. That places both CS2 and CS3 at the same address and leaves the real CS3 window unmapped. Point the CS3 region at OMAP_CS3_BASE so the static chip-select layout matches the OMAP address definitions. Signed-off-by: GuoHan Zhao Fixes: ba1580299d0 ("omap_sx1: convert to memory API") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260403014441.38725-1-zhaoguohan@kylinos.cn> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/omap_sx1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c index d858dab3253..bcb7105323f 100644 --- a/hw/arm/omap_sx1.c +++ b/hw/arm/omap_sx1.c @@ -146,7 +146,7 @@ static void sx1_init(MachineState *machine, const int v= ersion) memory_region_init_io(&cs[3], NULL, &static_ops, &cs3val, "sx1.cs3", OMAP_CS3_SIZE); memory_region_add_subregion(address_space, - OMAP_CS2_BASE, &cs[3]); + OMAP_CS3_BASE, &cs[3]); =20 fl_idx =3D 0; if ((dinfo =3D drive_get(IF_PFLASH, 0, fl_idx)) !=3D NULL) { --=20 2.53.0 From nobody Sat Apr 11 18:34:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1775675920; cv=none; d=zohomail.com; s=zohoarc; b=nUyd1npLQLP1LWJvlY1fbvSqL1gIWFxfPpmjjUystnzlV2+KUlkWslfJcnTgKmd4T6X56LJBXSJdaQVT3BaXdDt15BG1SQGIi0JyNcJtvOVqHezD7fwOlFfx1OiIjOp/yhZ3QBYDatfCsr+9PEr0ifFxu/jBt/7Xsw1tkwNqE2Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775675920; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lhn2eC+DMoiExYnjeUurcV+Nld88cdr8TS7kyXuZAbU=; b=NC2WYVBR9R3WntrbrFD1uO1z8k7litf9qMU3Df6eHbfMZvGzL+6nqBfssSShpdqcbx66zB6Mknz1+b5reqkxtbFsH2bWtz2/Ul6ZGKeyy/Df6XPH/VXd8E+4f9r/xZCc/I8bHFTo3ne3XRPp/9KXPMLy/8+dfvOd7CzY0V1kA2A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775675920471270.68164232033746; Wed, 8 Apr 2026 12:18:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAYOY-00008d-0J; Wed, 08 Apr 2026 15:17:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAYK8-0002Gt-Oh for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:12:24 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wAESJ-0005VJ-Ki for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:59:32 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-48897fd88ebso41857445e9.2 for ; Tue, 07 Apr 2026 14:59:31 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4f5016sm57075155f8f.33.2026.04.07.14.59.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 07 Apr 2026 14:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775599170; x=1776203970; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lhn2eC+DMoiExYnjeUurcV+Nld88cdr8TS7kyXuZAbU=; b=csyioh4UJfR+ATnIXGJLW73VxeW3X8PAwpBUzRptus9mWC7qCnEPrB3rcS2DSIBbAB 1V0WWqrCnZyAvIspYCDgtkcaC1cDi3feVu2ZzQmjXCCCiFgmJIFXft/3mxPI674iJU5z NNzCaJt0fg/xHi2jxlUAZMEf4sfLYFtwL9ErEOGOrMW+LHpIa1clT+ZG8qFZl7TwZvzp w+TyNM0WLmWGUfv/NXTOO0qCVHbGsleJMLtaRx/uoWGPpbyA9/lNCqUrBVQCTDkxE/+O rab8iPQKT/O5kud+iu605luw1VFHGxeaM+vIwh9XZpqfd2L/WUyp2JBJdGeXW0aer3lS Au7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775599170; x=1776203970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lhn2eC+DMoiExYnjeUurcV+Nld88cdr8TS7kyXuZAbU=; b=WHqpslVprOzjD5V0Mrd+NkBh+9/pZ8ExQb4MIvVFAAd74ng5RKW+38ne6kGixGT67R XZudFxgo/9yKfwTCYrJEHB155fgQar15Jrh9LKOMJc5cO2psqAIU72kElRczR/rqgMxd 7HfKhG0thsii5O2KwDjGUcXDa/i9ikdKmgXkbm7o3OyWWBSBtgKFFxtmo0T9Ntcxesp4 hy+mB6iYVb/bS+/4k1igTxAD+rNOAkCAZeqb3prt9b9UidhmP/y+q1v9rN9JTbnvgo/x 0pmC9GxT7osT6P35efJWbPHtpfQhqS5FHK5k40uNJq/TKZWgWiWivVYSnlfW8vvXVmzX PS3A== X-Gm-Message-State: AOJu0YxIyuIOhupboOnE9usUenzqz8A3ZpBgV+isixVP/0GwvRl3Y20y cN+YZcPGZVIIsWFfvALZyryKrnT0Wrwhe/dUB6ei6YwNI5AfY0by+l7hCJyErWxRe84+p8K1KvP m0obW+mA= X-Gm-Gg: AeBDiesVn8Os4LuRQY/QifVemMkiKvUWugP5EOj1j58O+7yIL6Xjgmc3adNgUUjqDY+ +qKhnqQUiUce+LjM94i/RJAZ6q6TczB0t9zoIkENauUBUJxFlbqEgqV75f0nu7Q2e0N60R+qd7I BiEaP06y4UIdDQPQ7se/daleTzM6OfNbkR6PJT5Fho1YDYWU4JDniVQ/U6t7a6m3jnYQX37SNum SBqhCH4gAy7zdDuaJv9WGjPpVKPxuc8I4nv2aS0zPsC8YTN4/kZzNiBbGutDLTPvmpD/lGxUoZw EMMJuHQLKT3oQQYErQqBztD85y1b6bYmrFiGp0+/L6QzEo9QA3SiR0ih9jlxxAZky0TN9yH4Upr wipvn1NyA/hcUJ8f8NcoCAhOKw5PYnrYIhhZiSnvt+0P8tZ87/Q7LTztmVym30r9dr2vW91dKwu 5i9EvvxfrdKDvi5nuu0SGrlGgzyNjwMlZsxFcGH+696H8+6skuQtAv4VEnMdd6m26rRYga7chl X-Received: by 2002:a05:600c:4447:b0:480:1c69:9d36 with SMTP id 5b1f17b1804b1-48899785c7bmr292690955e9.17.1775599169827; Tue, 07 Apr 2026 14:59:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jamin Lin , Pierrick Bouvier , Fabiano Rosas , Harsh Prateek Bora , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH-for-11.0 4/6] ati-vga: Fix setting CRTC_OFFSET Date: Tue, 7 Apr 2026 23:58:58 +0200 Message-ID: <20260407215900.63390-5-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407215900.63390-1-philmd@linaro.org> References: <20260407215900.63390-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1775675922774154100 From: BALATON Zoltan Offset (display start address) should also be updated when changing the register value not only on mode change. Fix the register write mask to hard code bits 0:2 to 0 as the chip docs say and update the start address on register write. This fixes virtual screen panning for screens larger than displayed resolution. As this register allows values that cannot be handled by the VBE_DISPI X and Y offsets (which is restricted by line length) we add a function to set it directly not through the VBE offsets. Signed-off-by: BALATON Zoltan Tested-by: Chad Jablonski Reviewed-by: Chad Jablonski Message-ID: <2b8af6022aba06aa98a249ae67922de29d82d86f.1775228029.git.balato= n@eik.bme.hu> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/ati.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index 97d871b1e22..a283afbfff5 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -48,6 +48,19 @@ static const struct { =20 enum { VGA_MODE, EXT_MODE }; =20 +static void ati_vga_set_offset(VGACommonState *vga, uint32_t offs) +{ + int bypp =3D DIV_ROUND_UP(vga->vbe_regs[VBE_DISPI_INDEX_BPP], BITS_PER= _BYTE); + + if (!bypp || + vga->vbe_regs[VBE_DISPI_INDEX_YRES] * + vga->vbe_regs[VBE_DISPI_INDEX_VIRT_WIDTH] * bypp + offs > + vga->vbe_size) { + return; + } + vga->vbe_start_addr =3D offs / 4; +} + static void ati_vga_switch_mode(ATIVGAState *s) { DPRINTF("%d -> %d\n", @@ -109,26 +122,12 @@ static void ati_vga_switch_mode(ATIVGAState *s) vbe_ioport_write_data(&s->vga, 0, VBE_DISPI_ENABLED | VBE_DISPI_LFB_ENABLED | VBE_DISPI_NOCLEARMEM | (s->regs.dac_cntl & DAC_8BIT_EN ? VBE_DISPI_8BIT_DAC : 0)); - /* now set offset and stride after enable as that resets these= */ + /* now set offset and stride because enable resets these */ if (stride) { - int bypp =3D DIV_ROUND_UP(bpp, BITS_PER_BYTE); - vbe_ioport_write_index(&s->vga, 0, VBE_DISPI_INDEX_VIRT_WI= DTH); vbe_ioport_write_data(&s->vga, 0, stride); - stride *=3D bypp; - if (offs % stride) { - DPRINTF("CRTC offset is not multiple of pitch\n"); - vbe_ioport_write_index(&s->vga, 0, - VBE_DISPI_INDEX_X_OFFSET); - vbe_ioport_write_data(&s->vga, 0, offs % stride / bypp= ); - } - vbe_ioport_write_index(&s->vga, 0, VBE_DISPI_INDEX_Y_OFFSE= T); - vbe_ioport_write_data(&s->vga, 0, offs / stride); - DPRINTF("VBE offset (%d,%d), vbe_start_addr=3D%x\n", - s->vga.vbe_regs[VBE_DISPI_INDEX_X_OFFSET], - s->vga.vbe_regs[VBE_DISPI_INDEX_Y_OFFSET], - s->vga.vbe_start_addr); } + ati_vga_set_offset(&s->vga, offs); } } else { /* VGA mode enabled */ @@ -737,7 +736,8 @@ static void ati_mm_write(void *opaque, hwaddr addr, s->regs.crtc_v_sync_strt_wid =3D data & 0x9f0fff; break; case CRTC_OFFSET: - s->regs.crtc_offset =3D data & 0xc7ffffff; + s->regs.crtc_offset =3D data & 0x87fffff8; + ati_vga_set_offset(&s->vga, s->regs.crtc_offset & 0x07ffffff); break; case CRTC_OFFSET_CNTL: s->regs.crtc_offset_cntl =3D data; /* FIXME */ --=20 2.53.0 From nobody Sat Apr 11 18:34:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1775676083; cv=none; d=zohomail.com; s=zohoarc; b=Xt0lC19wAYvhJ82WwyGB0bKaCdu6lzapNcErFGHp/9Ph6CA2bJ4DKhfUBY9pZbGkcbwmX66P2R9cQvcb4hDJ/ekuCHbHC5xvEQ7jCxN5zsOkOV9YSI6+z/qPEUf/kPhs7/z80nk4xjyHdx+MqyhInh01DWO8MXWDbDJ+8oj2/b8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775676083; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=p3wWXjzOY7eN/MkISFSo7wNwF1Jd1biTE5Rgyb00uNY=; b=WNnYGOOJGaxeGcZ4FfLE80Fv4PDewNWAOfr5KTn9CBhbJ/EB7dgEbgWsAA/t6jCk8vG6PZtLNjMOpFh1Av6HQh+EKfIqyB8tJR3N8E+6/XzDS+u9zFVvLUtK73+a5TCTvGeCXMvQEjiy7cyM5tt33FAwyoS9E3hkq5aim0I2Bds= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775676083817900.0912137992966; Wed, 8 Apr 2026 12:21:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAYPH-0000hX-Ty; Wed, 08 Apr 2026 15:17:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAYMS-0006Al-HS for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:14:48 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wAESR-0005W9-BO for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:59:40 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-48896199cbaso49972705e9.1 for ; Tue, 07 Apr 2026 14:59:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e822227sm659497595e9.4.2026.04.07.14.59.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 07 Apr 2026 14:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775599177; x=1776203977; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p3wWXjzOY7eN/MkISFSo7wNwF1Jd1biTE5Rgyb00uNY=; b=YeEOLNmjwb5+xljjaAVvTY6ndzJY05gOlaJkp7gw/jop3UD9CWSX2qM2B3i7kv7Jqj YTUR1r/t5Du0zbshnqR2CiChresq06epkL0HOIUdc1G4zyC/T7qP2ccxTawLwKwrmpSW dv9+i9XEs76MOSRjmj1xKwr9KSoKgGfr0YjL1VWU1yMhitYf7aPRoSLkU8vTo5jPDAGr lg0JSqb0xdZLTCWraHIC9lIGEx7PzzljegxGTaMnuujTYx6gVCekgwihrvB+H1M12y5Z 0HhWkObtRPno62sYpylzodjzw6uX7a+xdpzvsaFWgmjaQ7iHa9tZSQ9vAwSdNGaKtFAx 8Gjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775599177; x=1776203977; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p3wWXjzOY7eN/MkISFSo7wNwF1Jd1biTE5Rgyb00uNY=; b=pnu7dD54yjjGGgqvYzS9SIlAMpGORbxTxFa0fAZaXtN1S5BJRMidb2+EuStn3lwQjE thi1F1BPU17ZHD1kdWHDH20hQsMq/DOt8THZ6QXCOnE0S7LifdJU6XKNJdHS9/o1FvZd xjgpbuI3m0/NISjNW02aBGeWri3mJyUZ0NByHuSSWy/LFcNbTpYHxaLxY4mB/h7JxTMd jU5mEMyjZrgJ8CHcZ9wLgMOdVhKpXLywnF1fmRzvQzj6ixGW9pwOyAJIyiLGkAyDuKjH mhhjfZdZnNFHS0NBYx3Z8oWEUbTwwqvaLUyAa1edyAM7tnMFshPomuaDpXoDmYci4Ltw yI7g== X-Gm-Message-State: AOJu0Yy+8Xga7xV9IR50KqJtZPd8fXsLPEIjp88Z5MA3N0+RcUP0Zs4f usiujU7OTy/w7UPFA+IoXeCxLHHdibkxXShyu4ptcFV/O833ZzzeLP+QSbBaNWod4yYBg3/JUX5 wofwrjKs= X-Gm-Gg: AeBDietAZd9/9+A4S14bDyVlffVym42i/65RVcoE31aS55vcKS8mG9I1ZzyZC/o/EFJ DwnTq2UBKj8o7BkXx4opOSL5hme1KgZ6ZyV92aEuxyiPtCI3lR314GeH6oKKinyt273D+qi+btT r4rIJkz9speuxiSXMzqhBTUNKOz0dmtXCpBYUHfRHQ1SuVniRhgKoP7nvZSoz7zAXr/IqdRb23C vfeVSJjDrUZwdBvmyeBy3Cwq1ve1S3Q5JQD+EgipHuDtCYWtaBbnFOLOCrizb5cZFSlx7Y5seL/ p7woNAAN9QuIY4/CHS+Iw+AeDAD6Sh6knCi4igMslSzopUXy9lZr0+MS+rRVC+S6tXuuejMS6A1 9sJJiyFLYR3F4XZbveekmfGFhuqhhvW2k+R/BcNoTFkZzfbIqo0bpU23hCJcZRR8OJV3pigcR0K LyuTGbF3nRCcAPjZhDHgbL33+3uRHUcj+R1t7ngBf18YwKbQC2HOq0HaINecTlPXkOExFILQFZ8 oLE9P12oUw= X-Received: by 2002:a05:600c:8b54:b0:488:869c:edaa with SMTP id 5b1f17b1804b1-488996d9cdcmr282324695e9.7.1775599177517; Tue, 07 Apr 2026 14:59:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jamin Lin , Pierrick Bouvier , Fabiano Rosas , Harsh Prateek Bora , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH-for-11.0 5/6] ati-vga: Update mode on CRTC_PITCH change Date: Tue, 7 Apr 2026 23:58:59 +0200 Message-ID: <20260407215900.63390-6-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407215900.63390-1-philmd@linaro.org> References: <20260407215900.63390-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1775676085445154100 From: BALATON Zoltan When changing line length we need to update display parameters so call mode change when changing CRTC_PITCH if the value has changed. Signed-off-by: BALATON Zoltan Reviewed-by: Chad Jablonski Message-ID: <3f54ff54a873a8f8a0cc5f14660703b4025a69e2.1775228029.git.balato= n@eik.bme.hu> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/ati.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index a283afbfff5..7bb57c44d95 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -743,7 +743,11 @@ static void ati_mm_write(void *opaque, hwaddr addr, s->regs.crtc_offset_cntl =3D data; /* FIXME */ break; case CRTC_PITCH: - s->regs.crtc_pitch =3D data & 0x07ff07ff; + data &=3D 0x07ff07ff; + if (s->regs.crtc_pitch !=3D data) { + s->regs.crtc_pitch =3D data; + ati_vga_switch_mode(s); + } break; case 0xf00 ... 0xfff: /* read-only copy of PCI config space so ignore writes */ --=20 2.53.0 From nobody Sat Apr 11 18:34:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1775675554; cv=none; d=zohomail.com; s=zohoarc; b=WYUeNCv89GJNJKd+iWSqdMDu/OUPlrwuXCBLUiST7L8d/jiNupWEkPAzGfRdqYfE/C04lZ+8TtADoX2WkGGcyiVrY/oq49Z2h9AqWaXEJPTRkg9qIdGhEDfy4co1fORzMWAlAmW67xM3bCLGk9bWyneDqTnBOBBNed4ixoVs8dQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775675554; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=agmdtPgbKNlH9bAAj1AAHRxJL/aBymX0MFrBnGbacuc=; b=cAGrMRiRYRHnDmc6vpM/re7o6to7dKn0oVbFxXI0XhLx4NK4IfAPbalvyID/uq+cja5WgVkznfSXGiFb3i+/pbMUsU4qjVJHBvuLrmLye2yutfZYCWEEz/cZPnH0+Sx1JMPSYaYCuc/VLe6evHr+WFm8XHjM8mtHwW5dzIfQJ5A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775675554784995.6457164920247; Wed, 8 Apr 2026 12:12:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAYJM-0007x2-DV; Wed, 08 Apr 2026 15:11:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAYGn-0004S0-AD for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:08:57 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wAESY-0005Xk-DK for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:59:47 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-488c2690057so8708595e9.0 for ; Tue, 07 Apr 2026 14:59:46 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488c1c5291esm91154425e9.15.2026.04.07.14.59.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 07 Apr 2026 14:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775599184; x=1776203984; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=agmdtPgbKNlH9bAAj1AAHRxJL/aBymX0MFrBnGbacuc=; b=NhZ+eN3SWHnww8pIvyqKKOzGUdO1TYrOLkztMddlTxJb87nZJqxhrOZ7T4BezsZRPy kKPXLg5x0U/fk3ClUL9BS15RqyzlEbY3fiSd2FpvV5wrdR/K/0CuUCQLjaWj8kgIGrjo D7zJN3QfK8ylg/mF0yXL47X4gZb4AzvXltoTfs15G/0sCel4y4+ewZSw/m6qMomV/t1P Y5QNecgHT8+3iThfMxTk14sSijkh9me50FgMH0lrYEc6xxA6UY3AaYyMKo24os4ZLZ8+ 2ZVL5gkrL/bxFXB/lLSUfPXmgx4EZNpSp3HHa7LHCLn77sh2eXMDD+Y0MHX8NlPOKbip vsVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775599184; x=1776203984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=agmdtPgbKNlH9bAAj1AAHRxJL/aBymX0MFrBnGbacuc=; b=nWScz/LP31Je89HRGklS/9S+gMZhByQQ73cpnXP9AOc/WTmoqa2f19XG4ueVQ5SesU DwNyKBSsLdVFwH9gkg9zYeuu6/aGY5jODIJnHtd2MOA6fqT9ATQbToUVEU0JFIDWa+0O /SB+Rm9KWXsVpcDiL+B0uSmlLdNcFeAIYyX7OJl+woqnQRPH8+iGVMfRKBJIhgzP7B1D q6BvJQgyi5Yx1g3mpw5jpDprEIL2Y6TwIjIJRAc0F/FVTKqLTmeP4QYVrM8pGqF9CqUU nubpOrS1Li9M9HFikqNlDsdZJ4CHva40Xk5ssAKKUFXga9DWjmDoF0azYUAKxck0TgIy li6g== X-Gm-Message-State: AOJu0Ywik995ut2tgWmc+Jj3gSExnRUo/cRexjqlsnlFGSsWMKu8a/rf v9JvecPUq5fTMA8KrA0+D4L7l5QpRWFsTeKZkKxKWtNbdZHI84fWDXC+hjyQwloeu/rwDsRD7HO yc4UdT/0= X-Gm-Gg: AeBDiesirp9Zt+YWWslN/nd4OvryRJKB90e/pB3O+0aZYEVPgNG0HuXdo+LDuwFZnH9 b2dYda/GUgqPrOvIHs8O1ibJ1jBEvvKTLGJOutFLEYM0IbV5Om1z/2aXA0LQ/byOvzU5EE8+hkP 6VA2uECxbUMPEG/t8E9gFgxCT4tJd42Gb/VaAf8fu2zA8tJjQLF3A6H0vENGG8kCDcpzPQFg5O/ XRhzToVnyXxKIYQPQUFcwNtT/0abyse+GFK2bywwzHsNKpaX61z+LTL3hisutH8aEq7s4NKf6L4 P+ludPXIWWEckuMOA7KjSHQ9aEyTCIFi6ScmoTT+rOtPwNU6TPkS0X4P5liW4kRNKtUbaFILWwM ou4m9pEZvO1x3K7wj+T+leVl7NxpAmQhJa0Ncmy7hfyl5ayfVK7Ol3w62MiEDNxcySEB3JyJbtL dORPcS+9mBxhE86W5KV+vD20PXohjkovbS4Ix9wt7W40+J7fzc3zJfXxSaSMXTtRR19RoS8ygJ6 A69gYjk5cc= X-Received: by 2002:a05:600c:6286:b0:486:af22:4a2a with SMTP id 5b1f17b1804b1-488996dfebamr259333495e9.7.1775599184543; Tue, 07 Apr 2026 14:59:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jamin Lin , Pierrick Bouvier , Fabiano Rosas , Harsh Prateek Bora , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH-for-11.0 6/6] ati-vga: Do not crash on 24 bits per pixel Date: Tue, 7 Apr 2026 23:59:00 +0200 Message-ID: <20260407215900.63390-7-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407215900.63390-1-philmd@linaro.org> References: <20260407215900.63390-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1775675557176154100 From: BALATON Zoltan The stn_he_p function only supports power of two sizes so it will assert if we call it with size 3 that happens with 24 bits per pixel. It's not clear from the documentation if this should be supported or not and drivers tested so far don't use it so refuse the parameters that would crash QEMU for now. Signed-off-by: BALATON Zoltan Reviewed-by: Chad Jablonski Message-ID: <20260406012031.335A0596A24@zero.eik.bme.hu> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/ati_2d.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/display/ati_2d.c b/hw/display/ati_2d.c index 9baf6ff37b0..f0f77cecc65 100644 --- a/hw/display/ati_2d.c +++ b/hw/display/ati_2d.c @@ -265,6 +265,10 @@ static bool ati_2d_do_blt(ATI2DCtx *ctx, uint8_t use_p= ixman) { uint32_t filler =3D 0; =20 + if (ctx->bpp =3D=3D 24) { + qemu_log_mask(LOG_UNIMP, "Fill blt unsupported in 24 bits\n"); + return false; + } switch (ctx->rop3) { case ROP3_PATCOPY: filler =3D make_filler(ctx->bpp, ctx->frgd_clr); @@ -362,6 +366,11 @@ bool ati_host_data_flush(ATIVGAState *s) =20 setup_2d_blt_ctx(s, &ctx); =20 + if (ctx.bpp =3D=3D 24) { + qemu_log_mask(LOG_UNIMP, + "host_data_blt: unsupported in 24 bits mode\n"); + return false; + } if (!ctx.left_to_right || !ctx.top_to_bottom) { qemu_log_mask(LOG_UNIMP, "host_data_blt: unsupported blit direction %c%c\n", --=20 2.53.0