From nobody Sat Apr 11 20:12:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1775589614; cv=none; d=zohomail.com; s=zohoarc; b=LRdph6RfnsNc5eWpSV8kX3ykWKEQWNE1L4eqc+Nfd6iiqu7O+mS42D4bYEdIB1F0ya0ssJeUAhkaF33QokrvzBtncjrJzo+njhExVA/DKqpt2LWZWyP5LBCWec93v2dH9MHHwC0hROy7mQfJfOBVTotkfEUDGDS7VK681H0hi84= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775589614; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oiFezQHOAaqMmcJKMFlY6nIZQsohwq1z122fNT7RHvQ=; b=Oxn7+Wcw1JDvEcfDFd++mZimPM23yHzye5SnRqa4gB2wc0dDgz+kihThPIkvtDfHTFcoGg4rKUnvH57Ki+pnzymSJnFhDZUp8MWH1KBFMq1BA7Yepc6F2WUpCyPzBlBq/3yGIAu99womls0mK4BOe87RoMdIKkZ/IopV+Az2HDs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775589614623572.7383861727906; Tue, 7 Apr 2026 12:20:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wABXe-0000J4-Q9; Tue, 07 Apr 2026 14:52:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wABUK-0003zm-ET for qemu-devel@nongnu.org; Tue, 07 Apr 2026 14:49:24 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w9yDO-0007Hy-5x for qemu-devel@nongnu.org; Tue, 07 Apr 2026 00:39:03 -0400 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-35d971fb6f1so4018045a91.0 for ; Mon, 06 Apr 2026 21:39:01 -0700 (PDT) Received: from toolbx.alistair23.me ([2403:581e:fdf9:0:6209:4521:6813:45b7]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c6491fedsm15809963a12.8.2026.04.06.21.38.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 21:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775536741; x=1776141541; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oiFezQHOAaqMmcJKMFlY6nIZQsohwq1z122fNT7RHvQ=; b=DDGlJsY7JlvlmWSMLWt+t9Ukpho7fx4xDhJyaDaI9X/s/pyT8qpYt/42U7akQYGX/+ TBb0+iXn38TRxOOIHZXwN37WrdlMH5DE3qvB6pEwaUNJxSq4pqbWwLwotGjai9AZG0rv 3tcHXK16R1zaL7xfvjHzDRhVU2ArVqJoi9/5tAu7xqcBKZyKDnFoLqq/BZxyv+bOYLcd 5RRI83zKFccGeo3vNZoBnoIy/YsjsfsrQXvJKUaHXpG1E2uMvvowBgEBc1hUFgHrcPMI nXJWFAbDFHsQc5/6lUNBWJnCyNOR1PKzkbsgsO0+NLOkGM7xzqEKCsvt67xM1uPxO3sN zrMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775536741; x=1776141541; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oiFezQHOAaqMmcJKMFlY6nIZQsohwq1z122fNT7RHvQ=; b=bfPhdbSKS+4Ps26vdSdV4vNuIvrG5OqdHVgrELjsM1oW0GLl1terra4O3wqgSpxYvh 62EZkfCHKj0IqFSeLIY6OeYyg70hLAPI/P7UlTV43t9/ylNpyAAxtZhyJM6Xmp+2lqFI O0kw1Kus5jGqqn10DlCUhUAuHFW7FnU2/PpZwTP6fJAxTcYOrNv7rJ6bo5XhvzC7qVbr Mj7EAGn4I/9DwixWQKOuzFQOsdpkO6rjj6D2xaFOsKYuyaXoidlgXQ2hWgXhRMA4dtSj xMssCXTLBG8K1wwqlWTROKFTN77WIWaiRmTDjCkBtXjdoyDp4LXZ307yOMAdg8SQd2yX u5iw== X-Forwarded-Encrypted: i=1; AJvYcCUNUhsCsi6ako7+jzTgxwO62v3NNlrcmto+BxSrAGALtmnrw0H8d7/m+GWoPAmkcYu6QHDwHqlS7vlL@nongnu.org X-Gm-Message-State: AOJu0YzuDsO3otlfrFxB/jc8tLOIY8R3/9Fm3Ww9pOLutxOe0CXO7VqG BfrdtHfgDFQgMqPbw1rbUisI323APSsNL4/1DjrO7JIDfVPF2n9Hq/5x X-Gm-Gg: AeBDieuE+wKfLwJdrAjFW8eu3q+bEZuf2HnJDChKQjixNHN44cPdPJZZCVEYJiaQNOf Txz0/nQf2NaW02CvRmyPkd+DeCSs0HW4s6nptRZznX5EU6pzEKPb9c4WXwycxwCpShybxQgD/eN qKH+cm6HLU48oUwGimIj9xXSa/nP/FYOHHWzS0m+UDnr6QlXyRM0M6N5A1YNO1DB9MPxHpgYKxm ZV+89ldk6cDf0heK1ZK85zFNLcBxdiFl8sDwi0B+iE7FmXehJ1KS2vC8ocVz33easaFZIJXL6G9 rvjcnbOUzhFpsOAKGRXQpd68WW4H682mwb9X8IRH9xFIp1gY3+KQDVqf0HVFF5cRkOp3uDR2W+S mi2cCphifXbm0vPfmyz+tQNbtRUrAR2bQDve+joZgd8y095vZJ3LacxzWCUwAAa5TJvNVktbm+f Iq3sj8txS2WGvlcH+xpi64mddF9ybbcaYrYshA5v6B X-Received: by 2002:a17:90b:350e:b0:35b:9682:51e6 with SMTP id 98e67ed59e1d1-35de691ac13mr15140403a91.16.1775536740743; Mon, 06 Apr 2026 21:39:00 -0700 (PDT) From: alistair23@gmail.com X-Google-Original-From: alistair.francis@wdc.com To: palmer@dabbelt.com, liwei1518@gmail.com, daniel.barboza@oss.qualcomm.com, zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com, qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: alistair23@gmail.com, Alistair Francis Subject: [PATCH 3/5] target/riscv: Don't OR mip.SEIP when mvien is one Date: Tue, 7 Apr 2026 14:36:12 +1000 Message-ID: <20260407043614.372871-4-alistair.francis@wdc.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407043614.372871-1-alistair.francis@wdc.com> References: <20260407043614.372871-1-alistair.francis@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=alistair23@gmail.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1775589616968154100 From: Alistair Francis The RISC-V spec states that """ But when bit 9 of mvien is one, bit SEIP in mip is read-only and does not include the value of bit 9 of mvip. Rather, the value of mip.SEIP is simply the supervisor external interrupt signal from the hart=E2=80=99s external interrupt controller (APLIC or IMSIC). """ From my understanding this means we should remove MIP_SEIP from the alias mask. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/2828 Signed-off-by: Alistair Francis Reviewed-by: Chao Liu Reviewed-by: Daniel Henrique Barboza --- target/riscv/csr.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index a75281539b..2a2f9497db 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -3796,6 +3796,14 @@ static RISCVException rmw_mvip64(CPURISCVState *env,= int csrno, /* Remove bits that are zero in both mideleg and mvien. */ alias_mask &=3D (env->mideleg | env->mvien); nalias_mask &=3D (env->mideleg | env->mvien); + } else { + if (env->mvien & MIP_SEIP) { + /* + * Bit SEIP in mip is read-only and does not + * include the value of bit 9 of mvip + */ + alias_mask &=3D ~MIP_SEIP; + } } =20 /* --=20 2.53.0