From nobody Sat Apr 11 18:39:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775180739053663.1988582841575; Thu, 2 Apr 2026 18:45:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w8Tam-0004qh-W8; Thu, 02 Apr 2026 21:45:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w8Tak-0004pt-3y; Thu, 02 Apr 2026 21:44:58 -0400 Received: from mailgw.kylinos.cn ([124.126.103.232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w8Tah-0000l5-PN; Thu, 02 Apr 2026 21:44:57 -0400 Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1403329136; Fri, 03 Apr 2026 09:44:44 +0800 X-UUID: b054e4aa2efe11f1aa26b74ffac11d73-20260403 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12, REQID:90d5a4cf-d200-4673-a9d7-902d7365fe68, IP:0, U RL:0,TC:0,Content:-5,EDM:-20,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-25 X-CID-META: VersionHash:e7bac3a, CLOUDID:e500c946175ebbebd7f7dd8ab3bad864, BulkI D:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|123|850|898,TC:nil,Content:0|1 5|50,EDM:1|19,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,O SI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: b054e4aa2efe11f1aa26b74ffac11d73-20260403 X-User: zhaoguohan@kylinos.cn From: zhaoguohan@kylinos.cn To: qemu-devel@nongnu.org, Peter Maydell Cc: qemu-arm@nongnu.org, GuoHan Zhao Subject: [PATCH v2] hw/arm/omap_sx1: map CS3 at the correct base Date: Fri, 3 Apr 2026 09:44:41 +0800 Message-ID: <20260403014441.38725-1-zhaoguohan@kylinos.cn> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260402071718.130490-1-zhaoguohan@kylinos.cn> References: <20260402071718.130490-1-zhaoguohan@kylinos.cn> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=124.126.103.232; envelope-from=zhaoguohan@kylinos.cn; helo=mailgw.kylinos.cn X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1775180744588158500 Content-Type: text/plain; charset="utf-8" From: GuoHan Zhao omap_sx1 wires the "sx1.cs3" region to OMAP_CS2_BASE instead of OMAP_CS3_BASE. That places both CS2 and CS3 at the same address and leaves the real CS3 window unmapped. Point the CS3 region at OMAP_CS3_BASE so the static chip-select layout matches the OMAP address definitions. Signed-off-by: GuoHan Zhao Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- v1 -> v2: - Resend to qemu-devel@nongnu.org - Keep qemu-arm@nongnu.org on Cc as requested by Peter Maydell hw/arm/omap_sx1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c index d858dab32534..bcb7105323fd 100644 --- a/hw/arm/omap_sx1.c +++ b/hw/arm/omap_sx1.c @@ -146,7 +146,7 @@ static void sx1_init(MachineState *machine, const int v= ersion) memory_region_init_io(&cs[3], NULL, &static_ops, &cs3val, "sx1.cs3", OMAP_CS3_SIZE); memory_region_add_subregion(address_space, - OMAP_CS2_BASE, &cs[3]); + OMAP_CS3_BASE, &cs[3]); =20 fl_idx =3D 0; if ((dinfo =3D drive_get(IF_PFLASH, 0, fl_idx)) !=3D NULL) { --=20 2.43.0