From nobody Sat Apr 11 20:11:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1775167296; cv=none; d=zohomail.com; s=zohoarc; b=j8GEuJCMeFzRLimFb8wJYw7IrKS1AKKZIx4UmulLoSxu1dclt7RYouqpn2p6+ra0fwqewpLa685qtsFE/393tRDyNT7KlpsDbddJUGOEVqAvjY8aCgn8hfRhOvHJSZOaULlQyixPeW9h67+06uQVyecV1RlRGryTArucE7ARHds= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775167296; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IY/Psqmc5gYs7mEXOklu9W6iJGvX3f2xns3E+/gt5OY=; b=MrMGr9VnBPujD2V3wJsqBGcFO+4iC7kwpgowKGPAbJRpvPEjz5wlyZidyHtZ+wjlXvQbrWN0SnGC/2/u8By9xIMPKqcULI9QzrEKvSDf4/ZxQJhk8iUrKwm/XjduLMoLhiBekun5OInrj9wZLEui7HT6DgtUjzk2eY0yIVvvMrc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775167296696610.8872165602745; Thu, 2 Apr 2026 15:01:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w8Q2A-0008Io-E2; Thu, 02 Apr 2026 17:57:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w8Q27-0008Hq-Ju for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:56:59 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w8Q25-00075L-W9 for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:56:59 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-66c05fb27e4so2504490a12.2 for ; Thu, 02 Apr 2026 14:56:57 -0700 (PDT) Received: from thinkpad-t470s.. (93-143-182-244.adsl.net.t-com.hr. [93.143.182.244]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b9c3cac0e1asm134009166b.27.2026.04.02.14.56.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 14:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775167016; x=1775771816; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IY/Psqmc5gYs7mEXOklu9W6iJGvX3f2xns3E+/gt5OY=; b=tJWvlBfgwmrT/6bF9jRxdYwlDOGWKMehNzg7cdihLz0+5X++8cXHU3qKZJ39w0v7kT 6euxrvug/z2vP2v+gD5HXd3CEAovlwlT5z7CwicY7AxjWNKzSLYFSK+qIbymO4/7lGEx HSuekU1ZfqamjAHirI7qgKlmQQTEMbR4zHlZgOWBbeScy0ztG4VvYYm19Nx1d2T6r9xt oqHdnKG86+TyVbkwkVHsfBt2i1w4wAxMPsiMn70N6oAkjYMCtxUqkXT8Kcz+xwQhYEKi 4EVyT/GqX2QHCUYIuHik1SVIbX5wJU3tl08cYYLb/4iUNjtt7MHNFPYkgH10jPVh8DPe 7ZIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775167016; x=1775771816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IY/Psqmc5gYs7mEXOklu9W6iJGvX3f2xns3E+/gt5OY=; b=Yl9IPqFbhuZ3PAH3ldaMIzIyXVklUEbOax+D22c7BKgwdFa2IE7vKR1/SYCiPu7KRn B4VzOC8Ju8QpVfjuJwBpg0TFsbiqT0PE7uXDUXBa1qbFcSd4qnNnPjyOqOsIpvMuyb+x hiQBKcCN58uQc5geZ925VhaNuj359ZDEdisfXtV6dc527bEZry18Zisn8n/qv/+pibJp NBqNC8swipRt7URHvdxXBgRdc5+qd5mcKmQ7aItR2uw5uL1bTf0VnYJSbFw+WEeJS5WJ vgiyynF9FI2sIhXXbOUWp3r+T69WYRGzEQ1aMG1LFYJl9ueKovxTfJtfKE3WDpnxq1Tj Mmjg== X-Gm-Message-State: AOJu0YyFNSqTwbvHQWWZGKZHr4BMfDugHlI9wfDwJ3ODNE6E2DVAutAT ZiQJ1Bu5dwHx3vpnvupz5ZtzU5xI7vgOmduw19v/tBWP/tT3T/xi88J8ZPdcuhRn X-Gm-Gg: ATEYQzyHjgPBzkApRWzwxBmjNmwBnWRGg+xBjj5QcxlTNjpdDUnXz9bJrKT9HPW0zZ+ jaFPVt6rzR+jIfCnkAG9hfoAopHdaZhjkTGwb2SYb+vHmuBz+uqQmotBgpGlGtPW4JKSe+xy/HV 1mXGj4jU7vUEBzxSPi2vwk+YdPE9Dh2R/Ye9+IwMo/3H368tEzhaSuAgmTCzZdbZsRlOo9o8xy4 sszULJe/FxsW2kwqEysc55jPXTmf/i4AuxGXfGpd+a+zSeVabbdhtKC+K4ySnYjJ2eqDMdy7Itb SQ5ysNpuNxrlWvRMaFg0cxDwtWoPLal8gEHd9ChC75DETJ71Eel0YxqCzuRt99BInAjpTmqIz79 OotTZAw/cz9xa8GdsFWDEAiqXGpllKx0oKxBPGfuxREA+vwHcKPm2NT2b1VvtO+rNGwKzJcaF3O EzCv42l2gb0z1Nv1Pz/BRJ4/d8yEAd9vBakf9bz8aIfzS0VcfSWayT4kyhVXqZCJWmSjI9esBl+ Uk3uTwY X-Received: by 2002:a17:906:bf49:b0:b98:3b5d:e147 with SMTP id a640c23a62f3a-b9c67446620mr30557666b.3.1775167015877; Thu, 02 Apr 2026 14:56:55 -0700 (PDT) From: Ruslan Ruslichenko To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, alex.bennee@linaro.org, peter.maydell@linaro.org, artem_mygaiev@epam.com, volodymyr_babchuk@epam.com, takahiro.nakata.wr@renesas.com, "Edgar E . Iglesias" , Ruslan_Ruslichenko@epam.com, balaton@eik.bme.hu Subject: [PATCH v3 08/33] hw/core/fdt_generic_util: implement fdt_init_qdev Date: Thu, 2 Apr 2026 23:55:53 +0200 Message-ID: <20260402215629.745866-9-ruslichenko.r@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260402215629.745866-1-ruslichenko.r@gmail.com> References: <20260402215629.745866-1-ruslichenko.r@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=ruslichenko.r@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1775167298676158501 Content-Type: text/plain; charset="utf-8" From: Ruslan Ruslichenko Implement main routine to create device object from compat. The following steps implemented: - parse node compatible and device types - try to create object from compat - set correct parent based on device tree. Signed-off-by: Ruslan Ruslichenko --- hw/core/fdt_generic_util.c | 120 +++++++++++++++++++++++++++++++++++++ 1 file changed, 120 insertions(+) diff --git a/hw/core/fdt_generic_util.c b/hw/core/fdt_generic_util.c index 2f7a3fc3dd..565f577238 100644 --- a/hw/core/fdt_generic_util.c +++ b/hw/core/fdt_generic_util.c @@ -41,6 +41,7 @@ #include "qemu/config-file.h" #include "hw/core/boards.h" #include "qemu/option.h" +#include "hw/cpu/cluster.h" =20 #define fdt_debug(...) do { \ qemu_log_mask(LOG_FDT, ": %s: ", __func__); \ @@ -226,8 +227,127 @@ static int simple_bus_fdt_init(const char *node_path,= FDTMachineInfo *fdti) return 0; } =20 +static inline const char *trim_vendor(const char *s) +{ + /* FIXME: be more intelligent */ + const char *ret =3D memchr(s, ',', strlen(s)); + return ret ? ret + 1 : s; +} + +static Object *fdt_create_from_compat(const char *compat) +{ + Object *ret =3D NULL; + + /* Try to create the object */ + ret =3D object_new(compat); + if (!ret) { + const char *no_vendor =3D trim_vendor(compat); + + if (no_vendor !=3D compat) { + return fdt_create_from_compat(no_vendor); + } + } + return ret; +} + +static void fdt_init_parent_node(Object *dev, Object *parent, char *node_p= ath) +{ + if (dev->parent) { + fdt_debug_np("Node already parented - skipping node\n"); + } else if (parent) { + fdt_debug_np("parenting node\n"); + object_property_add_child(OBJECT(parent), + strdup(strrchr(node_path, '/') + 1), + OBJECT(dev)); + if (object_dynamic_cast(dev, TYPE_DEVICE)) { + Object *parent_bus =3D parent; + unsigned int depth =3D 0; + + fdt_debug_np("bus parenting node\n"); + /* Look for an FDT ancestor that is a Bus. */ + while (parent_bus && !object_dynamic_cast(parent_bus, TYPE_BUS= )) { + /* + * Assert against insanely deep hierarchies which are an + * indication of loops. + */ + assert(depth < 4096); + + parent_bus =3D parent_bus->parent; + depth++; + } + + if (!parent_bus + && object_dynamic_cast(OBJECT(dev), TYPE_SYS_BUS_DEVICE)) { + /* + * Didn't find any bus. Use the default sysbus one. + * This allows ad-hoc busses belonging to sysbus devices t= o be + * visible to -device bus=3Dx. + */ + parent_bus =3D OBJECT(sysbus_get_default()); + } + + if (parent_bus) { + qdev_set_parent_bus(DEVICE(dev), BUS(parent_bus), + &error_abort); + } + } + } else { + fdt_debug_np("orphaning node\n"); + if (object_dynamic_cast(OBJECT(dev), TYPE_SYS_BUS_DEVICE)) { + qdev_set_parent_bus(DEVICE(dev), BUS(sysbus_get_default()), + &error_abort); + } + + /* FIXME: Make this go away (centrally) */ + object_property_add_child( + object_get_root(), + strrchr(node_path, '/') + 1, + OBJECT(dev)); + } +} + static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *comp= at) { + Object *dev, *parent; + char *parent_node_path; + + if (!compat) { + return 1; + } + dev =3D fdt_create_from_compat(compat); + if (!dev) { + fdt_debug_np("no match found for %s\n", compat); + return 1; + } + fdt_debug_np("matched compat %s\n", compat); + + /* Do this super early so fdt_generic_num_cpus is correct ASAP */ + if (object_dynamic_cast(dev, TYPE_CPU)) { + fdt_generic_num_cpus++; + fdt_debug_np("is a CPU - total so far %d\n", fdt_generic_num_cpus); + } + + parent_node_path =3D qemu_devtree_getparent(fdti->fdt, node_path); + if (!parent_node_path) { + abort(); + } + while (!fdt_init_has_opaque(fdti, parent_node_path) && + !object_dynamic_cast(dev, TYPE_CPU)) { + fdt_init_yield(fdti); + } + + parent =3D fdt_init_get_opaque(fdti, parent_node_path); + + if (object_dynamic_cast(dev, TYPE_CPU)) { + parent =3D fdt_init_get_cpu_cluster(fdti, parent, compat); + } + + fdt_init_parent_node(dev, parent, node_path); + + fdt_init_set_opaque(fdti, node_path, dev); + + g_free(parent_node_path); + return 0; } =20 --=20 2.43.0