From nobody Sat Apr 11 18:35:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775092193603630.7257439695153; Wed, 1 Apr 2026 18:09:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w86YZ-00062p-Bc; Wed, 01 Apr 2026 21:09:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w86YV-00061W-GG for qemu-devel@nongnu.org; Wed, 01 Apr 2026 21:09:07 -0400 Received: from mailgw.kylinos.cn ([124.126.103.232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w86YS-0007eH-2g for qemu-devel@nongnu.org; Wed, 01 Apr 2026 21:09:06 -0400 Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1172094376; Thu, 02 Apr 2026 09:08:52 +0800 X-UUID: 838cb1562e3011f1aa26b74ffac11d73-20260402 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12, REQID:ce95f29d-8079-4ecd-bd6c-b11c5036d264, IP:0, U RL:0,TC:0,Content:0,EDM:-20,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-20 X-CID-META: VersionHash:e7bac3a, CLOUDID:769fadc428a988fc1653aaa529932671, BulkI D:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|850|898,TC:nil,Content:0|15|50 ,EDM:1,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OS A:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 838cb1562e3011f1aa26b74ffac11d73-20260402 X-User: xieyi@kylinos.cn From: Yi Xie To: jasowang@redhat.com Cc: qemu-devel@nongnu.org, Yi Xie Subject: [PATCH v2] net/filter-buffer: use qemu_del_net_queue() in cleanup Date: Thu, 2 Apr 2026 09:08:47 +0800 Message-Id: <20260402010847.34793-1-xieyi@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260401082754.96320-1-xieyi@kylinos.cn> References: <20260401082754.96320-1-xieyi@kylinos.cn> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=124.126.103.232; envelope-from=xieyi@kylinos.cn; helo=mailgw.kylinos.cn X-Spam_score_int: 1 X-Spam_score: 0.1 X-Spam_bar: / X-Spam_report: (0.1 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1775092196609158500 Content-Type: text/plain; charset="utf-8" incoming_queue is allocated by qemu_new_net_queue() and must be torn down w= ith qemu_del_net_queue(), which frees any queued NetPacket nodes. Using g_f= ree() on the NetQueue struct directly could leak packets if the queue was n= ot empty. Clear the pointer after destroy. Signed-off-by: Yi Xie --- net/filter-buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/filter-buffer.c b/net/filter-buffer.c index 427da24097..ce3e9027a0 100644 --- a/net/filter-buffer.c +++ b/net/filter-buffer.c @@ -95,7 +95,8 @@ static void filter_buffer_cleanup(NetFilterState *nf) /* flush packets */ if (s->incoming_queue) { filter_buffer_flush(nf); - g_free(s->incoming_queue); + qemu_del_net_queue(s->incoming_queue); + s->incoming_queue =3D NULL; } } =20 --=20 2.25.1