From nobody Sat Apr 11 19:59:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1775075370; cv=none; d=zohomail.com; s=zohoarc; b=QoMPYUfFLJA5C+il+mORaA7pcv++uSyLwAWWTAe9Et1xGEKtco6kXbr4Nw8SI8ADJNhF0WjaoczCeCB8vxMPJv0zHLX3XXzXhDq3Hicsfp9H1s8ePibpiC6qe24Hm1mBNUx4vZBNu0TkMHnWRhS8rF1x6leXBy710xBEP0RaL9k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775075370; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kb2EMKRNvdGGvafy+iD9MxCie+cNqjcod0U6cR8fsMU=; b=FrVtJfju0DcMOoJMArytqZv2HORBQiKXOc122txkoCt67+MKaUS9a0SsNHJQyeeg9z+QOCOxA60ukC8opBoDoG8j2+cRmqIaBnzb1oCLGjzvpB0d6mRoxREHRvmNRFZbpu3kCqlTf7DsrVPzaOIqGcsBuNFEz9gf4TGq1alcDVY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775075370258401.6808767267007; Wed, 1 Apr 2026 13:29:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w82BM-0004Ij-SU; Wed, 01 Apr 2026 16:28:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w82BL-0004IF-8x for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:28:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w82BI-00037d-SX for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:28:55 -0400 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-r6_3a1X9MvCFWx1yetxmMQ-1; Wed, 01 Apr 2026 16:28:49 -0400 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cfc575fa15so81095785a.2 for ; Wed, 01 Apr 2026 13:28:49 -0700 (PDT) Received: from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8d2a548a4efsm68194085a.8.2026.04.01.13.28.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 13:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775075330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kb2EMKRNvdGGvafy+iD9MxCie+cNqjcod0U6cR8fsMU=; b=WAXYEqfxt+fXMFD5e7Qbuy2WTbBpawK9CFixg/NP2cwYiC50y9Hc/lh0zr86C8IaHT8mFm LFKtinuonJ9KKKojYnlij3W+JiormaUJmwTibzux5Tt8LMMN5xLJwWq0+nW/Pnlu0UEkT2 mK/i+y3nQkO/9I5xpxgPPsT3Ml7OgN8= X-MC-Unique: r6_3a1X9MvCFWx1yetxmMQ-1 X-Mimecast-MFC-AGG-ID: r6_3a1X9MvCFWx1yetxmMQ_1775075329 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775075328; x=1775680128; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kb2EMKRNvdGGvafy+iD9MxCie+cNqjcod0U6cR8fsMU=; b=LzIQOCW0SuWXVoljHadEzaXPLnn4rYYvI2VeNK9mJiB/NJ1Uru3K6iNqQ1Inn54pW1 /SBb6h+1ii/hgqTEdVSO1mJoRJGJgJEoCXsqlcAgL2YnEFuqAvnUch6oKlx0WYfOh+iE EZ3fi8pCoUDfb4+xsg2c0B5j7uE2liv2NgEYt9RQ1NVS1tVqVIPWB05536qlZAInyQ9v 1tegFsC5Z/c5VD6qWksSl3Wd0Byb5OxwrRCYfqzCTWAcu+VYNUwV7lGbw1Facz0xGcZT 28hwH3CBOZGPh8IMVCP09IZCBTcPbC9evzKIzIHUp1raBJJaaVRA44NB+HvBzskdrI9Y +l1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775075328; x=1775680128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kb2EMKRNvdGGvafy+iD9MxCie+cNqjcod0U6cR8fsMU=; b=igHT8pPcb+rg1KgQMCWD4CbfAMCBLFX7TJabMAO+oSFbdYNAQHrycAw9jwfBLfpie4 HCmErjJU8xe0iPXJfnQufPWLOxuGGdgD76Rd79eCVcYTYaqQgbsddxYGfa0zfJzpW/Rx 7gRN4Ks31+NWnKd2gsC8dM7f14Sx8hfrfygd49Sm5tBxYb9+8qi9bCixxHWadmaix5Xh kMYPgFWYe7uMsz6Ebtu8KCe0ifrhs8LzKqMVDHRWmURHyXfeKf6CqT2BlmfxHgYgVbvd 7PCOaPw4RmGKCzrB1pBT3TeDFQqhhmo8p3Gzb4klNBSosmP7qMqu7dWza0LcEhO8JQM3 ZvJw== X-Gm-Message-State: AOJu0YxZCVrZ8Bwbw9Ziuac0NG2QUNFxcYFcqEmIc8KSO3HfiB3Vx7S1 XXG4qq3MQ9VQivpb30crEGb3m18WbHbkcnVtZdu8po7KDvvGxpLDeZUUdlC+Lhs10ew+sPHOMi6 4iUe+b90/55vud9oHxnTXkmTkC3LzZEgtVg+tNHyX/1Cb6dHRCmxgh7bruna5kluXNVtXg4fWqY zPAI5kGemcvEVy0A+gQhB5AHViLeVYnw/I1bViRw== X-Gm-Gg: ATEYQzyby4+cbEIS2gBZfGo1KN4ExBVaKmKElm+Zjdxzsm5Z7EhJgHKr+p1fysl85x2 wMx7BKDWCqclYuBvEHeJz9hC4h9dB2TWu903729ncFuu6ckTBlodaZw2mtEPactLJHIMJSg7Nb1 xFU9/2+L9KQkcEKOADFJyLliRMM60c1QAvwR3rH1+w5O9PWubjalPcsumhUSBhygzuVe7UGtoWU N/faJX3EJ2ahsSQEmJK63h9K4sIccr7VhstFzBVfdlC3v/pijqfln1+f3MtKcE+oigxnKeRO3tb 3YoMVNyZ7MDOjcDAGy/wl9Px0izu/vhU1uibsHPDOHjNvMFE8S1v74Tw45JkfyfLfGE8v+jKW2Z m1VNtpAzCNvvPI1iVcGnZr3fYvUU2LsVcvYoiOBFRN+I= X-Received: by 2002:a05:620a:2845:b0:8cf:b7c2:fd20 with SMTP id af79cd13be357-8d1b5aac057mr736321285a.11.1775075327841; Wed, 01 Apr 2026 13:28:47 -0700 (PDT) X-Received: by 2002:a05:620a:2845:b0:8cf:b7c2:fd20 with SMTP id af79cd13be357-8d1b5aac057mr736317485a.11.1775075327295; Wed, 01 Apr 2026 13:28:47 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Juraj Marcin , Alexander Mikhalitsyn , Fabiano Rosas , Peter Xu , Alexander Mikhalitsyn , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 01/11] vmstate: Pass in struct itself for VMSTATE_ARRAY_OF_POINTER Date: Wed, 1 Apr 2026 16:28:34 -0400 Message-ID: <20260401202844.673494-2-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260401202844.673494-1-peterx@redhat.com> References: <20260401202844.673494-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1775075372730154100 Passing in a pointer almost never helps. Convert it to pass in struct for further refactoring on VMS_ARRAY_OF_POINTER. Reviewed-by: Alexander Mikhalitsyn Reviewed-by: Fabiano Rosas Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Peter Xu --- include/migration/vmstate.h | 6 +++--- tests/unit/test-vmstate.c | 2 +- roms/seabios-hppa | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index d4a39aa794..d4880e75c2 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -547,9 +547,9 @@ extern const VMStateInfo vmstate_info_qlist; .version_id =3D (_version), \ .num =3D (_num), \ .info =3D &(_info), \ - .size =3D sizeof(_type), \ + .size =3D sizeof(_type *), \ .flags =3D VMS_ARRAY|VMS_ARRAY_OF_POINTER, \ - .offset =3D vmstate_offset_array(_state, _field, _type, _num), \ + .offset =3D vmstate_offset_array(_state, _field, _type *, _num), \ } =20 #define VMSTATE_ARRAY_OF_POINTER_TO_STRUCT(_f, _s, _n, _v, _vmsd, _type) {= \ @@ -1093,7 +1093,7 @@ extern const VMStateInfo vmstate_info_qlist; VMSTATE_TIMER_PTR_V(_f, _s, 0) =20 #define VMSTATE_TIMER_PTR_ARRAY(_f, _s, _n) \ - VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer = *) + VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer) =20 #define VMSTATE_TIMER_TEST(_f, _s, _test) \ VMSTATE_SINGLE_TEST(_f, _s, _test, 0, vmstate_info_timer, QEMUTimer) diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c index cadbab3c5e..6a42cc1a4e 100644 --- a/tests/unit/test-vmstate.c +++ b/tests/unit/test-vmstate.c @@ -668,7 +668,7 @@ const VMStateDescription vmsd_arpp =3D { .minimum_version_id =3D 1, .fields =3D (const VMStateField[]) { VMSTATE_ARRAY_OF_POINTER(ar, TestArrayOfPtrToInt, - AR_SIZE, 0, vmstate_info_int32, int32_t*), + AR_SIZE, 0, vmstate_info_int32, int32_t), VMSTATE_END_OF_LIST() } }; diff --git a/roms/seabios-hppa b/roms/seabios-hppa index cf3a472f4d..1a8ada1fb7 160000 --- a/roms/seabios-hppa +++ b/roms/seabios-hppa @@ -1 +1 @@ -Subproject commit cf3a472f4ddea30d2d483a8ba4b005505f0dabb3 +Subproject commit 1a8ada1fb70643172e251aacbac673c9ecda99e9 --=20 2.50.1