From nobody Sat Apr 11 20:07:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1775074722; cv=none; d=zohomail.com; s=zohoarc; b=LUUKg3NGNwwGmROKX/VfycLoT1A7iUXgOq/vC/9Pct8gAM0Ehb/Vby1iFNJHDOGPiw0JIxIuMzHc53dRJwjqcVChgCBos6IYRIBLoXP6ACR4ZUHK6stetqytxezNF/seZLomQORIDueFZsfBxy96Osc5XPjJsUMVxkFF7GsvTEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775074722; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=S1TEVy+T6k35I4U9/R8HmPKI1jXLjO9MCcFaUnfIfQ4=; b=lP5HpQeyF0t7tnw7v5ppP43UAY9BttpIUqR3N74mUTye+1W29qW6Z5IX1KzRqUtIz7m63/RmY84Pa4nDOcAzT4W/kGbGX9/h7yq5EJoy+dl+LYH1H7JQrl5P/8gVHEXVBQPGEnTCARxo0MEgcZnl66DmoFO0GYl0qz0kzeg70Wk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775074722770830.7979134946942; Wed, 1 Apr 2026 13:18:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w8215-00035r-Go; Wed, 01 Apr 2026 16:18:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w8213-0002x8-Fo for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:18:17 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w8210-0001aQ-8h for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:18:17 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4887f49ec5aso1574945e9.1 for ; Wed, 01 Apr 2026 13:18:13 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4888955d711sm39365835e9.9.2026.04.01.13.18.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 01 Apr 2026 13:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775074692; x=1775679492; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S1TEVy+T6k35I4U9/R8HmPKI1jXLjO9MCcFaUnfIfQ4=; b=kSyvrP/NsiKo+7FNADxkKcjvYuC5DQ4VfDPYCZjoHQQ/cC8FWzV0K+09cWOuTRUSLx tYXigCpweFBSSwXsd0q/uH+JlfDwGHi+6CkqrdAuq/eb6qtDhjTZl5nvstvnP706sR9Z qDoiId8RseSFrj4iy8TBT8fAeMEZyUJmB3bMzMl9uqASrfYkKlzI17+zwAhWLUEDtDfP UMsAJoe3Zg98N7fCogm3g81RWyQwH5UGRkRBWh/XC68xcs57KVEBgb/YMc1zPGatweoo XW7RzMcN9HSxkQNDoawBiwXF48tpL5B4YCC+bH7z115ITegIIpV11jmn8oHKbBhPD6Gq lMqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775074692; x=1775679492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S1TEVy+T6k35I4U9/R8HmPKI1jXLjO9MCcFaUnfIfQ4=; b=eqr2Z6l1Bur5OpyAiVCbMVYrwsKW5d/13tJW2KRr6/zE5fM9rfG69/xxBGtV2XeFtr 1s4pPw7MeZQvQRvOnHOWqqa/pmyOx8+DNzg+uKjmplAO/JoYd4DANQANODuBKLz0Bj3r kiTliGlY+mKN7y4G10m427QvK4qzd45GUdDKWVXoXiF40y4QHid77s+FlCkDeFzQWDt0 EJ2xPHtluHVvrXmDj811d6JYHuYaFc0700h9NNh+HBn+R7vNffTi86jQ1eCBE9YhlynZ cxPjJgpx1uec34ozcFtKlMkp0Ex7l70ioT+dhnaJre9/kUnAjgAvEoaaSOVsL9aTXh/D iGew== X-Gm-Message-State: AOJu0YwRhhDKJihXLSzzI3B6fV61I+LbD1pSWHh3OpPJUBnVrPy8x1ol LixYsl/DqtmEArjFQ448WiMIbnMQT7dPI+wXt+v/kLVO5MBU8WN4H4qmUgYLpwTlGcmlUDSpxyt d22QKhb4= X-Gm-Gg: ATEYQzzuX1wA7YcQBU+PcWqfU+BFMppTMgSw3XP+GNp/pyvvuMR2B3prpOsLNOFix76 ZaoW11aD72LZrRo3Bn7G+pl4qVusBr+a814k7wfiI2aVJ3I4299AK1EGZ+6YWtcOmKlE2Ei8veC NKcmyr4qFHc5jBRY0tKBwaTn0RwuZiuzhJmRBtVg/dk1IAMA4sJkdDdCJerkfUFi3JhE9/CYPEn j6UtTn/Fqj+g3+simdW0D8fQ207RUQnFLxXq1UzhXE/064cd3IxWPlp5omOBaiMhyr54BNyV1mP 6I4OtRvDSd05zn2URpxg7tJ6Wxp+7EXtlT/4xSEU+kWRHnDueXTm9WfyMeeiVV5/Hy/KEsiVshx /jHz8uNezguGjkHM6Y8z4CLnGLQYgdl3/F0K8jQ+85ghGvQ/pBF/766+HdY7VfaU5eY5iLgkaOR BoUrRjprFOpoMfZWeyhJD/96AuWBEaMqhUcT0/4R3chHcnuutp6GZ8ZCa355MWyiPTI5kCYCCH X-Received: by 2002:a05:600c:34c4:b0:485:3b9e:caa7 with SMTP id 5b1f17b1804b1-48883597b55mr94970015e9.23.1775074692245; Wed, 01 Apr 2026 13:18:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Eric Farman , Alistair Francis , Palmer Dabbelt , Paolo Bonzini , Matthew Rosato , Daniel Henrique Barboza , Pierrick Bouvier , kvm@vger.kernel.org, Peter Maydell , Huacai Chen , qemu-riscv@nongnu.org, Alexander Graf , Pedro Barbuda , Anton Johansson , Song Gao , Weiwei Li , Aleksandar Rikalo , Liu Zhiwei , Cornelia Huck , qemu-s390x@nongnu.org, Chao Liu , Bibo Mao , qemu-arm@nongnu.org, Jiaxun Yang , Mohamed Mediouni , Zhao Liu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno Subject: [PATCH-for-11.1 2/8] accel/kvm: Remove TARGET_KVM_HAVE_GUEST_DEBUG Date: Wed, 1 Apr 2026 22:17:46 +0200 Message-ID: <20260401201753.92290-3-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260401201753.92290-1-philmd@linaro.org> References: <20260401201753.92290-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1775074725719154100 All targets except MIPS have TARGET_KVM_HAVE_GUEST_DEBUG=3Dy. Declare the kvm_update_guest_debug() stub to MIPS and have TARGET_KVM_HAVE_GUEST_DEBUG be the default. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson --- configs/targets/aarch64-softmmu.mak | 1 - configs/targets/i386-softmmu.mak | 1 - configs/targets/loongarch64-softmmu.mak | 1 - configs/targets/ppc-softmmu.mak | 1 - configs/targets/ppc64-softmmu.mak | 1 - configs/targets/riscv64-softmmu.mak | 1 - configs/targets/s390x-softmmu.mak | 1 - configs/targets/x86_64-softmmu.mak | 1 - include/system/kvm.h | 7 ------- include/system/kvm_int.h | 2 -- accel/kvm/kvm-accel-ops.c | 4 ---- accel/kvm/kvm-all.c | 13 ++----------- target/mips/kvm.c | 5 +++++ 13 files changed, 7 insertions(+), 32 deletions(-) diff --git a/configs/targets/aarch64-softmmu.mak b/configs/targets/aarch64-= softmmu.mak index d34aead41c4..6f60ca6505c 100644 --- a/configs/targets/aarch64-softmmu.mak +++ b/configs/targets/aarch64-softmmu.mak @@ -1,6 +1,5 @@ TARGET_ARCH=3Daarch64 TARGET_BASE_ARCH=3Darm -TARGET_KVM_HAVE_GUEST_DEBUG=3Dy TARGET_XML_FILES=3D aarch64-core.xml aarch64-fpu.xml arm-core.xml arm-vfp.= xml arm-vfp3.xml arm-vfp-sysregs.xml arm-neon.xml arm-m-profile.xml arm-m-p= rofile-mve.xml aarch64-pauth.xml aarch64-sme2.xml # needed by boot.c TARGET_NEED_FDT=3Dy diff --git a/configs/targets/i386-softmmu.mak b/configs/targets/i386-softmm= u.mak index 38a8f85201f..2eef68dc55e 100644 --- a/configs/targets/i386-softmmu.mak +++ b/configs/targets/i386-softmmu.mak @@ -1,5 +1,4 @@ TARGET_ARCH=3Di386 -TARGET_KVM_HAVE_GUEST_DEBUG=3Dy TARGET_KVM_HAVE_RESET_PARKED_VCPU=3Dy TARGET_XML_FILES=3D i386-32bit.xml TARGET_LONG_BITS=3D32 diff --git a/configs/targets/loongarch64-softmmu.mak b/configs/targets/loon= garch64-softmmu.mak index 476407f9413..7e0b1ab5d05 100644 --- a/configs/targets/loongarch64-softmmu.mak +++ b/configs/targets/loongarch64-softmmu.mak @@ -1,6 +1,5 @@ TARGET_ARCH=3Dloongarch64 TARGET_BASE_ARCH=3Dloongarch -TARGET_KVM_HAVE_GUEST_DEBUG=3Dy TARGET_XML_FILES=3D loongarch-base32.xml loongarch-base64.xml loongarch-fp= u.xml loongarch-lsx.xml loongarch-lasx.xml # all boards require libfdt TARGET_NEED_FDT=3Dy diff --git a/configs/targets/ppc-softmmu.mak b/configs/targets/ppc-softmmu.= mak index 867898bd47c..c47887f8992 100644 --- a/configs/targets/ppc-softmmu.mak +++ b/configs/targets/ppc-softmmu.mak @@ -1,5 +1,4 @@ TARGET_ARCH=3Dppc TARGET_BIG_ENDIAN=3Dy -TARGET_KVM_HAVE_GUEST_DEBUG=3Dy TARGET_XML_FILES=3D power-core.xml power-fpu.xml power-altivec.xml power-s= pe.xml TARGET_LONG_BITS=3D32 diff --git a/configs/targets/ppc64-softmmu.mak b/configs/targets/ppc64-soft= mmu.mak index 10d7a2681e7..8c6dc84b821 100644 --- a/configs/targets/ppc64-softmmu.mak +++ b/configs/targets/ppc64-softmmu.mak @@ -1,7 +1,6 @@ TARGET_ARCH=3Dppc64 TARGET_BASE_ARCH=3Dppc TARGET_BIG_ENDIAN=3Dy -TARGET_KVM_HAVE_GUEST_DEBUG=3Dy TARGET_XML_FILES=3D power64-core.xml power-fpu.xml power-altivec.xml power= -spe.xml power-vsx.xml # all boards require libfdt TARGET_NEED_FDT=3Dy diff --git a/configs/targets/riscv64-softmmu.mak b/configs/targets/riscv64-= softmmu.mak index 5059c550480..e0d2c7032d6 100644 --- a/configs/targets/riscv64-softmmu.mak +++ b/configs/targets/riscv64-softmmu.mak @@ -1,6 +1,5 @@ TARGET_ARCH=3Driscv64 TARGET_BASE_ARCH=3Driscv -TARGET_KVM_HAVE_GUEST_DEBUG=3Dy TARGET_XML_FILES=3D riscv-64bit-cpu.xml riscv-32bit-fpu.xml riscv-64bit-fp= u.xml riscv-64bit-virtual.xml riscv-32bit-cpu.xml riscv-32bit-virtual.xml # needed by boot.c TARGET_NEED_FDT=3Dy diff --git a/configs/targets/s390x-softmmu.mak b/configs/targets/s390x-soft= mmu.mak index e273075f1a9..699e5ced96f 100644 --- a/configs/targets/s390x-softmmu.mak +++ b/configs/targets/s390x-softmmu.mak @@ -1,6 +1,5 @@ TARGET_ARCH=3Ds390x TARGET_BIG_ENDIAN=3Dy -TARGET_KVM_HAVE_GUEST_DEBUG=3Dy TARGET_XML_FILES=3D s390x-core64.xml s390-acr.xml s390-fpr.xml s390-vx.xml= s390-cr.xml s390-virt.xml s390-virt-kvm.xml s390-gs.xml TARGET_LONG_BITS=3D64 TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/x86_64-softmmu.mak b/configs/targets/x86_64-so= ftmmu.mak index c7f8746b4f5..491173df466 100644 --- a/configs/targets/x86_64-softmmu.mak +++ b/configs/targets/x86_64-softmmu.mak @@ -1,6 +1,5 @@ TARGET_ARCH=3Dx86_64 TARGET_BASE_ARCH=3Di386 -TARGET_KVM_HAVE_GUEST_DEBUG=3Dy TARGET_KVM_HAVE_RESET_PARKED_VCPU=3Dy TARGET_XML_FILES=3D i386-64bit.xml i386-64bit-apx.xml TARGET_LONG_BITS=3D64 diff --git a/include/system/kvm.h b/include/system/kvm.h index 12f7fc8fb58..a2463a3ac3f 100644 --- a/include/system/kvm.h +++ b/include/system/kvm.h @@ -236,14 +236,7 @@ void kvm_irqchip_change_notify(void); * calling down to kvm_arch_update_guest_debug after the generic * fields have been set. */ -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap); -#else -static inline int kvm_update_guest_debug(CPUState *cpu, unsigned long rein= ject_trap) -{ - return -EINVAL; -} -#endif =20 /* internal API */ =20 diff --git a/include/system/kvm_int.h b/include/system/kvm_int.h index 0876aac938d..9d1d3fd3deb 100644 --- a/include/system/kvm_int.h +++ b/include/system/kvm_int.h @@ -113,9 +113,7 @@ struct KVMState struct kvm_coalesced_mmio_ring *coalesced_mmio_ring; bool coalesced_flush_in_progress; int vcpu_events; -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints; -#endif int max_nested_state_len; int kvm_shadow_mem; bool kernel_irqchip_allowed; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 6d9140e549f..d4af6b416c3 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -85,12 +85,10 @@ static bool kvm_cpus_are_resettable(void) return !kvm_enabled() || !kvm_state->guest_state_protected; } =20 -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG static int kvm_update_guest_debug_ops(CPUState *cpu) { return kvm_update_guest_debug(cpu, 0); } -#endif =20 static void kvm_accel_ops_class_init(ObjectClass *oc, const void *data) { @@ -105,13 +103,11 @@ static void kvm_accel_ops_class_init(ObjectClass *oc,= const void *data) ops->synchronize_pre_loadvm =3D kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt =3D generic_handle_interrupt; =20 -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; ops->supports_guest_debug =3D kvm_supports_guest_debug; ops->insert_breakpoint =3D kvm_insert_breakpoint; ops->remove_breakpoint =3D kvm_remove_breakpoint; ops->remove_all_breakpoints =3D kvm_remove_all_breakpoints; -#endif } =20 static const TypeInfo kvm_accel_ops_type =3D { diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 774499d34f8..9a46a61b7f5 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2919,9 +2919,7 @@ static int kvm_init(AccelState *as, MachineState *ms) s->sigmask_len =3D 8; accel_blocker_init(); =20 -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG QTAILQ_INIT(&s->kvm_sw_breakpoints); -#endif QLIST_INIT(&s->kvm_parked_vcpus); s->fd =3D qemu_open_old(s->device ?: "/dev/kvm", O_RDWR); if (s->fd =3D=3D -1) { @@ -3032,23 +3030,19 @@ static int kvm_init(AccelState *as, MachineState *m= s) kvm_vm_attributes_allowed =3D (kvm_check_extension(s, KVM_CAP_VM_ATTRIBUTES) > 0); =20 -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG kvm_has_guest_debug =3D (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); -#endif =20 kvm_sstep_flags =3D 0; if (kvm_has_guest_debug) { - kvm_sstep_flags =3D SSTEP_ENABLE; - -#if defined TARGET_KVM_HAVE_GUEST_DEBUG int guest_debug_flags =3D kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG2); =20 + kvm_sstep_flags =3D SSTEP_ENABLE; + if (guest_debug_flags & KVM_GUESTDBG_BLOCKIRQ) { kvm_sstep_flags |=3D SSTEP_NOIRQ; } -#endif } =20 kvm_state =3D s; @@ -3781,7 +3775,6 @@ bool kvm_arm_supports_user_irq(void) return kvm_check_extension(kvm_state, KVM_CAP_ARM_USER_IRQ); } =20 -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG struct kvm_sw_breakpoint *kvm_find_sw_breakpoint(CPUState *cpu, vaddr pc) { struct kvm_sw_breakpoint *bp; @@ -3941,8 +3934,6 @@ void kvm_remove_all_breakpoints(CPUState *cpu) } } =20 -#endif /* !TARGET_KVM_HAVE_GUEST_DEBUG */ - static int kvm_set_signal_mask(CPUState *cpu, const sigset_t *sigset) { KVMState *s =3D kvm_state; diff --git a/target/mips/kvm.c b/target/mips/kvm.c index a85e162409c..49bff68b137 100644 --- a/target/mips/kvm.c +++ b/target/mips/kvm.c @@ -1262,6 +1262,11 @@ int kvm_arch_msi_data_to_gsi(uint32_t data) abort(); } =20 +int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap) +{ + return -EINVAL; +} + int kvm_arch_get_default_type(MachineState *machine) { #if defined(KVM_CAP_MIPS_VZ) --=20 2.53.0