From nobody Wed Apr 1 22:06:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=yodel.dev ARC-Seal: i=1; a=rsa-sha256; t=1775063145; cv=none; d=zohomail.com; s=zohoarc; b=GWLNq70cZkkGCea1mAQK31pJ501w8WrXmv0h8ADMmPLbUKOL+mu/65RjtAc7qPl6Z6MfLcKYYFHTlT2QDq4rJ2tOmWx9AGUNUCi0aYeA86OhVblmSRvesb22RSJBMuKQggR+RrKCAwq9ZSNAN2QpIU8IT1yL8+b49sH/EbXWm6k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775063145; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sbl1/SbOW5RNXGHHar18gl/ANw6AoNz11ZBRCd42A2E=; b=OKM04x5Nn86h70IA8wHGb6KrKAgXfixVzdr9jwwv4bHxWKuDVyJCLEnWHkVvU4p3SQ6oJ+OAh2MHKfIPufgp4g/xWvRnP5ZP14Dj0RLuNgf+4oeMVYmTj+7F0gsRt4Mh2BLbaHPbzZABfqt2U2OQqjOOQDMCX+2gJlnix7TChGU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775063145077709.5030879953591; Wed, 1 Apr 2026 10:05:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7z0O-0000vL-Pu; Wed, 01 Apr 2026 13:05:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7z09-0000pk-O0 for qemu-devel@nongnu.org; Wed, 01 Apr 2026 13:05:11 -0400 Received: from v512.v5f06b487.use4.send.mailgun.net ([143.55.232.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w7z07-0007ss-A9 for qemu-devel@nongnu.org; Wed, 01 Apr 2026 13:05:08 -0400 Received: from mail.yodel.dev (mail.yodel.dev [35.209.39.246]) by ff02f649880f4c1d5d70100ea9aa6e7e10e475320cb5153f37db282a819a7e15 with SMTP id 69cd503a909492175f9ecf6f; Wed, 01 Apr 2026 17:04:58 GMT X-Mailgun-Sid: WyI4ZDFlNiIsInFlbXUtZGV2ZWxAbm9uZ251Lm9yZyIsIjk3NjA3ZSJd X-Mailgun-Sending-Ip: 143.55.232.12 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yodel.dev; s=rsa2048; t=1775063098; bh=sbl1/SbOW5RNXGHHar18gl/ANw6AoNz11ZBRCd42A2E=; h=X-Mailgun-Dkim:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:From:Reply-to: Subject:Date:Message-id:To:Cc:Mime-version:Content-type: Content-transfer-encoding:In-reply-to:References; b=DhaU0sya4y8ECW/vFKKDG5ogOzFK5AalKAx6xq+fISybhtbjKZKPdQKU9ZrgEoWoM X1ryqziLXsm0RFuOC4uvZ+p5hxE+SKt5yvp6QndFcc3LvrcUrqoAgSTCVkt2k+cw+S zq1POc88TbK9ejvPTMf/qH0ktHRzF1pXjO4blrJUJVVBORkYxU5DSHSDaHWdni608w 4SfTz6Jh9LxdMLOFZVlJLFbiaMNr/zVTKiqXYhf++DTX2z1k7mFH97e39SNQ4i8U70 8+Kz4gBbpvKP+93GQqZ4CBPGzlQL9nFkbXU4IAs8eWt23f1b0nJhFYZInBsEBNXsoq M+PfgLgo1Hq8w== X-Mailgun-Dkim: no X-Mailgun-Dkim: no From: "Yodel Eldar" To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yodel Eldar Subject: [RFC PATCH 2/4] alpha: Propagate CPU index via MemTxAttrs Date: Wed, 1 Apr 2026 12:04:52 -0500 Message-ID: <20260401170454.32045-3-yodel.eldar@yodel.dev> In-Reply-To: <20260401170454.32045-1-yodel.eldar@yodel.dev> References: <20260401170454.32045-1-yodel.eldar@yodel.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=143.55.232.12; envelope-from=bounce+0e9322.97607e-qemu-devel=nongnu.org@yodel.dev; helo=v512.v5f06b487.use4.send.mailgun.net X-Spam_score_int: 0 X-Spam_score: -0.1 X-Spam_bar: / X-Spam_report: (-0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HELO_STATIC_HOST=-0.001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yodel.dev) X-ZM-MESSAGEID: 1775063148102154100 Content-Type: text/plain; charset="utf-8" From: Yodel Eldar Currently, a read of the Typhoon Cchip's MISC register dereferences current_cpu for the CPU index. To decouple Typhoon from the CPU, let's instead pass the CPU index through the requester_id attribute of the memory transaction. Signed-off-by: Yodel Eldar --- hw/alpha/typhoon.c | 7 ++++--- target/alpha/helper.c | 15 ++++++++++++--- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index 26580664d8..5dadfa7691 100644 --- a/hw/alpha/typhoon.c +++ b/hw/alpha/typhoon.c @@ -74,7 +74,6 @@ static MemTxResult cchip_read(void *opaque, hwaddr addr, uint64_t *data, unsigned size, MemTxAttrs attrs) { - CPUState *cpu =3D current_cpu; TyphoonState *s =3D opaque; uint64_t ret =3D 0; =20 @@ -90,10 +89,12 @@ static MemTxResult cchip_read(void *opaque, hwaddr addr, /* All sorts of stuff related to real DRAM. */ break; =20 - case 0x0080: + case 0x0080: { /* MISC: Miscellaneous Register. */ - ret =3D s->cchip.misc | (cpu->cpu_index & 3); + uint64_t cpu_index =3D attrs.requester_id & 3; + ret =3D s->cchip.misc | cpu_index; break; + } =20 case 0x00c0: /* MPD: Memory Presence Detect Register. */ diff --git a/target/alpha/helper.c b/target/alpha/helper.c index 179dc2dc7a..bebb0e4804 100644 --- a/target/alpha/helper.c +++ b/target/alpha/helper.c @@ -164,13 +164,19 @@ void alpha_cpu_record_sigsegv(CPUState *cs, vaddr add= ress, env->trap_arg2 =3D cause; } #else +static inline QEMU_ALWAYS_INLINE +MemTxAttrs alpha_cpu_get_mem_attrs(const CPUState *cs) +{ + return (MemTxAttrs){ .requester_id =3D cs->cpu_index }; +} + /* Returns the OSF/1 entMM failure indication, or -1 on success. */ static int get_physical_address(CPUAlphaState *env, vaddr addr, int prot_need, int mmu_idx, hwaddr *pphys, int *pprot) { - const MemTxAttrs attrs =3D MEMTXATTRS_UNSPECIFIED; CPUState *cs =3D env_cpu(env); + const MemTxAttrs attrs =3D alpha_cpu_get_mem_attrs(cs); target_long saddr =3D addr; hwaddr phys =3D 0; uint64_t L1pte, L2pte, L3pte; @@ -327,8 +333,11 @@ bool alpha_cpu_tlb_fill(CPUState *cs, vaddr addr, int = size, cpu_loop_exit_restore(cs, retaddr); } =20 - tlb_set_page(cs, addr & TARGET_PAGE_MASK, phys & TARGET_PAGE_MASK, - prot, mmu_idx, TARGET_PAGE_SIZE); + tlb_set_page_with_attrs(cs, addr & TARGET_PAGE_MASK, + phys & TARGET_PAGE_MASK, + alpha_cpu_get_mem_attrs(cs), + prot, mmu_idx, TARGET_PAGE_SIZE); + return true; } =20 --=20 2.53.0