From nobody Thu Apr 2 00:09:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1775037068; cv=none; d=zohomail.com; s=zohoarc; b=Elzvg6QKCfz6zKfzVjQ6E3IrentQcVgr93BialyMAx9JvgQH9qBVEHcIDVuHRLBcCdm+mXT5a39+t4zv6UN2UbJW2fAqqv27PDrQUO33YuHMl/ANH3H28MbO8Okkl0f3YgYa3/Tg4kuw6uxlCHz41p0QJ5ubt7lgHe9M8OS+PW8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775037068; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FQlLuqBlofX3uwleqTH/bOejvCfxP7Dih45IUdK2pVA=; b=RG1wfs0Ib9iZSzIaxeCCXA75JR582zTmyjoaXcDPOhWDVCr734mvFvlmTGi+eDUxC3ISBkvppg4h6dCkTBG5SN/hI6fu+E6DTpvOumtsd0aIwCt2v1LpYDKQ3aFO6v1J8gYxCGPODw/4MLAu9KgFZDn48KnecJPGZaF3bhXy6/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775037068124429.6676218554212; Wed, 1 Apr 2026 02:51:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7sDe-0002Sd-94; Wed, 01 Apr 2026 05:50:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7sDc-0002Pj-9r for qemu-devel@nongnu.org; Wed, 01 Apr 2026 05:50:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7sDZ-0000j2-F9 for qemu-devel@nongnu.org; Wed, 01 Apr 2026 05:50:35 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-I01FGTmaNJWMRa5sl99-Kg-1; Wed, 01 Apr 2026 05:50:31 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9D750180034E for ; Wed, 1 Apr 2026 09:50:30 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.44.48.48]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CC1B419560AB; Wed, 1 Apr 2026 09:50:29 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 11F96180060B; Wed, 01 Apr 2026 11:50:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775037032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FQlLuqBlofX3uwleqTH/bOejvCfxP7Dih45IUdK2pVA=; b=MxWOEsfnz7eL/5A8aiLm4hlOK5kVFg1lNjASyJJTQ1Se3f+C12E6+1DE5dbZlMTGd8+kYF ZHaMFwk8sD2CBHOoj3lFpKAM3bf/UaiNSNc3sqlg7z40rRktVhkK7mXyu9GCetI4qgsgui RuUlVIAtjO9nP736mtZ3lEd7XI3Au48= X-MC-Unique: I01FGTmaNJWMRa5sl99-Kg-1 X-Mimecast-MFC-AGG-ID: I01FGTmaNJWMRa5sl99-Kg_1775037030 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Ani Sinha , Stefano Garzarella , Gerd Hoffmann , Luigi Leonardi Subject: [PULL 2/3] igvm: fix memory leak on failed memory region init Date: Wed, 1 Apr 2026 11:50:23 +0200 Message-ID: <20260401095024.1562621-3-kraxel@redhat.com> In-Reply-To: <20260401095024.1562621-1-kraxel@redhat.com> References: <20260401095024.1562621-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1775037070157158500 Content-Type: text/plain; charset="utf-8" From: Luigi Leonardi When memory_region_init_* fail, `igvm_pages` is not freed causing a leak. Free `igvm_pages` in the error path. Fixes: c1d466d267cf ("backends/igvm: Add IGVM loader and configuration") Signed-off-by: Luigi Leonardi Message-ID: <20260330-igvm_fixes-v1-2-03587a5a808b@redhat.com> Signed-off-by: Gerd Hoffmann --- backends/igvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/backends/igvm.c b/backends/igvm.c index 50f0d6fb9a7b..c347d0c17e7e 100644 --- a/backends/igvm.c +++ b/backends/igvm.c @@ -216,11 +216,13 @@ static void *qigvm_prepare_memory(QIgvm *ctx, uint64_= t addr, uint64_t size, ctx->machine_state->cgs->require_guest_memfd) { if (!memory_region_init_ram_guest_memfd(igvm_pages, NULL, region_name, size, err= p)) { + g_free(igvm_pages); return NULL; } } else { if (!memory_region_init_ram(igvm_pages, NULL, region_name, siz= e, errp)) { + g_free(igvm_pages); return NULL; } } --=20 2.53.0