From nobody Sat Apr 11 21:59:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1774976966; cv=none; d=zohomail.com; s=zohoarc; b=fwxJ1lqMynVefUe6GfWO9L3Pvo2DrhlMOuEihmvXFIUY7SKJuLXSWraktH4kp0a6I4txlZz2gleyJbCx5OxAKMOiTxadUz3G1Bg/rlD7t/2mjCc4OUmf2WYDftjhfkOjFXe7aHm4s7FmsjcYib96r9cRixjDZbm4k3QX7UwLMUk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774976966; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=W/Vp9csjxDdP8UCdEEf84+/qxz8piPF+LrR8kcVgFz0=; b=B7wEqCG6ln9K8B03enojXTYY36TKXS/dWiC7r7OiMUsQ2n8kDHtBz8lS4sggzLKKVeUXTVN6BzlPa1g6kYz2y0tMCozYF8jQP9P7CpPSniXEwWFI7mrYJXIeIUajh7t/XEeaIywUoULo3HFKtpg8duuD24A7BwsB0R7oTVbk+bc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17749769661940.33107690475287654; Tue, 31 Mar 2026 10:09:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7caK-0003wa-So; Tue, 31 Mar 2026 13:09:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7caG-0003pT-Lj for qemu-devel@nongnu.org; Tue, 31 Mar 2026 13:08:56 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w7caF-0003Cd-6u for qemu-devel@nongnu.org; Tue, 31 Mar 2026 13:08:56 -0400 Received: by mail-pf1-x442.google.com with SMTP id d2e1a72fcca58-829a9d08644so3156308b3a.1 for ; Tue, 31 Mar 2026 10:08:53 -0700 (PDT) Received: from fedora ([103.2.232.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca843b818sm13647889b3a.6.2026.03.31.10.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 10:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774976932; x=1775581732; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W/Vp9csjxDdP8UCdEEf84+/qxz8piPF+LrR8kcVgFz0=; b=tBHGtJrAfydRqCBxljz5f9awSV+vffYEO8epUIv3pQSWh4tlvqPD8BG2CJ9vBYOihv Sp9fxnfh4BH76Jfto9CIOyRDZjq3O2F63UUA1wtU/4aMNUOp9zxECYv78Uvbg/1Wq7jO 6l8dplOSgnyuUcYvthFW3mjgWGATISK7VnT5qfwB68fdd/Yb4fK4iWe0wEko3IM3aQGN Nowcb4/dnm89ToqGlgMHCpGl1nRedsacw7cpvsNqkmUv0MZhaPkpQry46m0/S+p7Y6Jk W1NWrzWvJWEcVvA2nCn9SikpJIdNlFRDLZv8+DQhqoehKRBi7wOb52dg8K2dwzMTKgs4 Yi3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774976932; x=1775581732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W/Vp9csjxDdP8UCdEEf84+/qxz8piPF+LrR8kcVgFz0=; b=ZLNr5uqxuVWWuOibMClP0uGtCvCJT12X5IAOwqFLY6jstphPQ1+Uu4PIAR5FNMhJmQ iOOLml+ElWgkys93pMMipTAusNkYLV4+6w915AEcLaO0zuhS48mevuDBUkp+5O/Ti7Rb RVQijk8i1s2eBQnfnUI8EkFMH4nnvcBFzsmIu/KyTAGwLFfO7A7Npm4PW9LhaK+BKFh5 SOYFxGZbjLZ920gj4O8t6WQK5gMKdN/l0kLwMUV459XUPBZVZw3kwH8snB8mO1/KQPrf UfiCn+6z2Rmy/BNDZCKwiQdVeTQ9pZkKublkpobxwtCgC3gEsloP4nsHuL+S3wu5Eoom 49fQ== X-Gm-Message-State: AOJu0YxvwJKI2qrzrpcGqoeiaaXKfqUqPaiGQqN/ieaobtkDHRd5MPqR /CxubIsEQueAdOTurL+USoTrzbxzCBOio3Vm90oQ9WFkFrZpF3D2jIbVBFBG38OF X-Gm-Gg: ATEYQzx50VTOS8ULWpg/Gd191FCD0LsEuXl40yPrmc95DCxnNnxsE5lLsub6nCL5sQL 19uqe2dBVVW0gZzhnMGp0zrbjUOPtfbFUqS3mzDct4CJBr5yWu+6PRjt3H8XaPuw8vBAxGBxRNz 2aXVnLedFgQ7jiUCLBgEePA6F/D0ts2Wv4r6IXQ2Pnhq3tm7edtMNnzX2en0d8inrPta3GktS10 oPoqne7slySWb8tfWvoILaHjePwev7uJ6Tx+kChBeXdxgeH+xylMvF6WRhUNlC81/pM2e20QrX3 xr45vFjjrGKZyWmdLUrzLZcjgNU08h5vP9xfW3WoZIvPZor03QzvxKXYVAbBqueLTg7qpf44de5 WFKW6o2t22nLgmZEffCDlqsWV3IVFPSysOmZHpYOI3KIqTYqXCn1lNUDhKX5iLEFqlVJHxRc0qG VpZxXI0TD8OKIcMYnWZwkfs0RvMDd3F3drS10SOG4R5QzE3PiuPe/q2fs4p8b1nxjFZ+sQv091N 8lC7Ie9iA9QMHepClfAfa+nNwjWqmt0B8s0HwLvRF1QU2PEs4vSdaoEFEA2TOdXdiHUrXurdg== X-Received: by 2002:a05:6a00:a1b:b0:7aa:a2a8:9808 with SMTP id d2e1a72fcca58-82ce893ed22mr420788b3a.20.1774976932503; Tue, 31 Mar 2026 10:08:52 -0700 (PDT) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org Cc: Richard Henderson , Paolo Bonzini , Soumyajyotii Ssarkar , Michael Tokarev , Thomas Lambertz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alex Golovko , ShengYi Hung , Soumyajyotii Ssarkar Subject: [RFC PATCH 4/5] usb/hid: handle mouse feature report for wheel/pan multipliers Date: Tue, 31 Mar 2026 22:38:22 +0530 Message-ID: <20260331170823.72511-5-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331170823.72511-1-soumyajyotisarkar23@gmail.com> References: <20260331170823.72511-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x442.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1774976968589154100 Content-Type: text/plain; charset="utf-8" Implement HID feature report handlers (GET_REPORT/SET_REPORT) for report ID 0x02 to allow guests to configure wheel/pan resolution multipliers. Multiplier encoding: - Bits [1:0]: wheel_multiplier (0=3D+-1, 1=3D+-4, 2=3D+-8, 3=3D+-16) - Bits [3:2]: pan_multiplier (0=3D+-1, 1=3D+-4, 2=3D+-8, 3=3D+-16) Supports flexible payload formats (with/without report ID byte). Allows Windows guests to dynamically adjust scroll sensitivity without driver installation. Signed-off-by: Soumyajyotii Ssarkar --- hw/usb/dev-hid.c | 65 ++++++++++++++++++++++++++++++++++++------ include/hw/input/hid.h | 2 ++ 2 files changed, 59 insertions(+), 8 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 49e23c2319..cdcf2a4a0e 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @@ -672,17 +672,66 @@ static void usb_hid_handle_control(USBDevice *dev, US= BPacket *p, } break; case HID_GET_REPORT: - if (hs->kind =3D=3D HID_MOUSE || hs->kind =3D=3D HID_TABLET) { - p->actual_length =3D hid_pointer_poll(hs, data, length); - } else if (hs->kind =3D=3D HID_KEYBOARD) { - p->actual_length =3D hid_keyboard_poll(hs, data, length); + { + uint8_t mult; + uint8_t report_type =3D (value >> 8) & 0xFF; + uint8_t report_id =3D value & 0xFF; + + if (report_type =3D=3D 0x03 && report_id =3D=3D 0x02 && + hs->kind =3D=3D HID_MOUSE) { + + if (length < 1) { + goto fail; + } + + mult =3D ((hs->ptr.pan_multiplier & 0x03) << 2) | + (hs->ptr.wheel_multiplier & 0x03); + if (length >=3D 2) { + data[0] =3D 0x02; + data[1] =3D mult; + p->actual_length =3D 2; + } else { + data[0] =3D mult; + p->actual_length =3D 1; + } + + } else if (hs->kind =3D=3D HID_MOUSE || hs->kind =3D=3D HID_TA= BLET) { + p->actual_length =3D hid_pointer_poll(hs, data, length); + } else if (hs->kind =3D=3D HID_KEYBOARD) { + p->actual_length =3D hid_keyboard_poll(hs, data, length); + } else { + goto fail; + } } break; case HID_SET_REPORT: - if (hs->kind =3D=3D HID_KEYBOARD) { - p->actual_length =3D hid_keyboard_write(hs, data, length); - } else { - goto fail; + { + uint8_t mult; + uint8_t report_type =3D (value >> 8) & 0xFF; + uint8_t report_id =3D value & 0xFF; + + if (report_type =3D=3D 0x03 && report_id =3D=3D 0x02 && + hs->kind =3D=3D HID_MOUSE) { + + if (length < 1) { + goto fail; + } + + if (length >=3D 2 && data[0] =3D=3D 0x02) { + mult =3D data[1]; + } else { + mult =3D data[0]; + } + + hs->ptr.wheel_multiplier =3D mult & 0x03; + hs->ptr.pan_multiplier =3D (mult >> 2) & 0x03; + p->actual_length =3D length; + + } else if (hs->kind =3D=3D HID_KEYBOARD) { + p->actual_length =3D hid_keyboard_write(hs, data, length); + } else { + goto fail; + } } break; case HID_GET_PROTOCOL: diff --git a/include/hw/input/hid.h b/include/hw/input/hid.h index 1bb1778ee7..1a1941d371 100644 --- a/include/hw/input/hid.h +++ b/include/hw/input/hid.h @@ -23,6 +23,8 @@ typedef void (*HIDEventFunc)(HIDState *s); typedef struct HIDMouseState { HIDPointerEvent queue[QUEUE_LENGTH]; int mouse_grabbed; + uint8_t wheel_multiplier; + uint8_t pan_multiplier; } HIDMouseState; typedef struct HIDKeyboardState { -- 2.53.0