From nobody Wed Apr 1 23:51:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774952830; cv=none; d=zohomail.com; s=zohoarc; b=M4vLHheF0THYUkC2PVuNfzpQX/T3H/juh+qF+qV7xSnh2YQevTsFsg+A0i6swKj2HNZsTQTqiMMXgpJmyZicgEVCboUioickogBe7ZN64zXNmlrcsIMdqMyi6h2fkd9dBN0uk0KAzaREC9Y8RB6WEN8Gp4QHzG0fCokWCiq8oww= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774952830; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YMX7uqCepZbBy0LM9S6dtaAYYNd8bWTL8dzhvurWY/c=; b=JOit6Y5oF+I2LlN+HaccjHRsWCQiOxnLWyvUHthhGFaAEDcuAeVtdOTYL/ekHdC8z7Ky61o6XbZ2r1mhYK1HLOe4C7f+zgiNDkqEIrwYmrr2aMxV7qHrtuQfJKhRH1LHyfTDOm4KsDDs6HyFIOYRXDOsEpnfguE5nAk8wfEmfR0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774952830047167.479367946327; Tue, 31 Mar 2026 03:27:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7WIw-0006YW-OK; Tue, 31 Mar 2026 06:26:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7WIk-0006Ne-L2 for qemu-devel@nongnu.org; Tue, 31 Mar 2026 06:26:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7WIi-0003y7-Tu for qemu-devel@nongnu.org; Tue, 31 Mar 2026 06:26:26 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-45-kE__8mKrNe-6d7kTvaqrEw-1; Tue, 31 Mar 2026 06:26:20 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 62695195607B; Tue, 31 Mar 2026 10:26:19 +0000 (UTC) Received: from merkur.redhat.com (unknown [10.44.50.38]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E4A9E19560AB; Tue, 31 Mar 2026 10:26:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774952783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YMX7uqCepZbBy0LM9S6dtaAYYNd8bWTL8dzhvurWY/c=; b=T0Fz1+qY0KwTkOdH96H3Bh9g1Ox518+CYcmxDJrs1sgrtOY7w5MAw8CZF6YXIOSdhoa48w BBgMYSVRnn+r4g5EhbO7N85CQaxJd5rxH6YGqZcFKalaxJdk9TLC3L62gFiFZYfsSHz100 p6UKriLFBKjND21MzEMSU0AnKPLoy7E= X-MC-Unique: kE__8mKrNe-6d7kTvaqrEw-1 X-Mimecast-MFC-AGG-ID: kE__8mKrNe-6d7kTvaqrEw_1774952779 From: Kevin Wolf To: qemu-block@nongnu.org Cc: kwolf@redhat.com, hreitz@redhat.com, qemu-devel@nongnu.org Subject: [PATCH] block: Fix crash after setting latency historygram with single bin Date: Tue, 31 Mar 2026 12:26:08 +0200 Message-ID: <20260331102608.60882-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 27 X-Spam_score: 2.7 X-Spam_bar: ++ X-Spam_report: (2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774952831320158500 Content-Type: text/plain; charset="utf-8" Passing an empty list of boundaries to block-latency-histogram-set sets up a state that leads to a NULL pointer dereference when the next request should be accounted for. This is not a useful configuration, so just error out if the user tries to set it. The crash can easily be reproduced with the following script: qmp() { cat < Reviewed-by: Hanna Czenczek Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- block/accounting.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/block/accounting.c b/block/accounting.c index 5cf51f029b1..f00fe997403 100644 --- a/block/accounting.c +++ b/block/accounting.c @@ -185,6 +185,15 @@ int block_latency_histogram_set(BlockAcctStats *stats,= enum BlockAcctType type, prev =3D entry->value; } =20 + /* + * block_latency_histogram_account() assumes that it can always access + * hist->boundaries[0], so require at least one boundary. A histogram = with + * a single bin is useless anyway. + */ + if (new_nbins <=3D 1) { + return -EINVAL; + } + hist->nbins =3D new_nbins; g_free(hist->boundaries); hist->boundaries =3D g_new(uint64_t, hist->nbins - 1); --=20 2.53.0