From nobody Thu Apr 2 01:33:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1774896805; cv=none; d=zohomail.com; s=zohoarc; b=Is0j0bAnY8IHGFKIQVVcHXuWuKq68IOev1QkZ8CmwUCw2SLfsBm4DvhOGX+sIZIYKEApXO0vT0CNAkArcWLnnLLN7JuycLNS9Kx2u5s3C76eiJ/RlCIWYz2gZoBa9BzOShdOCuz72i5/piUI4LnhrKMWVezvwtfPsObhGYB6IJU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774896805; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ceVDVX8xD+d+HSxRibRQlzvG5AaZb0ZMAVIgjx6IF9o=; b=QR9QnXvS15PZ0NogF/pvnJrxrlNdyVR8PeDVvXYyfkOQdBn7J3JnnIWL/CSpwWxAWQn3Redh8MRlNA8Gk/+ef8bvwDwPAcDsy30Ybqs7ee8LBFcpXZkWkBxnE+qAC+OKJDk/KB3TIf7lBcGgo6iOeV7pe13Wz9E3uEFfScq/ZoM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774896805001584.7360034813831; Mon, 30 Mar 2026 11:53:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7HjM-0007i2-VQ; Mon, 30 Mar 2026 14:53:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7HjB-0007h4-Nb for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:45 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w7Hj9-00038d-7Y for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:45 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-48374014a77so58652145e9.3 for ; Mon, 30 Mar 2026 11:52:41 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21f1749sm21229400f8f.14.2026.03.30.11.52.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774896760; x=1775501560; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ceVDVX8xD+d+HSxRibRQlzvG5AaZb0ZMAVIgjx6IF9o=; b=OUgWogsHpwlK8uE58Z5Z2lFcMGmKCP10c9NCnG0mkidx06bvODFZKm/60gjxM2ximn S4ybmnRDbXL9qroeLmkP+L1l0hA+mrAG8K5NFMO6FJGxM7vAIw0MgluvimEjNR8m0oKz 2DwjDBuP5/PeWs5vSpO+NokXifS/qcAwO10Dp9H9raTvyOQWeffFeZqKbEOz83P/koD2 v9VdB8zjkBwpk+kxIRDrgCXTdqwTaL/52YZM+XWkZi0FevAwEDhRBbq7RDk9vyg2QNLN dWPbmQsUiVOZSjOyS1DjTCkotOZ6zxNj1qpgK18MmI+OuMEK6dxzJHo92zdzkP6wU7Of eeEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774896760; x=1775501560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ceVDVX8xD+d+HSxRibRQlzvG5AaZb0ZMAVIgjx6IF9o=; b=p4hlluaJS3KvyTXGhWx+NzoO/3JuJPQZu56iBXVpCGLSxhPQ5SEofopFT3SJmxIytD Mt/6Y5f69r+c7L8d1UE+omZ14U4mqdFx0xcv2DOBSCOSQ8X1HqxsEK+OsfqdwgME52si x20YOOBQueGWe6tXID4E7hBNAeKDoGZBEizuzdRvaLPOz3KVYGnDBqeCIyhvwS+xtYvy detfBiS0+acG1873tD5xItd/oSpRNOra+7bqZ6WFwzIIgZiRUYsfH5WpBVd0wWM1k4y3 QYt02vup2VRVjQVeVTrywcLuhwWQJx86QpRtNET0/22PMDNEa3Uzl0U1TVqW8T19h3Gu mw8A== X-Gm-Message-State: AOJu0YxGNMObS6DwQi2JYjFtjt8JKD4cK5wFLoQaJ0glMmd+QQt0j7xS EtOIwyUqBT7Yb24VP/bJDtCsIEibjwRSboxFx5Ey5OzHAGu6j5wS22UHepYkl/K8HfY8MGVfs6w Fn4vGrT0= X-Gm-Gg: ATEYQzz7JlPAUGB22Jm8CV2HE33GYRbIjwSLcApHm2G6F2i4zJkROunJEzaQeez+ziA yYz7jCBt+WcN9IcmcrBotpoqeVSQP+Mr8sMSJxGrSDCCF6KfZ8+DStUx0sFYzxXonZz1hmZZwxF Y48U8edImk9PIyy2JgMkbHMId6A3iHodEWTR8NPg8hObkaxWeL3b98KObJfD+V2gt8Mfc/GPgbG PpIAWen+T20ZgqczUK8Qu/ee1b7W5nvUoQp8v2Ve+XAckdugLYBW1B/xcUHju0Miff88fbQ4z5Q V4CoCvcFxNVsLWKzeFmYZ9heoy+5ZhCOlEGHEqJieIhECQeYPhAZlQNHexayUn/MFhmJx+xc5oB mz9prt+DRO1u5hSTLp+E4z4ew1xcSHjd+mRgqQdBjYWW2CFuturJJfY602AqqlGWVnnS0LLCtJU Drui6vZ8liGgmhs8SbCmHNGyEyJwk0dFJDFDspCE+l40po56dxdmnojioRxnlBKYYuK650V43xo VF4QmBAOH1X4AOnnHYoJttjbwKoEKE07eojLOd6LQ== X-Received: by 2002:a05:600c:19cc:b0:487:300:d9ca with SMTP id 5b1f17b1804b1-48727ee9ea9mr207332015e9.31.1774896759432; Mon, 30 Mar 2026 11:52:39 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 1/5] target/arm: Don't skip access flag fault for AccessType_AT Date: Mon, 30 Mar 2026 19:52:32 +0100 Message-ID: <20260330185236.1905636-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330185236.1905636-1-peter.maydell@linaro.org> References: <20260330185236.1905636-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1774896806276158500 Content-Type: text/plain; charset="utf-8" From: Zenghui Yu As per the pseudo code from DDI0487 M.a.a (on J1-16021) AArch64.S1Walk(): // Check descriptor AF bit elsif (descriptor<10> =3D=3D '0' && walkparams.ha =3D=3D '0' && (!accdesc.acctype IN {AccessType_DC, AccessType_IC} || boolean IMPLEMENTATION_DEFINED "Generate access flag fault on IC= /DC operations")) then fault.statuscode =3D Fault_AccessFlag; an access flag fault should be generated for AccessType_AT, if the AF bit is 0 and !param.ha. Besides, we should continue to not raise the access flag fault for in_debug =3D true which is what we've been doing previously (before commit efebeec13d07) for LPAE and is what intention of the debugger access codepath is. Cc: qemu-stable@nongnu.org Fixes: efebeec13d07 ("target/arm: Skip AF and DB updates for AccessType_AT") Signed-off-by: Zenghui Yu Message-id: 20260324160321.96347-1-zenghui.yu@linux.dev Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/ptw.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index e289f88124..08a76bd3f1 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -2118,6 +2118,14 @@ static bool get_phys_addr_lpae(CPUARMState *env, S1T= ranslate *ptw, descaddr &=3D ~(hwaddr)(page_size - 1); descaddr |=3D (address & (page_size - 1)); =20 + if (likely(!ptw->in_debug)) { + /* Check descriptor AF bit */ + if (!(descriptor & (1 << 10)) && !param.ha) { + fi->type =3D ARMFault_AccessFlag; + goto do_fault; + } + } + /* * For AccessType_AT, DB is not updated (AArch64.SetDirtyFlag), * and it is IMPLEMENTATION DEFINED whether AF is updated @@ -2127,15 +2135,9 @@ static bool get_phys_addr_lpae(CPUARMState *env, S1T= ranslate *ptw, /* * Access flag. * If HA is enabled, prepare to update the descriptor below. - * Otherwise, pass the access fault on to software. */ - if (!(descriptor & (1 << 10))) { - if (param.ha) { - new_descriptor |=3D 1 << 10; /* AF */ - } else { - fi->type =3D ARMFault_AccessFlag; - goto do_fault; - } + if (!(descriptor & (1 << 10)) && param.ha) { + new_descriptor |=3D 1 << 10; /* AF */ } =20 /* --=20 2.43.0 From nobody Thu Apr 2 01:33:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1774896803; cv=none; d=zohomail.com; s=zohoarc; b=jzx1C5H42afHKsrurS4H6c3Yb4UaW2Dm5/0XCSrP7qMTvnlsmwqvGOFg58Y6foqcG5B51mNLx0Cj/laKUSNfNHeKyVROgvpXNMBL2mb/n6jRF4aVnlzkuXBzwfZCmPs/uGu8q5MrQWU40+PcbM3OzKthOzVtgy+7TzaUxH5uTEM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774896803; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=BF7n0AeribVf5J8IKbflMfLGP0Uet1AjDdCOhZOnHQw=; b=DytDmyuc0JhGwppfbw14DgFQH3/tB1I5x0iRRkn7UeEd/xQBswn7F/ZRAHxs9lc5lyV7Y5rzUoRhj6PBoD+k7OI1r9KlNsHCstUu01g1DH3BmvVIsmMc5xgfDaYvrOszZzrvxQe+Q892kKSCGjvXkwSOkIUKtW+HgaMHXPNPzEI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774896803111959.5787893840075; Mon, 30 Mar 2026 11:53:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7HjD-0007hX-B5; Mon, 30 Mar 2026 14:52:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7HjB-0007h3-Lc for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:45 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w7Hj9-00039C-7J for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:44 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-439d8df7620so3447354f8f.0 for ; Mon, 30 Mar 2026 11:52:41 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21f1749sm21229400f8f.14.2026.03.30.11.52.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774896761; x=1775501561; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=BF7n0AeribVf5J8IKbflMfLGP0Uet1AjDdCOhZOnHQw=; b=bzo5q2yDcGVSZrrZJ21hpzmKIE6m3Kmml/RcDUehKEBzodFZneUQjm3ulFe8XxTtdA 7FQMxKRkz9oU7HMYrEMOIoiNMHA7Lr0R5j6l7+D6hUtodxFVIe8PmQKW2MXjtiyI4s/K +JDXHl34hVuHsbBaWp8sFg6LcBJAEP6/+bP2Jmdb5z1IcutJX4PeU8HSBMSoGzleBneD 0Y3fl9N9EkczZSpCJ2Bcn32oZ9j7B/A5kQwweCYJF2I1s+byGA2nvgKWWyBtvhprh6tf ZcGZf3YYicWx3iL5qhFHutEft8m4zmYYwy4CsEEx8I6OQ86BH4zhtVgCRZXK7A/hHKmv wDlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774896761; x=1775501561; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BF7n0AeribVf5J8IKbflMfLGP0Uet1AjDdCOhZOnHQw=; b=ofMwTaIV28HRYPHD1MlQduUdOHveCK1sjO8cd/feMOYvRbASOnqdx0reC2UhmpMOUb H8abVUjJOwX0GkcitkmDGCF/wGC4uIYvkTs217A3Srb2oO8+2Eyf0SnbscbkfsYyKRdd 9l0ViswrYdi+x4cUnCcetDsMQ1ItKo9BTfQFMJfxCqOW262tyq3ZbPX8/ykHMspa1X4k EeKTdKP/hqiAg0/AWLiKCJI7MMZbNMUqd5ptebd81iHfWWTHYow/HFz2fRdGvEbGoc7u sKC8aM369jn37u9d5XlEcjYWnn6pDtS3R4lGSj3fcHHM9oVpwBfvtgvixy2+4WzKynPS 6eYw== X-Gm-Message-State: AOJu0Yx6pMYl+gMImNFVyFatdQRi3dneyW4yX261x3LbESEedFR+TrgZ B7NtBnBxFXU/r9KjdPZiDCo7wRFEPcSyW3vq/H65AkdK6pOltSxaVawPYzzDY8OHLT1VCuByFNX oECAr9Ec= X-Gm-Gg: ATEYQzw3SeKqU3mIADQEARvEqlVXkz2oVGDVISTRd41wifwUV8EeKdAZ5+2TU9CQJfo 8TI4VApNqiCLfCxPbpnLgDRnE0LORVLbhbid8qHl6FKDm7fSVvaqJ+DcMNnrhH7+FDQNyXahz1T cALbOKSf5zYNiOpL66vXl5bvR+TPRpxOUY+MC+pxEHnX7kvtdXjjzVhX5UyaPnGBOej9ZpVeRI/ JTQSaCR8WWidC9E9d9r7G7hLhrimnKRgOFf7BbFvNAlouvVqzK6TR2iKV5hNclrF5DG2G7KlHX8 RdVWuIoZcpJzhdGKWUdiuNV4UOWI7vxAB0immSONDRCeqKJ1LamHMJZBM/uRrD2aThanQviu3xH LWWOFRp055407SEKUhg5U1sTnJ1GO+PYVFKv07G4HJvOI9YOLxFPa5q0VN0alE2boWKBcXLpu7S MfW0Ko0K7fCFxy2SqjfwKsQm8+cj+btz1mHJdA7P/VDr2694usgscY1xp0d2iesa6ZRuDlg9vzp JWIb1gN4VJTqK2RLANYSEcV1YAWWp4= X-Received: by 2002:a5d:5d12:0:b0:43d:6e0:9458 with SMTP id ffacd0b85a97d-43d06e09528mr3281574f8f.39.1774896760726; Mon, 30 Mar 2026 11:52:40 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 2/5] hw/net/rocker: Avoid double-free of l2_flood.group_ids Date: Mon, 30 Mar 2026 19:52:33 +0100 Message-ID: <20260330185236.1905636-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330185236.1905636-1-peter.maydell@linaro.org> References: <20260330185236.1905636-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1774896805724154101 In of_dpa_cmd_add_l2_flood(), we allocate memory for the group->l2_flood.group_ids array, freeing any previous array. However, in the error-exit path we free the group_ids memory but do not clear the pointer to NULL. This means that if the guest causes us to take the error-exit path and then later call the function again, we will try again to free the memory we already freed. Fix this by clearing the group_ids pointer in the error exit path, so we maintain the invariant of "either it points at allocated memory, or it is NULL" (both being valid to g_free()). Cc: qemu-stable@nongnu.org Fixes: dc488f88806 ("rocker: add new rocker switch device") Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3253 Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20260324193530.375628-1-peter.maydell@linaro.org --- hw/net/rocker/rocker_of_dpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/rocker/rocker_of_dpa.c b/hw/net/rocker/rocker_of_dpa.c index 814f19afc5..3190a0e75c 100644 --- a/hw/net/rocker/rocker_of_dpa.c +++ b/hw/net/rocker/rocker_of_dpa.c @@ -2059,6 +2059,7 @@ static int of_dpa_cmd_add_l2_flood(OfDpa *of_dpa, OfD= paGroup *group, err_out: group->l2_flood.group_count =3D 0; g_free(group->l2_flood.group_ids); + group->l2_flood.group_ids =3D NULL; g_free(tlvs); =20 return err; --=20 2.43.0 From nobody Thu Apr 2 01:33:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1774896874; cv=none; d=zohomail.com; s=zohoarc; b=P1si1dfd7d+rNtZsCdQhDmcPhYCPSgAJa+gLThDncEro2SACFmHzIqHFgRjZTLqMGA8igsXAqpDH69Allzast2KLkd5gqR9fzlG3GJgRWPXut/kfGZyVJDjtRhxsDv7yxCpWUNUfqFobk/DbxPFgL8V+yYtlEgSrvvkWuEIZvsc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774896874; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=p8uB8xGKHFafOJAt7VvZZu5jT93acMkkOA2W6vmo5NM=; b=YR5IaUhT3s7Lg/PZNPHG7WcgKssNAvdxgYRBNASXH6G9Kn/2xZBAI0ocwlUIYPicvZpuUzsd14ozX/43/RFDn/yBOZmrrWQ341kqDeAuEprI/zAEuKcgexE6HIV87MsBebOR04GlYtxLe+vV/tRVB/CPPvnM/Yx9nQzqsMHkvTo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774896874131263.85094699172475; Mon, 30 Mar 2026 11:54:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7Hjj-0007lx-E3; Mon, 30 Mar 2026 14:53:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7HjD-0007hZ-D1 for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:47 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w7HjA-00039I-0z for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:46 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-43cf5ad500fso1875967f8f.0 for ; Mon, 30 Mar 2026 11:52:43 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21f1749sm21229400f8f.14.2026.03.30.11.52.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774896762; x=1775501562; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=p8uB8xGKHFafOJAt7VvZZu5jT93acMkkOA2W6vmo5NM=; b=aP2GC6Syft03GqE6Dz51PNraQxzhHVwaaJVHGdVkTjTkeBpbeSWzsFc4vHlfhzrCWg +6v81YNGfbVmbgD07EVlvSORr/G8EC1AdOA1fghbyrB3pyuFkmLYg8M87vufuyPEvdCV dFxyRudItY2HIA88UL8lo6kx/qPVRWP40VulAu/j47q/2wOX253cb8p13nQp5XTJgUQc ArX/3l2ipb6CrXQSf1O49SblI4bxxQliBSh8/yDI3yB8nHC4gbsvBl5sZJ2wwMaoG+zB LNdD9OqkPRdIFTwegvPjwyGqMtmgupS4l+BPXrTuyhc/x1hD7lJUelpuyhUMMw4Tv3GV s5Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774896762; x=1775501562; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=p8uB8xGKHFafOJAt7VvZZu5jT93acMkkOA2W6vmo5NM=; b=VMWOgverhJ1AAjfTu5n8Bm4ahrvjTsbF3fvfC9wB99YRiTjesp/wBmM+jZHeIKM5dR mR9U5FCsptwACaH2q72dwyqO6+7Grhq1cVxjC1JJ7NJMPR2tnxf9rgxRnI2ewqMDwVS7 5h+uufh6JlcgAJ3VV33V4gfZB5/GoK0yHSZulGjzWr53SWn0f5xypAfgKXlfzW1cuz3E 98QXh40qcPRcnWOLvLSD8O46hAmlq2qvViiFx+ag++XfGBS4UYWCQD50YCnU7O5VcW+B bgyoPB1KQm6eLHzIdfbRHr3O1KhkJRkpLDqHlR5eYMILpS37e+HkARGAImoSLYPKiJEJ PG+g== X-Gm-Message-State: AOJu0Yx3+FsjMJfMXFhyfp6u2bR730ljXU7hfmqqLNMnLSkQVK+hayQc nN6E8PgQhIIHRLPnCyfpdCKx4nfs4QlFsno3NT8jvbVfBRv6YWN/yeFxiEFivQOa5NGKWKizhfd EChD0SRw= X-Gm-Gg: ATEYQzy9FJiURsWM8PxoyD/7SzWVOw8OmKudlmcI/GtMRHyAHLHvXcm6jmEjzv7Nqp/ z1c6mdvyQExjcTUavLywH8yHq7eAPND/7IiDdpWYHQPw2NByap59gOs/RlTIqRe8DnEP/n/72sr g5awkHTY0xzNNja32HjkKuyNWlbK+q8BJwGzJDXKPdMd6a9W+f363qZD//SNYHjlTrgH2HGicxJ 8078BZzZ5RnNY4BaKUFuF/WITVR2TSv6epvphN31eqiMwwFG2l05u4Io8q7ZKeh2J0TocpbeDmF mwjlVzvn8EezlEnSGfZxW1pOO174si/uiWA0toPW6X3Z6jqsW1sBT7r1MXYHv6JCCrsMKEE+plk ZR06ES+SlYLAk9lojQp14bJlckgmg4M9/2SnlkjHx1Omb1bk/bNn0iwLhTIcgdsnPObG+EoDKM5 HVRrv1NGnJboxGE0AfSCCvtWT4fnmqbIqr7+2uhw17ve1ERE4dryZmCXzrHoJq4FlQcAf7rMSdl W2GVTRCerlNOF6jCbvtLzuXCSNSi74= X-Received: by 2002:a05:6000:2911:b0:43b:9cff:e32c with SMTP id ffacd0b85a97d-43b9e99792cmr22652341f8f.18.1774896762100; Mon, 30 Mar 2026 11:52:42 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 3/5] MAINTAINERS: Remove Riku Voipio Date: Mon, 30 Mar 2026 19:52:34 +0100 Message-ID: <20260330185236.1905636-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330185236.1905636-1-peter.maydell@linaro.org> References: <20260330185236.1905636-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1774896874654158500 Content-Type: text/plain; charset="utf-8" Riku Voipio doesn't wish to be listed in MAINTAINERS any more; remove his email from the relevant sections. This moves the "overall usermode emulation" section to Orphan status. Signed-off-by: Peter Maydell Message-id: 20260323134741.4114629-2-peter.maydell@linaro.org --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index eb7132e39d..ae356d886f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4054,8 +4054,7 @@ F: hw/core/resetcontainer.c Usermode Emulation ------------------ Overall usermode emulation -M: Riku Voipio -S: Odd Fixes +S: Orphan F: accel/tcg/user-exec*.c F: hw/core/cpu-user.c F: include/user/ --=20 2.43.0 From nobody Thu Apr 2 01:33:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1774896805; cv=none; d=zohomail.com; s=zohoarc; b=k/a6BXG3ohMQ4Io0uFTmThEIZhm2S7t25bsMQJ8NlNewbPjuVPvQ/siKUhPYDak63zC8CL19HDd+orFBS15e1y9DVxdqfXxVbQ17Mt56Nv1+CKyp3EFG/fC9YKLnezIbWo5p2YjZ15jrUn/6EHQ1us4YjktTFufSfMTNcUQTW3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774896805; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ZybrFBw7Ix8mwMCX2q8Yt1KrEczHCjP+PGVzV3FEqrY=; b=WkHd7cRg+nwe+IHeZNKfyrnizmR/8fagGUwNar856oa78T4dsdgRAe7xw/mEKwnJXe7xj+i6JyuPRY8Lt4YhghpQ/bqHWP3m8inicreOgLld18AjJMSn2rTEv3SwQt4p3Cpvuf2Zfu/1pMZ7CoDbkYBVsnyvwm/QRcp0Er+mGbQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774896805037311.91797146691295; Mon, 30 Mar 2026 11:53:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7Hjh-0007kT-94; Mon, 30 Mar 2026 14:53:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7HjD-0007hY-CR for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:47 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w7HjB-00039Z-BI for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:46 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-43cf5fbacc9so1111168f8f.1 for ; Mon, 30 Mar 2026 11:52:44 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21f1749sm21229400f8f.14.2026.03.30.11.52.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774896763; x=1775501563; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ZybrFBw7Ix8mwMCX2q8Yt1KrEczHCjP+PGVzV3FEqrY=; b=rkAsugEqUV3HpjutLo+R8FUsSp/onUH6pesHBD6+0AXusZu9b8FpOQ6joqx6Z2rWWm 6yyJLO37LSOeYPxXjxRSfGyyAuLpAFfbbUx2ug64hSzNZV0Yfxd+tflXXSSuqbbp8piW mBuRRhgHT7q/2W4UnCNt8ANCnb0Z8vozbFITzR+SA9TDwcsUPx/MZcG9r6slydLEpMza EJRiKP8ffPcLFqS/wdTn1senEbVH2utHPtuoLijCMerITVNIN02hp58OyMEYKRrC9eL/ 10OshR1f00liRA2fiLZde0DfFYuKzpDfsUdTJWl0q/8Rj2XqmiG4/+vWnptdw7SlcsfK EVAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774896763; x=1775501563; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZybrFBw7Ix8mwMCX2q8Yt1KrEczHCjP+PGVzV3FEqrY=; b=fR/w1nFPsLb2V/zq3lDWP8dH7BQ8gUwPOPrM9MMXoYC4X6GkdcINcwMFSopsYJZbJ2 hhEkgkHsH3Be94ysFVn4iivzEPqVb1XwkY7l//l5kBrv8geOnnqOu/sRLYXJsA1E1G64 QAZrK8WDJ++ZX9F1+ihmFAKTVXv4Bw2dIV3tC88P5+O5dgjfL9Oq8bvoKjEd0gwfF+eL OA7xk00fXtVKOs8rw0Q8+BBFCk4oKw26CxK99LZcbbNsDNtRmLmi/xD8LjFPpMk5iKu6 OTZTsFDz/lz8PBxFwDi0bYffF1fjnWGi4rkqQ1tY9aVNwwgHfV20mstdknch/reCxYwY r2KQ== X-Gm-Message-State: AOJu0YyFx8MLd/cBrWMHZs3o4f9yToNI0qrxjutxqG5d+pOVySt/kQ1M rCArk68k6TOYVAECqIBWHJ0kp1F5BteN6CAH3o1ajQ7neysn4NjmCJL10W84bvdNeq49EUlJUvl X6CURZsI= X-Gm-Gg: ATEYQzx3mzWBczgNkaKEfyBOQCae5tmmFSZd0q/en6JHwaaqS5Fq1fox6F77sIw8zZi qLEppDRyBhIOKo5cN9J0r+PsAMwQltoZeZUXbJWeaw1QlhvZI4w0n+RFFZa3NRJ+P1bhIEP9LK5 D6kuj59VPe6VIzZPcg53Ft1l76tCV0Xxfgtg2T2PKd3vmTv7h9JwmDxqoSXmsXqoEk508XFUnO3 ZYonp4iLneNM+VH0ng3lCF6OeH7hqPFpUQLIZB6Uql2h2cgCPUKXa3JyhpNyJkHv/1OIBTnLS+M HPZeQeYk56bW67vPEIK4nKYNX7fqTX5ViUIZmhdFMIXQkFtetN8ehy2axx23nSwaw7ei/E7vlXW 6OWGDcTyPMoMR0TwCd8vsjQSIWCDl3aP47wVvcxD/jCnTxfufVUAPJZ2QgiwbTWlodEfvnoHh+H q5IPTQZmph0r1sYzsLd7yZx9JtcOOA7hJLYnhFq70v3PMH4uNesstnu/wk18zNsm9CBBwY8w5lv XzOrdQfSlSO91IA3iulkc8ea9bduHI= X-Received: by 2002:a05:6000:23ca:b0:43b:9d69:43a with SMTP id ffacd0b85a97d-43d081c1b5amr922063f8f.8.1774896763163; Mon, 30 Mar 2026 11:52:43 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 4/5] MAINTAINERS: Remove Igor Mitsyanko Date: Mon, 30 Mar 2026 19:52:35 +0100 Message-ID: <20260330185236.1905636-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330185236.1905636-1-peter.maydell@linaro.org> References: <20260330185236.1905636-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1774896806261158500 Content-Type: text/plain; charset="utf-8" Igor Mitsyanko doesn't wish to be listed in MAINTAINERS any more; remove his email from the relevant sections. Signed-off-by: Peter Maydell Message-id: 20260323134741.4114629-3-peter.maydell@linaro.org --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ae356d886f..81f49b232b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -821,7 +821,6 @@ F: hw/display/dm163.c F: tests/qtest/dm163-test.c =20 Exynos -M: Igor Mitsyanko M: Peter Maydell L: qemu-arm@nongnu.org S: Odd Fixes --=20 2.43.0 From nobody Thu Apr 2 01:33:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1774896839; cv=none; d=zohomail.com; s=zohoarc; b=luNWtCedtq812rjdebBC1xhgLlEpWz//o+5lnBb9jBiqGSVG/ZPf3OuFo6ePZCpfbuL5pLnDKD1+8dnQBP8BZhzrGwU5cA2ShYPB887Mbp7y+C8P8PprPH0psRoKVVktt1zbPVcSsFoR8fpeR3/ShiBaIP9zCVhjfcMmiWrdlMs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774896839; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Xv4fXudi8WmA4+DY+5K9JiStPbSVSJvSdVrxjTUqZ30=; b=WuQxWm5GPlM7DAgyGutVWKBbq4aExalclkvTjzLlXW/cuoV2//DX9d1ii9Y4THofkjfSm5Y5c9NSZyHuJt7ufdi2L8r3U0Am+BCxO1FrIuSI5cMcYPxwiG2sFVa8HbRe6htkfC9CALJCmd3ToqGiN8NZ2ePpTsdJ9ZtqurzQLW8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774896839304414.1953236950271; Mon, 30 Mar 2026 11:53:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7Hjs-0007n7-Fa; Mon, 30 Mar 2026 14:53:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7HjE-0007i4-Sh for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:49 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w7HjD-00039j-5G for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:48 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-43b87970468so4387716f8f.3 for ; Mon, 30 Mar 2026 11:52:45 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21f1749sm21229400f8f.14.2026.03.30.11.52.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774896764; x=1775501564; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Xv4fXudi8WmA4+DY+5K9JiStPbSVSJvSdVrxjTUqZ30=; b=jwaFwx6SGUF18VvmcJ6DxZs4fqSG7KLo/eaZF3JDFuqyaQU1mUCDsX2Eh7RwHtBTA8 xZ3ENvZ1gA7CpoqVKG47+ciOCFxvLxwzw29nN/HljPvup7/r4bgQPZ0A2VDSaC0jHQtw ck1lCvj93TF/8/WHDHBKVJRzDuolQtQLYBrfsoEWselN1EPT7KpWvRYLwyy2CC4CzoEi Zz7GGxprdW3j6PVx5nTBBs3VGGdp3t+9Y6Alt/jXpbjvShWkLWDKcLJyKMIpqIbMert6 SRiI2q4XFZn6vbvrBvXFzxS+TpZ6itC8fU9BUMUfpDQEXRO1Uc4bBOi0+WCNUzWC02Mh PYxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774896764; x=1775501564; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Xv4fXudi8WmA4+DY+5K9JiStPbSVSJvSdVrxjTUqZ30=; b=jderCelg1vmoCZ4fyD4zDQFNFNaFS3QyPWiYd9Mh7LMA1YBewC7A0ZoAid7iOz1JJz QzKppND8RsBpi1KhUZmog8c3P8PfkH9J6tHDFOpXyVtoTYlTcZy10M5XuLD7PEHEOQRZ dLGbNecSuL51YnqebleljAX7e2Z4+Rk5rYBdFgsdhnZ6PFRWDeoVbTjoPXVa5LONi3me KTe6WLgbUdJsPAbsD8ohdgFbYvBtn+asUQE1E1j1I6GAIhG+bBh3XkhgckC/VFSbfCx/ j4+9ZPq+eIWWNqmgT81ZD4bylw+K3CDVXIk/npE3MJO1TSayIPZFx65klTftDlI45FSV kApw== X-Gm-Message-State: AOJu0YzOV+aR9jT8/pXZBB0zaWQkQhg9WVT0uI0xn2ORwiFHrF43hTwH DlzSxAATQNd6SM3urWnn/72ILeEdEySPDiLVQwTZ4hpZiZFBiUu7ZKDioGvUIyMWMgQxp+9KHXH j99WuXqg= X-Gm-Gg: ATEYQzw6YkYSEAd+0NjFi+A/plskVZpJJVqGlT0FgFih+u0noalba7NPlOJarueg20d tSC8OY3Az5w99P/Adj2KtrMkDw4afa1lEn11gGZ0e8qlMldX9avoni3l1ov4h8v6WHUIsY11MDZ dRG2bfBm9StOevoMXfNpXclAJMD/vQOMdcGTWkqdQmjYMrLwYKwAJv7F9JqlYpvh29oAkVR6CKP 8KKFZchdFf0feUipOKJClMheflZosPexR+oGU8rgwT9C441z6vGjsNCTpi4E2KUEhXvf3nZlnLU pbHw6BXRk3YkkGYeptZ9trOBajzFuKH3ux+df0TDfyLGYPkWs9D8Ohgawctfp/4EO/aP0z90OJ/ ta3HtD2SsDHBmTXJdfCBRsjSkKaK6+/f3gIv5JUbOK7inTrS+BUfM/lpw05A3hajXWeedCrS/yC xDCLBHpTC1KE8DstumW9HAp/BJ4ylWvp4PHGelqCLzNpZAwF2MFehFmrPjhBJxfEoTIjlXXS84n pBuEDsOCCrIyOkqkw/lfeiMnR7tz1k= X-Received: by 2002:a05:6000:40db:b0:43c:fd0a:5c6c with SMTP id ffacd0b85a97d-43cfd0a5fc9mr9798822f8f.0.1774896764197; Mon, 30 Mar 2026 11:52:44 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 5/5] hw/arm/xilinx_zynq: Use strcasecmp to parse boot-mode option values Date: Mon, 30 Mar 2026 19:52:36 +0100 Message-ID: <20260330185236.1905636-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330185236.1905636-1-peter.maydell@linaro.org> References: <20260330185236.1905636-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1774896840413158500 Content-Type: text/plain; charset="utf-8" In zynq_set_boot_mode() where we parse the string the user has set the boot-mode option to, we use strncasecmp(str, "qspi", 4) and so on. This is wrong, because it means that we will ignore any trailing junk on the end of the option string, and handle -machine boot-mode=3DsdXYZZY the same as -machine boot-mode=3Dsd In the documentation we say: Supported values are ``jtag``, ``sd``, ``qspi`` and ``nor``. and that's obviously what we meant to implement. The correct tool for this job is a simple strcasecmp operation. Switch to that. We use the g_ascii_strcasecmp() rather than plain strcasecmp() because we're comparing ASCII strings here and don't want the potentially locale-specific behaviour that strcasecmp() implies (and we're trying to standardize on the glib function for this kind of string comparison). Fixes: 7df3747c92d13 ("hw/arm/xilinx_zynq: Add boot-mode property") Signed-off-by: Peter Maydell Reviewed-by: Alistair Francis Reviewed-by: Kostiantyn Kostiuk Reviewed-by: Paolo Bonzini Message-id: 20260327145012.907264-1-peter.maydell@linaro.org --- hw/arm/xilinx_zynq.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index d43f36b718..9dcded9219 100644 --- a/hw/arm/xilinx_zynq.c +++ b/hw/arm/xilinx_zynq.c @@ -186,13 +186,13 @@ static void zynq_set_boot_mode(Object *obj, const cha= r *str, ZynqMachineState *m =3D ZYNQ_MACHINE(obj); uint8_t mode =3D 0; =20 - if (!strncasecmp(str, "qspi", 4)) { + if (!g_ascii_strcasecmp(str, "qspi")) { mode =3D 1; - } else if (!strncasecmp(str, "sd", 2)) { + } else if (!g_ascii_strcasecmp(str, "sd")) { mode =3D 5; - } else if (!strncasecmp(str, "nor", 3)) { + } else if (!g_ascii_strcasecmp(str, "nor")) { mode =3D 2; - } else if (!strncasecmp(str, "jtag", 4)) { + } else if (!g_ascii_strcasecmp(str, "jtag")) { mode =3D 0; } else { error_setg(errp, "%s boot mode not supported", str); --=20 2.43.0