From nobody Thu Apr 2 07:43:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774866573; cv=none; d=zohomail.com; s=zohoarc; b=eaXBUNEtd52gHt5mR+7DZOpNqW6G3v0OaH4T+3613UNKVNAYnbbzWHsijlFYG1I5Bq/jJG3/b+o2XA1wRrFq7Ge4WU9X1wlHfbvVa8ez82Ch6wBIZ4AHD2tvoEUiFZl7D0x6AxqbydcQPVj6j+zEszz63deUvu3ltHec9t/Ibqo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774866573; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ww94gMkt11Wk7lcnwhAkRmngRIfU7Z3lB/Oh9OuXyhI=; b=RUBSRmr8I9avZMxE85SIHHQ6bg8ywjpelWJoPlW8ih6SJEw5mhyCw+ALiLHI4KY5R4mzz86P5/4bvsBLrMFPFJgmMxUYVDiIfR1No/Ps8nw9rsPY+sHWztU7yw5Di9uY2Zfyx/kld6htWiSXsDYmREC/vHRG3vky9yVJTZuvgLo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774866573591807.9368403116133; Mon, 30 Mar 2026 03:29:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w79rS-0001C6-MP; Mon, 30 Mar 2026 06:28:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w79rL-00016D-VH for qemu-devel@nongnu.org; Mon, 30 Mar 2026 06:28:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w79rK-0005Ef-Hj for qemu-devel@nongnu.org; Mon, 30 Mar 2026 06:28:39 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-LoQfeR6_OqG1p21QcL0q8g-1; Mon, 30 Mar 2026 06:28:34 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A911619560A2; Mon, 30 Mar 2026 10:28:32 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.35.14]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 596A530001A2; Mon, 30 Mar 2026 10:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774866517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ww94gMkt11Wk7lcnwhAkRmngRIfU7Z3lB/Oh9OuXyhI=; b=dCVfsgl7t/Atxa4WgiqWl3QtRQqcIV2ZhvXPlsf9SOxwNGAeXrVQBJglj/NUGZZP7CgcOM Fkf8ZG1w7XvziTLTDKCgufN3E3E4ZllHTyoD+G9W58i7ZlAJHBg6sk0qPhSG8lfFpP7xr8 PhCyBLuSjxEXcA6FM69l4+3bD7oEuL4= X-MC-Unique: LoQfeR6_OqG1p21QcL0q8g-1 X-Mimecast-MFC-AGG-ID: LoQfeR6_OqG1p21QcL0q8g_1774866513 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Fabiano Rosas , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 5/7] hw/display/cirrus_vga_isa: Disable global_vmstate by default for new machines Date: Mon, 30 Mar 2026 12:28:13 +0200 Message-ID: <20260330102815.6759-6-thuth@redhat.com> In-Reply-To: <20260330102815.6759-1-thuth@redhat.com> References: <20260330102815.6759-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 27 X-Spam_score: 2.7 X-Spam_bar: ++ X-Spam_report: (2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774866575347154100 From: Thomas Huth In the long run, we would like to get rid of the code that allows to register migration state globally, so set global_vmstate to false when using the isa-cirrus-vga device with new machines, and only enable it for older machines to avoid breaking the migration there. Reviewed-by: Fabiano Rosas Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth Message-ID: <20260326154850.301609-1-thuth@redhat.com> --- hw/core/machine.c | 1 + hw/display/cirrus_vga_isa.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index 6cf0e2f404e..0aa77a57e95 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -40,6 +40,7 @@ =20 GlobalProperty hw_compat_10_2[] =3D { { "scsi-block", "migrate-pr", "off" }, + { "isa-cirrus-vga", "global-vmstate", "true" }, }; const size_t hw_compat_10_2_len =3D G_N_ELEMENTS(hw_compat_10_2); =20 diff --git a/hw/display/cirrus_vga_isa.c b/hw/display/cirrus_vga_isa.c index bad9ec7599c..76034a88605 100644 --- a/hw/display/cirrus_vga_isa.c +++ b/hw/display/cirrus_vga_isa.c @@ -56,7 +56,6 @@ static void isa_cirrus_vga_realizefn(DeviceState *dev, Er= ror **errp) s->vram_size_mb); return; } - s->global_vmstate =3D true; if (!vga_common_init(s, OBJECT(dev), errp)) { return; } @@ -74,6 +73,8 @@ static const Property isa_cirrus_vga_properties[] =3D { cirrus_vga.vga.vram_size_mb, 4), DEFINE_PROP_BOOL("blitter", struct ISACirrusVGAState, cirrus_vga.enable_blitter, true), + DEFINE_PROP_BOOL("global-vmstate", struct ISACirrusVGAState, + cirrus_vga.vga.global_vmstate, false), }; =20 static void isa_cirrus_vga_class_init(ObjectClass *klass, const void *data) --=20 2.53.0