From nobody Thu Apr 2 15:43:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774646867; cv=none; d=zohomail.com; s=zohoarc; b=JBEZb74IsFBDIIzRFUysJXXNvVmH/ddy3QQH74Hsub9j51LL/5ONzpzS8yjQS71ooAsxreMUEnskJrJheZGQOOvswNwyFz8NZDpaV6g3c1uTW4lAfP53JFYwM0TKLNGZWWcX6bhIOjjWOG2cG16jOjvx0InZH3tFUo9GRQBHVDI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774646867; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iZniXf7Th5qb+Qh//mdwiOoh7tVxEGpoHVgDrxDagI0=; b=m3jxvL2uQtWG9tpMRpdBwyjt43hI9WtQokItPRTVnUpX1Iju8VK+dUm/FzGE3mR7CGS4vmzFZnl1WQ9THeTa5TSx/q0iJeocFjBCQUsQSizXhPfrKDPRRHx9vBi5FOmsvtFawFk1QY+M74nhHPPFz5+5ujY6FLfMTuQCYGbSk2Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774646867297805.9726136992556; Fri, 27 Mar 2026 14:27:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w6EhM-0002ui-KP; Fri, 27 Mar 2026 17:26:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w6EhL-0002tq-Kq for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w6EhK-0003dt-A7 for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:31 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-cjdAACioPq2zLwSPM7PsFQ-1; Fri, 27 Mar 2026 17:26:28 -0400 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-439ae2cba40so1932536f8f.1 for ; Fri, 27 Mar 2026 14:26:27 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf1db08e6sm1906528f8f.0.2026.03.27.14.26.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 14:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774646789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iZniXf7Th5qb+Qh//mdwiOoh7tVxEGpoHVgDrxDagI0=; b=PzJHE7O0cF8DZPtF3M7Aa6amVMUYiY7AauyF26oQIuNVbfATYhiIKiXhmkULuQJI+w/SHp kDm9OfYIklorzAztt49/Tm7VIxD4mwPETtVU4zyl+SrxVNoI/GPArMWX3ZeoAj6mEDsdcb J2H/xLDIZ30aNXOZQw5ZKKJHiMqbK48= X-MC-Unique: cjdAACioPq2zLwSPM7PsFQ-1 X-Mimecast-MFC-AGG-ID: cjdAACioPq2zLwSPM7PsFQ_1774646787 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774646784; x=1775251584; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iZniXf7Th5qb+Qh//mdwiOoh7tVxEGpoHVgDrxDagI0=; b=fPt59BAlMlA+BtANcCh+Vf4pk3nN3LKgMYStC2O7/ZxMxOudJahyK93Zo5p4GKwRHS C2rJMs1OVjSFGAq+eE0nbyYK9aUEyp0nJyNZUdpRr8wcGZ/zLheOLb0MOFT8WOsSbmCg 3PjrRa0awNJqNjC/oE7X8DxSz6se+V8gqZ9pVYrIlzV7Gc30erKOVcHFfF8v+Wvq69na awn96dT2lZnQB+LXaf272Gu16jZtYC2ELR5FZ0xCHf/AubH9f/5//AXbq/ZPdjmheU/I Q4Jc9Ow0bG+ldn8Ijjt6U/wY4zpe9Qfevsx02OHc86AZeNAFumR0la3lQrRyDaUHzsCq q+lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774646784; x=1775251584; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iZniXf7Th5qb+Qh//mdwiOoh7tVxEGpoHVgDrxDagI0=; b=RX0pwF8sAHwSwXWAXzmuJfNaWV6K4Qp2gC/F7fIEifNi0uNT9zscdZer4Jx5NARQHA bnU20pdfbUoguRmDkcodsLKLRD0xS0c4NwKVg6uccsta3N1bWaroO/DITeU5TS072pY8 OolXH1widNc8iN+3pAv70lqobZ8AUsWSvTBBvlhk6xJ6j9AitkGbkxdAhKi+SMjLCWUq kBJHU+jBnbfiBj7f+EXNNNQ+K3M7NDXJtvPEYRc6T3i72go8QbOT0cEjuV6yrdi+4OBE 0pm8aE82XnSNt9vy4fFBwbbhLwnIMYztj6ZmjFxKIDxGdw7WpiOPxkYvXAr8hPQcOT4o gmJw== X-Gm-Message-State: AOJu0YwX2Z2g/dA0y39fERWBDtx3V+NGYf+qmhSq5qmDye0rt/78sfdx b8cSdbovTaR9Q/6ncEVloLt+M5vnxiDkDuYL9VaVxH43VTKavyDqZ7IGPQMFEO7VVUk9N4AkN4u SF9KQkFZRcY2m7KmgeT0Hn5WJekHwSL3OVTToM1cHGKOVEWT6B5V+CUAdQ8IHUnKC/cRPTLnkep /KuslbB2FnsFQQMyS4iaJgxTTiMhWJF6HgV8yjTLLR X-Gm-Gg: ATEYQzy5bprq38eIe+NlaEwi6t+wpmgC3nYCALlqz+eU6dqrByrb0WQzNrg6mlbz9wf kBBJVmJ6aW73BK9+n7BzCxFKNfDXiWcxuizly+93xcNoK7DpyuOn/xG/X9mOy1LwBEuLZM3P7Ug ALafsILTlBjq6iJXQ/txdoTJwNmtaQswTEKwptxmsIjSIUTx78RYVRdJfOhAvykJBIwZfdqfkrm qw78+TIjsvHxtwx5HdhIihTlwDl3sml6tXRErgChyEvDnOoD4lYpl8Z3ao0Dek2xj5rWDRRu9W7 gZ/pliwrjsz+whVKGAlXds1YHm+bDAYOQJjx1Nk2nb2j1iKjL1oEcn4TGkJe5JuRlVRlYBEKL4n qZ90PA8sWe0CrdMvrflFw/8qqGuD8D0DHRGkuEiumHYlcBjom8ytLAADXqr7OlRnEeOjs4O4gUO 8bPx2ga3gZhu005+uB5bVDCHR5 X-Received: by 2002:adf:ec4f:0:b0:43c:dc99:7722 with SMTP id ffacd0b85a97d-43cdc99778amr1474189f8f.42.1774646784320; Fri, 27 Mar 2026 14:26:24 -0700 (PDT) X-Received: by 2002:adf:ec4f:0:b0:43c:dc99:7722 with SMTP id ffacd0b85a97d-43cdc99778amr1474152f8f.42.1774646783701; Fri, 27 Mar 2026 14:26:23 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Helge Deller , Jihe Wang , qemu-stable@nongnu.org Subject: [PATCH 05/16] lsi53c895a: keep SCSIRequest alive during DMA Date: Fri, 27 Mar 2026 22:25:36 +0100 Message-ID: <20260327212547.460420-6-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260327212547.460420-1-pbonzini@redhat.com> References: <20260327212547.460420-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774646868411158500 Content-Type: text/plain; charset="utf-8" Reentrant MMIO can cause the SCSIRequest to be completed, at which point lsi_request_orphan would drop the last reference. Anything that happens afterwards would access freed data. Keep a reference to the SCSIRequest and, through req->hba_private, to the lsi_request* for as long as DMA runs. Reported-by: Jihe Wang Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index b882fc02276..54123f77579 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -637,7 +637,7 @@ static void lsi_do_dma(LSIState *s, int out) } =20 p =3D s->current; - req =3D s->current->req; + req =3D scsi_req_ref(s->current->req); dev =3D req->dev; assert(dev); =20 @@ -667,6 +667,11 @@ static void lsi_do_dma(LSIState *s, int out) } else { lsi_mem_write(s, addr, p->dma_buf, count); } + if (p->orphan) { + scsi_req_unref(req); + return; + } + scsi_req_unref(req); =20 p->dma_len -=3D count; if (p->dma_len =3D=3D 0) { --=20 2.53.0