From nobody Thu Apr 2 15:43:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774646842; cv=none; d=zohomail.com; s=zohoarc; b=kvxSrvUJZb9ceoaR4WyU8d6ByKFxVxnMT8OenQ8kfItMvz+hvVmY4mAQ6RoFxYdLWkA/qqlQSwqlzQP4UPBOOIi1m63+CVy/FVPa7uhfhg599tOTEBLkZF1SU8e9RWOHCQxKJBUCmY2qIzRDzaxdbUTtVPMiM2fvwubLVLhgenU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774646842; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6j+8F9WY80KMSNsIWnJr/7G6jY4kVXncWxg0JKnHv9A=; b=Wcmp8uq10mwhJEccoquZDBq9EhXAcYWb9CQxXUwRcGPJ+LS3+2ywtLCzeHpAzBjmlpNkyxqrszQ86dwdNSm1IYEQoHbfkBi7HcISDlpiSvVQ6xRZgDFIPJbva0wCqZiNocJUNhdJWVumU3Ul0wDzjOc3mwmKZniyJf+mJc71Zt4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774646842845495.22292969685225; Fri, 27 Mar 2026 14:27:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w6Ehv-0003ui-AI; Fri, 27 Mar 2026 17:27:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w6Ehp-0003fd-LQ for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:27:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w6Ehl-0003iJ-Su for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:27:00 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-HFpQQ921MTSMdlM8WSCXIQ-1; Fri, 27 Mar 2026 17:26:55 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4871fc50fe7so16847985e9.0 for ; Fri, 27 Mar 2026 14:26:55 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722d49c18sm115720295e9.14.2026.03.27.14.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 14:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774646817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6j+8F9WY80KMSNsIWnJr/7G6jY4kVXncWxg0JKnHv9A=; b=VmzxgmzhYltZu+llmVcmKUainiiHDMzLlnFaeV19XEB7hatZxETTWJKgBfliPIk+dE/kRU Xpm96nAXEX+pMBxn7x3F0YSSAzDPhg06Myhthx+IRhfN4GcSX+XjCG8JmbywwJCd+8kI+7 6LEfrZoiQYZDc8kR2iitUg+VWJ+pdvo= X-MC-Unique: HFpQQ921MTSMdlM8WSCXIQ-1 X-Mimecast-MFC-AGG-ID: HFpQQ921MTSMdlM8WSCXIQ_1774646815 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774646813; x=1775251613; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6j+8F9WY80KMSNsIWnJr/7G6jY4kVXncWxg0JKnHv9A=; b=tB7kMR89smjw2mOcULJ9lL30zg+EWagjKuOx1eUh6YstpVadFR4IZSvzyhtl3mnHmS REUtI8jVezDPO1y3bfkbQSZQUCxH4WiHwauGqWVoBwUvItVn7+bzlTyrEzodTICxOBTo QGay/6hhyEO+p2iwJmzZ6BFMFhH0JgsI5aQahPyNwhbskNCZlUYPDEiA3ETA01cmRtOV KnOi5Uf41j5EFpKhg3vQsFZWhZ/8jSreyd6Ap7NG461pD8isrR63EZgl0cO9FH10zWnX jN31QdFtUB589yKDTeWrNjoXaYzVwHECo00Lf10+ceXF+trxLeEezXiKLEW4o79VtGxX L6CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774646813; x=1775251613; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6j+8F9WY80KMSNsIWnJr/7G6jY4kVXncWxg0JKnHv9A=; b=Hr3AYx7SVLWIoI+2bumWAip8hyeDpNCWStCjoHcgLmHi/PBM8yyFwB2p7kxAJlfF0O AlpoHegPewUlx+mo5KT4EB/0dL6kzmLzT0ETPRK+jd1vv+vKM7Qwpv88yRD6dzE+hBTw LQ0NIf4c33BcgZYNIZwjpQdsUPbhGOV1mFi8nyh2j8NKMJZiLKt7MVmkqwuwQIfKnTzr bGavpaMww43jsA48ZcGVdhPK7avOoMYlpcWtvPRAedkzRW/k7MJQns4OfNnfsATKbFAI LyORBLfmZhI8+ozw02j/ISnrLY4RsXi67RjmodwGFypMzQQXoX+NuviPliUDpgbhLAW/ sS+A== X-Gm-Message-State: AOJu0YwLFHRRvvS8mJIw/dReAWxYrgeSCdZy9KE6+aS/nYSBnrAO5VKL bGIvmFJGPciznD5Gs+IMCq+qP6cive+iHrhcN0H6YrKtnDePf8eTcBH8CCiDzXDlRyjxWw6QLVp ng3Hrck9ypI5OzMLWACXj8cjjpkqiddothKugEwsoNHHLaZT+Mov8yz1umaa1qqlJAYfeCwCUL7 1VNjCmirJuOm5Q2otN0USxArwkTMtq9zCf9J5GyWtc X-Gm-Gg: ATEYQzwaCB4gxJVOXN+e5hkY/AwQNooyHlWoDb12X1GG2OXjhsQUIchz7IhnYMhzvu2 jv0sKCTjmUwNiMEWqdpWffmauo7G96KCs3lZZdi4iNjIMLIHvNdJ9zpplQf66TEujfe0MqR2qp8 uY2OvFmFUbewWzlPW9SLtY3Na4XJD5PqnbKCbOdEQeKoTPfw+2qROwL605dxm4D7R6YoEVgyeW7 19HfSgtnHkix9EX6oP+XhMYr2aEmogiWXnUKQEKTNmX6ZYPh+GDOq2UFiisO2XCD6DsTGj/4O+v bs48kS/sZPB3mZ4SeHmhDINkmoeqhNr+4IFHsxqqHVB6RdE2TV0oYjkSSPUkYkIH3uwmcBhertw uCDpMw6XXkL18rYOIJjWGgjn0bUWNS1k7cZtLoabThHhgsEZrz4p/D215qW4/QxZKoRlxFkehUD z2skyT0UVIkEuNs1Y1aoZhsfjv X-Received: by 2002:a05:600c:a10a:b0:485:3f72:324d with SMTP id 5b1f17b1804b1-48727e9ea73mr65002955e9.14.1774646813588; Fri, 27 Mar 2026 14:26:53 -0700 (PDT) X-Received: by 2002:a05:600c:a10a:b0:485:3f72:324d with SMTP id 5b1f17b1804b1-48727e9ea73mr65002735e9.14.1774646813152; Fri, 27 Mar 2026 14:26:53 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Helge Deller Subject: [PATCH 10/16] ncr710: remove weird p->req == NULL case Date: Fri, 27 Mar 2026 22:25:41 +0100 Message-ID: <20260327212547.460420-11-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260327212547.460420-1-pbonzini@redhat.com> References: <20260327212547.460420-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774646845337154100 Content-Type: text/plain; charset="utf-8" Setting p->req to NULL in ncr710_request_cancelled and ncr710_command_compl= ete only protects from clearing p->req->hba_private in ncr_request_free. Howev= er, in this case p->req->hba_private must have been already cleared (by the same ncr710_request_cancelled and ncr710_command_complete); so the reference to = the SCSIRequest can be kept until ncr710_request_free (called eventually by e.g. ncr710_do_command) and that assignment can be made unconditional in ncr710_request_free. Signed-off-by: Paolo Bonzini --- hw/scsi/ncr53c710.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index 7503d791205..ff0d3cf0c86 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -735,12 +735,11 @@ static void ncr710_add_msg_byte(NCR710State *s, uint8= _t data) =20 static void ncr710_request_free(NCR710State *s, NCR710Request *p) { - if (p->req && p->req->hba_private =3D=3D p) { - p->req->hba_private =3D NULL; - } + p->req->hba_private =3D NULL; if (p =3D=3D s->current) { s->current =3D NULL; } + scsi_req_unref(p->req); g_free(p); } =20 @@ -750,10 +749,8 @@ void ncr710_request_cancelled(SCSIRequest *req) NCR710Request *p =3D (NCR710Request *)req->hba_private; if (p) { req->hba_private =3D NULL; - p->req =3D NULL; ncr710_request_free(s, p); } - scsi_req_unref(req); } =20 static int ncr710_queue_req(NCR710State *s, SCSIRequest *req, uint32_t len) @@ -795,12 +792,9 @@ void ncr710_command_complete(SCSIRequest *req, size_t = resid) =20 if (p) { req->hba_private =3D NULL; - if (p =3D=3D s->current) { - p->req =3D NULL; - } else { + if (p !=3D s->current) { ncr710_request_free(s, p); } - scsi_req_unref(req); } =20 if (s->waiting =3D=3D NCR710_WAIT_RESELECT || s->waiting =3D=3D NCR710= _WAIT_DMA) { --=20 2.53.0