From nobody Thu Apr 2 20:20:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774543940; cv=none; d=zohomail.com; s=zohoarc; b=FyFcIM5fe5YZ8nrhk7gVuuOl97HpKByEhjbFyfo+5cHcLPiX+ActKtwp9gWxn3XN+2vxWtHXiII/EioJjAs1VqmMbUvKTnVgjlMxgDOMmTH1zX5qcxoXU2RBtl5UyFGj9VmTjxCj//Xi/6A3tAVLHplZy7hJcKz4xJPFl8JTpk0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774543940; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=o1KBBjUYqJEnfeVv5wHKdbXX2csFQ28RirQWc/5D4Os=; b=oATNFMr/SMh3oKY3xnRTEnRHwB0jhfF1np5QvaEQ0OeTlea5HoCru0xFAhUNRi/Feg7a0juZ/ixWkgH3/xU+qUmW0xhCA5r1m1A5emxGqSX1W/8abj5QvL7/YoUj/S+ndaAZZePMMWR9AMn6K1H8GVUyqfxCDCw/zIsTowHx7e0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774543940417594.683528810858; Thu, 26 Mar 2026 09:52:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w5nvv-0002t7-0D; Thu, 26 Mar 2026 12:51:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w5nvt-0002sj-2Q for qemu-devel@nongnu.org; Thu, 26 Mar 2026 12:51:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w5nvr-0002c6-EW for qemu-devel@nongnu.org; Thu, 26 Mar 2026 12:51:44 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-GV6cZ7f-MPSuRfjgUfoipA-1; Thu, 26 Mar 2026 12:51:38 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BC7471964CF2; Thu, 26 Mar 2026 16:51:34 +0000 (UTC) Received: from merkur.fritz.box (unknown [10.45.226.108]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 50C531955D84; Thu, 26 Mar 2026 16:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774543902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=o1KBBjUYqJEnfeVv5wHKdbXX2csFQ28RirQWc/5D4Os=; b=YeRQDDilOxo0Y5C2h10KX16PoMk9NrYOzGd9fMWroktLxUNQ51hk8OsiAX/sV3ppVBcRbL gddP1eugyN1JoNPbcRGLWfkm4iUWhap5D/3X8j/lclVSvOql2zVsdX2Xv93NEpHiyAhEDu jmuovj6KIazdSzmmVZOH+vDvlqqeoX8= X-MC-Unique: GV6cZ7f-MPSuRfjgUfoipA-1 X-Mimecast-MFC-AGG-ID: GV6cZ7f-MPSuRfjgUfoipA_1774543897 From: Kevin Wolf To: qemu-block@nongnu.org Cc: kwolf@redhat.com, timao@redhat.com, hreitz@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org Subject: [PATCH] ide: Fix potential assertion failure on VM stop for PIO read error Date: Thu, 26 Mar 2026 17:51:24 +0100 Message-ID: <20260326165124.138593-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774543942641158500 Content-Type: text/plain; charset="utf-8" ide_sector_read() as well as its callers neglect to call ide_set_retry() before starting I/O. If the I/O fails, this means that the retry information is stale. In particular, ide_handle_rw_error() has an assertion that s->bus->retry_unit =3D=3D s->unit, which can fail if either there was no previous request or it came from another device on the bus. If the assertion weren't there, a wrong request would be retried after resuming the VM. Fix this by adding a ide_set_retry() call to ide_sector_read(). This affects only reads because ide_transfer_start() does call ide_set_retry(). For writes, the data transfer comes first and the I/O is only started when the data has been read into s->io_buffer, so by that time, ide_set_retry() has been called. For reads, however, the I/O comes first and only then the data is transferred to the guest, so the call in ide_transfer_start() is too late. Buglink: https://redhat.atlassian.net/browse/RHEL-153537 Reported-by: Tingting Mao Signed-off-by: Kevin Wolf Reviewed-by: Hanna Czenczek --- hw/ide/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index b45abf067b2..52a991fc482 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -799,6 +799,7 @@ static void ide_sector_read(IDEState *s) s->error =3D 0; /* not needed by IDE spec, but needed by Windows */ sector_num =3D ide_get_sector(s); n =3D s->nsector; + ide_set_retry(s); =20 if (n =3D=3D 0) { ide_transfer_stop(s); --=20 2.53.0