From nobody Thu Apr 2 20:41:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1774541019; cv=none; d=zohomail.com; s=zohoarc; b=a4iaQ6j+bxgyBuoEvM1WOWa9GdQMiCP3/rra864COGG2Do6fvjK+uD04w7YYCrPZ3BI2KFmX56lfiiNW1FEUoxYyU6WWzbMa/gtuoacZP4lAvhvSPtH+mG7mLSIrRcID5098L7n8aCsBYg1JtX8a7l7UDlwrIkUzrOoPQhaE+sY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774541019; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=L/XOeeZJbH562gwsN3ZvedpHu8ETHOSgikP+7Qk+gTY=; b=axmXtdePtL+tNTY20E6cnwzUJIjM5USJf70TaXA7vOzK7fJXmvpOygsh/Hn5iH8wnFAK7y9371/5YikaY5un3EH9RhSGwoJS8OqHVnnUI8Y08P8wPA2Gl8u/0f6ECLj5h5A6fuhVc1Pu8WacyukQmOUZBfSpq0Q6GjqDwbnklys= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774541019086119.58659675466129; Thu, 26 Mar 2026 09:03:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w5nA8-0005Ui-5d; Thu, 26 Mar 2026 12:02:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w5mb2-00026h-Jx for qemu-devel@nongnu.org; Thu, 26 Mar 2026 11:26:10 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w5maz-0005ZF-0S for qemu-devel@nongnu.org; Thu, 26 Mar 2026 11:26:07 -0400 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-35c06831dd3so1131834a91.2 for ; Thu, 26 Mar 2026 08:26:04 -0700 (PDT) Received: from localhost.localdomain ([36.33.26.5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c22a82231sm3208677a91.6.2026.03.26.08.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 08:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774538763; x=1775143563; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L/XOeeZJbH562gwsN3ZvedpHu8ETHOSgikP+7Qk+gTY=; b=owfc7ck3CFxBJGOsYV0H5TUzZLc8ypcTNphztNHIfC3myw35T2Xapm+hdZRey8WHTn 8uttWgzs4Vn5hTPMokWgpa460DUP2FS92wSjTL27J1JHoOsp7UmzviR9Gld+SgJZa2pM iiE4/DYkcCz+GqSUlHg8W+18DUQ6AxdFDQb7wl2dqSKfi07IhX2BM+ba8kdztR758H5K lI85N+rnORI7Cs9VWUH0k4V3hp2OoHa2FUXlPR/pgm1VSaC3QqBdaFYSpHh9eZ/lSL5S KoGJrKQCVWNuLyMS5vQsRgi0rhYbayk9Wgz/YYb1I6VwzInqDI367M8X15iMyRtaMRSK xE5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774538763; x=1775143563; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L/XOeeZJbH562gwsN3ZvedpHu8ETHOSgikP+7Qk+gTY=; b=tU7e3zM+buqbpOOroEDxrfOqFlOG0ne+EH8veMFh2qkIjbLZlV9oxsKyNRT8Y1Oiy0 1RV9Z+bKXm022qX2YEIbGNQ3nSC1ppeEtjR86rH1zNOtd3r8A1Ir4GgJJal5u+N8rLoq dc8fP4YspAhx+jZ8rVaiLdf+ud9WxasFodYfqbVJY8mYFzLC4lRwOVOoN7yG/M0c44+D iqLMJTTsT+T8cP2xrO6WsCsLoWeljbx7phS6e+QQXQmY0uNAMFe8tpxh42RbFqZJ4jdd wH6BBbgRsTF8+ORtHES7o1+hyCPj7bLCTJJgrv0StxZ6pcj/jeoobRKSzyChbrVeAnVd ZsgA== X-Gm-Message-State: AOJu0Yzh9uLAEvo1KkEr+EQXdD1uk3i7ZqHxe7wvtcp0/SMJG0gPQwEw NRfWTd5oGQkOSO6Jsj8mG/us5eOhOloEuoAVsjN+CXvoK4Pb2x6fnkjORaFJHitiuP1pIQ== X-Gm-Gg: ATEYQzxqhO0MFM1WlRx2heiiZzUwXP3WWMedlDIFFBwz/FGeyQB3ptlxtDKeoQZgpeT GEs7H/EydfeRenKb+fC6aaBN5HekvTknj0sT9ABHKJFht7X22Nsybwtvu2ITSwu9S9WaxbFmXXl KalJ1vROdGac0TSbfz6qWHefS3ltmGQ6Rs9MUSkQ/6E5BoKa3XvXbL3fRLLn3oAJCve7VIZacWW 75hJWGv8++PiM2gvuVW+JDMIArg43XCWNzpojx21ByI1hshU0UkHWNXfqz38iFGmoVsm8H+q3cr UKa6dYezU1pPSnm8KdsFTMJLNJm/wv+CSkd3sb2uSr8cRx7+Y7Sh5Vnv3KkPQ+uKHoFHobYcLVi 4O0xirJQeoVb5B41PXyPkh7nEyBAcw6ZiLAFrdj4puoghcdMzUyM9xeKIZ7jTzHyy95rjQEdfMl Ex0fs6mTILNQe5cDbImg6AAdeB3ODUubqOwWMQeOZY X-Received: by 2002:a17:90b:1d4c:b0:35b:aca5:db39 with SMTP id 98e67ed59e1d1-35c0dcb2a8amr7534683a91.9.1774538763081; Thu, 26 Mar 2026 08:26:03 -0700 (PDT) From: Zexiang Zhang To: qemu-devel@nongnu.org Cc: Nicholas Piggin , Harsh Prateek Bora , qemu-ppc@nongnu.org (open list:sPAPR (pseries)), kiki , Zexiang Zhang Subject: [PATCH] As reported in qemu-project/qemu#3324 Date: Thu, 26 Mar 2026 23:25:57 +0800 Message-Id: <20260326152557.344808-1-chan9yan9@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=chan9yan9@gmail.com; helo=mail-pj1-x1034.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 26 Mar 2026 12:02:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1774541021382154100 Content-Type: text/plain; charset="utf-8" From: kiki A malformed IVE value can result in an invalid server field being passed to icp_irq(). The function assumes the server id is valid and may access invalid state otherwise, potentially leading to a crash. Fix this by validating the server id before using it and ignoring invalid values. Reported-by: Zexiang Zhang Signed-off-by: Zexiang Zhang --- hw/intc/xics.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index 1d40c4386d..25c7b0c8a5 100644 --- a/hw/intc/xics.c +++ b/hw/intc/xics.c @@ -222,6 +222,13 @@ void icp_irq(ICSState *ics, int server, int nr, uint8_= t priority) =20 trace_xics_icp_irq(server, nr, priority); =20 + if (!icp) { + qemu_log_mask(LOG_GUEST_ERROR, "XICS: invalid server %d for IRQ 0x= %x\n", + server, nr); + ics_reject(ics, nr); + return; + } + if ((priority >=3D CPPR(icp)) || (XISR(icp) && (icp->pending_priority <=3D priority))) { ics_reject(ics, nr); --=20 2.34.1