From nobody Fri Apr 3 04:33:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=unpredictable.fr ARC-Seal: i=1; a=rsa-sha256; t=1774385440; cv=none; d=zohomail.com; s=zohoarc; b=S2wHu/DRVygQ23601a+L0XxV6yrmsyke3EkHcMRHKGiCWRYCU1h2xeeXQ9G7E8K0uykio50mgKf34ZH5NKeoRLFZMumf4OHsxIcftScPWeV1ysCsExUb4mgS41zNAR/REzuCykSNyYsfWpiD3yY2ZSqCRedk4dyunicH8nddDnU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774385440; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CLyeZj/GfOb93UxqHuC1UwrRT6SXCCYzhO+nvypMIRo=; b=CoL2mX2zOp9lvi1aEe32IplVZ+WRDKI+8iaHiKCRSWQy4n4ODcuIhpqzunuDgr+dt3N53s+aZDhVsmzVahdoT0viJp0j0oGf2WQP3P+Rmm9+4/4uJI8qDS+gIYnohKDBCtkfUJwquafA5CdxiwNI/n4U5hllDsMY645MlvD60yM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177438544029298.46316189707682; Tue, 24 Mar 2026 13:50:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w58h5-0000vE-4d; Tue, 24 Mar 2026 16:49:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w58gw-0000pZ-AH for qemu-devel@nongnu.org; Tue, 24 Mar 2026 16:49:35 -0400 Received: from p-west2-cluster5-host12-snip4-10.eps.apple.com ([57.103.71.23] helo=outbound.mr.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w58gt-0004e9-QT for qemu-devel@nongnu.org; Tue, 24 Mar 2026 16:49:34 -0400 Received: from outbound.mr.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-west-2a-10-percent-0 (Postfix) with ESMTPS id ABC171800455; Tue, 24 Mar 2026 20:49:23 +0000 (UTC) Received: from localhost.localdomain (unknown [17.57.152.38]) by p00-icloudmta-asmtp-us-west-2a-10-percent-0 (Postfix) with ESMTPSA id B9ADD1800444; Tue, 24 Mar 2026 20:49:19 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1774385364; x=1776977364; bh=CLyeZj/GfOb93UxqHuC1UwrRT6SXCCYzhO+nvypMIRo=; h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme; b=YHLrR3e2drM6JqCVE/zD93YxiM591d2Li1MWlr7QTAnsBPEgaapfvzvCYzZUab6u9HtliT5Irh9Niew9cgxRyW1b1162LzpEBdO/NTwmkVkaYI/Wqv+RRgNNifUh1FVBxAxGg12dLT8CQdhs4dTv8Pi0Xzjo7iXu17nejrpVYtJMxxPF+EEbiWTd/7FH6aXiS6vnBOq1SMVv+8d3nIOQkkEgdVG+ESC2TtzN8yz4XtwnIYbVFeVcBpPjpA2IKKtOnwLggtsoDJu0UgwWozBhTcFTdvW+otdjbE3GjjUazJtTzk2UkQM1ssqIm7Tcq+MPX/yIXb5DaO+pZWcULZ4wcw== mail-alias-created-date: 1752046281608 From: Mohamed Mediouni To: qemu-devel@nongnu.org Cc: Akihiko Odaki , qemu-arm@nongnu.org, Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Phil Dennis-Jordan , Peter Xu , Mads Ynddal , Roman Bolshakov , Alexander Graf , Mohamed Mediouni Subject: [RFC PATCH v7 2/7] hw/vmapple: aes: convert MAX_LEN to a #define Date: Tue, 24 Mar 2026 21:48:50 +0100 Message-ID: <20260324204855.29759-3-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260324204855.29759-1-mohamed@unpredictable.fr> References: <20260324204855.29759-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: z_dy_z5nbP2qRh63tb_SEwOrC_EnwgBs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDE2MSBTYWx0ZWRfX11GXr3MBspyw o9PrqMEuZ92wQTTAVLrXR5eqPVwRJemxsxiRt+fR1BVbpbRqT1dvVp2Qjrh+yGAqUL7zcs9StgG leY5tf3V4M3gzBKl8WQtpZ4PXs94GLLHumDc5w/UsvJ/XZBu5qegdgaVQL3A1srPETaPFjQJmPX OJ5I799W/XTt3vq6ZqOTtnwiedPNXAhmcxwWkZ8vv6+i9MG1GFb2QB+2R+on4T+EUpm76NRaK+J aT0Da5x/mpB5L4DEgKGQyMYGPzeB2u4yGzCsCbylofDdmCjiToF7uP3hidlXvTuQ4OfiSTLFYYi mTwThXVCVAeuZmonKOXys0xj+jCDAXhl/2cEjUyyvyztwPqoNlaxwpHIefFejk= X-Proofpoint-ORIG-GUID: z_dy_z5nbP2qRh63tb_SEwOrC_EnwgBs X-Authority-Info-Out: v=2.4 cv=ceffb3DM c=1 sm=1 tr=0 ts=69c2f8d4 cx=c_apl:c_pps:t_out a=9OgfyREA4BUYbbCgc0Y0oA==:117 a=9OgfyREA4BUYbbCgc0Y0oA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=CNpkFlK3StMqgsPjqO8A:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_03,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxlogscore=783 clxscore=1030 bulkscore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2603240161 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=57.103.71.23; envelope-from=mohamed@unpredictable.fr; helo=outbound.mr.icloud.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @unpredictable.fr) X-ZM-MESSAGEID: 1774385442837154100 Content-Type: text/plain; charset="utf-8" Working around this compiler warning: ../hw/vmapple/aes.c:257:14: warning: variable length array folded to consta= nt array as an extension [-Wgnu-folding-constant] 257 | char hex[MAX_LEN * 2 + 1] =3D ""; | ^~~~~~~~~~~~~~~ 1 warning generated. Signed-off-by: Mohamed Mediouni --- hw/vmapple/aes.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/vmapple/aes.c b/hw/vmapple/aes.c index 553e688adb..9d062d5a7f 100644 --- a/hw/vmapple/aes.c +++ b/hw/vmapple/aes.c @@ -253,7 +253,7 @@ static bool cmd_iv(AESState *s) =20 static void dump_data(const char *desc, const void *p, size_t len) { - static const size_t MAX_LEN =3D 0x1000; +#define MAX_LEN 0x1000 char hex[MAX_LEN * 2 + 1] =3D ""; =20 if (len > MAX_LEN) { @@ -262,6 +262,7 @@ static void dump_data(const char *desc, const void *p, = size_t len) =20 qemu_hexdump_to_buffer(hex, sizeof(hex), p, len); trace_aes_dump_data(desc, hex); +#undef MAX_LEN } =20 static bool cmd_data(AESState *s) --=20 2.50.1 (Apple Git-155)