From nobody Sun Apr 5 13:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774378631; cv=none; d=zohomail.com; s=zohoarc; b=kCc+skGeWsH3iTTbjrzoJE0A6wdonB4NhJWrOEtPBWjD7ffdETRUfm2vCwDO1fFjU8fTCAZILD+vxAnmu73xPMA8/Kredfu4rl4VhAhw4QqIRGYJfgEe6igoax3PW8DaH+xty+FZt5LMdCsOjbhrhNq7oNUfiggUuIxCX/iJ8jQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774378631; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7bb1sau8Aoz4VRZKYzN8vn5yOtnyef9vGgg9AFx+GME=; b=j68YYVZ+f+c4YzuDpZL2j4a2TZP5PjrjMaD+JAIKhgQEnVzdJDdnfGl0ST/l5owdA+v31yv7WsrqGcl12mqG88dXAaKBb2T1bOoytUQHTpjXHLTRe0wr4vlNz1fOp1R5LK8BzJXh6gLIWy1GZ8VGYumN0kF+tm8dB0MnWhw7qFE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177437863112817.30838552307307; Tue, 24 Mar 2026 11:57:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w56vh-0004ic-65; Tue, 24 Mar 2026 14:56:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w56ve-0004gh-IU for qemu-devel@nongnu.org; Tue, 24 Mar 2026 14:56:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w56vc-0006fd-Qr for qemu-devel@nongnu.org; Tue, 24 Mar 2026 14:56:38 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-247-SPNMaiREM-2XmVvs3ZuUYw-1; Tue, 24 Mar 2026 14:56:34 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4F81F18005B0; Tue, 24 Mar 2026 18:56:33 +0000 (UTC) Received: from merkur.fritz.box (unknown [10.44.33.246]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9F09730002C3; Tue, 24 Mar 2026 18:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774378595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7bb1sau8Aoz4VRZKYzN8vn5yOtnyef9vGgg9AFx+GME=; b=fFa5Vg2xlnLQwSTh3hZbNmGBnSXPCHaPEBZ2Xy2wRUqQsg2Vq9cWTRMLh2OsYmZ4Q7faDL 4sch9D9PqcyJASVFbRCSxNji8zakEPOUKQcD9vuJN+o8+UEBNz+u2yqQJRexdRiT/q4Mlj lb5IgDXBWok+FQQVl/BfcMjTPhVCZuo= X-MC-Unique: SPNMaiREM-2XmVvs3ZuUYw-1 X-Mimecast-MFC-AGG-ID: SPNMaiREM-2XmVvs3ZuUYw_1774378593 From: Kevin Wolf To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org Subject: [PULL 1/4] block/curl: free s->password in cleanup paths Date: Tue, 24 Mar 2026 19:56:16 +0100 Message-ID: <20260324185619.296946-2-kwolf@redhat.com> In-Reply-To: <20260324185619.296946-1-kwolf@redhat.com> References: <20260324185619.296946-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774378631786158500 Content-Type: text/plain; charset="utf-8" From: GuoHan Zhao When password-secret is used, curl_open() resolves it with qcrypto_secret_lookup_as_utf8() and stores the returned buffer in s->password. Unlike s->proxypassword, s->password is not freed either in the open failure path or in curl_close(), so the resolved secret leaks once it has been allocated. Free s->password in both cleanup paths. Fixes: 1bff96064290 ('curl: add support for HTTP authentication parameters') Signed-off-by: GuoHan Zhao Message-ID: <20260320063016.262954-1-zhaoguohan_salmon@163.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/curl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/curl.c b/block/curl.c index 66aecfb20ec..419df78258b 100644 --- a/block/curl.c +++ b/block/curl.c @@ -903,6 +903,7 @@ out_noclean: g_free(s->cookie); g_free(s->url); g_free(s->username); + g_free(s->password); g_free(s->proxyusername); g_free(s->proxypassword); if (s->sockets) { @@ -1014,6 +1015,7 @@ static void curl_close(BlockDriverState *bs) g_free(s->cookie); g_free(s->url); g_free(s->username); + g_free(s->password); g_free(s->proxyusername); g_free(s->proxypassword); } --=20 2.53.0