From nobody Fri Apr 3 22:13:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774270626; cv=none; d=zohomail.com; s=zohoarc; b=MHoZtP9sqFdB9w6CS3DZJAJwZDUfbrq8ZkVe74MZOIH3H3l1fI07OvYOSgv6/agwKY+5zAjYNo6JzAS67/23YUxQcNoSBtVl1ATyX4NgxAMIU0J2JIktdzOSEXSINcnkIWMcYsqlpWCiv3Mq8KjzazPlW4qcDSsWj1BdbB0EGVY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774270626; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fg+1S6CTTkxP9OnhcYMF04vJJdpPNBc8fkDbt1OGcN8=; b=i2wFD85mkWCi2xH7WY+nhJT4Gvftlf42ujBuyqKaB9GrbRRSyniHpO8dip3ZG+wKaC57/M3ddZ88X+VZwwUW7FTKKQZF+kgKna6z3Y+NkbGI4DumeT7QcutHKxBjZKsnQFXDx7cdZkEv9i/imVvpVFRBv0ALJSUS/00xrHkdtWw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17742706260271011.6789821119289; Mon, 23 Mar 2026 05:57:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w4epn-0000P9-17; Mon, 23 Mar 2026 08:56:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w4ep9-0008SB-Mg for qemu-devel@nongnu.org; Mon, 23 Mar 2026 08:56:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w4ep8-00063R-4O for qemu-devel@nongnu.org; Mon, 23 Mar 2026 08:56:03 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-alBXpG2WOyeqZESNx9ft5A-1; Mon, 23 Mar 2026 08:56:00 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C186519560A7; Mon, 23 Mar 2026 12:55:58 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.42]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CD59919560B7; Mon, 23 Mar 2026 12:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774270561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fg+1S6CTTkxP9OnhcYMF04vJJdpPNBc8fkDbt1OGcN8=; b=YOqxwBAt/PfHj99hX3hlLNz9MALfvXcWZlwiyswO6vY3aCqwZeeQa7svij3AFGC1g037w9 vzDgHetpRO3q/zEu/+uZBSnJlP9287hLZ6A+uKlPSPnyDAjG52T+sxliO1j8yD9sDyibJP a583WxBrbEIEMSDVu/3S9ZARN4tGeSI= X-MC-Unique: alBXpG2WOyeqZESNx9ft5A-1 X-Mimecast-MFC-AGG-ID: alBXpG2WOyeqZESNx9ft5A_1774270558 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Jamin Lin , Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 3/3] hw/i2c/aspeed_i2c: Remove assert Date: Mon, 23 Mar 2026 13:55:45 +0100 Message-ID: <20260323125545.577653-4-clg@redhat.com> In-Reply-To: <20260323125545.577653-1-clg@redhat.com> References: <20260323125545.577653-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774270627950158500 According to the Aspeed datasheet, the RX_BUF_LEN_W1T and TX_BUF_LEN_W1T bits of the A_I2CS_DMA_LEN (0x2c) register allow firmware to program the TX and RX DMA length (TX_BUF_LEN and RX_BUF_LEN fields of the same register) separately without the need to read/modify/write the value. If RX_BUF_LEN_W1T and TX_BUF_LEN_W1T bits are 0, then both TX and RX DMA length will be written. When setting the RX_BUF_LEN field, the TX_BUF_LEN field being set is not an invalid condition. Remove the assert. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3315 Reviewed-by: Jamin Lin Link: https://lore.kernel.org/qemu-devel/20260322215732.387383-4-clg@redhat= .com Signed-off-by: C=C3=A9dric Le Goater --- hw/i2c/aspeed_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index ad6342bec0d4..5d18f8d49ea4 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -780,7 +780,6 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus,= hwaddr offset, bus->regs[R_I2CS_DMA_RX_ADDR] =3D value; break; case A_I2CS_DMA_LEN: - assert(FIELD_EX32(value, I2CS_DMA_LEN, TX_BUF_LEN) =3D=3D 0); if (FIELD_EX32(value, I2CS_DMA_LEN, RX_BUF_LEN_W1T)) { ARRAY_FIELD_DP32(bus->regs, I2CS_DMA_LEN, RX_BUF_LEN, FIELD_EX32(value, I2CS_DMA_LEN, RX_BUF_LEN)); --=20 2.53.0