From nobody Fri Apr 3 22:35:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1774267133; cv=none; d=zohomail.com; s=zohoarc; b=MmxJIvSFIiBhiuKYjOLps0iKBwdYlQa36tGNXyWhl44xQBaVq7xapMEOhfEo1La4ClFeermeRR7ioOCXnjiPoZ1/IFt8OUJFWukc/k6HmORw/xMYhMm4z7/JO7xVWfvoY/pP4l4toVDqs68ctKE+ByPbaHWBT8y1P2q9JjED36c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774267133; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3qKH/AOjRjhm/x8a9eu7OnZ3TkDZ/w2V+YOycx7vrL0=; b=lJ6GMU24vv8E1mxe9OQ8pKH8fStDdQrWy6fGooZYzg/9sH5gE9/F0gpuL26Qvbtl2msiIvDtzIyyiIGDNIdgZuQO593MFxsdKyaSdHHIflUymKue8t0/8MqWq+mXHsan2fBr2c8e3sV5L+F611ZVL6uUUw945OJvNTAFgXW29bg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774267133066267.4113625335235; Mon, 23 Mar 2026 04:58:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w4duT-0000Ld-NQ; Mon, 23 Mar 2026 07:57:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w4duR-0000Jv-D0 for qemu-devel@nongnu.org; Mon, 23 Mar 2026 07:57:27 -0400 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w4duP-0003ep-VE for qemu-devel@nongnu.org; Mon, 23 Mar 2026 07:57:27 -0400 Received: from DESKTOP-TUU1E5L.localdomain (unknown [167.220.208.76]) by linux.microsoft.com (Postfix) with ESMTPSA id 2526B20B710C; Mon, 23 Mar 2026 04:57:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2526B20B710C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1774267044; bh=3qKH/AOjRjhm/x8a9eu7OnZ3TkDZ/w2V+YOycx7vrL0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gjmzbRuQro4yAxPIUF++q3ijPizn0qJVZqXMULdmR8Ii8ulfHDH1PSb9FYVt6b7w0 hKqHmTHA5hrQCweOmy0z+fikM8qNbGoVospK7SAF4H0tn3XGzZxfe/OuftWvTwpJYT 3PXn76SGusD4qkwBb1rigr1v0NMEJFjoRLv7ULxg= From: Magnus Kulke To: qemu-devel@nongnu.org Cc: Wei Liu , Paolo Bonzini , Wei Liu , Magnus Kulke , Magnus Kulke , Zhao Liu Subject: [PATCH v3 4/9] target/i386/mshv: change cpuid mask to UINT32_MAX Date: Mon, 23 Mar 2026 12:57:06 +0100 Message-Id: <20260323115711.353793-5-magnuskulke@linux.microsoft.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260323115711.353793-1-magnuskulke@linux.microsoft.com> References: <20260323115711.353793-1-magnuskulke@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=13.77.154.182; envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.microsoft.com) X-ZM-MESSAGEID: 1774267134147158500 Content-Type: text/plain; charset="utf-8" The current implementation would only override the feature bits that are enabled, however we also want to consider disabled features, hence all bits are set on the masks in the hypercall argument. Signed-off-by: Magnus Kulke Acked-by: Wei Liu --- target/i386/mshv/mshv-cpu.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 4183727a86..e42b5a614d 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -538,22 +538,17 @@ static int register_intercept_result_cpuid_entry(cons= t CPUState *cpu, .input.always_override =3D always_override, .input.padding =3D 0, /* - * With regard to masks - these are to specify bits to be overwrit= ten - * The current CpuidEntry structure wouldn't allow to carry the ma= sks - * in addition to the actual register values. For this reason, the - * masks are set to the exact values of the corresponding register= bits - * to be registered for an overwrite. To view resulting values the - * hypervisor would return, HvCallGetVpCpuidValues hypercall can be - * used. + * Masks specify which bits to override. Set to 0xFFFFFFFF to + * override all bits with the values from the QEMU CPU model. */ .result.eax =3D entry->eax, - .result.eax_mask =3D entry->eax, + .result.eax_mask =3D 0xFFFFFFFF, .result.ebx =3D entry->ebx, - .result.ebx_mask =3D entry->ebx, + .result.ebx_mask =3D 0xFFFFFFFF, .result.ecx =3D entry->ecx, - .result.ecx_mask =3D entry->ecx, + .result.ecx_mask =3D 0xFFFFFFFF, .result.edx =3D entry->edx, - .result.edx_mask =3D entry->edx, + .result.edx_mask =3D 0xFFFFFFFF, }; union hv_register_intercept_result_parameters parameters =3D { .cpuid =3D cpuid_params, --=20 2.34.1