From nobody Fri Apr 3 22:13:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774261875; cv=none; d=zohomail.com; s=zohoarc; b=OoGIO99W1wLd3fkt5PtxO1o0rQydnIAiRw6hZgLlBHtjNbB9O5Sxj4Xkoj39JodW382qjJqebhiAa84Si9TS1fpJfAvZADORBf2omFFgqKxGgWEJyzbODffFomQMkG45Nl3EqvFIvGCd7rq+cFot+BP/EiwChts81oDPZxXG7QY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774261875; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gPE0PGbUieh4H5tEywglXPgc/0vbzNmgzvnwWExdN24=; b=cfQ0VGnemoVeUdFl/Szop+drPBaK6dVM92PT73Xe71FO0iR5nnHYDg7kpjQuzZteL3xBkcgjshY7vDmiBAoKF8Af7wJ6qvazCGf8SFm0m4X3+VmieXIUSgyn733O3oS92JvcL7SrULlD+7LFcB8gjng8N5JH33+SdopndGa/BVk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774261875871805.8317389305988; Mon, 23 Mar 2026 03:31:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w4cXV-00030M-5X; Mon, 23 Mar 2026 06:29:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w4cXP-0002zQ-Dg for qemu-devel@nongnu.org; Mon, 23 Mar 2026 06:29:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w4cXN-0008Do-L9 for qemu-devel@nongnu.org; Mon, 23 Mar 2026 06:29:34 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-aEnvW9e2NsScVVTxMvggMw-1; Mon, 23 Mar 2026 06:29:31 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F08E31944F2F; Mon, 23 Mar 2026 10:29:28 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.32.50]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2F86A300019F; Mon, 23 Mar 2026 10:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774261772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gPE0PGbUieh4H5tEywglXPgc/0vbzNmgzvnwWExdN24=; b=IJB2RGFOlNU2pbQu3/DR6coaM2ZdeOUfgwllmH3wFE7Aj8sI9BHv31gStb2JsnNvpca1Rn h3pBi7KhEqz7wi8+QoKv0gHQ3/KFu5O2nqByllvAA1VRuGREAxGSORRIcMaZB34Wl5IWNa kfExlKm5uTwG6tNxGR1fcHdVRzqU5+w= X-MC-Unique: aEnvW9e2NsScVVTxMvggMw-1 X-Mimecast-MFC-AGG-ID: aEnvW9e2NsScVVTxMvggMw_1774261769 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Markus Armbruster Subject: [PULL 2/6] hw/display/cg3: Fix crash when introspecting cgthree from the CLI Date: Mon, 23 Mar 2026 11:29:16 +0100 Message-ID: <20260323102920.25170-3-thuth@redhat.com> In-Reply-To: <20260323102920.25170-1-thuth@redhat.com> References: <20260323102920.25170-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774261877016154100 Content-Type: text/plain; charset="utf-8" From: Thomas Huth QEMU currently crashes when introspecting the cgthree device from the command line interface: $ ./qemu-system-sparc -device cgthree,help Segmentation fault (core dumped) This happens because the memory_region_init_rom() function internally calls qemu_ram_alloc_internal() that needs the current_machine pointer to be set up - which is not the case here since the machine has not been created yet. There does not seem to be a compelling reason for initializing the memory regions from the instance_init function, so let's simply move the code into the realize() function instead to fix this issue. Tested-by: Markus Armbruster Signed-off-by: Thomas Huth Message-ID: <20260317080623.438230-1-thuth@redhat.com> --- hw/display/cg3.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/hw/display/cg3.c b/hw/display/cg3.c index 61bdb0552e9..0a413fbb7ec 100644 --- a/hw/display/cg3.c +++ b/hw/display/cg3.c @@ -277,10 +277,13 @@ static const GraphicHwOps cg3_ops =3D { .gfx_update =3D cg3_update_display, }; =20 -static void cg3_initfn(Object *obj) +static void cg3_realizefn(DeviceState *dev, Error **errp) { - SysBusDevice *sbd =3D SYS_BUS_DEVICE(obj); - CG3State *s =3D CG3(obj); + SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); + Object *obj =3D OBJECT(dev); + CG3State *s =3D CG3(dev); + int ret; + char *fcode_filename; =20 memory_region_init_rom(&s->rom, obj, "cg3.prom", FCODE_MAX_ROM_SIZE, &error_fatal); @@ -289,14 +292,6 @@ static void cg3_initfn(Object *obj) memory_region_init_io(&s->reg, obj, &cg3_reg_ops, s, "cg3.reg", CG3_REG_SIZE); sysbus_init_mmio(sbd, &s->reg); -} - -static void cg3_realizefn(DeviceState *dev, Error **errp) -{ - SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); - CG3State *s =3D CG3(dev); - int ret; - char *fcode_filename; =20 /* FCode ROM */ fcode_filename =3D qemu_find_file(QEMU_FILE_TYPE_BIOS, CG3_ROM_FILE); @@ -381,7 +376,6 @@ static const TypeInfo cg3_info =3D { .name =3D TYPE_CG3, .parent =3D TYPE_SYS_BUS_DEVICE, .instance_size =3D sizeof(CG3State), - .instance_init =3D cg3_initfn, .class_init =3D cg3_class_init, }; =20 --=20 2.53.0