From nobody Sun Mar 22 14:11:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1774054218; cv=none; d=zohomail.com; s=zohoarc; b=msAP4GRPrrIW1IuSapfpe+G/omjA8aYjYnW3mtWB+G5Z4kB1SfzUVEG+rkqhWWBXcH7rE4LkcVrxPnkqRuYF8wfLlhN5O6JQTa+7S4/sjSruCrEzrdGkBMmxkvYYTQdSvrcox7JTXGBXPe2WQ4ynp+1ML7C128Rom8yc6XBoR+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774054218; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=j2p6psSGBay8A2Y7TVO3feWIFubdiokxQDyyjj14QeI=; b=DPqkWC+xMEoOXzFWZshG8AKdBlp/cr+FLHUGeNItOYX0JsEDL1iQioJv90DIc5NcNSbec8LpJnq0Cx9aGPqVygjAlVuwbREn6cGJ8Wkq8jaT6NHxZ1d5Grna22FmwB2LaFcF5Hljvb2HmW7aLnM8RicxY7lurTGikYG++hc/rwo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774054218301322.5042466042912; Fri, 20 Mar 2026 17:50:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3kWZ-0005Q7-1Z; Fri, 20 Mar 2026 20:49:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3kWX-0005Pg-7P for qemu-devel@nongnu.org; Fri, 20 Mar 2026 20:49:05 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3kWV-000257-N5 for qemu-devel@nongnu.org; Fri, 20 Mar 2026 20:49:04 -0400 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2ab39b111b9so5253775ad.1 for ; Fri, 20 Mar 2026 17:49:03 -0700 (PDT) Received: from lima-default (103.95.112.190.qld.leaptel.network. [103.95.112.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083527f84sm34637685ad.18.2026.03.20.17.48.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 17:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774054142; x=1774658942; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j2p6psSGBay8A2Y7TVO3feWIFubdiokxQDyyjj14QeI=; b=EwA2zkQLcbnGLhtMRuJWNsC+rsmc3dHm/SjXwpew1mVdywl2AJaVUL8u+2oUs3hv8J uoM1Ekb402XjYrNkMy7fCrBp1fK2H+8qa3faAaOcpSJvdN/t/Peypk0kNzcfXpSg4o/L 23wZTDgUx/SfPNMHdeIMUCDlX2ss3PUHbZGB0fAtX0KoEWZzFLMul+3lLNMp/GmzMOv2 Vd3rGFDjwxzyps475o0aVd1C6DeqzTprI7TSOmjEJhWNC+TsdrVQecsFxHnbC2/Q74TA W7+7znr2kXzFlfJN+HR8zL/85KksXfRsYpWEc8qDX6CdoQLrk/KkXgDW/mcEvGaQtrVC IWYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774054142; x=1774658942; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=j2p6psSGBay8A2Y7TVO3feWIFubdiokxQDyyjj14QeI=; b=jyrwJ12OMH1ADe88YCAAdXSlaHCMEezQtOd7Il0zciSuYr0IQqE7BxwUAgudOt3WM0 3qhOwThaHkCuxScJfqCP/yczbWZnWemjW8qJZrK4voSZCcITb/2R66wKYnjMX4u8XeYy L4AqI+jU2WHb0vkzlOAFsTmowsGfc9c8KvD641LoeRbtRoc4L65sy8AUIHiC3/dMwOgv 5Z+R4koX6ZdbVEGFhr4q0RVsEXwIE3ktiDuETl3fNm4lY43Ps1hlHlFX0lQT1m09Ze2Z AQARHmdxtbwrHiXNPYFP8nuTDka3i/vzSiFSRd89oSeM9W4ML1ji6yg7R7UfNS0R+R12 owqQ== X-Gm-Message-State: AOJu0Yw/td+YgucDeNRJHp66ZJExgcBcw4T7WXHhuIvl9SgZfcd27uXF hVfUQuvFlbjtyTPBSj4xlnqgdof7NpW0eYTBT3EKz7wAoG0CM4+bc7zL2Ngn9g== X-Gm-Gg: ATEYQzzvqyNHE2auqitHZcN1Utq9iQ4kf6QKh0IIvrBmRx1jCMyAnPdgjERY4kVkh2j Ry12m/ottAQztzZ+tAw5qiSeYndNH2VOma812+3yZrj0MpilZD+mpHXlvOwdagyf33V6AEX/Oog 4w/aUStJZvLFibCKr4UI3zZOmy6IIr4GQhKcXXKcV3rGmHLXanzK9UBYatTx3hOjzd8bE9GLZZl PtJ739Pwpv6PNXUmiY+NXd0a8oQp6mO4AJK4w7soDM2nhRJADg8jZUqUaL03GcMUnhRcjQR4DK+ Wn4MF2P3CUiI5ZGOdOSJa57Lbqjp2orcXkQ/UI6uboLOHtl6i7gsvh7OUfpfjALl05ZfqUyb1fl IV1S+F3GZyWk0T/VM879pLTLZgoHiUKfkj3pbJyPQXkVKglOzRl5YdhxEEH7Y2AmyQa4rtxE3N+ 34cb03ym9v1MS5DYQGuWrIkRTdpzoH3XLQ+zQVp1dWMo6GM+Nluu05VFcj2c62WB3HtKWY X-Received: by 2002:a17:902:dac9:b0:2b0:6f7e:6f3d with SMTP id d9443c01a7336-2b082826fa4mr45149225ad.53.1774054141807; Fri, 20 Mar 2026 17:49:01 -0700 (PDT) From: Nicholas Piggin To: qemu-devel@nongnu.org Cc: Nicholas Piggin , Warner Losh , Kyle Evans , Laurent Vivier , Pierrick Bouvier , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-riscv@nongnu.org Subject: [PATCH 1/3] bsd-user: Fix unlock_user API usage Date: Sat, 21 Mar 2026 10:48:34 +1000 Message-ID: <20260321004836.500390-2-npiggin@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260321004836.500390-1-npiggin@gmail.com> References: <20260321004836.500390-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=npiggin@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1774054219660158500 Content-Type: text/plain; charset="utf-8" Fix errors in unlock_user() calls: - unlock_user() with len=3D1 instead of len=3Dwritten - unlock_user() with len=3D1 instead of len=3D0 Signed-off-by: Nicholas Piggin Reviewed-by: Warner Losh --- bsd-user/bsd-misc.c | 2 +- bsd-user/bsd-misc.h | 2 +- bsd-user/bsdload.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bsd-user/bsd-misc.c b/bsd-user/bsd-misc.c index 3e1968718f..eac3edb8ac 100644 --- a/bsd-user/bsd-misc.c +++ b/bsd-user/bsd-misc.c @@ -95,7 +95,7 @@ abi_long host_to_target_semarray(int semid, abi_ulong tar= get_addr, for (i =3D 0; i < nsems; i++) { __put_user(array[i], host_array + i); } - unlock_user(array, target_addr, 1); + unlock_user(array, target_addr, nsems * sizeof(unsigned short)); return 0; } =20 diff --git a/bsd-user/bsd-misc.h b/bsd-user/bsd-misc.h index 13e40d9cde..13abc7e3b1 100644 --- a/bsd-user/bsd-misc.h +++ b/bsd-user/bsd-misc.h @@ -211,7 +211,7 @@ static inline abi_long do_bsd___semctl(int semid, int s= emnum, int target_cmd, break; } out: - unlock_user(target_un, un_ptr, 1); + unlock_user(target_un, un_ptr, 0); return ret; } =20 diff --git a/bsd-user/bsdload.c b/bsd-user/bsdload.c index 5b3c061a45..9ea3b93825 100644 --- a/bsd-user/bsdload.c +++ b/bsd-user/bsdload.c @@ -30,7 +30,7 @@ abi_long memcpy_to_target(abi_ulong dest, const void *src, return -TARGET_EFAULT; } memcpy(host_ptr, src, len); - unlock_user(host_ptr, dest, 1); + unlock_user(host_ptr, dest, len); return 0; } =20 --=20 2.51.0 From nobody Sun Mar 22 14:11:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1774054186; cv=none; d=zohomail.com; s=zohoarc; b=Gl3l4A6CY+lIwFCLRlsFmVSkkfaj1DF1cleGugff9kknmVUSjqhCWq68ISSjOzLpo54rkJwBcRd44/BLLAbBjZY1S7kp6JK55+3v+d+4zfrrkbG1HvAyT3wuGU++gaAdYYgt+pCDarCvPSfndmo0IGWnD2XRLqps5aUfzDOtuVI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774054186; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3Vn78SmAAKLbz3+kHLOEDEuAaN8ZeC+NU4A6mFcmLx8=; b=GS3laxY/9xL42RCi5tPcOIh2vXlSiDu9M8qYUT+HXOPObR534L8rjRHPBFDGLQRaX1ZwKtYrE7Xqxd79JvTB80wrBT621caXem4cxKmGkUhU8ccuh/o7dQwyEyAdZtYtNnN/nc1fZiSGx6dxR6qsbN/l2arGau06+dmfdtEgBkA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774054186833741.0977870059169; Fri, 20 Mar 2026 17:49:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3kWe-0005R3-AE; Fri, 20 Mar 2026 20:49:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3kWd-0005Qr-1E for qemu-devel@nongnu.org; Fri, 20 Mar 2026 20:49:11 -0400 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3kWb-00025V-HF for qemu-devel@nongnu.org; Fri, 20 Mar 2026 20:49:10 -0400 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-35b97ed057cso684991a91.1 for ; Fri, 20 Mar 2026 17:49:09 -0700 (PDT) Received: from lima-default (103.95.112.190.qld.leaptel.network. [103.95.112.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083527f84sm34637685ad.18.2026.03.20.17.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 17:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774054147; x=1774658947; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3Vn78SmAAKLbz3+kHLOEDEuAaN8ZeC+NU4A6mFcmLx8=; b=MFrxdr7PfbLJ9SKsElFlsyx408sS2LhE5YFhZ1IcfockPDKibiRKCQHymh0cni9WJ3 qdgPsHqTvDvxQsCjp6KVwgD4i7639EwjZFpiyNbK66jEtCSBbuRL3Go2SNx6Au+92e2P 5IWwKTMIZYNUwztU38jorDdAv58fJrkd6cDkauZ1tTvkBXK164p69VP3rph+QbGfzKmd tSgov0hhRJLw8swufbMogeeY+O6ifsT1sCxn2lMFN4W5MxvAlmmdO/gQXxpnsAFf8X2p d+vgfRQt8/3flr5J5DH8mf45gkaNtuXP8bpGHyJpkk3VFHqLYG33eaaYsobmlIo6AXzY SVxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774054147; x=1774658947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3Vn78SmAAKLbz3+kHLOEDEuAaN8ZeC+NU4A6mFcmLx8=; b=gwwoDwexd1zrmu2w7THm5DRn6hJn6j9IlDjZdYLyzPp3Pux9HtDWp3ncHurWgUtT+x 1OmeGNOYSAPn6H+BVRqVjb1biL7+Vi9Sjozx8TJku6CMpDmny4t8ZiwuFkqgYvkGwtqO VfCbNLV2TC6qbcUZHYKY3FreEemuvPv/0BJBV4OEbjQK8Mse/KDhJqI2K74gzUNXkfdz nsi1Vjo1Chr167hRxiLgctpZzSjPlMC7utVHzWOsU4Y3yu2BlXKzmchmWVOdR/3W2Ak+ xm3uYz8H9tY82DrP7NYZ3GCSQHSJVdM9YIY5L+vQD4sLb76NT7v4dae73PVVLs8EyMsE OZ+g== X-Gm-Message-State: AOJu0YzmjxAdOOcXqkphQDFvut1VSeDff3tWddGqDeZfT9oUQ7X+Hoyu he5DxMrLgNFG/6bxukSEo04puOwrq5/oelGrsnillPBNdXueBEzFD0woTur5fQ== X-Gm-Gg: ATEYQzworgzYgV+tsT8XH1/NLIv6cweY4AXKtFA47nRXhlQ1KseD1AGFfyvBYDXENHb IZFr1bhz2ReeqXTBf03z9i5hPJyIeLockmHAAL5jLamuRS1ppZ6zRtxjjrp5Dn1FIahz7OCUImU ZxXt3BF/GszXM5y/i9vXecwJyaLh3EXtPESLRCAHy8FwlHvzfHxZ5tGE8XYiNUOP3YGyA9kw3Lo iqIyRhOoQK0rLX07HOp8jLI8hYoaFY/v5SeYO3ykHu1KhWymISR7w5OUSBFKMV1n9lKNOBNYGmw HTiIfH5N2Q34VIjdmJVS7x0R+0WnIi4BUwCCTyuvcUMlZTRrKatafi/LX88WW2dkjmmw3cLu+XL T2kJ4xvq5yAMTrasPMJXJWxpMZHw/0AeriZdmXPAy+pJG2lGUK6rHQ43CdY2k7HwZZmQXg0Vchh f1lmlhXyg0sdxMzLHQxirKiXR57vNiAFkxMsf7e4da+as66KJqO9anPfeFOnpNkgDFi1bg X-Received: by 2002:a17:903:2984:b0:2b0:5ae9:ee4 with SMTP id d9443c01a7336-2b0826d8307mr43580205ad.5.1774054147270; Fri, 20 Mar 2026 17:49:07 -0700 (PDT) From: Nicholas Piggin To: qemu-devel@nongnu.org Cc: Nicholas Piggin , Warner Losh , Kyle Evans , Laurent Vivier , Pierrick Bouvier , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-riscv@nongnu.org Subject: [PATCH 2/3] linux-user: Fix unlock_user API usage Date: Sat, 21 Mar 2026 10:48:35 +1000 Message-ID: <20260321004836.500390-3-npiggin@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260321004836.500390-1-npiggin@gmail.com> References: <20260321004836.500390-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102b; envelope-from=npiggin@gmail.com; helo=mail-pj1-x102b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1774054189687158500 Content-Type: text/plain; charset="utf-8" Fix errors in unlock_user() calls: - unlock_user() with len=3D1 instead of len=3Dwritten - unlock_user() with len=3D1 instead of len=3D0 - unlock_user() with len=3D0 instead of len=3D1 Signed-off-by: Nicholas Piggin Reviewed-by: Chao Liu --- linux-user/linuxload.c | 2 +- linux-user/syscall.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/linux-user/linuxload.c b/linux-user/linuxload.c index 85d700953e..79416a94c9 100644 --- a/linux-user/linuxload.c +++ b/linux-user/linuxload.c @@ -19,7 +19,7 @@ abi_long memcpy_to_target(abi_ulong dest, const void *src= , unsigned long len) return -TARGET_EFAULT; } memcpy(host_ptr, src, len); - unlock_user(host_ptr, dest, 1); + unlock_user(host_ptr, dest, len); return 0; } =20 diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 7832a1aba5..13b8bd9ed3 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -2989,7 +2989,7 @@ get_timeout: if (put_user_u32(lv, optlen)) { return -TARGET_EFAULT; } - unlock_user(results, optval_addr, 0); + unlock_user(results, optval_addr, len); break; } #endif /* LINUX_VERSION_CODE >=3D KERNEL_VERSION(4, 2, 0) */ @@ -4006,7 +4006,7 @@ static inline abi_long host_to_target_semarray(int se= mid, abi_ulong target_addr, __put_user((*host_array)[i], &array[i]); } g_free(*host_array); - unlock_user(array, target_addr, 1); + unlock_user(array, target_addr, nsems * sizeof(unsigned short)); =20 return 0; } @@ -7888,7 +7888,7 @@ static inline abi_long target_to_host_sigevent(struct= sigevent *host_sevp, host_sevp->sigev_notify =3D tswap32(target_sevp->sigev_notify); host_sevp->sigev_notify_thread_id =3D tswap32(target_sevp->_sigev_un._= tid); =20 - unlock_user_struct(target_sevp, target_addr, 1); + unlock_user_struct(target_sevp, target_addr, 0); return 0; } =20 --=20 2.51.0 From nobody Sun Mar 22 14:11:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1774054208; cv=none; d=zohomail.com; s=zohoarc; b=RCi7glsPbzfuBLbZIlAAl9T8nRPvhK9AW3GgI+JgO3y0tEkdSKmzeCP2Ri2Bw+UFe/vyHKq8mjd6XayWOhzHRcqWuX3bjqBwNc56iGp0+QFS9SCfUHoD9sdJFbOOYFMK0ndITMPFr16xiJHDwb/CEh0+yNgrqCA+ZHRNTDVSNr8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774054208; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hFmstGmcFWszN/qiAw2otwmThWAyPfpEPK+SFVFBwqs=; b=jvIYNhbslwJ5KZsGFyXiEOAHDJnKuXM5Sw4W0bE5ic5D/DbFWp1nNk/NHI4hpcAneMpDwiob7Bw22jiQObZJ9n5nHwxAU8Ql3ySaMLWh6M4mDT220ae5eg6YgHUTr34ouBeCrQTXhsKsaySyHjkFLm2s57P9Go0B1SAbo+1g5xM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774054208953594.3882340488038; Fri, 20 Mar 2026 17:50:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3kWm-0005SL-Vw; Fri, 20 Mar 2026 20:49:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3kWj-0005Rn-Ci for qemu-devel@nongnu.org; Fri, 20 Mar 2026 20:49:17 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3kWg-00026E-Ik for qemu-devel@nongnu.org; Fri, 20 Mar 2026 20:49:16 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-2ab46931cf1so30079435ad.0 for ; Fri, 20 Mar 2026 17:49:14 -0700 (PDT) Received: from lima-default (103.95.112.190.qld.leaptel.network. [103.95.112.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083527f84sm34637685ad.18.2026.03.20.17.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 17:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774054153; x=1774658953; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hFmstGmcFWszN/qiAw2otwmThWAyPfpEPK+SFVFBwqs=; b=PKrglVy/MtOr4PyV7WgavzHpVtUmS6gciLR0jjTlxxcLPefwdKk/gEsjWnyS8BRd/i 0qcJKz+XOpltNx6ie1uJSf8H0rbF+qKXg76LmbJUfp6t6mob1ZUpBbqqbZcdje5a/AwZ arkGtrq3Xu5AOdotaRH+7zLZchtiJLU0U7Pg2NBSOYPGySDrQpTSS3Ay4tO6fO9qUYeX +b3t9jEmAF0qkFHLQMkPE2UjoI0Inh/b/xutB2dw3dTePjY9D5aWK01/P/J2xIy6xsdI Ab5lXpLJ8FN26wYsJknDEcu8DMcAtJJTmI8FW6Tqflbrkgf5yYt5Fw8Fp5NiqTVwM9Jm GgFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774054153; x=1774658953; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hFmstGmcFWszN/qiAw2otwmThWAyPfpEPK+SFVFBwqs=; b=ARUVahir3k+B1EMO/BM0hAUt4//2MvtlayvaaVVi3Jr0VcqxKxU9QXWhakFz/9RRaL rw5sCrMoqPPZwVANOfzKmEojRYDNm94kOL68v+HUf/ZQItt1TLz/j933mJomRI40a2nF Kq9is00VdITZwZ/r4jRkRLppg/Cmd4yympYPwctDB92xwYt0rqRnztElRutm9rtwN6YE JcIntN9MjraP5lH/OeU/v0yeW709G8vT7WbTHl59tbJcHj648rSbympVj5X5r6sYOKVR horJDBFgsbSxUoLJXB+Vke0XtELmlhymWV9vUhIJyVPL0pFcqEOLyRYm7bf//ujTBzdd qqGA== X-Gm-Message-State: AOJu0YyhkzDA/dTABP8DMebVL+kKgCqIrr7J00uceZ8CQjoCiCzK28u9 26qF9DXYRu1AwzebVn5iaFTEPG30AdO3qjphU8ORL6gdwQunH4He0yfUcVZAnw== X-Gm-Gg: ATEYQzzA0B1toHZnrJjs8pUevZMyZdCMs+MOXPLcQFtVq6ep78Dfa/8zxBiLO1P07JC IvGtxFrHbHXBznfnUJQ8TWmM8PhcSSYRv3rPA/a0gvNiyQv/BGyu0UGXClfjmmadBTKEnhtG790 9jdwQQKhUadUPt/6PqhSp0EnZlQaTNztQO3H6hYHYvOjuCtsXfPoFvliYvGXFXRffJZ2QwOe9VL t5njyhsOJs6AEpg3lf6IwNejNaSuU5KdratVdkINdAb5nkqzcBQI+Oa3QL/mwmifs+VHScij+1C sMn4uJqafn9mxTC1fo431BcIuZ47n5ZdL2O/zw8VwWAudwlgDH2BbwJLr6HqGIQhihUi2hejQIV 4tlNcIXF8AdqI17a64Byvz1BgAkm81mhzVFG1tYuLoV3X7BghTiTc9XPkxC2CMGL/cNhp9MYIIi cjfxXJ9Uovd+7Gwg08YP8b54xUqYCSUbZDigG9Ww/s3V6UMdzkzhGBi2/ArmWxrKcPmcG1 X-Received: by 2002:a17:903:8c3:b0:2ae:4aa8:cab8 with SMTP id d9443c01a7336-2b082702646mr36963335ad.4.1774054152740; Fri, 20 Mar 2026 17:49:12 -0700 (PDT) From: Nicholas Piggin To: qemu-devel@nongnu.org Cc: Nicholas Piggin , Warner Losh , Kyle Evans , Laurent Vivier , Pierrick Bouvier , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-riscv@nongnu.org Subject: [PATCH 3/3] linux-user: riscv: Fix signal frame user mapping Date: Sat, 21 Mar 2026 10:48:36 +1000 Message-ID: <20260321004836.500390-4-npiggin@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260321004836.500390-1-npiggin@gmail.com> References: <20260321004836.500390-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=npiggin@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1774054209503158500 Content-Type: text/plain; charset="utf-8" riscv signal frame setup is missing unlock_user_struct(). Signed-off-by: Nicholas Piggin Reviewed-by: Chao Liu --- linux-user/riscv/signal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/riscv/signal.c b/linux-user/riscv/signal.c index 358fa1d82d..22b1b8149f 100644 --- a/linux-user/riscv/signal.c +++ b/linux-user/riscv/signal.c @@ -126,6 +126,7 @@ void setup_rt_frame(int sig, struct target_sigaction *k= a, =20 setup_ucontext(&frame->uc, env, set); frame->info =3D *info; + unlock_user_struct(frame, frame_addr, 1); =20 env->pc =3D ka->_sa_handler; env->gpr[xSP] =3D frame_addr; --=20 2.51.0