From nobody Sun Mar 22 15:36:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1774018307; cv=none; d=zohomail.com; s=zohoarc; b=dxOsaC8KLJ0ylo7jaRc4T/jFEpmOqhLbfM2Bhwlakv+yvq0eD4Hj3gSU9Y3uq0RLX8R6RGOJp6rqtliJbj9AW1fDtmWBRQHslG3Yj6QngRrygKoICcDVHqkJtl+msHAeZv374YYO2GcuDHDLjiOApXw3/scGrU+KAyYqGqSNrKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774018307; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XyZLk11vPlN5n1JcVQOim0LAUFqmjg+6RUDj+Icm3JQ=; b=GQH2R8d5tRNUOlYcTVVearAuOdnOiXum4oSGJNaWeZDYIbpMne3u0KKpVNx+lWqlEUE49F06EtKln/fPhbIwu90wJCftqZ1H6w4tCIEmyLzoNyxW63tTkC0anQTV5AzidDjYO4rl63xUD94LuECWBfJObXuxlCM1tCiLWI6ggFo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774018307470479.6578453094115; Fri, 20 Mar 2026 07:51:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3bBu-0006Gj-Mj; Fri, 20 Mar 2026 10:51:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3bBq-0006G3-Bo for qemu-devel@nongnu.org; Fri, 20 Mar 2026 10:51:07 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3bBl-0007Kk-7N for qemu-devel@nongnu.org; Fri, 20 Mar 2026 10:51:04 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62KBsOma3875956 for ; Fri, 20 Mar 2026 14:50:58 GMT Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d15s08e9d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 20 Mar 2026 14:50:58 +0000 (GMT) Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-1275c6fc58aso437616c88.0 for ; Fri, 20 Mar 2026 07:50:58 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12a733e794esm2473061c88.6.2026.03.20.07.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 07:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XyZLk11vPlN5n1JcVQOim0LAUFqmjg+6RUDj+Icm3JQ=; b=DlK5eVNRYJOVQ2Uz uZAKJcXri1BILaCP2zCYjyAGLgLNYgBITrWIV0ht9amcyDRbZZ0hJlNUOo1DZJFA PoVPABTeFvk4r4btyjRiPyjrMzDJuLbMuhCdW/ZPfADFa9VFr8DxBoRl0IRhjWhz ceNNFTCpTtJ30hdJdfZsavrnKk4q0EjgLmMkNeklH+g4Nku0fCoS4AdxwS8WBHqM VEDyjETtHsds34uuMqW/qiD5aIq/RVCRqQYvWe01rx3S/+HACf7QM44kiXIB3q9D 5IbYT6mo376KGGZ5v7LHUykOQ+lztZdNV4FxDCLX5AKH7z0h53udEhODRsfvoxkh uLRkMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774018257; x=1774623057; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XyZLk11vPlN5n1JcVQOim0LAUFqmjg+6RUDj+Icm3JQ=; b=hLPEs6o/Fr8WHCRFehuS3AEvAuB9bQqY5tk3WbP1A/fjjxhdNXqQUSPta54qBl9Nkg PeabD0QwBU3IUHgRa6I558Uddr+90qkAcH+QOEf3gU0fOMixMHM31sDtHWgeZ+GPEskG Y/xi7hhJk+F8x8ibe6K+4P+rkW8w/PLcp+Oa52W8kmsNabYbJtst23+fOCT74YMegGTj sZ4bwStVoiIMkJXuD36hAzJ6eTItxVR3C0NfP2bOjO6q3pypEiiMGmn/AvZsS+w18mdz AN+bL7wTn7RQTKv7Cv/I6IWRfCrMV/wYipE4hZJm8UhyKCBFiu7g6XTSOfxWGXaj0lLe IfkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774018257; x=1774623057; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XyZLk11vPlN5n1JcVQOim0LAUFqmjg+6RUDj+Icm3JQ=; b=Wt/MCh3xzh3945D5v2AzcmmQS+WKU+NFFDspyQhiTOtHK0B4eDKpiooUnSkdOZV9c8 1dy7tufd1RcfIqDkc0E0UyzbMKjaN6+Gpq2z17RLTkFawHIxnZOGLkTfnfnKQQMKaE0D xMDyHV9y0idSSd9L/FCSO6Q/an863cdWAzqiZMhev3Z4NvMb1zwum3XNBtyEsBRVDy2u BEEjQJ6YpP5CLxb7gKe5HJLSnTLHdbjKBCu/ya5ctVn9F/gejta8OE5SiPSs7QINpTxk 1sPO0EhiPsq1ivFRjWkhMmMxKk3Q1fW7OcL2QaN5cKlrHNA5L3AxgZjNO/E7qliOl/+C 2dXQ== X-Gm-Message-State: AOJu0YwPHzz1me1Sy2YdxhirYBiVbdu891HH1b2i0o8vaoODFHYyF1mF 063Xnv63kodE8nx4G/ImgFcDdr87zvn1QND7jTgWDviscOEk01H9thGxebKp1kFvzp0lpZDYoHE Zgn00hNXFXWMkfEgKJMgoMzeO9R2AKgZ++a4cyp1FA0h0NqcfaIbZg6F+85NOsAlv3Q== X-Gm-Gg: ATEYQzxy/Flim2uh5QjekR7GOUiTtka6xlMvOQz8/rXRTCs434Q3xS7SamOnFyvIyQn MhTqcdLcRgpwuBjdl0bhrpc+K45yheMAsKNtGcc8lJy0oKAL5uSekubtq6Lb21cG/ynuD3OzHJV FgLLxCxx2lb/cHHYJnuNreBbDUZ5QrOQWrGxI0EDJ8Hwo9JoAndZMqX6SitiqNYMF20Fh+4uvKT hq8qp0AUbodtvjuHnZp0MdGCp0PSrO8jhTY7N0ohodw7pvbqbjh8HXE3+ZOcVbYjsHdewxji1As fIKlAYYo3uTFh/2fNwqsRxhY44gHRCz3AWk7TDwbxcnVFYGgtde4HIkBt4Ucnhx/G4mL1DOgCax ZzhpnUaULXpHmGnkK43LTgPsbzecPkhWyVtM+w1NbWGdiqVaIvaV9lesqakpg4IzCAcsxkQ== X-Received: by 2002:a05:7022:78d:b0:128:d967:4678 with SMTP id a92af1059eb24-12a726e1bbemr1415911c88.23.1774018256866; Fri, 20 Mar 2026 07:50:56 -0700 (PDT) X-Received: by 2002:a05:7022:78d:b0:128:d967:4678 with SMTP id a92af1059eb24-12a726e1bbemr1415897c88.23.1774018256089; Fri, 20 Mar 2026 07:50:56 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: brian.cain@oss.qualcomm.com, Taylor Simpson Subject: [PULL 2/3] target/hexagon: use TCG_COND_TSTEQ/TSTNE for predicate branches Date: Fri, 20 Mar 2026 07:50:40 -0700 Message-Id: <20260320145041.3027130-3-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260320145041.3027130-1-brian.cain@oss.qualcomm.com> References: <20260320145041.3027130-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: HaXZFstWGB-8polI8u1KOtthdjSyysiI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIwMDExOSBTYWx0ZWRfX6N5p8/nZyT13 mb1DlLkqP83JZlhW/FNAVSJVwRdKKJf3tMYHEDUA0POuyP98JNYubd64IxZN4oz9aIVQghMszKF jrsHYiQLHfU8IutNdrSZkbE8K/KpWvP+ngAkXB+ZQloZlbJFcldEjSW4toHRISadIwtXknt0vMr UMX9Ave7zrRkjFKnpFJRtWr31WOYKXhhfV8lXZdECTejSG+w1yEFXmZ+RFMnUI2NJvI1/9S3vTM xSBou3bv1sR+mAYK8vMTGu8X/0QdJkr2OWl+n06Es6IG9NRYdCDn+dDI+Cfuqcm/sLj7Vj4fzd0 RyPYYcIBIig2ameBsO1TZnxzWSJA+2LV9JxMYBmZ0sAw1/phxieXWWK3P/10/kMw9TgEE1Smru0 l6EbDmWowWHyaljPu4k2h/KuxsVAmpnU10TgyU/aUJQKan0XbOSs6NDE5B8OmtGAxHsloYhKmpx CArTJGH1uTNwzn4buCA== X-Proofpoint-GUID: HaXZFstWGB-8polI8u1KOtthdjSyysiI X-Authority-Analysis: v=2.4 cv=KORXzVFo c=1 sm=1 tr=0 ts=69bd5ed2 cx=c_pps a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=ao8-HdWYDGaaWDIvVGwA:9 a=QEXdDO2ut3YA:10 a=vBUdepa8ALXHeOFLBtFW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-20_02,2026-03-19_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 clxscore=1015 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603200119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1774018309269154100 Replace TCG_COND_EQ/NE comparisons against 0 with TCG_COND_TSTEQ/TSTNE comparisons against 1 for all predicate-conditional branches. This tests bit 0 of the predicate register directly, eliminating redundant andi operations that previously extracted the LSB before the comparison. For predicate-conditional jumps (jumpt, jumpf, jumptnew, etc.) and jump-register variants (jumprt, jumprf, etc.), pass the raw predicate value directly instead of going through fLSBOLD/fLSBNEW extraction. For callers that produce a 0/1 result via setcond (compare-and-jump, jumprz, etc.), the TSTEQ/TSTNE test on bit 0 is equivalent to the previous EQ/NE test against 0. Reviewed-by: Taylor Simpson Signed-off-by: Brian Cain --- target/hexagon/gen_tcg.h | 94 +++++++++++++++----------------------- target/hexagon/genptr.c | 32 +++++-------- target/hexagon/translate.c | 2 +- 3 files changed, 50 insertions(+), 78 deletions(-) diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h index 45ccd518883..1e0cc3b29a8 100644 --- a/target/hexagon/gen_tcg.h +++ b/target/hexagon/gen_tcg.h @@ -696,13 +696,13 @@ gen_callr(ctx, RsV) =20 #define fGEN_TCG_J2_callt(SHORTCODE) \ - gen_cond_call(ctx, PuV, TCG_COND_EQ, riV) + gen_cond_call(ctx, PuV, TCG_COND_TSTEQ, riV) #define fGEN_TCG_J2_callf(SHORTCODE) \ - gen_cond_call(ctx, PuV, TCG_COND_NE, riV) + gen_cond_call(ctx, PuV, TCG_COND_TSTNE, riV) #define fGEN_TCG_J2_callrt(SHORTCODE) \ - gen_cond_callr(ctx, TCG_COND_EQ, PuV, RsV) + gen_cond_callr(ctx, TCG_COND_TSTEQ, PuV, RsV) #define fGEN_TCG_J2_callrf(SHORTCODE) \ - gen_cond_callr(ctx, TCG_COND_NE, PuV, RsV) + gen_cond_callr(ctx, TCG_COND_TSTNE, PuV, RsV) =20 #define fGEN_TCG_J2_loop0r(SHORTCODE) \ gen_loop0r(ctx, RsV, riV) @@ -893,21 +893,21 @@ gen_cmpnd_cmp_n1_jmp_f(ctx, 1, TCG_COND_GT, RsV, riV) =20 #define fGEN_TCG_J4_tstbit0_tp0_jump_nt(SHORTCODE) \ - gen_cmpnd_tstbit0_jmp(ctx, 0, RsV, TCG_COND_EQ, riV) + gen_cmpnd_tstbit0_jmp(ctx, 0, RsV, TCG_COND_TSTEQ, riV) #define fGEN_TCG_J4_tstbit0_tp0_jump_t(SHORTCODE) \ - gen_cmpnd_tstbit0_jmp(ctx, 0, RsV, TCG_COND_EQ, riV) + gen_cmpnd_tstbit0_jmp(ctx, 0, RsV, TCG_COND_TSTEQ, riV) #define fGEN_TCG_J4_tstbit0_fp0_jump_nt(SHORTCODE) \ - gen_cmpnd_tstbit0_jmp(ctx, 0, RsV, TCG_COND_NE, riV) + gen_cmpnd_tstbit0_jmp(ctx, 0, RsV, TCG_COND_TSTNE, riV) #define fGEN_TCG_J4_tstbit0_fp0_jump_t(SHORTCODE) \ - gen_cmpnd_tstbit0_jmp(ctx, 0, RsV, TCG_COND_NE, riV) + gen_cmpnd_tstbit0_jmp(ctx, 0, RsV, TCG_COND_TSTNE, riV) #define fGEN_TCG_J4_tstbit0_tp1_jump_nt(SHORTCODE) \ - gen_cmpnd_tstbit0_jmp(ctx, 1, RsV, TCG_COND_EQ, riV) + gen_cmpnd_tstbit0_jmp(ctx, 1, RsV, TCG_COND_TSTEQ, riV) #define fGEN_TCG_J4_tstbit0_tp1_jump_t(SHORTCODE) \ - gen_cmpnd_tstbit0_jmp(ctx, 1, RsV, TCG_COND_EQ, riV) + gen_cmpnd_tstbit0_jmp(ctx, 1, RsV, TCG_COND_TSTEQ, riV) #define fGEN_TCG_J4_tstbit0_fp1_jump_nt(SHORTCODE) \ - gen_cmpnd_tstbit0_jmp(ctx, 1, RsV, TCG_COND_NE, riV) + gen_cmpnd_tstbit0_jmp(ctx, 1, RsV, TCG_COND_TSTNE, riV) #define fGEN_TCG_J4_tstbit0_fp1_jump_t(SHORTCODE) \ - gen_cmpnd_tstbit0_jmp(ctx, 1, RsV, TCG_COND_NE, riV) + gen_cmpnd_tstbit0_jmp(ctx, 1, RsV, TCG_COND_TSTNE, riV) =20 /* p0 =3D cmp.eq(r0, #7) */ #define fGEN_TCG_SA1_cmpeqi(SHORTCODE) \ @@ -933,31 +933,24 @@ do { \ TCGv LSB =3D tcg_temp_new(); \ COND; \ - gen_cond_jump(ctx, TCG_COND_EQ, LSB, riV); \ + gen_cond_jump(ctx, TCG_COND_TSTEQ, LSB, riV); \ } while (0) -#define fGEN_TCG_cond_jumpf(COND) \ - do { \ - TCGv LSB =3D tcg_temp_new(); \ - COND; \ - gen_cond_jump(ctx, TCG_COND_NE, LSB, riV); \ - } while (0) - #define fGEN_TCG_J2_jumpt(SHORTCODE) \ - fGEN_TCG_cond_jumpt(fLSBOLD(PuV)) + gen_cond_jump(ctx, TCG_COND_TSTEQ, PuV, riV) #define fGEN_TCG_J2_jumptpt(SHORTCODE) \ - fGEN_TCG_cond_jumpt(fLSBOLD(PuV)) + gen_cond_jump(ctx, TCG_COND_TSTEQ, PuV, riV) #define fGEN_TCG_J2_jumpf(SHORTCODE) \ - fGEN_TCG_cond_jumpf(fLSBOLD(PuV)) + gen_cond_jump(ctx, TCG_COND_TSTNE, PuV, riV) #define fGEN_TCG_J2_jumpfpt(SHORTCODE) \ - fGEN_TCG_cond_jumpf(fLSBOLD(PuV)) + gen_cond_jump(ctx, TCG_COND_TSTNE, PuV, riV) #define fGEN_TCG_J2_jumptnew(SHORTCODE) \ - fGEN_TCG_cond_jumpt(fLSBNEW(PuN)) + gen_cond_jump(ctx, TCG_COND_TSTEQ, PuN, riV) #define fGEN_TCG_J2_jumptnewpt(SHORTCODE) \ - fGEN_TCG_cond_jumpt(fLSBNEW(PuN)) + gen_cond_jump(ctx, TCG_COND_TSTEQ, PuN, riV) #define fGEN_TCG_J2_jumpfnewpt(SHORTCODE) \ - fGEN_TCG_cond_jumpf(fLSBNEW(PuN)) + gen_cond_jump(ctx, TCG_COND_TSTNE, PuN, riV) #define fGEN_TCG_J2_jumpfnew(SHORTCODE) \ - fGEN_TCG_cond_jumpf(fLSBNEW(PuN)) + gen_cond_jump(ctx, TCG_COND_TSTNE, PuN, riV) #define fGEN_TCG_J2_jumprz(SHORTCODE) \ fGEN_TCG_cond_jumpt(tcg_gen_setcondi_tl(TCG_COND_NE, LSB, RsV, 0)) #define fGEN_TCG_J2_jumprzpt(SHORTCODE) \ @@ -975,35 +968,22 @@ #define fGEN_TCG_J2_jumprltezpt(SHORTCODE) \ fGEN_TCG_cond_jumpt(tcg_gen_setcondi_tl(TCG_COND_LE, LSB, RsV, 0)) =20 -#define fGEN_TCG_cond_jumprt(COND) \ - do { \ - TCGv LSB =3D tcg_temp_new(); \ - COND; \ - gen_cond_jumpr(ctx, RsV, TCG_COND_EQ, LSB); \ - } while (0) -#define fGEN_TCG_cond_jumprf(COND) \ - do { \ - TCGv LSB =3D tcg_temp_new(); \ - COND; \ - gen_cond_jumpr(ctx, RsV, TCG_COND_NE, LSB); \ - } while (0) - #define fGEN_TCG_J2_jumprt(SHORTCODE) \ - fGEN_TCG_cond_jumprt(fLSBOLD(PuV)) + gen_cond_jumpr(ctx, RsV, TCG_COND_TSTEQ, PuV) #define fGEN_TCG_J2_jumprtpt(SHORTCODE) \ - fGEN_TCG_cond_jumprt(fLSBOLD(PuV)) + gen_cond_jumpr(ctx, RsV, TCG_COND_TSTEQ, PuV) #define fGEN_TCG_J2_jumprf(SHORTCODE) \ - fGEN_TCG_cond_jumprf(fLSBOLD(PuV)) + gen_cond_jumpr(ctx, RsV, TCG_COND_TSTNE, PuV) #define fGEN_TCG_J2_jumprfpt(SHORTCODE) \ - fGEN_TCG_cond_jumprf(fLSBOLD(PuV)) + gen_cond_jumpr(ctx, RsV, TCG_COND_TSTNE, PuV) #define fGEN_TCG_J2_jumprtnew(SHORTCODE) \ - fGEN_TCG_cond_jumprt(fLSBNEW(PuN)) + gen_cond_jumpr(ctx, RsV, TCG_COND_TSTEQ, PuN) #define fGEN_TCG_J2_jumprtnewpt(SHORTCODE) \ - fGEN_TCG_cond_jumprt(fLSBNEW(PuN)) + gen_cond_jumpr(ctx, RsV, TCG_COND_TSTEQ, PuN) #define fGEN_TCG_J2_jumprfnew(SHORTCODE) \ - fGEN_TCG_cond_jumprf(fLSBNEW(PuN)) + gen_cond_jumpr(ctx, RsV, TCG_COND_TSTNE, PuN) #define fGEN_TCG_J2_jumprfnewpt(SHORTCODE) \ - fGEN_TCG_cond_jumprf(fLSBNEW(PuN)) + gen_cond_jumpr(ctx, RsV, TCG_COND_TSTNE, PuN) =20 /* * New value compare & jump instructions @@ -1101,13 +1081,13 @@ gen_cmpi_jumpnv(ctx, TCG_COND_LE, NsN, -1, riV) =20 #define fGEN_TCG_J4_tstbit0_t_jumpnv_t(SHORTCODE) \ - gen_testbit0_jumpnv(ctx, NsN, TCG_COND_EQ, riV) + gen_testbit0_jumpnv(ctx, NsN, TCG_COND_TSTEQ, riV) #define fGEN_TCG_J4_tstbit0_t_jumpnv_nt(SHORTCODE) \ - gen_testbit0_jumpnv(ctx, NsN, TCG_COND_EQ, riV) + gen_testbit0_jumpnv(ctx, NsN, TCG_COND_TSTEQ, riV) #define fGEN_TCG_J4_tstbit0_f_jumpnv_t(SHORTCODE) \ - gen_testbit0_jumpnv(ctx, NsN, TCG_COND_NE, riV) + gen_testbit0_jumpnv(ctx, NsN, TCG_COND_TSTNE, riV) #define fGEN_TCG_J4_tstbit0_f_jumpnv_nt(SHORTCODE) \ - gen_testbit0_jumpnv(ctx, NsN, TCG_COND_NE, riV) + gen_testbit0_jumpnv(ctx, NsN, TCG_COND_TSTNE, riV) =20 /* r0 =3D r1 ; jump address */ #define fGEN_TCG_J4_jumpsetr(SHORTCODE) \ @@ -1150,14 +1130,14 @@ gen_jumpr(ctx, hex_gpr[HEX_REG_LR]) =20 #define fGEN_TCG_SL2_jumpr31_t(SHORTCODE) \ - gen_cond_jumpr31(ctx, TCG_COND_EQ, hex_pred[0]) + gen_cond_jumpr31(ctx, TCG_COND_TSTEQ, hex_pred[0]) #define fGEN_TCG_SL2_jumpr31_f(SHORTCODE) \ - gen_cond_jumpr31(ctx, TCG_COND_NE, hex_pred[0]) + gen_cond_jumpr31(ctx, TCG_COND_TSTNE, hex_pred[0]) =20 #define fGEN_TCG_SL2_jumpr31_tnew(SHORTCODE) \ - gen_cond_jumpr31(ctx, TCG_COND_EQ, ctx->new_pred_value[0]) + gen_cond_jumpr31(ctx, TCG_COND_TSTEQ, ctx->new_pred_value[0]) #define fGEN_TCG_SL2_jumpr31_fnew(SHORTCODE) \ - gen_cond_jumpr31(ctx, TCG_COND_NE, ctx->new_pred_value[0]) + gen_cond_jumpr31(ctx, TCG_COND_TSTNE, ctx->new_pred_value[0]) =20 /* Count trailing zeros/ones */ #define fGEN_TCG_S2_ct0(SHORTCODE) \ diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 9eb21da6f3e..c7b9436c8d4 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c @@ -455,7 +455,7 @@ static void gen_write_new_pc_addr(DisasContext *ctx, TC= Gv addr, TCGLabel *pred_false =3D NULL; if (cond !=3D TCG_COND_ALWAYS) { pred_false =3D gen_new_label(); - tcg_gen_brcondi_tl(cond, pred, 0, pred_false); + tcg_gen_brcondi_tl(cond, pred, 1, pred_false); } =20 if (ctx->pkt->pkt_has_multi_cof) { @@ -579,9 +579,7 @@ static void gen_cond_jumpr(DisasContext *ctx, TCGv dst_= pc, =20 static void gen_cond_jumpr31(DisasContext *ctx, TCGCond cond, TCGv pred) { - TCGv LSB =3D tcg_temp_new(); - tcg_gen_andi_tl(LSB, pred, 1); - gen_cond_jumpr(ctx, hex_gpr[HEX_REG_LR], cond, LSB); + gen_cond_jumpr(ctx, hex_gpr[HEX_REG_LR], cond, pred); } =20 static void gen_cond_jump(DisasContext *ctx, TCGCond cond, TCGv pred, @@ -609,14 +607,14 @@ static void gen_cmpnd_cmp_jmp_t(DisasContext *ctx, int pnum, TCGCond cond, TCGv arg1, TCGv ar= g2, int pc_off) { - gen_cmpnd_cmp_jmp(ctx, pnum, cond, arg1, arg2, TCG_COND_EQ, pc_off); + gen_cmpnd_cmp_jmp(ctx, pnum, cond, arg1, arg2, TCG_COND_TSTEQ, pc_off); } =20 static void gen_cmpnd_cmp_jmp_f(DisasContext *ctx, int pnum, TCGCond cond, TCGv arg1, TCGv ar= g2, int pc_off) { - gen_cmpnd_cmp_jmp(ctx, pnum, cond, arg1, arg2, TCG_COND_NE, pc_off); + gen_cmpnd_cmp_jmp(ctx, pnum, cond, arg1, arg2, TCG_COND_TSTNE, pc_off); } =20 static void gen_cmpnd_cmpi_jmp_t(DisasContext *ctx, @@ -624,7 +622,7 @@ static void gen_cmpnd_cmpi_jmp_t(DisasContext *ctx, int pc_off) { TCGv tmp =3D tcg_constant_tl(arg2); - gen_cmpnd_cmp_jmp(ctx, pnum, cond, arg1, tmp, TCG_COND_EQ, pc_off); + gen_cmpnd_cmp_jmp(ctx, pnum, cond, arg1, tmp, TCG_COND_TSTEQ, pc_off); } =20 static void gen_cmpnd_cmpi_jmp_f(DisasContext *ctx, @@ -632,7 +630,7 @@ static void gen_cmpnd_cmpi_jmp_f(DisasContext *ctx, int pc_off) { TCGv tmp =3D tcg_constant_tl(arg2); - gen_cmpnd_cmp_jmp(ctx, pnum, cond, arg1, tmp, TCG_COND_NE, pc_off); + gen_cmpnd_cmp_jmp(ctx, pnum, cond, arg1, tmp, TCG_COND_TSTNE, pc_off); } =20 static void gen_cmpnd_cmp_n1_jmp_t(DisasContext *ctx, int pnum, TCGCond co= nd, @@ -665,9 +663,7 @@ static void gen_cmpnd_tstbit0_jmp(DisasContext *ctx, static void gen_testbit0_jumpnv(DisasContext *ctx, TCGv arg, TCGCond cond, int pc_off) { - TCGv pred =3D tcg_temp_new(); - tcg_gen_andi_tl(pred, arg, 1); - gen_cond_jump(ctx, cond, pred, pc_off); + gen_cond_jump(ctx, cond, arg, pc_off); } =20 static void gen_jump(DisasContext *ctx, int pc_off) @@ -698,11 +694,9 @@ static void gen_cond_call(DisasContext *ctx, TCGv pred, TCGCond cond, int pc_off) { TCGv lr =3D get_result_gpr(ctx, HEX_REG_LR); - TCGv lsb =3D tcg_temp_new(); TCGLabel *skip =3D gen_new_label(); - tcg_gen_andi_tl(lsb, pred, 1); - gen_write_new_pc_pcrel(ctx, pc_off, cond, lsb); - tcg_gen_brcondi_tl(cond, lsb, 0, skip); + gen_write_new_pc_pcrel(ctx, pc_off, cond, pred); + tcg_gen_brcondi_tl(cond, pred, 1, skip); tcg_gen_movi_tl(lr, ctx->next_PC); gen_set_label(skip); } @@ -710,10 +704,8 @@ static void gen_cond_call(DisasContext *ctx, TCGv pred, static void gen_cond_callr(DisasContext *ctx, TCGCond cond, TCGv pred, TCGv new_pc) { - TCGv lsb =3D tcg_temp_new(); TCGLabel *skip =3D gen_new_label(); - tcg_gen_andi_tl(lsb, pred, 1); - tcg_gen_brcondi_tl(cond, lsb, 0, skip); + tcg_gen_brcondi_tl(cond, pred, 1, skip); gen_callr(ctx, new_pc); gen_set_label(skip); } @@ -955,7 +947,7 @@ static void gen_cmp_jumpnv(DisasContext *ctx, { TCGv pred =3D tcg_temp_new(); tcg_gen_setcond_tl(cond, pred, val, src); - gen_cond_jump(ctx, TCG_COND_EQ, pred, pc_off); + gen_cond_jump(ctx, TCG_COND_TSTEQ, pred, pc_off); } =20 static void gen_cmpi_jumpnv(DisasContext *ctx, @@ -963,7 +955,7 @@ static void gen_cmpi_jumpnv(DisasContext *ctx, { TCGv pred =3D tcg_temp_new(); tcg_gen_setcondi_tl(cond, pred, val, src); - gen_cond_jump(ctx, TCG_COND_EQ, pred, pc_off); + gen_cond_jump(ctx, TCG_COND_TSTEQ, pred, pc_off); } =20 /* Shift left with saturation */ diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 8a223f6e13e..633401451d8 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -163,7 +163,7 @@ static void gen_end_tb(DisasContext *ctx) if (ctx->branch_cond !=3D TCG_COND_NEVER) { if (ctx->branch_cond !=3D TCG_COND_ALWAYS) { TCGLabel *skip =3D gen_new_label(); - tcg_gen_brcondi_tl(ctx->branch_cond, ctx->branch_taken, 0, ski= p); + tcg_gen_brcondi_tl(ctx->branch_cond, ctx->branch_taken, 1, ski= p); gen_goto_tb(ctx, 0, ctx->branch_dest, true); gen_set_label(skip); gen_goto_tb(ctx, 1, ctx->next_PC, false); --=20 2.34.1