From nobody Sun Mar 22 15:37:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1774018283; cv=none; d=zohomail.com; s=zohoarc; b=Qd5EkFz4HgpEkf/Z6i3sxeHcXBJePaasPjemYu5Uh7fUubPICyRtz16uPKC5NxpvuGUCe4dxyh40yHyDkEprgz6ypRl9w8uidKRpvC3dRvXoUxDrfXLzMYLr4VJ3AAyecv6nFmWR+qw5KvlDBxE7t6tGS3dAsR3c2FxLRhHVGB0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774018283; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CzV1xE5LP5frPMIb94o5a/qKxfcUAvsY4yhrqKF41vQ=; b=fNqmy8vEU8YBIJTLYcOUwty07gLENunhhPyeV0EawPHxPQiuzdEYlHvY/uoz88QMJXwl1uT5cBysnW2YBZDh0xuo+tR1fRJiVNFJE/Iq/ZWz3m2KAHI9Jlfih140qYPWklKv9WyhhFTWw09b12ASzV53i9ywW3DCKp7u9HJyXcA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774018283806901.62240161855; Fri, 20 Mar 2026 07:51:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3bBp-0006Fp-Q2; Fri, 20 Mar 2026 10:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3bBn-0006FI-4k for qemu-devel@nongnu.org; Fri, 20 Mar 2026 10:51:04 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3bBl-0007KX-4U for qemu-devel@nongnu.org; Fri, 20 Mar 2026 10:51:02 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62KElucw989742 for ; Fri, 20 Mar 2026 14:50:57 GMT Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0k0vbq0g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 20 Mar 2026 14:50:57 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-128ba70cc99so1344261c88.0 for ; Fri, 20 Mar 2026 07:50:56 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12a733e794esm2473061c88.6.2026.03.20.07.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 07:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CzV1xE5LP5frPMIb94o5a/qKxfcUAvsY4yhrqKF41vQ=; b=QeOpn2HKClPOgmNI qP6iAFAMDQrWvUON5YlLuJMUgAHwWAByLiz5xldXlYR9czZxZl5pITvcNmLyWgGe t9CX9aYTvE/HV7HRgyTqd4ccIVTvvUz0ySEizTuBRwODo3gsIy3Mx3U3JPQ1beBK UcEOmoDPMUA0bjMpZ61so8gUN0cAx7QLSPEtJFz7Tn09RtzsZQ+7laHPvdTKvShs 9ZPN7BgBg2B7QbUKCNXB0Q4WaUV1XZdKW0FZZ18+bj+yNwjOXp7uru8J9UnXr15H 0d59lcuFIB7zhqBxZUZfjemqOBKDwF0Kmtm/TvE2ZnxHE6L/5CUifSxmkJR2tSrX 41XM8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774018256; x=1774623056; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CzV1xE5LP5frPMIb94o5a/qKxfcUAvsY4yhrqKF41vQ=; b=G+JNVKkGcrc2W5tEeXwWbDSuKLqFD9EamCN6sOMP5XIJomb1x1qtI1F9G40xNnPGIc zm4ZXsq34EXet1vi2c4YxhRvs7jZOnaYpQcFItQ70zIgwRX2da0/3eh0paoqZDEHucZw T6bQPzypWSRn5YwRhGX9OANSm6MFzs3R1dhdLCAPI+ZOatWtrOTqyTMzTvNrzdBLKAwm VjQ3ckxXhvJhBAe4DBZxruf2g0/F0FwzR6nlQ0RgmtowII2D/pzz33k0eHQ1C9ukS59Y vg0O+/wklSHRyMLmGNKFxj1gftE6ipUwR66rnaoPE3yzBcQymn8yDiz2Pvc7YA4TRZhN NgAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774018256; x=1774623056; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CzV1xE5LP5frPMIb94o5a/qKxfcUAvsY4yhrqKF41vQ=; b=Qd9lqF4yFwuVNFKLiZEx+0dmMe7D1rg2tRiYHsOFsY3rOtkXytGK7Zb5OmfdHHVJ1W 0tnohM0su6StwoecZ234BKOdw95NeN0d440tVj2w9kgmzYsWGQAAE9NXepSdyj/sVlhD Vckyevh830WtbUF8ZNzkfdCo1hx/FNWHH2rjERCsr0J6z4vsAd+wiM5m+Uq7Iz/VgaK3 0s+jLpflH5DRdouxz6OOGeoC4H3yCK0FOrDxzWnmqTbdCotpVXOADQzZRU1zOLMDl3jr 0fsJ3r7cOVn0YdIL7+wDEUhXUG1r/sFSoY+ItK/sojrsSN9layLUuAx+n7km5aAC+Y0a k/ug== X-Gm-Message-State: AOJu0YzHkDb6IFzRi8KLEAygb/xGuU2YI5jxhmfsVLSMgCTFvfu6O//f qZ53lUMDr4u45rH5TEBp1TDYYcfI8apinJU4amSszXsQUeFlqeIXzKiTH83qXUp7y/NBrDoawxf r8EFUgLjH/GY4YCcwOkx1f3XClPqliQe8ijTC8C3Pjlxi/GvKtPGIzcNL0AZbfGNpFw== X-Gm-Gg: ATEYQzwFTuXJvSlp4skb5U/4tW1DJcrfiwGVjq8/YrmG5lFlf1vKBWZ+D202M7HCYKv 5f7j04otEycmeheqLtKGYn4eLGwCvrYHtOqImwvvBvrmx6nJWYqfys1eugG4htpuiYaCyI2uJyF V8MT7wfzeM83U5Gl9Q51VrICLN0zuaz8BfkZSQLROwYdcTeaIrj2NCZVUaBoj9W+TrI2KRXDP7Q nmPTSGzH0G/0K9BJmhHY+H5xHJ1dg4dGrBxR5fr9B9OPx/w4qWsw1Rji0rfW+6RERTVUfikcdhe AmoqUBbQ9ZluGv64vbu/HJ3zftUAW5BJVkQTSjF2Lmj+FiGo28ihOF0C+EdBu5GFAuJwfy0B1Pf JYn8zRMTV28RkWX+kU+f9S8EVar0fWmLdislc1EzizGaM+Aqiyxx6YhdACNmNY+DzcJXycw== X-Received: by 2002:a05:7022:45a1:b0:128:d375:f1d4 with SMTP id a92af1059eb24-12a726dad97mr1554321c88.28.1774018255936; Fri, 20 Mar 2026 07:50:55 -0700 (PDT) X-Received: by 2002:a05:7022:45a1:b0:128:d375:f1d4 with SMTP id a92af1059eb24-12a726dad97mr1554302c88.28.1774018255300; Fri, 20 Mar 2026 07:50:55 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: brian.cain@oss.qualcomm.com, Alexey Karyakin , Taylor Simpson Subject: [PULL 1/3] target/hexagon: fix J2_jumptnew/pt predicate check to use LSB Date: Fri, 20 Mar 2026 07:50:39 -0700 Message-Id: <20260320145041.3027130-2-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260320145041.3027130-1-brian.cain@oss.qualcomm.com> References: <20260320145041.3027130-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: Pdp96hTYxN3hZ1hBm6CBVBtBZkMo7MeN X-Authority-Analysis: v=2.4 cv=EcjFgfmC c=1 sm=1 tr=0 ts=69bd5ed1 cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=ivnBtVQm4APjhFw-y08A:9 a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-GUID: Pdp96hTYxN3hZ1hBm6CBVBtBZkMo7MeN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIwMDExOSBTYWx0ZWRfXzOlzPGkzAcNQ hwkR5dp7bFZS5RstY9duEa6BQ9UNYzeoV4Kf1Y1TWS99Jg9286qTj3F+v1UabSgmohciiml811u XXEbiSCRFujAd9xksHtMiXeKyCNizl1VUcPdbAZjX4W//Groc6OK32U65iRvDIXqF7aZsN05tmk dTlvxK6LV2LOqbEg/+6jPdhNaZpZifUSBuZFO/6NvTrwFotvVjnC1iDUwSb1kfIZHAFTHfgu1ze XEUjqa2F5jWTAirVW/pZ/5g1fLdI/A/gqtRALinTV+eEUcqkMcrZ70Kyxnmi+VDsJ5gNG41tTZT 0RjZTzhE0g5srO0WFUvZfdAtCWMLZXRZV2LAhebHVmL7/FF7eQKWaxIRKu3PwYXmwaAOrZDeo0G WMFGCXnP2rHDKJw1JmQjsEufBMgKttADD5Vhg6OXHh18udwySwd/dpRdxgO6xHHaO8FpQUv1EvF +QLWW1zb+Rv8bDR/qtg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-20_02,2026-03-19_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603200119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1774018289672158500 J2_jumptnew and J2_jumptnewpt passed the raw predicate value to gen_cond_jump(), checking if the full 8-bit value was non-zero. Refer to PRM Section 6.1.2 "predicate-consuming instructions examine only the least-significant bit". This inconsistency caused if (p0.new) jumps and if (p0.new) loads within the same packet to disagree when the predicate had values other than the ones generated by predicate-generating instructions (e.g. 0x80 or 0xAA where bit 0 is clear but the value is non-zero): the jump would be taken while the loads were skipped. Fix by routing both macros through fGEN_TCG_cond_jumpt(fLSBNEW(PuN)), matching the pattern used by every other predicated jump. Discovered-by: Alexey Karyakin Reviewed-by: Taylor Simpson Signed-off-by: Brian Cain --- target/hexagon/gen_tcg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h index 7b96dab9185..45ccd518883 100644 --- a/target/hexagon/gen_tcg.h +++ b/target/hexagon/gen_tcg.h @@ -951,9 +951,9 @@ #define fGEN_TCG_J2_jumpfpt(SHORTCODE) \ fGEN_TCG_cond_jumpf(fLSBOLD(PuV)) #define fGEN_TCG_J2_jumptnew(SHORTCODE) \ - gen_cond_jump(ctx, TCG_COND_EQ, PuN, riV) + fGEN_TCG_cond_jumpt(fLSBNEW(PuN)) #define fGEN_TCG_J2_jumptnewpt(SHORTCODE) \ - gen_cond_jump(ctx, TCG_COND_EQ, PuN, riV) + fGEN_TCG_cond_jumpt(fLSBNEW(PuN)) #define fGEN_TCG_J2_jumpfnewpt(SHORTCODE) \ fGEN_TCG_cond_jumpf(fLSBNEW(PuN)) #define fGEN_TCG_J2_jumpfnew(SHORTCODE) \ --=20 2.34.1