From nobody Fri Mar 20 22:04:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1774012628; cv=none; d=zohomail.com; s=zohoarc; b=BqO6BrIaHuXFgEarjOWGcSqJ6D6wyLqXl9WGSIka8WsO/9UFF35qt0INTDqraeVZXUmR6EsLpYYTnAOzKxrRrnoe845/oeiGMci8j/q1y804pxutErjbX2DUGzPddPkYwSG2a/nYJifhbjMmqqJYpTYgAX0/L9C1MBhhSa6cxtg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774012628; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ox09lJlrIlX36nSOA8lgaot7ry6qFt0dJt6CN6nPMoA=; b=N/TyS2JmfxACmAHsp5ohFmbEDakqsri+53poYJVRahh6Nc2LuRDdbTDsS23dAZkP5d8KVpPn8sipUKQcjpksCrV8aAnottyOs0MRkjQE6GW3NZ4ItB/9p7NHLvLOdjuASg0Q7wCPZnv4MULgHGkc4b2T514dkAIagH2i62bxeS8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774012628312794.360441609353; Fri, 20 Mar 2026 06:17:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3Zi8-000686-6P; Fri, 20 Mar 2026 09:16:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3Zhs-0005v1-IH for qemu-devel@nongnu.org; Fri, 20 Mar 2026 09:16:05 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3Zhp-0000Lb-A7 for qemu-devel@nongnu.org; Fri, 20 Mar 2026 09:16:03 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-b979d16dd0cso259899566b.1 for ; Fri, 20 Mar 2026 06:15:59 -0700 (PDT) Received: from draig.lan ([185.124.0.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9832f8db2fsm163039866b.23.2026.03.20.06.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 06:15:55 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 20F0E5F9E2; Fri, 20 Mar 2026 13:06:09 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774012558; x=1774617358; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ox09lJlrIlX36nSOA8lgaot7ry6qFt0dJt6CN6nPMoA=; b=sU4T0j5rQj+oBfkRNHDvtITvBCKkewC10WuPK0PZ8UwtHmGiUtLpKYCpP575Xp4JES V6rJ6SCxtFxvJ9rP0moxYYatgkAcKdTrzr+4dG6yKqG6oxHUOscSgg7cImQNXmN0NbYR R9fgtwd/nrtK3aTCytvMtCKHVFQyAr/xohL6LJ+D9xEe8MMxDuh/s+DxW+miycjKncc3 jjnB3Goa7iTT4+lxEnxPkLGLmeAh7ZesoYZHksrmttfrsqQgeBKq0urZbmFJDYCAd+7F rtROuEYxgNycP+l3JioXUlB/lx/PfEIrIeStdoirwruh+7+fXq2MDZV/5Uj5Bdj1myVk QPEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774012558; x=1774617358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ox09lJlrIlX36nSOA8lgaot7ry6qFt0dJt6CN6nPMoA=; b=QZPoimxV2FVDqEQHpn5ssl8vq7QnBZmzBTWsFSbb3MGo3EW94/rvBku1jaBsYbC+pD o6r9f3ua9L5QmWYHMJRul5PfAeqos5THlM7Gd2SBI95uP9IGXBQ9iXbKSRVkvmSSaoui WJaBM39Ut0Z54s7E0wiZHk+Am1v/oTydCsaw9DsL3YX9TtEcbtLhHZlBCa0u/1iBKBqI Srcap1KQH1VoFqFbxqFGzkPIU3hiCXvRDXE7rDo35dz4KmDeH4P12JiTbkh/apYvKlLU nwQml6/CBsEjfoSMMRdfthQB2zFTxXu4EpCnMVGntb9LGkwHFkXIzv81sIPqgbgv+aTk 94tw== X-Gm-Message-State: AOJu0Yx32s/zxHwOag1U4f38a3MjL0tBP6uIQKWE0jCzGc0x3u3fMB5h txPziToPQXe/prw+sX3g4iR6qaJC2O+pgnFfLoAMTGl7xyt0Obn1NFO7s4m3RdsjIsqoxRATNx5 Suw8mnv4= X-Gm-Gg: ATEYQzwYIjfD0245p2AMFLq82Jup8DF0G3ENAx9U6rxyFOviOJFeAS9bmF2vzGLdGTl V62PY7B7rgotVeMgDIM1zPE868WivelHzSvILilDNWTutzLH/0EtJ21Syin9EURDcClYXcFU6Ml F4tctBdUIByMy+1/1+z+UZG+eJX53LLd021J0lGC1IzjJBv5WnqdlhD1pw0pfmt6Ligt3qSCDCj ettIXLVQzLT4+5hcZUxOjLQBCpVVOiN7V/LBRMcE9vIzU+cUzfct/4RimdXtRGyTfWFZozPZmMu yerTgAUPbYltlCyCPK+1zseSDMxmA9aSg6o8Yz7eSu9hIFvP5Qysdruui7UfMpeW+/9DyipCcZG D5cXYm4PCPa0LgElhbYwFo5jsenWWmo+TokB/xBkJZ/+7QEGK63I4IFC9PCaiGbpJevUS6bApDZ HKutRXHBYGKokjXDKdtou7eTQ= X-Received: by 2002:a17:906:8406:b0:b93:99a8:c366 with SMTP id a640c23a62f3a-b982f3df9d1mr182055366b.55.1774012558228; Fri, 20 Mar 2026 06:15:58 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Alexander Graf , Peter Maydell , qemu-arm@nongnu.org, Pedro Barbuda , Mohamed Mediouni , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 18/35] target/arm: make whpx use syndrome helpers for decode Date: Fri, 20 Mar 2026 13:05:49 +0000 Message-ID: <20260320130607.2071996-19-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260320130607.2071996-1-alex.bennee@linaro.org> References: <20260320130607.2071996-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1774012630078154100 Rather than open coding a bunch of shifts and masks we can use the syndrome definitions. While we are at it assert it really is a EC_DATAABORT. Signed-off-by: Alex Benn=C3=A9e --- target/arm/whpx/whpx-all.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 513551bec1b..f5646e7127e 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -356,15 +356,16 @@ static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY= _ACCESS_CONTEXT *ctx) { uint64_t syndrome =3D ctx->Syndrome; =20 - bool isv =3D syndrome & ARM_EL_ISV; - bool iswrite =3D (syndrome >> 6) & 1; - bool sse =3D (syndrome >> 21) & 1; - uint32_t sas =3D (syndrome >> 22) & 3; + bool isv =3D FIELD_EX32(syndrome, DABORT_ISS, ISV); + bool iswrite =3D FIELD_EX32(syndrome, DABORT_ISS, WNR); + bool sse =3D FIELD_EX32(syndrome, DABORT_ISS, SSE); + uint32_t sas =3D FIELD_EX32(syndrome, DABORT_ISS, SAS); uint32_t len =3D 1 << sas; - uint32_t srt =3D (syndrome >> 16) & 0x1f; - uint32_t cm =3D (syndrome >> 8) & 0x1; + uint32_t srt =3D FIELD_EX32(syndrome, DABORT_ISS, SRT); + uint32_t cm =3D FIELD_EX32(syndrome, DABORT_ISS, CM); uint64_t val =3D 0; =20 + assert(syn_get_ec(syndrome) =3D=3D EC_DATAABORT); assert(!cm); assert(isv); =20 --=20 2.47.3