From nobody Sun Mar 22 15:45:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1773962869; cv=none; d=zohomail.com; s=zohoarc; b=U/4ily7k1VKaU+GY6y1C8xv7EdU3JCGzt+DY6V30HoJsLez+Zi0YF9AteztoJnzX5WpseBOXJjlHvIS+9fqbxIzaNZcLjH8ZnX2qxtq+tbFl+trkzzJJN3ve3KYeIe4df4bfOjpe6rzQsoIzNFwRZlsFSvC8jrFPfHeslSwB9m8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773962869; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dnpq0ftMx8G84qoaXkcolzp3tfJeZoMWYUC6e4g/8hM=; b=fQtd249HEsc3cyaXTOlmStSBZxqtgcEZ/YrHdCe99ykc59ceN4VBfdIOjSjTaRBXRwym1WTdP0+owU1ggzGYMC5OO8IpHU6bFJiEbvhsvOExQukC6Kiz3P+gWKCOQPDxAVmKsYPQsbT39rAtbciPwx1NVgntBGx4SPpk/Gfw3Ns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773962869985432.20498856769825; Thu, 19 Mar 2026 16:27:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3Mka-0000ki-7I; Thu, 19 Mar 2026 19:26:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3MkX-0000jr-Bo for qemu-devel@nongnu.org; Thu, 19 Mar 2026 19:25:58 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3MkU-0007ct-Uj for qemu-devel@nongnu.org; Thu, 19 Mar 2026 19:25:56 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2ab39b111b9so328055ad.1 for ; Thu, 19 Mar 2026 16:25:54 -0700 (PDT) Received: from toolbx.alistair23.me ([2403:581e:fdf9:0:6209:4521:6813:45b7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083516ae1sm2979165ad.13.2026.03.19.16.25.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 16:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773962753; x=1774567553; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dnpq0ftMx8G84qoaXkcolzp3tfJeZoMWYUC6e4g/8hM=; b=eNZa8EFwRdPW/ZuSsvyxqEuvgfNKYQVnRoe03Zfw1T4lHOPSAbsioKvcNkJ61dRg2B 5kTiGZXv1UzF5sPEhjyCH+LPNXyz6ZltlFyurfxLNQqC4og/Hz/1WkVV5xsqij151M77 RYfhYqi3YG0s3+Ih+OQ5909dEeGzziZETp36wEhaG98cBd3nRxp/sUUUubJXK2e1dPB0 3yJg6vXcx9p0BpT8dy7xUdYxjBWWSnZKaPs8WLe01EE5pppEEjq8GyTx2f4MiNaskCH3 Y6iP9F88mnOeKlhVVBHTrI8dtm+IBXIje1A2d3g2rzOV3sxD83mKsbLCB0gxtBy5iHTu U8kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773962753; x=1774567553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dnpq0ftMx8G84qoaXkcolzp3tfJeZoMWYUC6e4g/8hM=; b=Lu/UVpvYA/trmRmEC1Ee8ml1tlAHUh8OLrPOGahcTfQHhskswxIVquR/HXEbEdkN61 F1L2pIxrDcbT+o7+KOTV1GE4Xl7Eei84fqj9F/jGmeR7D+WpjO1pR/Y4GHgBWq2qxkFu i2li87x4+hQrT2GYXZd8tLD9e+HRebi8TGhVq+LvS5tkiFfjMSmB2lIppy6EK0QTlSdM asjCQg/W4kFn65dHlwQgeq4rQk3DljRPmUANNe6nm5mX7LUJlF3W/hTdRibr6snMk+gw MxB8533Yxa941t+KO+qUfJobdMWRP+qO6q3Y7AsnoIsXvSDeerMPSnTztv7kIsi5ZOh+ TlyQ== X-Gm-Message-State: AOJu0Yz2vLcj7Os6qS4EYwSBndz32qN+6m3uTYY5UyFrSsLWuelIJ9Gd CiYPHXror6SzOKrVUiuJtkVJrZrFCjgqJZd0+bp4NSukhxJzDP0rezSCSoS2/Q== X-Gm-Gg: ATEYQzw+TDOHU1gUhchrN3QN8nrHyHXHa8pySIxBCIh+nsoMpXPI/Qq+W+sGawkw6U+ BHFsmVm52xSf02DG0WotSsynwd6gxAtS/oL+srXeJqwESDs3n245/2xPX3Mzm1V8lfFfdrw0pXh bEKoUD08thhM3pyQud3Uf8qic0SX2g7G4cbNHA5tuB89A8ItX7xSUHpE0UItbw9f36yM33a2iJy Uq7e8Mkzk47q/YE28XqzSh0RUIIYtzn/lDsRjE3LTNnTcAbPnxOe0NF/leYXY3O8JD9EExDlvEH m1q1DcW+VY3WnIqqRRMG2VO13g6xRXqgkP20SQalDsRUb7cP0n1vWd+ieX2Ieq2HUe7qsq88dIk 6sWo5FnmDRd96DMY3a2IxGPPyRbuexHGa/vtbaBFxDp574a1R0TSosvtjbuz9WpbW/YgYmNy/eC db+qfHW/GSZEURSMyLaH9I4gRW+DH1cq9b2S3pF84DdQ== X-Received: by 2002:a17:902:f790:b0:2ae:6259:5aff with SMTP id d9443c01a7336-2b0826ffc3bmr8420105ad.6.1773962753006; Thu, 19 Mar 2026 16:25:53 -0700 (PDT) From: alistair23@gmail.com X-Google-Original-From: alistair.francis@wdc.com To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, Jay Chang , Frank Chang , Alistair Francis Subject: [PULL 05/17] hw/dma: sifive_pdma: Set done bit upon completion Date: Fri, 20 Mar 2026 09:25:10 +1000 Message-ID: <20260319232522.1867400-6-alistair.francis@wdc.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319232522.1867400-1-alistair.francis@wdc.com> References: <20260319232522.1867400-1-alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=alistair23@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1773962870350158500 Content-Type: text/plain; charset="utf-8" From: Jay Chang Ensure that the 'done' bit is set upon transfer completion, even if an error occurs, since all transfers are considered completed regardless of success or failure. Signed-off-by: Jay Chang Reviewed-by: Frank Chang Reviewed-by: Alistair Francis Message-ID: <20260304030816.33209-1-jay.chang@sifive.com> Signed-off-by: Alistair Francis --- hw/dma/sifive_pdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/dma/sifive_pdma.c b/hw/dma/sifive_pdma.c index 6d06ec0375..7b22e51492 100644 --- a/hw/dma/sifive_pdma.c +++ b/hw/dma/sifive_pdma.c @@ -153,6 +153,7 @@ done: error: s->chan[ch].state =3D DMA_CHAN_STATE_ERROR; s->chan[ch].control |=3D CONTROL_ERR; + s->chan[ch].control |=3D CONTROL_DONE; } =20 static inline void sifive_pdma_update_irq(SiFivePDMAState *s, int ch) --=20 2.53.0