From nobody Sun Mar 22 15:39:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773962063; cv=none; d=zohomail.com; s=zohoarc; b=NuiPWQJQRa92OR1RnkgZiV3nnj/FgkmvE3Dt+EoTH82J8n4hioK+qzCRTmvORhcoSBguG3eYOsij4aJYnx9fNrIgVR+GxBxHsDeg45JE+6zfXWb0W+dOKmCpmXe2FmW70ieGSmY/tl5g4vra/VWWnUxL16ENnYz3dUCIHEhCdjE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773962063; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qhGfQJ/1tmgLlZlyqT2rU+eJDb8Vl/eOR9kvn1/xgAk=; b=AaVu9YW20/pJdzHXpKeNks+cKxVarOTfg2gRDAQ8X8jBpchRQGXICGyQV2Z2ujv2Aphw1NavoKgZKaTkWjBrMgSBNOC0NW3+vc4h+matVX9rV4KbjoZIjOxUkyBVgwgkIkZ6VtVxmKyhIVLSG5OPWzrWcf8cu1uCimPZN8n1sqA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773962063801208.08908642217023; Thu, 19 Mar 2026 16:14:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3MYV-0001PG-Bh; Thu, 19 Mar 2026 19:13:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3MYT-0001P5-V8 for qemu-devel@nongnu.org; Thu, 19 Mar 2026 19:13:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3MYS-0001ba-GB for qemu-devel@nongnu.org; Thu, 19 Mar 2026 19:13:29 -0400 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-I2wGZJvDNOS4RksiDia57Q-1; Thu, 19 Mar 2026 19:13:26 -0400 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-899f474fae1so229123626d6.0 for ; Thu, 19 Mar 2026 16:13:26 -0700 (PDT) Received: from x1.local ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50b36e5bee3sm6717161cf.21.2026.03.19.16.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 16:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773962007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qhGfQJ/1tmgLlZlyqT2rU+eJDb8Vl/eOR9kvn1/xgAk=; b=Oxa81qr4bzVtofzce1JkvMmPPMCf3mBdTgw60OY6AiXokdSZSAodbdxIV3Ou6V3tjCSX9c VpAQqdpJku+EAjacsSlzIGe9Yisll2KH+B2j5oZoDLYRRgF7KZm4sNTLzt/T3ERYiZniTc 7LRhqm5NdUGcrLQNn6P5WrSVabrKN0k= X-MC-Unique: I2wGZJvDNOS4RksiDia57Q-1 X-Mimecast-MFC-AGG-ID: I2wGZJvDNOS4RksiDia57Q_1773962006 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773962005; x=1774566805; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qhGfQJ/1tmgLlZlyqT2rU+eJDb8Vl/eOR9kvn1/xgAk=; b=Ds4YrvIDUyoZFHkUr7kD4h9KTYJK9CrUhFoIYKEpBTOTkcgMkDbwAVXirf4daN5sgb IZ8OPFja0MwpuQWQc0kKnltaKyxCW19tohZ8e7BJnwTAqfv038LbsUqz7r20OxtWbLhe nV9VfA1PXiFE2AnnJA75njVpLl45Y6Tp/f6mmh4OjUNOG6+pFpRJGR72DmyyOvzBu52Z aG9lu979kHencMQO3fRtb5i8ZVss3/2l0kbYbAokI7cjJKWdJmzaJyjApIRs/VOvpFJU FBhtRJu4Mtjvd7R4mpUiERVoadq9gB/ehE+Krc7cpkZ3rLh5xZl6czn2i8oZ57ErjzPo 5pDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773962005; x=1774566805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qhGfQJ/1tmgLlZlyqT2rU+eJDb8Vl/eOR9kvn1/xgAk=; b=RWUER4bGm/zi2x2mOYh7V4AL312GrCkwjtvRMRDE/Il6THWBTt8G881lICDYf+4NRE 87R6GTMyfpRKRIfBreDvOlRTlNsRvBC23j4Iils60ujv0BlbNK6G/SNc7rOzNcO9dQcH 1sYhHWlIAUCgAGaYo+hIxoLhIcB+kz/6GRu9bIVGQuEOHPIMBpBaHaBYDyokaLVkqXe1 pjPMnTyJsq4f/SX1t88k4pz8jyBT+qY08bfkqsNJ7QT1LveaBnO7H5z31JwfsnQjZ66x dTSCIUGX0hvGT4nR/1WzYejqVd0JfkiURtlClHAd/Dxn3iwAgNt/2XK4IrEEYibGE/qS b8cQ== X-Gm-Message-State: AOJu0YxJC6kERdO0jUkBKpjKfhXZwscIi7zbtZAKikqK49J4c4koUbBj X4ayX/HA3miYwldkqDH8pfPifMsiMZgg450Zfsno6J1EHFwn6lWSDXULSk5ygyvhUmBdd77rCy2 JC9NxxmUC5i6qaVyhWwjcv4jlW501xYlLHqVRSb5qxt4iAZ78olwud1C7vvdf+T0ozNBoJxGLe3 e8b4yeyw2YOVVnxFv0E79TjX23Wa29H+GQCPL3UA== X-Gm-Gg: ATEYQzzdKTVpxSJnmT+gsQCkxgwUcJiMOJ98hVIcotheTeXZiDLX47VuNCoso1Zg86k YWBfH/ZybPlY7MEWTwtNh9+XMVfq+8+GBpaLgR5G++Z6QRNGi6ZhtrzQP3isxRi7hunm4C5ORJn nzu479aa9As+hE9Z2iTR7yB+OYjXum4R6zOBQNvesgddBnmnLQ5GVT64gwXncGrbA8jyvfhreDO G0eK5SY37HLza8PfMDoT/q+nJ/AZYJ08GSsby4meXKgDR64oEKR0ZfkIJsuilwtPItkZPBxrSNq m7S10X92AvigUy1IgR1Ocv4VRNKEN4l05+NHbYtHr6Vuh+3tgOFnXlt6i/qp7wb38qmIKdCqU+6 /I36EI6hSlF8CQw== X-Received: by 2002:ac8:7dcb:0:b0:506:baf9:5dd9 with SMTP id d75a77b69052e-50b2461b5c6mr75315851cf.17.1773962005186; Thu, 19 Mar 2026 16:13:25 -0700 (PDT) X-Received: by 2002:ac8:7dcb:0:b0:506:baf9:5dd9 with SMTP id d75a77b69052e-50b2461b5c6mr75315341cf.17.1773962004654; Thu, 19 Mar 2026 16:13:24 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Juraj Marcin , Kirti Wankhede , "Maciej S . Szmigiero" , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Joao Martins , Alex Williamson , Yishai Hadas , Fabiano Rosas , Pranav Tyagi , peterx@redhat.com, Zhiyi Guo , Markus Armbruster , Avihai Horon , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH RFC 08/12] vfio/migration: Fix incorrect reporting for VFIO pending data Date: Thu, 19 Mar 2026 19:12:58 -0400 Message-ID: <20260319231302.123135-9-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260319231302.123135-1-peterx@redhat.com> References: <20260319231302.123135-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773962065125154100 Content-Type: text/plain; charset="utf-8" VFIO used to report different things in its fast/slow version of query pending results. It was likely because it wants to make sure precopy data can reach 0 hence trigger sync queries. Now with stopcopy size reporting facility it doesn't need this hack anymore. Fix this. Copy stable might be too much; just skip it and skip the Fixes. Cc: Avihai Horon Signed-off-by: Peter Xu --- hw/vfio/migration.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index c054c749b0..9dbe5ad9e9 100644 --- a/hw/vfio/migration.c +++ b/hw/vfio/migration.c @@ -591,6 +591,10 @@ static void vfio_state_pending_sync(VFIODevice *vbased= ev) __func__, migration->precopy_init_size, migration->precopy_dirty_size, migration->stopcopy_size); + migration->stopcopy_size =3D 0; + } else { + migration->stopcopy_size -=3D + (migration->precopy_init_size + migration->precopy_dirty_size); } } =20 @@ -598,19 +602,18 @@ static void vfio_state_pending(void *opaque, MigPendi= ngData *pending) { VFIODevice *vbasedev =3D opaque; VFIOMigration *migration =3D vbasedev->migration; - uint64_t remain; =20 if (pending->fastpath) { if (!vfio_device_state_is_precopy(vbasedev)) { return; } - remain =3D migration->precopy_init_size + migration->precopy_dirty= _size; } else { vfio_state_pending_sync(vbasedev); - remain =3D migration->stopcopy_size; } =20 - pending->precopy_bytes +=3D remain; + pending->precopy_bytes +=3D + migration->precopy_init_size + migration->precopy_dirty_size; + pending->stopcopy_bytes +=3D migration->stopcopy_size; =20 trace_vfio_state_pending(vbasedev->name, migration->stopcopy_size, migration->precopy_init_size, --=20 2.50.1