From nobody Sun Mar 22 14:18:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773954008; cv=none; d=zohomail.com; s=zohoarc; b=Z7SmRiVrKcvzP9dx0AitP6SzwVZJ5GW70KEWb5l453TeELUYaMVRtpi7z2Bzezsi6jEMygQGn3l0wEp2fLK6xWuS6T2osa9Up9bCBZGPDL+3SjZ+PBPrgWoyWdytprQEn8UOArbiYGsO5AYdeDk2bHkMVxjqkI+bcRovwSyvkig= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773954008; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5ir/Gt6emdsq9JA6pjxJ2hRDANL1XoU83i0s7uDAsSk=; b=GS2xAxtlCEePuBD5kIghU2SqMUDEsZ1Lqk4egTRfqINm0JBlfWxyncH8LL2sTA/QTULB34n/0h4tPpK5GTSrY17WWhTzH8f7kBG9SkK0ZTPmZlXtPQQwo7w7/m5tmJc54c2YpjWyJH9TiPEAkpdF+bqpgz3sT86pSefLzEpOYOo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773954008066420.3268839467421; Thu, 19 Mar 2026 14:00:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3KTE-0006hb-Qg; Thu, 19 Mar 2026 16:59:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3KTD-0006gu-6W for qemu-devel@nongnu.org; Thu, 19 Mar 2026 16:59:55 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3KTB-0005s5-Di for qemu-devel@nongnu.org; Thu, 19 Mar 2026 16:59:54 -0400 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-3585ec417f6so1123633a91.1 for ; Thu, 19 Mar 2026 13:59:52 -0700 (PDT) Received: from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net. [216.71.219.44]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd40e4bfdsm31273a91.9.2026.03.19.13.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 13:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773953992; x=1774558792; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5ir/Gt6emdsq9JA6pjxJ2hRDANL1XoU83i0s7uDAsSk=; b=s5X5JFoMV/k1fXyxClwIKPQosLh5XG51H4YsnQvwz0nCYEmzMA/DA3OfVrzIfsYcPX rmkRAUembv4eSWKGYlcTvwq7RjgD1Mk08V8M13mVmkF3dtJKBq07nwE71nSAEnMJouLL Ij897w/oiDj3LQfEt7Id6AO7kB7E1IAZimKf2IgLTF8jBK0OKdMiaUelLFQr8Y4yQRCQ GEqkZil6BrYwX/w1zVck0pCHpmWqtVFFrTbAMEj7NO+sVV5NcPv3asTmrQSm9Zb2CLly 8YudRETeX2RUI/F3n3go0+4T6jI7Zms09+SLc6zf1u5NuApKf2Y1ib1Y4ds6lydncZiI kT4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773953992; x=1774558792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5ir/Gt6emdsq9JA6pjxJ2hRDANL1XoU83i0s7uDAsSk=; b=G5Rq3yZU75pggsbJoVKILJHOKn7PrL0BzmkGoBmrZJ7/2r0rK+z1rUcAJ/flXYOvOu tXMkjeDrzEb336NjpehO29xP9r+xnTmG/cfrbnIaD+sQJTQi5hjS3OtOxO9RJPxSWFx5 0PQH+QfjipYE40sLDTJpl0vsjGPuaRiiI550T6L706FChH7dL0yjJAmin7BZab9JZJ+5 WYcCz4xY+xXgdJnJ9L2+X3X+SrPTqvArNEcEVOhijv2EGcxsSLQBUkwlR/8Pcs1u4n1a GqyVS7vIQ0QYynny9dk5CerT21A5vbNBWdu4T3IcapEQYe1W0e51XJISvKkGZBHib4n5 0D4g== X-Gm-Message-State: AOJu0YxWpZZw5fvsCklrYPjFuFZZeaDQJ3zizH9gaLuRPKjx7GBpr4gX 1a7o2XclIk+LlBbQoIFHuMe+38sEN+R1t4PXhyDluoX9wgnZBihN4gTI5cBcyqgg10cnTM0ahV2 4b49qc/0= X-Gm-Gg: ATEYQzwhfKA8n7g/ob3uZb81R9MMsI4OB9bcBMTdkhKt/siIrvCqbTQFkmIn1/ZwpYK cwujZmVZcrndn+Qb2tX8GhgSE5CEjls/7K387H97dO5vOTXJL6zKrjlBIhG/+G9ik4BHo2x/kYV ww1uQwFW0NEyoF9YBk3ZjpORtPYTZpGGeRtpDJLSa65p0/IlEcQRRqG2eD4s7AhtLnXfLTsW5E8 WAawODmYwgQWj0pFzva4cvPRtqEEabivbVbLLLPpFfmVJjs7hfTV3YZvA2rSD+oBJ8RLeR+3oVv xVElQ73rMok1t2XOx/cqMr1eYcCimVf5FgIsbiq4GH6HbGDind+edbufw9jiPWub59/Y2lJKc/N wNvhh7+zMh4XztT9I9xev6aDiNH4dkInwWRji9qEUClCe2XNjDsaZ453sBCTzMRiXLKD69Hqo9S 0hztD4ogD0PXDfY9QLfBwl1FG/4GPv5avEKnT7/HcJTD++iKsFD8JR9qYfxJGvM6tLAEkXy1Yi8 T80 X-Received: by 2002:a17:90b:2e07:b0:35b:a0f0:8327 with SMTP id 98e67ed59e1d1-35bd2719d1emr450993a91.2.1773953991838; Thu, 19 Mar 2026 13:59:51 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Zhenzhong Duan , Yi Liu , Eric Auger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alex Williamson , philmd@linaro.org, Pierrick Bouvier Subject: [PATCH v3 1/2] backends/iommufd.c: report error when /dev/iommu is not available Date: Thu, 19 Mar 2026 13:59:41 -0700 Message-ID: <20260319205942.367705-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260319205942.367705-1-pierrick.bouvier@linaro.org> References: <20260319205942.367705-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773954011281154100 In case current kernel does not support /dev/iommu, qemu will probably fail first because /sys/bus/pci/devices/*/vfio-dev/ is not present, since QEMU opens it before /dev/iommu. Instead, report an error directly when completing an iommufd object, to inform user that kernel does not support it, with a hint about missing CONFIG_IOMMUFD. We can't do this from initialize as there is no way to return an error, and we don't want to abort at this step. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Pierrick Bouvier Reviewed-by: Zhenzhong Duan --- backends/iommufd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/backends/iommufd.c b/backends/iommufd.c index acfab907c03..e1fee16acf2 100644 --- a/backends/iommufd.c +++ b/backends/iommufd.c @@ -82,6 +82,9 @@ static void iommufd_backend_complete(UserCreatable *uc, E= rror **errp) } else { cpr_save_fd(name, 0, be->fd); } + } else if (!g_file_test("/dev/iommu", G_FILE_TEST_EXISTS)) { + error_setg(errp, "/dev/iommu does not exist" + " (is your kernel config missing CONFIG_IOMMUFD?)= "); } } =20 --=20 2.47.3 From nobody Sun Mar 22 14:18:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773954027; cv=none; d=zohomail.com; s=zohoarc; b=JWCvjc2OYuVfTW3N8CYFAL53ZsIskjGJd3I6DlMBXqrDbgPG1AJBAymdu7WeAeDa0UKwUOfoi6VHKetNmAZh35bDe+QKkf9vTvwS2nr0McmjZoVQ/xNHWNoJEuohZ06oW4g8r7/vUXd2MpXn7OZmWbD5VpA0umUGh6tzfimjmRg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773954027; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bBRdioarDBlwzHg1xa4ywHaBWAnWfXCcdobe4gbGus8=; b=VzcC4jW287VsX/Rbsb8bfbBvNXwhEPVppeMsur68likpI8P6dmdni8o3Kr/jiLsmeCkCby10VqBYUIR7BXKvpQ5v0h57wMakh3m3Pig71ey1VSBgMwWpqOGByfxFPyr8LaDCy5Tmp2Xqs2EC1Cx0pT9omB4yseWMAXEk3sh3j4U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773954027529221.4830644531329; Thu, 19 Mar 2026 14:00:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3KTG-0006i6-DQ; Thu, 19 Mar 2026 16:59:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3KTE-0006hP-9i for qemu-devel@nongnu.org; Thu, 19 Mar 2026 16:59:56 -0400 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3KTC-0005s9-V4 for qemu-devel@nongnu.org; Thu, 19 Mar 2026 16:59:56 -0400 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-35a1f549e7eso7681a91.0 for ; Thu, 19 Mar 2026 13:59:54 -0700 (PDT) Received: from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net. [216.71.219.44]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd40e4bfdsm31273a91.9.2026.03.19.13.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 13:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773953993; x=1774558793; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bBRdioarDBlwzHg1xa4ywHaBWAnWfXCcdobe4gbGus8=; b=WCgbVlcg5Qg9nlNiEJ8EfYAT8zFikZay8mFy/sjU8/OjYrx+ujCwtaKKAvJMQF4moe rVCs+I9t+CSjpc7r/O6jXVYLG9Oyx/I/mmKWoYq2nHmty6l7iU8sNVJoWIsxV9450F/M 24XU+Oy88mD/PhXoufqEsZmz0sflluERgI6Icy6iaDcKGhI3cV9KkQb2DSljYeYAosxd 4aE4vAbRv3LrekN8oOOwXU2NPVGgLaFXDlvd3N6Ng+BjI2p5ew5bloWcPb2ykNj/SyZz JvQrSbjxdCNNStziUIN+eRoFNhxe39st4hnWVsq7q+tOSlupGY/VD6kp3ZqDNTNvPfps yTww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773953993; x=1774558793; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bBRdioarDBlwzHg1xa4ywHaBWAnWfXCcdobe4gbGus8=; b=IEYJn6BSMHQ2It57pGvrnjaQhtiXJHxEZ+IqgZXlwBbo5Y1GRnSb8s02JJiTS3h125 B809egF8atGU3xTqB+iQJl2uPU+M7Tf/f1U5xMmwFFzFWSE5OyXrYqCb/PJfPmwQ/uCM 6nBMqCfdakYr4zk88Tla8gL0xQW4eBNu5gOF4iGyRG6wetqmwiCrmPdONjrQlhbpxZYj 0II65PCe2bsWqCrApl2tyXh9ON2DZ+mKcaMd5GZP7SvYWGMhNColzriLZZj8EJvSjiIQ od/inIaPUlvbcb8Kewo9cbrnYClKaC0pWvXG1Hv2K5Ox8yRREb2y86PNyG//aLUzYuw4 6uRA== X-Gm-Message-State: AOJu0YyG8ufSQWBex4A5xz9ZnkLEcQ5d7oB7xCywzRjvSHfD0wo4rUKh 0syvWU5LCneZaYjlJYkbRhPyPL/j6WtLhp1Jr/CpMrXRaDr6ThvmMJWEHLNQkcKkdZ1Qnt1xabi nYpGQ26k= X-Gm-Gg: ATEYQzygd+622VxRqvtgpcLZcCei5ZJYVIiZ7e3BcFs15VN/B7Aw2RKmOKcbar/kjed Atr9yYNegNKUvln2PPN8isz1TYHbLddi+drK6xOSOTAGBi+5eBU2oy55He+t5sXhUvlyJ/Jk4Vi oAHG2A5+fmM+vOkdiiALMeBNb3w9stLBmA8t7iTYMPH5dtSke4IUm152WGloJAL4rmtKgiC1r/l MKFvjJ5ldLuLrkAnnmnweuFiWA3bugdM5M/6TWKQEbq1TLm1A7qfC3SQ353CD6bTGfDebX3ArM6 u5S3bJmtjZNC9F7vWBRvEJHnX8eFCpFgNfArKrJlm0vZK42tBtNrklApC37c8yMnDSTEB/oH48I 7ni9PZRz4rvKlx2hH1KtHeMlQXLfpGlNfhD62e8uFePeH3Jw0j/6coZTgbBDZxvVf6J4DeimFQo s3gHWH2kJWMFNdIm0RjdaFDSt/fMiZB98Fy29p4Vkb1zjbvm9SawH+tQIG4uIpReR95SsBppRLR Vg0 X-Received: by 2002:a17:90b:288f:b0:35b:9a95:dfb0 with SMTP id 98e67ed59e1d1-35bd2ce31c9mr392221a91.25.1773953992731; Thu, 19 Mar 2026 13:59:52 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Zhenzhong Duan , Yi Liu , Eric Auger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alex Williamson , philmd@linaro.org, Pierrick Bouvier Subject: [PATCH v3 2/2] hw/vfio/iommufd.c: report hint to user when vfio-dev/vfio*/dev is missing Date: Thu, 19 Mar 2026 13:59:42 -0700 Message-ID: <20260319205942.367705-3-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260319205942.367705-1-pierrick.bouvier@linaro.org> References: <20260319205942.367705-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x1033.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773954029437154100 Give a hint about missing kernel config CONFIG_VFIO_DEVICE_CDEV. Reviewed-by: Yi Liu Reviewed-by: Zhenzhong Duan Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Pierrick Bouvier --- hw/vfio/iommufd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/vfio/iommufd.c b/hw/vfio/iommufd.c index 131612eb836..3e33dfbb356 100644 --- a/hw/vfio/iommufd.c +++ b/hw/vfio/iommufd.c @@ -274,7 +274,10 @@ static int iommufd_cdev_getfd(const char *sysfs_path, = Error **errp) } =20 if (!g_file_get_contents(vfio_dev_path, &contents, &length, NULL)) { - error_setg(errp, "failed to load \"%s\"", vfio_dev_path); + error_setg(errp, + "failed to load \"%s\"" + " (is your kernel config missing CONFIG_VFIO_DEVICE_CDE= V?)", + vfio_dev_path); goto out_close_dir; } =20 --=20 2.47.3