From nobody Sun Mar 22 14:10:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773947514; cv=none; d=zohomail.com; s=zohoarc; b=L1G29CKqUz5oejzDSD3sgXGobsi2Ulqwld4xaRVL/WEBGAU2SNRF59YzsNihYcHCoX7jpgm0WNt/2Ov/h75b1ltprEpCNldED1AHQy38uz416ouWfpXDZVPbtCnX7Z6nn+kOFITC5yaQAsK/GSxPspkvcvyFTQP7vjr6zJDNmw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773947514; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/baUhUHLskzt0UuYRNXOTK4Cu8bhklvA3O4wTh+q0Qk=; b=WLIb3MuQ3KbwLalnyO+ZCwxsGNgtF99jWAkfYCA6wSx2w3XbIjtxpdj3pG1T7RqORT9f5kpj9pdYrJqw8RlXu8EEuhuIztFgsI9k2JZJEHxuJVLOzt14l2XKOgeQrn7fs3Oh2WIScE5mTuh9wE4TqHlw9F/3fwl6BLR9FFIpRuI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773947514921918.8223363692091; Thu, 19 Mar 2026 12:11:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3IlN-00005f-OR; Thu, 19 Mar 2026 15:10:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3IlL-000056-Fl for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:10:31 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3IlJ-0008PV-RL for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:10:31 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-43b45bb7548so868654f8f.1 for ; Thu, 19 Mar 2026 12:10:29 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b647120a1sm641454f8f.30.2026.03.19.12.10.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 12:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773947427; x=1774552227; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/baUhUHLskzt0UuYRNXOTK4Cu8bhklvA3O4wTh+q0Qk=; b=xO41od1+3rz5gf2hXW/Lav6Doz3P/k7FWMfkt6twsXpTA5/pMGoVsPidvBRI5kNfCh bQADOhJzZFCxdEYARzUwgeokOzULhzU57PxDNizhJj50AXAAwUjqDY2BrH2KMylZ2Jt/ QAt+3CUvveSgyfkR40gnOtU517qw2nh9GAVofDRITaqPjOEzzq8Sn8MMFLhDnW7TgN1A v+iwGjJ8bWZhVnkJuQ1xpW/BpF4f9UkAq4BuBQ+tfDlAPRCAstzH2gW1qjogktILU787 KI6gVsDWFuIkJ6TfMvexYVvR6EpWuYCnW7p4/FPK4nDyHQWusvAfoBj7ZBHEO57WMWMO hOXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773947427; x=1774552227; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/baUhUHLskzt0UuYRNXOTK4Cu8bhklvA3O4wTh+q0Qk=; b=RRt7IO3jWXKuf1nxnU4/OETfyhsP2tWCzhBa9N6hXyyLcZNfafcisAlYGyYaETW8Ke Nht7PZsiSjrW1KyMtY9BrzjnJLQU3J3OSRngsMoBQjprm5El2oNED3Jp1T5lLsqi86Pm bmlTMnaxKDgIH5PvZtP+BThw44Og8Iru82Ta+dHqaPrIK4dsMRs7gwqvU6dch4US4mM+ S5+YG0DbryghRcvAznMMkJmwi6mukHSbdC0ox+bS9wlldGJ1yKZBJ7rHB1/GCLVogftf kji2sy5ydunYiuW5xyN31+TxsZ/9C/gMpkFhoEPxA0Hh9PQanKiLwUssuvvGJQ76OJDE yEFQ== X-Gm-Message-State: AOJu0Yz8risNzJahi+/+pgZcrWeIj4ZNPgF+W8Hu2LlMzre/OoxLsw4t Mq7v6vNVHfQiLCrtoBZcOIt7keBV1h6i3zBrOSHCL9e6qdf75VL+wze4HAPqydPmtoqmgXAB0zt I32jCjDs= X-Gm-Gg: ATEYQzxAxP6inoad/moUhejcOYE24FIegbndZoLFrhzxNsH+rFIxBAWZ7VjzyW7RJlb J72340cD2n3EdV4ytnFPF20RrusySAycS6IPXLqw3hpsDy+Ym85XwxUJPuRPxbVZ3Sr0RkTn40t YmBO2+oNRcc+u0ODD52eqo1Gq1nTqk4nKJqqWJXB2tY9oFlnwGO/TrMHLgNCfP+EwEkBx/AGoxw lAQv/CzRqkeFlxpjWBgpJRV85WgHSza6vVlRQO+anPy2q/qaLj7h33HT29F17tfmPY+N3kHbYCy 144NK3COy7BlONH+QJvYM0i1BWE70jpmCyDiOCkr2U/s5Q9qjhCN/ku2y4WWebXo+yPh4lsKSiG c2G+LrIArg3Yh/1ZXOKP0qIR+Gbv54WqmE1c93JdCdhvpbmuki3BI3Pf9ERSk2NkGEww3qHmOme USyJD7Q/vT15YHg6FQlysF2oy+BJZk0lpuRnpaJWi46kYAgva8JaJqHncPlrUc1ujTzia/sfdl X-Received: by 2002:a05:6000:18a6:b0:439:bdba:56be with SMTP id ffacd0b85a97d-43b6424067dmr926369f8f.10.1773947427260; Thu, 19 Mar 2026 12:10:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Paolo Bonzini , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-11.1 1/8] system/memory: Constify various AddressSpace arguments (flatview) Date: Thu, 19 Mar 2026 20:10:10 +0100 Message-ID: <20260319191017.12636-2-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319191017.12636-1-philmd@linaro.org> References: <20260319191017.12636-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773947517386154100 Mark the AddressSpace structure const when it is only accessed read-only. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- include/system/memory.h | 2 +- system/memory-internal.h | 5 +++-- system/memory.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/include/system/memory.h b/include/system/memory.h index d7b18b632d5..1417132f6d9 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -1201,7 +1201,7 @@ struct FlatView { MemoryRegion *root; }; =20 -static inline FlatView *address_space_to_flatview(AddressSpace *as) +static inline FlatView *address_space_to_flatview(const AddressSpace *as) { return qatomic_rcu_read(&as->current_map); } diff --git a/system/memory-internal.h b/system/memory-internal.h index 5f0524756eb..0066ffdffb6 100644 --- a/system/memory-internal.h +++ b/system/memory-internal.h @@ -20,12 +20,13 @@ static inline AddressSpaceDispatch *flatview_to_dispatc= h(FlatView *fv) return fv->dispatch; } =20 -static inline AddressSpaceDispatch *address_space_to_dispatch(AddressSpace= *as) +static inline +AddressSpaceDispatch *address_space_to_dispatch(const AddressSpace *as) { return flatview_to_dispatch(address_space_to_flatview(as)); } =20 -FlatView *address_space_get_flatview(AddressSpace *as); +FlatView *address_space_get_flatview(const AddressSpace *as); void flatview_unref(FlatView *view); =20 extern const MemoryRegionOps unassigned_mem_ops; diff --git a/system/memory.c b/system/memory.c index 17a7bcd9af7..bd12184a879 100644 --- a/system/memory.c +++ b/system/memory.c @@ -819,7 +819,7 @@ static void address_space_add_del_ioeventfds(AddressSpa= ce *as, } } =20 -FlatView *address_space_get_flatview(AddressSpace *as) +FlatView *address_space_get_flatview(const AddressSpace *as) { FlatView *view; =20 --=20 2.53.0 From nobody Sun Mar 22 14:10:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773947466; cv=none; d=zohomail.com; s=zohoarc; b=iB05gq/ZVnjw5aIB0FHaxcHSWafG+jllcJDq04KJ6DjX2Bj9J4hh+1P7kZt0vW5advYFBzL9hNIq3c2Bw+qlJMoLIuMKzZMnAV6CxZdtMIcB15ZkxEPwRNJQuQeaIcILaxkwmvQZO/Ulx0nFp1cYFqcw3znLDYY8I2To7FtAcAc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773947466; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=usTdj5QCO2BS7JbYt223RkU570yU80bsvLKdRRzFES0=; b=X/vdkkQPGX5EDz2kauSLTEibkxSukLYBaD2VtE589z2R7TPksTdc9rWR5MVnnOPcln8maQg0W6Fevi0Unofw56r4RrxxfXQsJKgxu4ZDbf5vDgfqELByRH5jRamuO6MbQ6SYE++s/qK6dR2GnITVj8LEgufLHxsKKU6SMzEM1hE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773947466752353.3590427066092; Thu, 19 Mar 2026 12:11:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3IlT-00008G-Mp; Thu, 19 Mar 2026 15:10:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3IlS-000082-0M for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:10:38 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3IlQ-0008Qb-CK for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:10:37 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-43b4fd681c2so1104111f8f.3 for ; Thu, 19 Mar 2026 12:10:35 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6470b243sm601578f8f.26.2026.03.19.12.10.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 12:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773947434; x=1774552234; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=usTdj5QCO2BS7JbYt223RkU570yU80bsvLKdRRzFES0=; b=CKYkmoutwWRAqf7r5cvAJqp/ajKSL0SdtdLJY74FNRQQ+lcbUCWgGgkcUweqfVPcmj AjlQun+/mF4vwKlMa2mvf+hH06KHAiSJYD3ZI+ujHQ3TeMHhZMowb839L4mOvmVB6mRB 8/ePkA0zFYyRBFhChXxPpOG1yN9/BRkMgRnkLWk9tJIfh1c37ig4wy27ddxr3z+eMEVw r/yNgFD+vlTrK8f7H3MR+JdrKcJ6/xLT3a6Q3geg75c/i9KFlsyzjBe0do3lWnEbaQNS PIottVeAJNZMNIv97Dkk3o6tta9yHVNxQiV9rqbTgRdMOf3AhfTaybaeANgUPcrfjCjB yNIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773947434; x=1774552234; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=usTdj5QCO2BS7JbYt223RkU570yU80bsvLKdRRzFES0=; b=d8giiBw4lY8FKSm1zjEpnHX1R6iZ4SYQdJIInKEs2uejcefEYbM4up7Wwr9zIWMPzG dGNtlP5z02R9odzBVy1N0DZonLgg6kmNDZFyVvbBPY9KHHxZRHVhSLAQxdCP2kZoL9Dk Tzpko285GarqBbs9UmIV5JwhhE+I0Nm2MbKCUo02kpncYZpASF+Zew4kB9xqPJtaZujb dXbD/FE3GIAfQSwJDGsYmffDzGYlmSL66sOz5vVQVtTCPhA4pKGEX6Bmmgll0/NEpb4E kmNq4iYonrsZGbPcX9FNYR7xQ9oE4JwB2HXWvbe6196HRx5MFmaFUECEhq8VR4fNNh5w T1Xg== X-Gm-Message-State: AOJu0YxmxIxGF5ajJ6mA3QUUVeGlB2yiWWlL7M0bRHtEPPFtOF4Eu+st 7dJaNZXV1BaCxnK5/anDtbGykgNQxmsgVrpRnai/fotBuEl6nlLNaBBxzSVFWBG0t7thJucVfj2 bFWTeWn8= X-Gm-Gg: ATEYQzxY9Ts4Hd/euKdjhWeiPCecKtFFXqjeW+XHCHuozOHBlEmOtUmxcAnHnPObGUv BbbsCN+6AQQPMewIeVmUB10rHs1SevYR8hbakdYfZMH048mvBYF+xlNHTzxzC8oALPHHC/poubZ iHGPk6GXLZmIMhl1jWx8yn5+VEn9q0tmMtD5EizCrYi0I6IKcl/wqElu6u9i/QQgtocMKNEovVE qweQhJNkNwlcDdFLZpxIUj8DGB1RWlIU8O5MZUonv30qbjuUOYleJC1cXHKFuNgi9OszIOXTdMG sH/4s9Y4PMPD7/h5jQcdV+3zCFTNqOxdBj8Fpf/Z0bk0hh/YKWBfLoyu0Rr5sJal8z0O/iSqc8+ bz6alZiHBK9qFc6U4bWdcBoyIKsxuw6xm8LLAmP+5Uik8er2sOeyU47LwxiTQvKkZk9CaXDNSNk z+qOKV9LG6JSRfX8exbOQ6hoE2ihti1dsJBYlIM3oN5GYkbhjwSvpDLN2qncd0zO/Cei25f2Sy X-Received: by 2002:a05:6000:2f84:b0:43b:3d53:93ae with SMTP id ffacd0b85a97d-43b6423f844mr803015f8f.12.1773947434269; Thu, 19 Mar 2026 12:10:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Paolo Bonzini , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-11.1 2/8] system/memory: Constify various AddressSpace arguments (checks) Date: Thu, 19 Mar 2026 20:10:11 +0100 Message-ID: <20260319191017.12636-3-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319191017.12636-1-philmd@linaro.org> References: <20260319191017.12636-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773947468988154100 Mark the AddressSpace structure const when it is only accessed read-only. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- include/system/memory.h | 5 +++-- system/physmem.c | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/include/system/memory.h b/include/system/memory.h index 1417132f6d9..858dc40dc5f 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -2829,7 +2829,8 @@ static inline MemoryRegion *address_space_translate(A= ddressSpace *as, * @is_write: indicates the transfer direction * @attrs: memory attributes */ -bool address_space_access_valid(AddressSpace *as, hwaddr addr, hwaddr len, +bool address_space_access_valid(const AddressSpace *as, + hwaddr addr, hwaddr len, bool is_write, MemTxAttrs attrs); =20 /** @@ -2839,7 +2840,7 @@ bool address_space_access_valid(AddressSpace *as, hwa= ddr addr, hwaddr len, * @as: #AddressSpace to be accessed * @addr: address within that address space */ -bool address_space_is_io(AddressSpace *as, hwaddr addr); +bool address_space_is_io(const AddressSpace *as, hwaddr addr); =20 /* address_space_map: map a physical memory region into a host virtual add= ress * diff --git a/system/physmem.c b/system/physmem.c index 4e26f1a1d42..23ea6b69255 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3652,7 +3652,7 @@ static bool flatview_access_valid(FlatView *fv, hwadd= r addr, hwaddr len, return true; } =20 -bool address_space_access_valid(AddressSpace *as, hwaddr addr, +bool address_space_access_valid(const AddressSpace *as, hwaddr addr, hwaddr len, bool is_write, MemTxAttrs attrs) { @@ -3663,7 +3663,7 @@ bool address_space_access_valid(AddressSpace *as, hwa= ddr addr, return flatview_access_valid(fv, addr, len, is_write, attrs); } =20 -bool address_space_is_io(AddressSpace *as, hwaddr addr) +bool address_space_is_io(const AddressSpace *as, hwaddr addr) { MemoryRegion *mr; =20 --=20 2.53.0 From nobody Sun Mar 22 14:10:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773947491; cv=none; d=zohomail.com; s=zohoarc; b=mkqGY2cAgm4YeRYv1otUzYLwW7oR3G6sKDVTGuCc4wQ7FQCqjRF6OjJ6z6smCpof908EeOWoRyMcI8Et5YxAfLV1bH7VfXqAxbLE2bgW8b8sIezYwZvz4jW7Yplo5nT4XeTh4Ch8cRRizhVkJTJ6s8fmJ7nOK6ywTlG2GXsM0Vo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773947491; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=urtBToIHoqmm7zXCsb5LBhu17lqcZ4qoLoYRqjsR7h0=; b=NdG+bBREsBFIQSB14mFoRYYFircrZ4bYjUj3fN8xz57HyNTF/BBbvVi7+oFiY+JUjxCq9IBZneiIByhfdqbUmfmOLMSVBlTATU+0rVQyVFp+AdXYEg79P2fqV538L+iVkfhRFhOvkB/iOjT0X6xeFO6vcbLJITr33PWylM2OXJU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773947491895294.375143880422; Thu, 19 Mar 2026 12:11:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3Ila-00009P-Gr; Thu, 19 Mar 2026 15:10:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3IlZ-00009G-G9 for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:10:45 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3IlX-0008RV-71 for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:10:45 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so7818695e9.1 for ; Thu, 19 Mar 2026 12:10:42 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff109b95sm1697385e9.1.2026.03.19.12.10.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 12:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773947441; x=1774552241; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=urtBToIHoqmm7zXCsb5LBhu17lqcZ4qoLoYRqjsR7h0=; b=L2vBLHpR8PxQoLpaqYBn2JQwf4PvBhDyNv80+ulTiJug2kE0GNfJZy3rxoTax167ek wTzK6w2ZHBWqz20C2PRpy7aIYKVBpyoefGZckUVgVMRiYlIsCMfzQzjTkru4cMI8/x4s JLbjJuxegvvZxsltpnC6xecDmIt/4isdJZ3gzrtodslOUOgYn/FE3zEow1Ig3iRSTxvt MfWHOcyXbPO6vEVpyOYWpOuFDsdViACNs5dgwEka3OsiIx/rFYGUEvHnxQdZuqudiPEM EzUC4bUtKplpwc38jfJLuNfgndopP2erqi1f0Dv4J7hZTq10jFko6uAhi9Ddnc5deENk i+GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773947441; x=1774552241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=urtBToIHoqmm7zXCsb5LBhu17lqcZ4qoLoYRqjsR7h0=; b=aqDyOjPe+DwiS4fyY84qbrE2QEWLE9cV2hQRrtjVV7Nw6BPUgm6+MBVLPb2Moxq96e l02JfcEA2YXgfhfRXZw9NZJ8Y9sLSi7GMc9WfRrwG4c1+1BWBTGhoU0O+RuzCIK7YAK9 sG8jYcDiSn9aJoxvKvoqE0Nw9jxaB4aF7OgB+hqYaCiole1ZMKfwHkbS+8gKKjpOmWyC Rqcczp0lp6ZyuiMIZ49VaEvUAv4bUnJV8J2UWhByBPo++ZUk+iPSiG8CKBHrEeQulEF0 6gyx/L0Flt6zO/y8I4+CjWBWQlcSPhnvJVOwLiXz/RsMF1WCBZK5v1qJCIhyj2x/Xs8X gnBA== X-Gm-Message-State: AOJu0Yz13Ysg/s0rlRhISW4thhfOFdsFWVMFzEHVQ9s3SkxUS9MR59C1 C6utoxQG7FrkpugufBECnGFvG/4aL5COyp7WZBoDG/b6rFykWPrKmFPpKmXSL21SAxSC6KPzpC8 KzUxsn70= X-Gm-Gg: ATEYQzzfHPr0WrFtgaZRkR7qeZH0gy8Cn9NQA8ulYS0K/ZViHKW6vy2J73xpL5A/i20 W2TF4lCTerv84QW5EOtSvQzo4NhNuOG1rTVovQYjl0pMLfVk/ULO08RmDv9mKTg3j176Sl59IqK pZH8dhhbNMijdZ/Qvg5h10+uXt+xcX84hupxAR3hQ+Ebrvv7nk/iSQAqRG9B1RO8PmfR2zD26z6 Su7UahHjiw0+LhBb3fR+hmpm9JikUCQLjLe2auAlGnnGqfnDEKnlWhfp9c8nOXEkVQFaagzsoj5 8dopQNBtioj/zoevnceux37pAROk6iPq186WcaqzGoAX9Y4kXpMloZw4q5HdVl0OzXHbcC0TqXw Iu90mUE8kjWAwOuIuztdDJBwWG5ODROiX4xjfexCUFcaKitNRWToBY8Bf6Dgut+Pu6v08nNaNwY AVrLTTberAjZDWQu8XpWo69DV+WkqRBZDtpiQ1KFObH+HtJOf4/NtPMVGJZC36tNgUgUjJx2L9 X-Received: by 2002:a05:600c:350b:b0:485:3f58:da2 with SMTP id 5b1f17b1804b1-486fe8fcf64mr7383985e9.16.1773947441003; Thu, 19 Mar 2026 12:10:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Paolo Bonzini , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-11.1 3/8] system/memory: Constify various AddressSpace arguments (xlat) Date: Thu, 19 Mar 2026 20:10:12 +0100 Message-ID: <20260319191017.12636-4-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319191017.12636-1-philmd@linaro.org> References: <20260319191017.12636-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773947493146154100 Mark the AddressSpace structure const when it is only accessed read-only. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- include/system/memory.h | 4 ++-- system/physmem.c | 10 ++++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/include/system/memory.h b/include/system/memory.h index 858dc40dc5f..38e4f7b25e5 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -2783,7 +2783,7 @@ void address_space_flush_icache_range(AddressSpace *a= s, hwaddr addr, hwaddr len) /* address_space_get_iotlb_entry: translate an address into an IOTLB * entry. Should be called from an RCU critical section. */ -IOMMUTLBEntry address_space_get_iotlb_entry(AddressSpace *as, hwaddr addr, +IOMMUTLBEntry address_space_get_iotlb_entry(const AddressSpace *as, hwaddr= addr, bool is_write, MemTxAttrs attr= s); =20 /* address_space_translate: translate an address range into an address spa= ce @@ -2804,7 +2804,7 @@ MemoryRegion *flatview_translate(FlatView *fv, hwaddr *len, bool is_write, MemTxAttrs attrs); =20 -static inline MemoryRegion *address_space_translate(AddressSpace *as, +static inline MemoryRegion *address_space_translate(const AddressSpace *as, hwaddr addr, hwaddr *x= lat, hwaddr *len, bool is_w= rite, MemTxAttrs attrs) diff --git a/system/physmem.c b/system/physmem.c index 23ea6b69255..bbcbcedda15 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -528,19 +528,21 @@ static MemoryRegionSection flatview_do_translate(Flat= View *fv, } =20 /* Called from RCU critical section */ -IOMMUTLBEntry address_space_get_iotlb_entry(AddressSpace *as, hwaddr addr, +IOMMUTLBEntry address_space_get_iotlb_entry(const AddressSpace *as, hwaddr= addr, bool is_write, MemTxAttrs attr= s) { MemoryRegionSection section; hwaddr xlat, page_mask; + AddressSpace target_as =3D *as; + AddressSpace *ptarget_as =3D &target_as; =20 /* * This can never be MMIO, and we don't really care about plen, * but page mask. */ section =3D flatview_do_translate(address_space_to_flatview(as), addr,= &xlat, - NULL, &page_mask, is_write, false, &as, - attrs); + NULL, &page_mask, is_write, false, + &ptarget_as, attrs); =20 /* Illegal translation */ if (section.mr =3D=3D &io_mem_unassigned) { @@ -552,7 +554,7 @@ IOMMUTLBEntry address_space_get_iotlb_entry(AddressSpac= e *as, hwaddr addr, section.offset_within_region; =20 return (IOMMUTLBEntry) { - .target_as =3D as, + .target_as =3D &target_as, .iova =3D addr & ~page_mask, .translated_addr =3D xlat & ~page_mask, .addr_mask =3D page_mask, --=20 2.53.0 From nobody Sun Mar 22 14:10:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773947466; cv=none; d=zohomail.com; s=zohoarc; b=YyOKWqQtyDQynB6jr3YI+jVBzAOWVtHjc7U9raoosMAnIpvRgtQg6izD9FeIO6/IfWyJFeqeew/m5LAzVDZU3AqFjXlidaIDnpbLGPox3HCimiIDORFYCaCDypKduAc2IqJcr2qmrr7B6wdzjDi3ZDOuajEjind+dqHzVfkwW9M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773947466; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GAJHgYrXKXC/iSuIeaBrhrwLYoHDHxYVlnJ8I9GtCSY=; b=bUg5wx9WJH2bAOeyevQ+FK7mMCRnqUvBVjTQWaaZgsOAV3tKnrKblP+tIelSiIQ4Lu+LALsbkQaMN/3x1zlKu1AtFqOjIbG6ymilYjpMvLbKxAkOMs+IOxJP10BVlC+jG/29lz3/80JOqcY8c2WcyBUPdKhqnEasgZg7mjz2bDQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773947466752246.29689373250994; Thu, 19 Mar 2026 12:11:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3Ilh-0000AS-IR; Thu, 19 Mar 2026 15:10:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3Ilf-0000AG-Uf for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:10:51 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3Ile-0008So-0N for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:10:51 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-48538c5956bso11594945e9.0 for ; Thu, 19 Mar 2026 12:10:49 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe6d91fbsm8499575e9.3.2026.03.19.12.10.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 12:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773947448; x=1774552248; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GAJHgYrXKXC/iSuIeaBrhrwLYoHDHxYVlnJ8I9GtCSY=; b=N9Yyn2WWsPuVAvenX+2eX+eGVrsknGP52yRf/3ddBXsWn0KKJehH/lWyX5/32CKUiQ 1aU0fZ7y2iI8kdncGkSqEPAg630sSYZQMlKYMHASQfHDTflJBmZ9meMb0Y8+mal53lKn aIHq15ldAxx3pNXzYW+8ZtLDKutuGECNMxlQJ18F3FWeH+U0ESOuBVKpsPJQdTX/pNwz 8Ga2+AubYeJCcXIgjmsdM9R2d5O2tgb3akUbHohp+pdniGGQrxWH1BNuhjqZDmozC+/7 9KV5wU4rNGSxzTFIGCoa2S2St5aqBPsSFCYZBsnPLm6O5eoXjB1JiuhH/I152pXLodj2 CVlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773947448; x=1774552248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GAJHgYrXKXC/iSuIeaBrhrwLYoHDHxYVlnJ8I9GtCSY=; b=an0qqO3AKQ7VJ9QdUsp6LSgmyAg2wRitaM0ombLN0e7Bxd94InmY/AgDE4yuKiiYh0 BfUJCz6MONJ+PiMuwnpA8sy1fsE1LQXKkoybVb/v7qTrUz9Nz50RJMSREEkg6+vs4hGU la4WUgZ/jiMLQMtSC1QlVtl/HVJbGc+WcsfvvxRtCsUtHm2h7shzGH2KgWq+4BmGBR7j h3EKSkvelo87vrHq9jBCmBSYXQHtXiovN3MOQ5M+xS0Aqkaqldog2tUnW8sZStqsbGMJ FrILUDJzignlLQILvVhs0MtaYIvAWU5RbZ1bpOwYNnn8MB1XYVThd9SjLNuFinzaMwtS 84wg== X-Gm-Message-State: AOJu0Yybf/Vcd5ch2l8VZcjFs04Pr6Bv/GfZi8IOogOn4VgXe3AcxLfw pOtR2S4mROKSFwgkLeYisTbqfw4T4iOQa1GApBvgjCR9lLLnK2zjF0YGY3MYKkAam+ew+Wq3Sn5 26270NS8= X-Gm-Gg: ATEYQzwKbn+8t3hHUfsPhWEMqD7EyESN9oFdRPKvhSoTvvyeJMXa7i4HVIKW4bLh2dY fiKGyvWPdu38bq8XsZpYA4gEqwPmsZEbUxARgjnQMrT+TG/gPcMAiMLjsLRh/V/2wUEFWKQszT2 T2hGMzq017IUZKvhF1fM7D/DhYNp7kzyhPhf8mL63ayXKZVjSGCXNQUmExg2PiNYYgTOuSwllSi xFDGzK9v+ANYa+ieGGMR0A1QN/pxvUXZDIsuqByKkkiOv4O9lP+IArB95e4M80AJsPDqvq1vtZZ yBmGBfTADwC0oIL1mshBFWkw28pnCUhTf4YtS3YspYOQYzzjw2Ra+/SQAby4LQotYo0na3xfNUf UOT5R3F0ENG+joC9qV/tnWLHOuTP9Zyj13q6YLoCKO6Ly3XYLei/pLUZ/NVRcPp42Cf/XY7HCOL 1d0GgS2Pwsqoh6hW/hZw9cAm9lalbP1gf1XpESvJ9C0zZbCb+DkxER2Sm559Dajc7Lhh31IQOs X-Received: by 2002:a05:600c:3e10:b0:485:3428:774c with SMTP id 5b1f17b1804b1-486fe8b0073mr8736885e9.4.1773947447852; Thu, 19 Mar 2026 12:10:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Paolo Bonzini , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-11.1 4/8] system/memory: Constify various AddressSpace arguments (flat-range) Date: Thu, 19 Mar 2026 20:10:13 +0100 Message-ID: <20260319191017.12636-5-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319191017.12636-1-philmd@linaro.org> References: <20260319191017.12636-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773947468963154100 Mark the AddressSpace structure const when it is only accessed read-only. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- system/memory.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/system/memory.c b/system/memory.c index bd12184a879..87ebeb93458 100644 --- a/system/memory.c +++ b/system/memory.c @@ -888,7 +888,8 @@ static void address_space_update_ioeventfds(AddressSpac= e *as) * range `cmr'. Only the part that has intersection of the specified * FlatRange will be sent. */ -static void flat_range_coalesced_io_notify(FlatRange *fr, AddressSpace *as, +static void flat_range_coalesced_io_notify(FlatRange *fr, + const AddressSpace *as, CoalescedMemoryRange *cmr, bool= add) { AddrRange tmp; @@ -912,7 +913,7 @@ static void flat_range_coalesced_io_notify(FlatRange *f= r, AddressSpace *as, } } =20 -static void flat_range_coalesced_io_del(FlatRange *fr, AddressSpace *as) +static void flat_range_coalesced_io_del(FlatRange *fr, const AddressSpace = *as) { CoalescedMemoryRange *cmr; =20 @@ -921,7 +922,7 @@ static void flat_range_coalesced_io_del(FlatRange *fr, = AddressSpace *as) } } =20 -static void flat_range_coalesced_io_add(FlatRange *fr, AddressSpace *as) +static void flat_range_coalesced_io_add(FlatRange *fr, const AddressSpace = *as) { MemoryRegion *mr =3D fr->mr; CoalescedMemoryRange *cmr; @@ -939,7 +940,8 @@ static void flat_range_coalesced_io_notify_listener_add_del(FlatRange *fr, MemoryRegionSection *mrs, MemoryListener *listener, - AddressSpace *as, bool add) + const AddressSpace *as, + bool add) { CoalescedMemoryRange *cmr; MemoryRegion *mr =3D fr->mr; --=20 2.53.0 From nobody Sun Mar 22 14:10:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773947486; cv=none; d=zohomail.com; s=zohoarc; b=X27VrlKA8Ca3n3hqShV3/UNGVyfbTOClgHXRfG2HTi3shOghJdE73uxhj6i5pN9pI+iUsEyJz65IGpR6fBnCCm/R9GbFmNOiY5cKH5CjsczRhDke2I8KDtK3T5h+OiDc5p1mHp5bGNdwINf9Gs3MAk0cHt/DGNvkrncRR8Mvfvc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773947486; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eayvJ5Zp7NdtS6KVYiYLFGGBY/XbYTEjOUNmnHg50PU=; b=WTBLsd1MlgkbGusVZ8B8NZEBD7oIEXQLVE5OpvaVkB69IaRpHRzVU+OAhdnHfclZeEfJMVKcpr/tjTdlRgkcrchUa5sKqpKSrQFXy32XYSUbA9eNBF4dQQxOE1Rg5C7sWQ76bdT3JNbsvZbvX3dZtl43BwjqCCNd3hRt2nmCdd4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773947486452974.6666009602632; Thu, 19 Mar 2026 12:11:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3Ilp-0000Bk-4b; Thu, 19 Mar 2026 15:11:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3Ilm-0000BM-K4 for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:10:58 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3Ilk-0008U1-SS for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:10:58 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-48541edecf9so14067465e9.1 for ; Thu, 19 Mar 2026 12:10:56 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe6d9896sm9506265e9.2.2026.03.19.12.10.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 12:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773947455; x=1774552255; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eayvJ5Zp7NdtS6KVYiYLFGGBY/XbYTEjOUNmnHg50PU=; b=gbIi66VoGN5yePlyC+MJv7jjFNZTMFuLUd15Y7Vcw+jYpOTQjoyUAIJIs9sDwG60yM BlHmJETkLVdybuVudrx5jDnupH7S37884klZXdVOruHE+geaEom9KzJ28A5JusY9QqLE VZTdhBBb6eU8lsSKNhB9eoKl5c3zM07hkvBctQYdVdf0DMvNtin5iIvHg90+OTZUgkHU 0MoGVA2q2IteBR10X6+h5ctBCDu25cI4KKa0z521gR2Aay8V6U3avvJMciefDTksdT3d sn6uWf6KTbOZIlUdU6yfsIZaT3yLjXsdSWWMoV0v2bVZJJEZPt3PEWxlA/CZn1IDYU3D V1+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773947455; x=1774552255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eayvJ5Zp7NdtS6KVYiYLFGGBY/XbYTEjOUNmnHg50PU=; b=Q9IYlIKML+n3nfOhnlbncckZfi1d0+ZzhaACbWnUnvNf5Y7gp5YLsBXKUEba/g2NvS xC0pOV6hsTadSsDL8ShRX0+b0Edrj+T3kkhlryYCUxUhrKgmspiVFbFS95mvyqNS2s2w 2nk80Rgr26Tv6+nd+/BeirxTFoJUYF1h3JGIjSO4htjl/pa5WTOkBw07neE2h3ch5yZL TdBRnCOMPJ9p9sasnJggCIfDJYGlj7FzBHb5b7nMvPWuCKPuTFGpD4F6rdDcymw336V6 Td1BhuiUZnQWeiWcaqacAKzkjXbolld1RCXxnOe6uK/rlGOcIQ2H/bOHvmQ7J1b3nq+B tkKQ== X-Gm-Message-State: AOJu0Yx+p59SHU+EecOxf9gBl9F+tw3rRHiwUacjHcY/a48cMv1ySA+o Fa5UD1Ju0nksNIr2C7WtXcaCtBXYUV5AuUaNj/BMXAX2yfRZETeqvx78Vvr1XfqrBU3/SjgPETO YKrulMJo= X-Gm-Gg: ATEYQzztBmNdLmqqbZGYrw+UtOZ86PTOHl7lPEhbAzsMl4GHd2OO37Jwzp0HDER7L7X QZV6ycbA1/4AgoC2Nclae8M/x9xaHLShPYH2BppENox851JGVdk0UfwCs3Tl45SW+KFaPzipIKp MPaDZXRjJXzcBbdoDpwXAqlQpBZSWL1HjpD2D9ALuRHOF9a1Q52Ptp8ki75I/q1+hZiDeL7ffTe FVADudVe96Wk12UNbGw/BTSKGm4qJ4KqO0jwG4zYgCENXH4As30FufBZUAL1ci6s9wkH5/wMsRP 04ZKznIcXVvKMwNqJXl/749heoc3kAhgR67xtBVF/WR5aVMEygjFkA/SDMH5qSZCfnZ0GUUR7Jw KWDpQ5Sp67eRPA1UuMzqqpwYp79ve5T174EQNJGKNjL2l9751RQA1fKpte+ASt96QOVqJdOnZTF f/kw21WJznt4yTnGUDax0tMBdyicGrjwqjAFPwpkqKg92jZE/MrZbl+LjvMBJBy0hALz77YRK0 X-Received: by 2002:a05:600c:8711:b0:485:3f58:d9f with SMTP id 5b1f17b1804b1-486ff029008mr3708615e9.30.1773947454801; Thu, 19 Mar 2026 12:10:54 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Paolo Bonzini , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-11.1 5/8] system/memory: Constify various AddressSpace arguments (notify) Date: Thu, 19 Mar 2026 20:10:14 +0100 Message-ID: <20260319191017.12636-6-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319191017.12636-1-philmd@linaro.org> References: <20260319191017.12636-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773947488895154100 Mark the AddressSpace structure const when it is only accessed read-only. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- include/system/memory.h | 2 +- system/memory.c | 6 +++--- system/physmem.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/system/memory.h b/include/system/memory.h index 38e4f7b25e5..4c013593cae 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -2682,7 +2682,7 @@ void address_space_destroy_free(AddressSpace *as); * * @as: an initialized #AddressSpace */ -void address_space_remove_listeners(AddressSpace *as); +void address_space_remove_listeners(const AddressSpace *as); =20 /** * address_space_rw: read from or write to an address space. diff --git a/system/memory.c b/system/memory.c index 87ebeb93458..40e17ed22c6 100644 --- a/system/memory.c +++ b/system/memory.c @@ -2978,7 +2978,7 @@ void memory_global_dirty_log_stop(unsigned int flags) } =20 static void listener_add_address_space(MemoryListener *listener, - AddressSpace *as) + const AddressSpace *as) { unsigned i; FlatView *view; @@ -3043,7 +3043,7 @@ static void listener_add_address_space(MemoryListener= *listener, } =20 static void listener_del_address_space(MemoryListener *listener, - AddressSpace *as) + const AddressSpace *as) { unsigned i; FlatView *view; @@ -3148,7 +3148,7 @@ void memory_listener_unregister(MemoryListener *liste= ner) listener->address_space =3D NULL; } =20 -void address_space_remove_listeners(AddressSpace *as) +void address_space_remove_listeners(const AddressSpace *as) { while (!QTAILQ_EMPTY(&as->listeners)) { memory_listener_unregister(QTAILQ_FIRST(&as->listeners)); diff --git a/system/physmem.c b/system/physmem.c index bbcbcedda15..c00f75bf591 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3573,7 +3573,7 @@ address_space_unregister_map_client_do(AddressSpaceMa= pClient *client) g_free(client); } =20 -static void address_space_notify_map_clients_locked(AddressSpace *as) +static void address_space_notify_map_clients_locked(const AddressSpace *as) { AddressSpaceMapClient *client; =20 --=20 2.53.0 From nobody Sun Mar 22 14:10:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773947487; cv=none; d=zohomail.com; s=zohoarc; b=XmWuNZKilo6QpcTYLcxLlqeoM08LFAuxvzusoLBTlSECQuRMOdXC8YrJcONffx9ClS2ZPk/zuW88mevLzC/S2JJmn7ZOVaA1TViQnNkK+/CfKiPOIDvOt86N/hiFYnY4lZ1uYOyvFz1yK52CNLNH//9aNDaQCnP8PGRYRKtbUq0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773947487; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=08aoZn44HcdaHVUd8YP+7Dk3Itjd86OK4YNsod7wDRU=; b=JYzHV+gvzmaBIcL2DNVr2gMlt7RES6kdwhPTdIJ26OaP6qQmiCVxWm25AN9lwTCdne4n0odKNtKyMxMACdBTU/qD0ayaJmHOaleZ/ZucFLNFgp69CyEvQhWpogu209x3f1dOsXJu03KEnfHma9+rxc7rQgDl+Ln0rqtaQbBo9hY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773947486992215.25191397248727; Thu, 19 Mar 2026 12:11:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3Im2-0000KH-Vd; Thu, 19 Mar 2026 15:11:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3Ilv-0000HG-7V for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:11:08 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3Ils-0008Uh-Kg for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:11:06 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-486fd5360d4so7124905e9.1 for ; Thu, 19 Mar 2026 12:11:03 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe68ec05sm18822185e9.0.2026.03.19.12.11.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 12:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773947462; x=1774552262; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=08aoZn44HcdaHVUd8YP+7Dk3Itjd86OK4YNsod7wDRU=; b=nYknbXY2HiDYqjRmq5SDw5gfAeuj9RSUmUPByYR1azGI4LneKhpx1z6J6CCJXbqTct GjUW1Ar8MKCufpHJYpLD18Mn06c/t13XT4wY5CFWXqlnrQC8GkZV9iJMBCfWkxTXf0RI Hf3nWpDsKYXVgYx+Zgpm5goq+ZfuUYPjceHcZdxeNelqDoqqywCwpMEyi0Qu+8QheP8f ePLkXBVRv89wCB47Xi+eSEkZqn+8ja33UgyEUs+FKLduetZcC0OMpaFhezwEZSvJJbub jPR5l/2m4By/V/TgC0eBDLMxEe53usnDa+rOSM0E9WL/Bo/SYYIb78XdV7PLdjHAM++9 tyMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773947462; x=1774552262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=08aoZn44HcdaHVUd8YP+7Dk3Itjd86OK4YNsod7wDRU=; b=XSG6yn5XHt3jnK+AXKCy1TfnpFbqFKp5lmjibvXF9I1VsFbImRv42wYYbDEEsoMh/L rqwvNDIGkqq08TcST1BGxr7E5yOwmAC25at2gDTN0h3sUTI7KAPmXo42EUY1r9inRadb FQXEa3fhv6PuDNtx7pTl8i+/k7qXofrqGMT23jIjtUrFfehSbuoI4ZOC0fdlWL4izwVs URWBoKehl9M9Kp+cIzKuOkopzwakdGO/Sxx7ZlPTjZ56D1RytL54qUf3PU/aMcomQq/T JKq41SxdLs9NxoaiTp+aqftvdfZcOLRmjCA0i6nLqZ3JHdsrVj0SQstjMdojb6DNJxI7 j7zA== X-Gm-Message-State: AOJu0YzSiK5tR1UT1onZ0hhFbkZzMN1zreAqVFUITdhZKBQMcF+qYErq 4pJDpvdqd31aEt38hcDjM2+OOuQuE3xhB6k58E3vomDkRYVMnALyRkxQmVf/YevF/2/sM7ouSDA 9i2ONNog= X-Gm-Gg: ATEYQzwcE0v4A8mlhWQSqBwackgsriGE/R32+JLPA4SsuN8Y51w54pLeaZRARfoyVef lF6OMl8E/9qhFZW1E1xaxZMxVI0q1lfuarHFWHwG55ifFEdRrbl9ftea3pPWRaKhwQpDnUriBm0 RylAGtfM8E4r4aAU/jBorfeKCcPHXOvdBQxQtU5CRZMZ4MZKI/Tvmr6OVuby+fARcnJ86m5WaOA KcbP8k2NrTlNS09yHDDIj0qVW/4jDhDHXDClzy6TzKhCPA6Bk55HJ7ZKeuOZ5HI9HlFcg0sVGNE CxMPMy/niCM7gH1b42FZ7dDZSbxVcQNT6isHAYE+vH9eJVrkga1rEDrkgfatwsBAImBTiEuHUts 4upTC3uYz3TmsDz3sw3uykv5Wp0NiIBpT1LFIKXQ3nyUvb/WBuPiK9IfO3ZDfKXwbBSnDSashCg LM3h+y/NWQkJsFfwWPFsm0LhIXqPN7ru4bMo/lkZxHpuZKwumlPy8Wmx25WILpPAkihXuEeoci X-Received: by 2002:a05:600c:a4a:b0:485:4eaf:eb14 with SMTP id 5b1f17b1804b1-486fee0fbf6mr3717685e9.21.1773947461624; Thu, 19 Mar 2026 12:11:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Paolo Bonzini , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-11.1 6/8] system/memory: Constify various AddressSpace arguments (cache) Date: Thu, 19 Mar 2026 20:10:15 +0100 Message-ID: <20260319191017.12636-7-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319191017.12636-1-philmd@linaro.org> References: <20260319191017.12636-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773947487717158500 Mark the AddressSpace structure const when it is only accessed read-only. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- include/system/memory_cached.h | 2 +- system/physmem.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/system/memory_cached.h b/include/system/memory_cached.h index 6eb6179140b..760ecb38c19 100644 --- a/include/system/memory_cached.h +++ b/include/system/memory_cached.h @@ -117,7 +117,7 @@ void address_space_stb_cached(MemoryRegionCache *cache, * are relative to @addr. */ int64_t address_space_cache_init(MemoryRegionCache *cache, - AddressSpace *as, + const AddressSpace *as, hwaddr addr, hwaddr len, bool is_write); diff --git a/system/physmem.c b/system/physmem.c index c00f75bf591..b7280e74aa2 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3837,7 +3837,7 @@ void cpu_physical_memory_unmap(void *buffer, hwaddr l= en, #include "memory_ldst.c.inc" =20 int64_t address_space_cache_init(MemoryRegionCache *cache, - AddressSpace *as, + const AddressSpace *as, hwaddr addr, hwaddr len, bool is_write) --=20 2.53.0 From nobody Sun Mar 22 14:10:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773947486; cv=none; d=zohomail.com; s=zohoarc; b=NQWlBmLHhwRSFcz2XijIGwYicUwQcAxTMzPeh1cbDSf/6oxIk/0VhVW/DcQyx6VRLviOvyjVMAJ+57bkDXkcPihgzKfCuNSgUjQ+qqNIlckzCayf3oBI3cgsvHtdMK61m0obPNVbMP/Q8A56OWqHVCzyeSPW6xte/JKKz639nAg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773947486; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Z8aNR9y2E9n4ZOiMZCdLhmicb9NfofciJCxllCBGqfg=; b=ClVD+SmIOhSflXmSa6sCHl4S503TBCCHalciMTHHDofYjINQg/0LPC2A8BBB0K+ADNZTPe7AQfhvWKQ+taBTk9x0PCFaTEpOl+5tViiwl2ydpQ/FToMav9y+94yYYV4yM0M5WWsEL1EDlVMIYZ+fvSJbA2Aj/+G0NDL2aRLY6EQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773947486883969.1814021007132; Thu, 19 Mar 2026 12:11:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3Im6-0000c1-6j; Thu, 19 Mar 2026 15:11:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3Im1-0000KD-3b for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:11:14 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3Ilz-0008VQ-0N for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:11:12 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-439c56e822eso1272702f8f.2 for ; Thu, 19 Mar 2026 12:11:10 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6470380asm637590f8f.24.2026.03.19.12.11.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 12:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773947469; x=1774552269; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z8aNR9y2E9n4ZOiMZCdLhmicb9NfofciJCxllCBGqfg=; b=jiGSIUuM3Tm+S/sjUWoBD6JgoQ3WNHdTUhBYWgpHu3vK/aUBtid/nNNFXEAVwvhZVM MWIqaKrXED1u2N72bjWlPcZbzOSeV8dbxvwkHfJ0QuR5vqgzoXgulLkltHYeZHMSQAfl XkKXO7Ax5tJMXaZHRI3Rz9++TW2BJhD4y7g6L0/Pi5ljPoW59J4nIMj8WE4RpsWKhilf fsKgg7SfjUBReAd+DdZ0ixus9m1SSiAw70s0b14OfoRLlL0HB0W561ZdnCTQYVWujdTk 6qCqr2iqCw/i0MrYACe8sOAq0nXBGO2uV1i0dHnLgFKy+a66iCniu+RSFwJ6actfZhmk 1KNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773947469; x=1774552269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z8aNR9y2E9n4ZOiMZCdLhmicb9NfofciJCxllCBGqfg=; b=XqVe8df5CotdpHoGCgI95rTzowrS5TgoFcKfmz4Em7jObDA/XOI+WmPS9fi7Qsp596 P8Ncq/xeZKFXrDIQ19aRViVz2A9a875EHDMQD6+L4wGaFhghI82ZrSpuFb64d+4HS8CI 5lLp6wLM4Me4R48ohKp9yuRpqiS4n2JuID3BEZSFBZTOOGMryZjW/lLiWjOFnv2inTP2 nXqgbEj0TmVpPyJM/Sh6n5b7fLQEgOB7GrrNja5oTq2v6H3XYgdV26tloLjh3pqgZlRq NzoGHXVRRSI1itemaXLx6sHvxUXIYLPVVWVKLSBvd60NemEV2cfOo7lSA/I16Z4dnv0R hfRg== X-Gm-Message-State: AOJu0YwCM0sFZJ1b7utnz0ChH05wUF1fhOdK8IltA+nO2qLTWawW4FM4 +yf0USX1Y6OgmS8bKNDjH1rdD71ks14utnUYO8BqCwpKNH28fh+wcsT6vMsXh3aJTaU08WQeGA4 QLiZewWw= X-Gm-Gg: ATEYQzxR0gZPelREIf7H/m0iER7dcn2iL1GeNlZA805IXeH6U1clO0R+JzqqW6lK+qr LOl3+OmkdeDBfUUBphIukI4oZ95dYbTT7Y0uxVFugLW/o1zecbawYUlndssMkSrEWTgAmOXjuNV iT897cFpg72TUrBTCIRfyv8wdSyfPBVrDbZ8ql7CCoOkyHg747C64AGp2Y9xOF8CXEyOtbeQxMP jkDNJT1IjEv2c5tN1X5eu/9T7+MVu1TNJmBF+g4a2BCOSWQ/MfDMDMVTAdySFiBl1M1M73qML4p 96ANbXnIUvvu/5EoS0GQdJciIY6esHf+pNM1s0Cqf1XR4kWrgOzCl4NqHjO8xTOcjUafN/tlKWQ 0A8dUG6OVCRL5dALsJkBiFx0Aa716gznNfegb4r2HPEXGWZOBOCB+ELTs12ZD0zlIvkQYFDBu5E zUSmq4Yk+XDb9XPRlqN+DtmAu/ViDFDmkdQGRY/icON2wAf79r8pANbvMNT3awzDS4yVRbVpeb X-Received: by 2002:a05:6000:4013:b0:439:c2b6:d5d8 with SMTP id ffacd0b85a97d-43b64278337mr793064f8f.36.1773947468809; Thu, 19 Mar 2026 12:11:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Paolo Bonzini , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-11.1 7/8] system/memory: Constify various AddressSpace arguments (access) Date: Thu, 19 Mar 2026 20:10:16 +0100 Message-ID: <20260319191017.12636-8-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319191017.12636-1-philmd@linaro.org> References: <20260319191017.12636-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773947487791158500 Mark the AddressSpace structure const when it is only accessed read-only. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- include/system/memory.h | 19 ++++++++++--------- system/physmem.c | 16 +++++++++------- 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a/include/system/memory.h b/include/system/memory.h index 4c013593cae..564b94f1448 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -2698,7 +2698,7 @@ void address_space_remove_listeners(const AddressSpac= e *as); * @len: the number of bytes to read or write * @is_write: indicates the transfer direction */ -MemTxResult address_space_rw(AddressSpace *as, hwaddr addr, +MemTxResult address_space_rw(const AddressSpace *as, hwaddr addr, MemTxAttrs attrs, void *buf, hwaddr len, bool is_write); =20 @@ -2715,7 +2715,7 @@ MemTxResult address_space_rw(AddressSpace *as, hwaddr= addr, * @buf: buffer with the data transferred * @len: the number of bytes to write */ -MemTxResult address_space_write(AddressSpace *as, hwaddr addr, +MemTxResult address_space_write(const AddressSpace *as, hwaddr addr, MemTxAttrs attrs, const void *buf, hwaddr len); =20 @@ -2741,7 +2741,7 @@ MemTxResult address_space_write(AddressSpace *as, hwa= ddr addr, * @buf: buffer with the data transferred * @len: the number of bytes to write */ -MemTxResult address_space_write_rom(AddressSpace *as, hwaddr addr, +MemTxResult address_space_write_rom(const AddressSpace *as, hwaddr addr, MemTxAttrs attrs, const void *buf, hwaddr len); =20 @@ -2768,17 +2768,18 @@ MemTxResult address_space_write_rom(AddressSpace *a= s, hwaddr addr, =20 #define SUFFIX #define ARG1 as -#define ARG1_DECL AddressSpace *as +#define ARG1_DECL const AddressSpace *as #include "system/memory_ldst.h.inc" =20 #ifndef TARGET_NOT_USING_LEGACY_LDST_PHYS_API #define SUFFIX #define ARG1 as -#define ARG1_DECL AddressSpace *as +#define ARG1_DECL const AddressSpace *as #include "system/memory_ldst_phys.h.inc" #endif =20 -void address_space_flush_icache_range(AddressSpace *as, hwaddr addr, hwadd= r len); +void address_space_flush_icache_range(const AddressSpace *as, + hwaddr addr, hwaddr len); =20 /* address_space_get_iotlb_entry: translate an address into an IOTLB * entry. Should be called from an RCU critical section. @@ -2898,7 +2899,7 @@ void address_space_register_map_client(AddressSpace *= as, QEMUBH *bh); void address_space_unregister_map_client(AddressSpace *as, QEMUBH *bh); =20 /* Internal functions, part of the implementation of address_space_read. = */ -MemTxResult address_space_read_full(AddressSpace *as, hwaddr addr, +MemTxResult address_space_read_full(const AddressSpace *as, hwaddr addr, MemTxAttrs attrs, void *buf, hwaddr le= n); MemTxResult flatview_read_continue(FlatView *fv, hwaddr addr, MemTxAttrs attrs, void *buf, @@ -2953,7 +2954,7 @@ static inline bool memory_access_is_direct(const Memo= ryRegion *mr, * @len: length of the data transferred */ static inline __attribute__((__always_inline__)) -MemTxResult address_space_read(AddressSpace *as, hwaddr addr, +MemTxResult address_space_read(const AddressSpace *as, hwaddr addr, MemTxAttrs attrs, void *buf, hwaddr len) { @@ -2996,7 +2997,7 @@ MemTxResult address_space_read(AddressSpace *as, hwad= dr addr, * @len: the number of bytes to fill with the constant byte * @attrs: memory transaction attributes */ -MemTxResult address_space_set(AddressSpace *as, hwaddr addr, +MemTxResult address_space_set(const AddressSpace *as, hwaddr addr, uint8_t c, hwaddr len, MemTxAttrs attrs); =20 /* Coalesced MMIO regions are areas where write operations can be reordere= d. diff --git a/system/physmem.c b/system/physmem.c index b7280e74aa2..8327b7c3de1 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3424,7 +3424,7 @@ static MemTxResult flatview_read(FlatView *fv, hwaddr= addr, mr_addr, l, mr); } =20 -MemTxResult address_space_read_full(AddressSpace *as, hwaddr addr, +MemTxResult address_space_read_full(const AddressSpace *as, hwaddr addr, MemTxAttrs attrs, void *buf, hwaddr le= n) { MemTxResult result =3D MEMTX_OK; @@ -3439,7 +3439,7 @@ MemTxResult address_space_read_full(AddressSpace *as,= hwaddr addr, return result; } =20 -MemTxResult address_space_write(AddressSpace *as, hwaddr addr, +MemTxResult address_space_write(const AddressSpace *as, hwaddr addr, MemTxAttrs attrs, const void *buf, hwaddr len) { @@ -3455,7 +3455,8 @@ MemTxResult address_space_write(AddressSpace *as, hwa= ddr addr, return result; } =20 -MemTxResult address_space_rw(AddressSpace *as, hwaddr addr, MemTxAttrs att= rs, +MemTxResult address_space_rw(const AddressSpace *as, + hwaddr addr, MemTxAttrs attrs, void *buf, hwaddr len, bool is_write) { if (is_write) { @@ -3465,7 +3466,7 @@ MemTxResult address_space_rw(AddressSpace *as, hwaddr= addr, MemTxAttrs attrs, } } =20 -MemTxResult address_space_set(AddressSpace *as, hwaddr addr, +MemTxResult address_space_set(const AddressSpace *as, hwaddr addr, uint8_t c, hwaddr len, MemTxAttrs attrs) { #define FILLBUF_SIZE 512 @@ -3497,7 +3498,7 @@ void cpu_physical_memory_write(hwaddr addr, const voi= d *buf, hwaddr len) } =20 /* used for ROM loading : can write in RAM and ROM */ -MemTxResult address_space_write_rom(AddressSpace *as, hwaddr addr, +MemTxResult address_space_write_rom(const AddressSpace *as, hwaddr addr, MemTxAttrs attrs, const void *buf, hwaddr len) { @@ -3522,7 +3523,8 @@ MemTxResult address_space_write_rom(AddressSpace *as,= hwaddr addr, return MEMTX_OK; } =20 -void address_space_flush_icache_range(AddressSpace *as, hwaddr addr, hwadd= r len) +void address_space_flush_icache_range(const AddressSpace *as, + hwaddr addr, hwaddr len) { /* * This function should do the same thing as an icache flush that was @@ -3828,7 +3830,7 @@ void cpu_physical_memory_unmap(void *buffer, hwaddr l= en, return address_space_unmap(&address_space_memory, buffer, len, is_writ= e, access_len); } =20 -#define ARG1_DECL AddressSpace *as +#define ARG1_DECL const AddressSpace *as #define ARG1 as #define SUFFIX #define TRANSLATE(...) address_space_translate(as, __VA_ARGS__) --=20 2.53.0 From nobody Sun Mar 22 14:10:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773947499; cv=none; d=zohomail.com; s=zohoarc; b=YVoCP68fhAh4+jn8J2Nd5Gj4kAa2vzAhACZ5l20EreFcEkZpfpXkw8NH//dOs+2v7NWMFNF0VDOmDIowhFSD6q7pbSDErFBEyVw69XLrlgXxgOe7XrJeYWe9mIoYwks4ZVP8mLb42nhxmzDvvRwK1hhfpqRXRH6hEWOUIrxpniQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773947499; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jY+N1T2BsnpBnvDoUycX3u016wRXwuuK2JDg3EykmW8=; b=EHw7g/3VklIodyMvxz75FaNRZjXXp6v3lPLp7snWOPxW5SmB0MpRNAsA8UoHFl+HQ2tV6Rvk9FrdUn5n5d8QBeDMONpbnvCOpO2+Ww9HTDNkD9xHJSmTAhIBU4riv7orpLBk4TiqMaOquaNe0Wr1fJgL8H54kKBFPUTKRWgiPQ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773947499301903.8095475216288; Thu, 19 Mar 2026 12:11:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3ImA-0001Aw-OU; Thu, 19 Mar 2026 15:11:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3Im8-0000xt-Qj for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:11:20 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3Im6-0008WL-34 for qemu-devel@nongnu.org; Thu, 19 Mar 2026 15:11:20 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-485392de558so8570305e9.1 for ; Thu, 19 Mar 2026 12:11:17 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64715539sm672366f8f.33.2026.03.19.12.11.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 12:11:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773947476; x=1774552276; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jY+N1T2BsnpBnvDoUycX3u016wRXwuuK2JDg3EykmW8=; b=JVbTYtkhfIAfuziS1XRUnweksIBdfNjq8TbQvPTVbveap4GYBWhjuI1w3j02NsQcWC BlgqZWBbvs6jkRl/ikmaCDNvklxhThtgj8+mP6TnvvQOo5a8ryIi8Zo8tG5iKQluDG7M WUwN4eFjeVbTKlosty28zOZMvIwZJmUMy/WGiNHTUiDN+R32SRNVeRSoyL3Dh6YQiOJi LmxeXCf19WjIGXOIYgsbVGpct2GGrUUxpGUJSryP8FpLdC8uZilFny6UYf7JcuBqOlO+ zdNuiZoCpIKgX6CWklqeaftaYvecKjB+l/4hoRxlTNOLyF+XQmpllwmTC7x+NH84Z7v1 Yxcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773947476; x=1774552276; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jY+N1T2BsnpBnvDoUycX3u016wRXwuuK2JDg3EykmW8=; b=e0Wu+OQGvgeRZvxElJ4qSfS51XGmN2uv9YnJAKZ3+QOYw6hTTlH9RkuxygJXwBUu4H 4WJxolqQUZkOUXPDP0xvxK1NZp6ayv0YEg70WwE3X35OkfGgFoThZjIN0HZcqBbg5cvK YRMU/6V0gCQSeblnxopd9/wgEjF6pw5BMuv39lkYEKKxKdWyJ1riaktzuUjQPb/G7HMV wRJysS1xHXkFv3owAIguIk7L9/o/RWqwO0IabkDfZYzh6dj1dAIGFxusfy3f6IqWE/bT Klu3uhb6VI0hcmkD0CbGC9AkUAyA1sls8gsLmiqjiNSCCA6Fz0osJmQe0UAIf9L5L9gK S58g== X-Gm-Message-State: AOJu0YyNLYekre14ed8kWcttq/6CoX3Swey6Avh7JwU70cgZd5QmYdOE ggrcjKIw3L/2+6gRNVCj2aWYf7fcHDW8LyBydoLyblLC/gmY2jzOAw77qt/oKFKgVb0osaEFORn v5wockso= X-Gm-Gg: ATEYQzwUH3XttY3FWME7tf1xH5I73/OwRMxV2uBA5LPyq2I/9Yoao3BDYR9MrqF5Tp3 NNROe3XfZhasufjcaTDqRHpBXhFWo1amKmq5p+nsGUi9ptHY+JemRi4pQBezsZi/v/JZAXR8Vao 5lGrHzNl9rdElghptHzt5IF/+7RrBLOsF1fhMBofK3XohubuK6iAL8NSK8U6hxaXK6k9C/9Rf4M pwNsy4m6RGQk7krNzCGW/cgJUnVCByI3PTuEhOTjZ3RZcsbV6FIui0FmrsobAK0uspe5VOspsRD +nTTYIUhtYp5HMvACrEfjJlhGB00OR+goqs9uiaxTMq2WmPYiOJdiLIz10oPQ4/0bERRV2oyONY PQvTCXaet40KD3gQRQo4GgBUl9AdehRJNNz3cMSk6322jJz2omF+XSBdANX+gheVM7il0Q5768p VwAnosAGKarFWX5UDtofSaE4WncTnAZoEc54lhogkw3N55f15Ua78W80HDeiu2wUjII5j3oNaH X-Received: by 2002:a05:600c:3b10:b0:485:3f72:3230 with SMTP id 5b1f17b1804b1-486fedcc4d3mr4055415e9.15.1773947476010; Thu, 19 Mar 2026 12:11:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Paolo Bonzini , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-11.1 8/8] system/memory: Constify various MemoryRegionCache arguments Date: Thu, 19 Mar 2026 20:10:17 +0100 Message-ID: <20260319191017.12636-9-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319191017.12636-1-philmd@linaro.org> References: <20260319191017.12636-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773947499909158500 Mark the MemoryRegionCache structure const when it is only accessed read-only. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- include/system/memory_cached.h | 18 +++++++++--------- include/system/memory_ldst_cached.h.inc | 15 +++++++++------ system/physmem.c | 10 +++++----- 3 files changed, 23 insertions(+), 20 deletions(-) diff --git a/include/system/memory_cached.h b/include/system/memory_cached.h index 760ecb38c19..09d46821bec 100644 --- a/include/system/memory_cached.h +++ b/include/system/memory_cached.h @@ -51,12 +51,12 @@ struct MemoryRegionCache { =20 #define SUFFIX _cached_slow #define ARG1 cache -#define ARG1_DECL MemoryRegionCache *cache +#define ARG1_DECL const MemoryRegionCache *cache #include "system/memory_ldst.h.inc" =20 /* Inline fast path for direct RAM access. */ static inline -uint8_t address_space_ldub_cached(MemoryRegionCache *cache, hwaddr addr, +uint8_t address_space_ldub_cached(const MemoryRegionCache *cache, hwaddr a= ddr, MemTxAttrs attrs, MemTxResult *result) { assert(addr < cache->len); @@ -68,7 +68,7 @@ uint8_t address_space_ldub_cached(MemoryRegionCache *cach= e, hwaddr addr, } =20 static inline -void address_space_stb_cached(MemoryRegionCache *cache, +void address_space_stb_cached(const MemoryRegionCache *cache, hwaddr addr, uint8_t val, MemTxAttrs attrs, MemTxResult *result) { @@ -93,7 +93,7 @@ void address_space_stb_cached(MemoryRegionCache *cache, =20 #define SUFFIX _cached #define ARG1 cache -#define ARG1_DECL MemoryRegionCache *cache +#define ARG1_DECL const MemoryRegionCache *cache #include "system/memory_ldst_phys.h.inc" =20 /** @@ -145,7 +145,7 @@ static inline void address_space_cache_init_empty(Memor= yRegionCache *cache) * address that was passed to @address_space_cache_init. * @access_len: The number of bytes that were written starting at @addr. */ -void address_space_cache_invalidate(MemoryRegionCache *cache, +void address_space_cache_invalidate(const MemoryRegionCache *cache, hwaddr addr, hwaddr access_len); =20 @@ -160,9 +160,9 @@ void address_space_cache_destroy(MemoryRegionCache *cac= he); * Internal functions, part of the implementation of address_space_read_ca= ched * and address_space_write_cached. */ -MemTxResult address_space_read_cached_slow(MemoryRegionCache *cache, +MemTxResult address_space_read_cached_slow(const MemoryRegionCache *cache, hwaddr addr, void *buf, hwaddr = len); -MemTxResult address_space_write_cached_slow(MemoryRegionCache *cache, +MemTxResult address_space_write_cached_slow(const MemoryRegionCache *cache, hwaddr addr, const void *buf, hwaddr len); =20 @@ -175,7 +175,7 @@ MemTxResult address_space_write_cached_slow(MemoryRegio= nCache *cache, * @len: length of the data transferred */ static inline MemTxResult -address_space_read_cached(MemoryRegionCache *cache, hwaddr addr, +address_space_read_cached(const MemoryRegionCache *cache, hwaddr addr, void *buf, hwaddr len) { assert(addr < cache->len && len <=3D cache->len - addr); @@ -197,7 +197,7 @@ address_space_read_cached(MemoryRegionCache *cache, hwa= ddr addr, * @len: length of the data transferred */ static inline MemTxResult -address_space_write_cached(MemoryRegionCache *cache, hwaddr addr, +address_space_write_cached(const MemoryRegionCache *cache, hwaddr addr, const void *buf, hwaddr len) { assert(addr < cache->len && len <=3D cache->len - addr); diff --git a/include/system/memory_ldst_cached.h.inc b/include/system/memor= y_ldst_cached.h.inc index d7834f852c4..b4c696bff1f 100644 --- a/include/system/memory_ldst_cached.h.inc +++ b/include/system/memory_ldst_cached.h.inc @@ -24,7 +24,8 @@ #define LD_P(size) \ glue(glue(ld, size), glue(ENDIANNESS, _p)) =20 -static inline uint16_t ADDRESS_SPACE_LD_CACHED(uw)(MemoryRegionCache *cach= e, +static inline +uint16_t ADDRESS_SPACE_LD_CACHED(uw)(const MemoryRegionCache *cache, hwaddr addr, MemTxAttrs attrs, MemTxResult *result) { assert(addr < cache->len && 2 <=3D cache->len - addr); @@ -36,7 +37,8 @@ static inline uint16_t ADDRESS_SPACE_LD_CACHED(uw)(Memory= RegionCache *cache, } } =20 -static inline uint32_t ADDRESS_SPACE_LD_CACHED(l)(MemoryRegionCache *cache, +static inline +uint32_t ADDRESS_SPACE_LD_CACHED(l)(const MemoryRegionCache *cache, hwaddr addr, MemTxAttrs attrs, MemTxResult *result) { assert(addr < cache->len && 4 <=3D cache->len - addr); @@ -48,7 +50,8 @@ static inline uint32_t ADDRESS_SPACE_LD_CACHED(l)(MemoryR= egionCache *cache, } } =20 -static inline uint64_t ADDRESS_SPACE_LD_CACHED(q)(MemoryRegionCache *cache, +static inline +uint64_t ADDRESS_SPACE_LD_CACHED(q)(const MemoryRegionCache *cache, hwaddr addr, MemTxAttrs attrs, MemTxResult *result) { assert(addr < cache->len && 8 <=3D cache->len - addr); @@ -71,7 +74,7 @@ static inline uint64_t ADDRESS_SPACE_LD_CACHED(q)(MemoryR= egionCache *cache, #define ST_P(size) \ glue(glue(st, size), glue(ENDIANNESS, _p)) =20 -static inline void ADDRESS_SPACE_ST_CACHED(w)(MemoryRegionCache *cache, +static inline void ADDRESS_SPACE_ST_CACHED(w)(const MemoryRegionCache *cac= he, hwaddr addr, uint16_t val, MemTxAttrs attrs, MemTxResult *result) { assert(addr < cache->len && 2 <=3D cache->len - addr); @@ -82,7 +85,7 @@ static inline void ADDRESS_SPACE_ST_CACHED(w)(MemoryRegio= nCache *cache, } } =20 -static inline void ADDRESS_SPACE_ST_CACHED(l)(MemoryRegionCache *cache, +static inline void ADDRESS_SPACE_ST_CACHED(l)(const MemoryRegionCache *cac= he, hwaddr addr, uint32_t val, MemTxAttrs attrs, MemTxResult *result) { assert(addr < cache->len && 4 <=3D cache->len - addr); @@ -93,7 +96,7 @@ static inline void ADDRESS_SPACE_ST_CACHED(l)(MemoryRegio= nCache *cache, } } =20 -static inline void ADDRESS_SPACE_ST_CACHED(q)(MemoryRegionCache *cache, +static inline void ADDRESS_SPACE_ST_CACHED(q)(const MemoryRegionCache *cac= he, hwaddr addr, uint64_t val, MemTxAttrs attrs, MemTxResult *result) { assert(addr < cache->len && 8 <=3D cache->len - addr); diff --git a/system/physmem.c b/system/physmem.c index 8327b7c3de1..5f1be89649e 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3886,7 +3886,7 @@ int64_t address_space_cache_init(MemoryRegionCache *c= ache, return l; } =20 -void address_space_cache_invalidate(MemoryRegionCache *cache, +void address_space_cache_invalidate(const MemoryRegionCache *cache, hwaddr addr, hwaddr access_len) { @@ -3917,7 +3917,7 @@ void address_space_cache_destroy(MemoryRegionCache *c= ache) * address_space_cache_init. */ static inline MemoryRegion *address_space_translate_cached( - MemoryRegionCache *cache, hwaddr addr, hwaddr *xlat, + const MemoryRegionCache *cache, hwaddr addr, hwaddr *xlat, hwaddr *plen, bool is_write, MemTxAttrs attrs) { MemoryRegionSection section; @@ -3998,7 +3998,7 @@ static MemTxResult address_space_read_continue_cached= (MemTxAttrs attrs, * out of line function when the target is an MMIO or IOMMU region. */ MemTxResult -address_space_read_cached_slow(MemoryRegionCache *cache, hwaddr addr, +address_space_read_cached_slow(const MemoryRegionCache *cache, hwaddr addr, void *buf, hwaddr len) { hwaddr mr_addr, l; @@ -4015,7 +4015,7 @@ address_space_read_cached_slow(MemoryRegionCache *cac= he, hwaddr addr, * out of line function when the target is an MMIO or IOMMU region. */ MemTxResult -address_space_write_cached_slow(MemoryRegionCache *cache, hwaddr addr, +address_space_write_cached_slow(const MemoryRegionCache *cache, hwaddr add= r, const void *buf, hwaddr len) { hwaddr mr_addr, l; @@ -4028,7 +4028,7 @@ address_space_write_cached_slow(MemoryRegionCache *ca= che, hwaddr addr, buf, len, mr_addr, l, mr); } =20 -#define ARG1_DECL MemoryRegionCache *cache +#define ARG1_DECL const MemoryRegionCache *cache #define ARG1 cache #define SUFFIX _cached_slow #define TRANSLATE(...) address_space_translate_cached(cache, __V= A_ARGS__) --=20 2.53.0