From nobody Sun Mar 22 15:40:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773928496; cv=none; d=zohomail.com; s=zohoarc; b=mnSe8eOBZOxKB7ONptwW2RcPJdqERFHrLYuQGfaIhzWwG0KbnWUhQr1pfocsiCxbgz+fqZrqIx6ZhSkCDwGd9S72E5DUIcFC/1Um2APCACszG/1j7PQX4UOagtUrOA/wqd7TyG7HeMgPCsiiYLg5IwjT2+ktMqmHqZcioClTjIk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773928496; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gQPI6WkJx9rs4KYo3QAUSEyEpqdbt7RFH0oOqRA2y6E=; b=NnKFPUT/Au+Jt33ndP0ljhD2iAFVQbnPTB1aS51rIPQg/hHUIt8VpcuSW7y8xc2DJhec/7pv1oCgUMsNkdRcCLAYQ5jPEjYO4hECgF7G1+XDT1UfnTuJjePE9yZ8uESjAxNp6yorScyh1573O25h5tF7G+E22MZWTWwI32uHbCo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773928496683918.4941431998626; Thu, 19 Mar 2026 06:54:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3Dpc-00069U-3R; Thu, 19 Mar 2026 09:54:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3Dou-0005nj-NU for qemu-devel@nongnu.org; Thu, 19 Mar 2026 09:53:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3Dot-0001Al-2Q for qemu-devel@nongnu.org; Thu, 19 Mar 2026 09:53:52 -0400 Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-PmSxEuzkPy6Nkr0fQlcpGg-1; Thu, 19 Mar 2026 09:53:49 -0400 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b064f043adso10987145ad.0 for ; Thu, 19 Mar 2026 06:53:49 -0700 (PDT) Received: from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.104.12]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e6216c5sm77287025ad.73.2026.03.19.06.53.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 06:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773928430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gQPI6WkJx9rs4KYo3QAUSEyEpqdbt7RFH0oOqRA2y6E=; b=RoJpWO7IQ3aYdSoZQzyO7w/ahEzRl7z4mZhSef/TbbkNMvY7IPWSw8c1059gp0ETt6UyUh e2lbzDd3aPYx8srkz/pVHYvtu+AAslSlbZ6wMqEjtEBvhv4DNoQxrqAW6tYpEGTYecX8C6 AUin8741KYO+PSVDcVR6YbLNxi7FwTA= X-MC-Unique: PmSxEuzkPy6Nkr0fQlcpGg-1 X-Mimecast-MFC-AGG-ID: PmSxEuzkPy6Nkr0fQlcpGg_1773928428 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773928428; x=1774533228; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gQPI6WkJx9rs4KYo3QAUSEyEpqdbt7RFH0oOqRA2y6E=; b=YiC5le898MdzhVk4aEXh4K+aILf8jsSjh6smUhsDd5SReLaLxvSGIym6SMQ4KmFcXP pxZpt9ENrbg0vMM0eFySCuxoJ7TfJ9xF4mPVNf+eqmOv2swFBqRZ5QANsVuJB3NWmlQE xNk3kDsnMYBJWmLi4AwU3WDRwqOhpraxHX0SYuQmMbRpAgYCdpZ/qKFBgblKXmAvA6/A tPhHrst+gbiqAw7YYtv+xF2PyZvIV4fvQ4osLT3YHFr1jf9B3/Ze5UWY4JeHH116iIta KWFjL3Bi5mv7Qdtl3EMuHaMd2CUswa5Bk903yXttJ7WyU+AK9SGUo8n9cXAcdHWwGWTc Nedw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773928428; x=1774533228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gQPI6WkJx9rs4KYo3QAUSEyEpqdbt7RFH0oOqRA2y6E=; b=elSFHvdiiKQv3vwLxmp8wl3XYHzYVOMfk0KHHPJQjxdR+cbSrxddp5bkJMZ1IqorP6 8Sq227eoENCULFIogjfgNaH1VHGHPoO75aea343e30QSRa7v9x/FbqDWOPFUACcSTVFS 2oXpeRoLxwRET4Xxvczaa7HZeZ9yEWfJm/zNc2hkPUTE4PqZKQptgJ9co41xm2xDbrUF N2z9JfgH4oBJ7nWGY2a/QJc3R6/WiyZnQFWEMI7L9kAItg7Z83ppNsVD2EJ2k5V/xhUw WTRgHz/o722JC44dplg0haC0/Uz7zr5vMxzp/V0wcpITy8LSvUnnVOFUZakJaRjhoLeW o2Vg== X-Gm-Message-State: AOJu0YxrpBETGQz1ems08Jdr5zRU71wGMMV/Ut/OJOmaMBpFttzk4vnF NC3+5MNfnaDDlIEuqgcWIJ1rkhbCbfI8l+WHQmLmIVtgclTbGZei+lFG8uOsTFm2ypOSuUrlOrH hjcDZyykwfjttqSk9CXY6plU+WVuzVIHaEe8o3PM7KCIrMpKpLzQDwav+qeE5gf6bLKHoZ5OH83 wp69lowjvYqRHWLuVjRLBLQ51lsrSylSiM1jrfo6E= X-Gm-Gg: ATEYQzxvjmmIOYmtjBeLN7Y0H4gErt9DTUV0DIKsB6hmSF40ieueF+NtkNaOJ6AyPPB 8eu8du1+qDxf04WHkLnTyaXSJNbN5ahyWHdmxUDe79b00P2bYnh7QlcR1a3r/on3Q9jL8YyWGzf AqnOecYiGckaNFRp0BXoCIgl7uR0wPHqE+xCyBK9zM6y22y5vRugjDYN0nMY4H58NvLaFBQG7s4 ABK90qTfqqfsCxn52IdRJbuVP2re7eTuuW02gXiIzXpdOZ/A9QYmCs4CGm1vnXse7qHMNkK54mX sG7JPhKHValTBUe+cfYnEyuLxYmhZ5QA+Bhg7twgVfgmbtD/4HYFS5pQA9w/CSgoW2oUDoYR0Ov K6UXPKHkklPgwDpmfZAMQEK+TWVDtXRwJBGQn8PTh0X2WnUBXktFo66c5eEZaIg== X-Received: by 2002:a17:902:ce12:b0:2b0:692d:78bd with SMTP id d9443c01a7336-2b06e4307aamr66616795ad.46.1773928427983; Thu, 19 Mar 2026 06:53:47 -0700 (PDT) X-Received: by 2002:a17:902:ce12:b0:2b0:692d:78bd with SMTP id d9443c01a7336-2b06e4307aamr66616415ad.46.1773928427488; Thu, 19 Mar 2026 06:53:47 -0700 (PDT) From: Arun Menon To: qemu-devel@nongnu.org Cc: Ani Sinha , Marcel Apfelbaum , Laurent Vivier , Zhao Liu , "Michael S. Tsirkin" , Stefan Berger , marcandre.lureau@redhat.com, Fabiano Rosas , Paolo Bonzini , Igor Mammedov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yanan Wang , Arun Menon Subject: [RFC v2 5/7] test/qtest: Add test for tpm crb chunking Date: Thu, 19 Mar 2026 19:23:14 +0530 Message-ID: <20260319135316.37412-6-armenon@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319135316.37412-1-armenon@redhat.com> References: <20260319135316.37412-1-armenon@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773928497479158500 Content-Type: text/plain; charset="utf-8" - New test case added to the swtpm test. Data is written and read from the buffer in chunks. - The chunk size is dynamically calculated by reading the CRB_CTRL_CMD_SIZE address. This can be changed manually to test. - Add a helper function tpm_wait_till_bit_clear() Signed-off-by: Arun Menon --- tests/qtest/tpm-crb-swtpm-test.c | 10 +++ tests/qtest/tpm-util.c | 106 ++++++++++++++++++++++++++----- tests/qtest/tpm-util.h | 5 ++ 3 files changed, 106 insertions(+), 15 deletions(-) diff --git a/tests/qtest/tpm-crb-swtpm-test.c b/tests/qtest/tpm-crb-swtpm-t= est.c index ffeb1c396b..050c7b0c1f 100644 --- a/tests/qtest/tpm-crb-swtpm-test.c +++ b/tests/qtest/tpm-crb-swtpm-test.c @@ -33,6 +33,14 @@ static void tpm_crb_swtpm_test(const void *data) "tpm-crb", NULL); } =20 +static void tpm_crb_chunk_swtpm_test(const void *data) +{ + const TestState *ts =3D data; + + tpm_test_swtpm_test(ts->src_tpm_path, tpm_util_crb_chunk_transfer, + "tpm-crb", NULL); +} + static void tpm_crb_swtpm_migration_test(const void *data) { const TestState *ts =3D data; @@ -54,6 +62,8 @@ int main(int argc, char **argv) g_test_init(&argc, &argv, NULL); =20 qtest_add_data_func("/tpm/crb-swtpm/test", &ts, tpm_crb_swtpm_test); + qtest_add_data_func("/tpm/crb-chunk-swtpm/test", &ts, + tpm_crb_chunk_swtpm_test); qtest_add_data_func("/tpm/crb-swtpm-migration/test", &ts, tpm_crb_swtpm_migration_test); ret =3D g_test_run(); diff --git a/tests/qtest/tpm-util.c b/tests/qtest/tpm-util.c index 2cb2dd4796..dfc1fd70b7 100644 --- a/tests/qtest/tpm-util.c +++ b/tests/qtest/tpm-util.c @@ -14,16 +14,42 @@ =20 #include "qemu/osdep.h" #include +#include "system/memory.h" =20 #include "hw/acpi/tpm.h" #include "libqtest.h" #include "tpm-util.h" #include "qobject/qdict.h" =20 +#define CRB_ADDR_START (TPM_CRB_ADDR_BASE + A_CRB_CTRL_START) +#define CRB_CTRL_STS (TPM_CRB_ADDR_BASE + A_CRB_CTRL_STS) +#define CRB_CTRL_CMD_SIZE (TPM_CRB_ADDR_BASE + A_CRB_CTRL_CMD_SIZE) + +#define BIT_START_INVOKE (1 << 0) +#define BIT_RETRY_RESPONSE (1 << 1) +#define BIT_NEXT_CHUNK (1 << 2) + +void tpm_wait_till_bit_clear(QTestState *s, uint64_t addr, uint32_t mask) +{ + uint32_t sts; + uint64_t end_time =3D g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND; + + while (true) { + sts =3D qtest_readl(s, addr); + if ((sts & mask) =3D=3D 0) { + break; + } + if (g_get_monotonic_time() >=3D end_time) { + break; + } + } +} + void tpm_util_crb_transfer(QTestState *s, const unsigned char *req, size_t req_size, unsigned char *rsp, size_t rsp_size) { + uint32_t tpmSts; uint64_t caddr =3D qtest_readq(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_CMD_L= ADDR); uint64_t raddr =3D qtest_readq(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_RSP_A= DDR); =20 @@ -31,24 +57,74 @@ void tpm_util_crb_transfer(QTestState *s, =20 qtest_memwrite(s, caddr, req, req_size); =20 - uint32_t sts, start =3D 1; - uint64_t end_time =3D g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND; - qtest_writel(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_START, start); - while (true) { - start =3D qtest_readl(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_START); - if ((start & 1) =3D=3D 0) { - break; + qtest_writel(s, CRB_ADDR_START, BIT_START_INVOKE); + tpm_wait_till_bit_clear(s, CRB_ADDR_START, BIT_START_INVOKE); + + tpmSts =3D qtest_readl(s, CRB_CTRL_STS); + g_assert_cmpint(tpmSts & 1, =3D=3D, 0); + + qtest_memread(s, raddr, rsp, rsp_size); +} + +void tpm_util_crb_chunk_transfer(QTestState *s, + const unsigned char *req, size_t req_size, + unsigned char *rsp, size_t rsp_size) +{ + uint32_t tpmSts; + + uint64_t caddr =3D qtest_readq(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_CMD_L= ADDR); + uint64_t raddr =3D qtest_readq(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_RSP_A= DDR); + uint32_t crb_ctrl_cmd_size =3D qtest_readl(s, CRB_CTRL_CMD_SIZE); + + size_t chunk_size =3D crb_ctrl_cmd_size; + + qtest_writeb(s, TPM_CRB_ADDR_BASE + A_CRB_LOC_CTRL, 1); + + for (size_t i =3D 0 ; i < req_size; i +=3D chunk_size) { + bool last_chunk =3D false; + size_t current_chunk_size =3D chunk_size ; + + if (i + chunk_size > req_size) { + last_chunk =3D true; + current_chunk_size =3D req_size - i; } - if (g_get_monotonic_time() >=3D end_time) { - break; + + qtest_memwrite(s, caddr, req + i, current_chunk_size); + + if (last_chunk) { + qtest_writel(s, CRB_ADDR_START , BIT_START_INVOKE); + tpm_wait_till_bit_clear(s, CRB_ADDR_START, BIT_START_INVOKE); + } else { + qtest_writel(s, CRB_ADDR_START , BIT_NEXT_CHUNK); + tpm_wait_till_bit_clear(s, CRB_ADDR_START, BIT_NEXT_CHUNK); } - }; - start =3D qtest_readl(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_START); - g_assert_cmpint(start & 1, =3D=3D, 0); - sts =3D qtest_readl(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_STS); - g_assert_cmpint(sts & 1, =3D=3D, 0); + } + tpmSts =3D qtest_readl(s, CRB_CTRL_STS); + g_assert_cmpint(tpmSts & 1, =3D=3D, 0); =20 - qtest_memread(s, raddr, rsp, rsp_size); + /* + * Read response in chunks + */ + + unsigned char header[10]; + qtest_memread(s, raddr, header, sizeof(header)); + + uint32_t actual_response_size =3D ldl_be_p(&header[2]); + + if (actual_response_size > rsp_size) { + actual_response_size =3D rsp_size; + } + + for (size_t i =3D 0; i < actual_response_size; i +=3D chunk_size) { + size_t to_read =3D i + chunk_size > actual_response_size + ? actual_response_size - i + : chunk_size; + if (i > 0) { + qtest_writel(s, CRB_ADDR_START, BIT_NEXT_CHUNK); + tpm_wait_till_bit_clear(s, CRB_ADDR_START, BIT_NEXT_CHUNK); + } + qtest_memread(s, raddr, rsp + i, to_read); + } } =20 void tpm_util_startup(QTestState *s, tx_func *tx) diff --git a/tests/qtest/tpm-util.h b/tests/qtest/tpm-util.h index 0cb28dd6e5..681544e7d8 100644 --- a/tests/qtest/tpm-util.h +++ b/tests/qtest/tpm-util.h @@ -24,10 +24,15 @@ typedef void (tx_func)(QTestState *s, const unsigned char *req, size_t req_size, unsigned char *rsp, size_t rsp_size); =20 +void tpm_wait_till_bit_clear(QTestState *s, uint64_t addr, uint32_t mask); void tpm_util_crb_transfer(QTestState *s, const unsigned char *req, size_t req_size, unsigned char *rsp, size_t rsp_size); =20 +void tpm_util_crb_chunk_transfer(QTestState *s, + const unsigned char *req, size_t req_size, + unsigned char *rsp, size_t rsp_size); + void tpm_util_startup(QTestState *s, tx_func *tx); void tpm_util_pcrextend(QTestState *s, tx_func *tx); void tpm_util_pcrread(QTestState *s, tx_func *tx, --=20 2.53.0