From nobody Mon Apr 6 10:45:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773919264; cv=none; d=zohomail.com; s=zohoarc; b=j0zqNTCi3gEUFRflFr0gOzbibvB3TlrZNw0pa3s9F6ygGg5b+mpjAzfkrr97ukNztUBDSVr/2r150sENKuqIopGdeI15svGrAYaZMM5Fw9sjWdDnyfpXRsn6SL5iqOjU64tYtRA7+Zg/BA9yLqOawPq+XR3XGtm/eLrwqI0fir4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773919264; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MAlQ6OL3gpyVI0jWnvjBgu6bCA13ejnahNH1d2j0ink=; b=Qxqu9zw/fyq8FXsbKXVsyshlQQ42aVZvHfuOxMxgfiIqoGBfk4tg2JlKZhKsI/EPh3coZNMrrID0/hCIV+UdspgPTSFO0oJT8THFh42F7h7EORmUpS6uUVyNX7+4vLGZhZdr5IHhfFyHCA6A0Br70kTFjdd88aT35e15pAu2JUI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773919264519179.19040959068127; Thu, 19 Mar 2026 04:21:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3BQI-0007fe-NZ; Thu, 19 Mar 2026 07:20:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BPq-0007WY-0U for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:19:57 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3BPo-0004Hc-9R for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:19:49 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-48557c8ad47so6521485e9.0 for ; Thu, 19 Mar 2026 04:19:47 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8b949e1sm103526265e9.9.2026.03.19.04.19.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 04:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773919186; x=1774523986; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MAlQ6OL3gpyVI0jWnvjBgu6bCA13ejnahNH1d2j0ink=; b=BrdwRIj/yB7cxkZ9iXg4wAcmeEJYaalcHtE9LhOIZMOx8dESoV7uI/bAoRRkNQvkzT VZ2KB24ekmI43IfHcyuZFS+EzjcBr4c/d77tQ4i6IarPVCGoVMo4f+9p/+W125/iOpRS tPwJ0E6W8MPbhCWD+BFOajee5Gjyh4it4erBmDazbzPT+rxk/3YuclqZV1mox2jz/QVs nTSdgP7M4aU7PwZzvvEiwNn1XkVsGgLkjnMm7Ze49gAvks8nVaKNTiWoC9r2kLykoFsJ x5/y0vI8QHqkOBbHcFrx5XGDB9oj3hiLcpj7iY+OAJQXyfc61QXlb0hYwD/5QcSGlkDW 9wIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773919186; x=1774523986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MAlQ6OL3gpyVI0jWnvjBgu6bCA13ejnahNH1d2j0ink=; b=qnTUoX3mZ7xn/dcHnNrbzQ0q+WMrQnQcCuwOBab3+KjUXUFvMSkg1YqgCDnc8Bdk9Q dCotNXh0ydkotyCOvDt7cmDJ9P31mCcKnvJUJjDtK3X8v3SKO5CA307gOoQDBejiQZl8 7e3ST1WWIA5/eBxTpbWLunezWjjFzN3+CMm98A1/E9kpU1qd3tMhBI+LsHjfifFOzHGg bS+bVEFf+fmdkZzSkwBKMZm3HfhoPIZrcul8E0CfZAyoPmybRndoQzj63BCDaQQxCuMT dz2PQPdCpcBYzwZfhbnSxjPsVpyiTSYFrSpskEAFyTikNlhfYQFizE2GP9FtBW85bV9J ehLw== X-Gm-Message-State: AOJu0YyuGMHKB4V0sGc+jnvv+a3dojo6aWe8tIq69Iag6LkxVF0owWMc LlwIYgWsAfPN5DrWoZHjUXxh7YwEEEi2p2sC0GEE/ZpFyd9YBf5U1rTaN9iez4l4grAj2SLvL7B 4diFQ9Dw= X-Gm-Gg: ATEYQzxDiXBAhc1QxQS1b2M3XpgYtdVI3uYmc2rEToSKBLjYKrtRNz3BkfjN6vZch0G WjzlY5l4iAIUNUyO5a8HshF1A4ZAXjEDrhAAIdI9ih8rVqPaxvHkxyaKIXbANkobnTf0fumWwWn rlkfSzndkmAUNnOJUcpKJTHarsXNuY9ouYY+ymlX4C2Wz6UeRAOefxu6vlonnTcZg1dHguGaGNk UjbuWA9HX+MINMTrn7q7DI3WDlQaNhruq1WvvIzbdBceXpgVbyUzMfNPyKtSzyz8nnXp8DEhCzT 2ymfRSSVjPOFsmT5TlKMW4fWwkZHU/TN8QcKZXNJ1PIs3KjQTTUkuemZQGO+dGYRYR+fdVPfX+l P1ZQVn3K52o6+5+IvkDvFKnAz/pYNs1nP4Kd0XevVSo8ySdvZGjP5d/nXNPev178lDIDFzHXI9H 0bjlWA32aqbMBeQxF6pdeHFghl+ynodIBJ5LZDam1Op0XdO+mPPgagQOKr0UlqLT3518guG/bz1 RTl+p10iYc= X-Received: by 2002:a05:600c:4fcb:b0:485:3f38:3de3 with SMTP id 5b1f17b1804b1-486f44384d4mr115148365e9.3.1773919186220; Thu, 19 Mar 2026 04:19:46 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Paolo Bonzini , Harsh Prateek Bora , BALATON Zoltan , Nicholas Piggin , Glenn Miles , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Pierrick Bouvier , Chinmay Rath , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/8] hw/ppc/spapr: Un-inline rtas_load/store() helpers Date: Thu, 19 Mar 2026 12:19:29 +0100 Message-ID: <20260319111936.68041-2-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319111936.68041-1-philmd@linaro.org> References: <20260319111936.68041-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773919265820158500 The 32-bit binary doesn't use these helpers, so don't need to compile them. Rather than using 64-bit target #ifdef'ry in a global header, un-inline the calls since the helpers are called from I/O (cold) path. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/ppc/spapr.h | 18 +++--------------- hw/ppc/spapr_rtas.c | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h index b022f8dd25d..9acda15d4f6 100644 --- a/include/hw/ppc/spapr.h +++ b/include/hw/ppc/spapr.h @@ -796,21 +796,9 @@ static inline uint64_t ppc64_phys_to_real(uint64_t add= r) return addr & ~0xF000000000000000ULL; } =20 -static inline uint32_t rtas_ld(target_ulong phys, int n) -{ - return ldl_be_phys(&address_space_memory, - ppc64_phys_to_real(phys + 4 * n)); -} - -static inline uint64_t rtas_ldq(target_ulong phys, int n) -{ - return (uint64_t)rtas_ld(phys, n) << 32 | rtas_ld(phys, n + 1); -} - -static inline void rtas_st(target_ulong phys, int n, uint32_t val) -{ - stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4 * n), v= al); -} +uint32_t rtas_ld(target_ulong phys, int n); +uint64_t rtas_ldq(target_ulong phys, int n); +void rtas_st(target_ulong phys, int n, uint32_t val); =20 typedef void (*spapr_rtas_fn)(PowerPCCPU *cpu, SpaprMachineState *sm, uint32_t token, diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index cb79ad34053..0871425237e 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -52,6 +52,21 @@ #include "migration/blocker.h" #include "helper_regs.h" =20 +uint32_t rtas_ld(target_ulong phys, int n) +{ + return ldl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4 = * n)); +} + +uint64_t rtas_ldq(target_ulong phys, int n) +{ + return (uint64_t)rtas_ld(phys, n) << 32 | rtas_ld(phys, n + 1); +} + +void rtas_st(target_ulong phys, int n, uint32_t val) +{ + stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4 * n), v= al); +} + static void rtas_display_character(PowerPCCPU *cpu, SpaprMachineState *spa= pr, uint32_t token, uint32_t nargs, target_ulong args, --=20 2.53.0 From nobody Mon Apr 6 10:45:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773919259; cv=none; d=zohomail.com; s=zohoarc; b=GPW7deEdaiynLZIL5rsuA71jKLxHBEOS3c4ArxpYObourSbdtU+e1BMPdysck92EnVLml4nWPZLN2dcPIqWTJBQLwB/lMOLfelbN47PDKZwnpu2CEc6O9g9mH5X5fy6uZS06k7Bzy8gJuuzEEhXYedVxaVuAdj6HKFzUjlmAMsk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773919259; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1EF35YN3CJ8u12H8BkNu2tiJ6lwUGD01EvYz7GmtlEg=; b=iEKmk7tdI9OXnmSckx6PV8KMAaAZ6PRVrSkd0Q7nfsP3E4OsBa8yAa6dLb276RwhS9n3730b+NE3E7RNc9pDjQtSe+/+gP1g06bhKaIQkD/lxtHX2UmY+8vbVTs6/1SEG5Gdwlm7fHHjniTYyO/IDNY1T34g+M4jitPFO01zvi0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773919259123395.7677450157404; Thu, 19 Mar 2026 04:20:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3BQJ-0007gS-W4; Thu, 19 Mar 2026 07:20:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQ5-0007YV-BA for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:05 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3BPz-0004jh-QG for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:02 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-48538c5956bso7110625e9.0 for ; Thu, 19 Mar 2026 04:19:57 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8bd9d78sm19811235e9.5.2026.03.19.04.19.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 04:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773919195; x=1774523995; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1EF35YN3CJ8u12H8BkNu2tiJ6lwUGD01EvYz7GmtlEg=; b=kKqbokV7hzT3WeeMCE2a2vowThXQK+07iJHsrc3htmqSCQYpW6yLqBf1anhUZTlBCb JfszmI80XpTtk9C2+qD7RjYMKUnLkeEBIUBp5QRHBqV1YJtgnQArwjn3VKIZaKMphBbL E04M9TKRxarFm+HC9bnuB9bhWsgJ24oz0gep58R1xVLr/GBiTBK6n80TewYC8sNiAV2q F8YJDdy9eDloXLHS4RO0LrLXIXHWD1HX2abfwaQxg0DT2mwnGzmVgytPDgcNv1fUrt9M 3AUP20K88u2jXVWwPFmzeOQsdDvHBKGIqYnOhur9y+Xv4vs653OMv7584fC+xh+cN9l0 fkCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773919195; x=1774523995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1EF35YN3CJ8u12H8BkNu2tiJ6lwUGD01EvYz7GmtlEg=; b=SY2GaelnM1dqkgqzXUdGjFsfpJdh+C6lKLUerQpJ6R3wi4ZHWIxGWUdCOsQ7HiAMhG +Nz5YlTgoYEpvNXxxC6OTCT19CKjDoZDKQkXEfGWDENaxNo2uPrYvRx6C7B/5LWg3hF8 Y7u1qnlc5mMfYnzQFGFDCfu2tGCgBJwUkKQiVqSdHexr4Cf+juGKfY5ka9ZEG7yFfhMv OG+1da0+SXUk8QFXzTWwfdOOuplCnaYZXhQEdjMr4jHHqXCSYAaSJZR7OnuWatRd/LQ5 n/40Oz6535nDHF1VrodvheH8TMmRUwK14b4OnMR1ff502y97ga8QRMLol6tAwIYTyDRG 2T+w== X-Gm-Message-State: AOJu0YxwC0oMvfktdWXg/EfOGCNHIKaiCE74Md+nrJjZnz4M5y4N2j1b ycOkZ/9vu42S1hpbdKVe0WaY6zDGXrGqM+2O7YyHgEOEmWigdkU3BmMjs1LiTvWos3HA3eCVJP1 /4udQ7Ek= X-Gm-Gg: ATEYQzyYnNbYYJKFwZQPGl+0h5Cc5uhFHeuJ909j62nT7hcS3ogaqOBp6ouYYwy1DWD XwaEL7f6C/AyIi7vXhpRrjscr5fkcLEYjr0suc0y3tPs070uRoIk+C1tzkmZuTP5zcV0XRQ9E69 2DtXp71IfXGJC2B6HcUJiTIHG+81l6yU/FaSp7CH+Yrh6AyGEetavfHDwAsg9HBUGqf6mvSPf/E ZZU+x57l7vv6PZcN+APnrqjcRLFUOrTL8rrcOPHc4XMDWxpLcq63kWWCCJyOlDdVI4aW3aqbm2c 8w02/wDfHZRQBskHtk7vIRluxqgMn/SjFryPPvdnI9bV29KP/CoshQymZV0+Pge3j3iHSiW0mJV 0lmjC0QHe3yVrWoEKJh7tsTQRxW8jyg7+2hgxxpjxzJ/uaF5N1SE26RPRS62kVgxqg8yR9C78Jv e9u/AC7OtiW4VNDf6BPXhZ9UTZKjuNRsRAs9m5jrSVv2VO8lnODjWCZII/07qZgXok5pB4pTbK X-Received: by 2002:a05:600c:8b10:b0:486:f893:56c6 with SMTP id 5b1f17b1804b1-486f8b46651mr48087815e9.10.1773919195014; Thu, 19 Mar 2026 04:19:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Paolo Bonzini , Harsh Prateek Bora , BALATON Zoltan , Nicholas Piggin , Glenn Miles , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Pierrick Bouvier , Chinmay Rath , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/8] target/ppc: Factor common ppc_load_epr() helper out Date: Thu, 19 Mar 2026 12:19:30 +0100 Message-ID: <20260319111936.68041-3-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319111936.68041-1-philmd@linaro.org> References: <20260319111936.68041-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773919259379158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/cpu.h | 2 ++ target/ppc/cpu.c | 8 ++++++++ target/ppc/excp_helper.c | 3 +-- target/ppc/kvm.c | 2 +- 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h index d637a50798f..e3e4bce91b7 100644 --- a/target/ppc/cpu.h +++ b/target/ppc/cpu.h @@ -2822,6 +2822,8 @@ enum { target_ulong cpu_read_xer(const CPUPPCState *env); void cpu_write_xer(CPUPPCState *env, target_ulong xer); =20 +uint64_t ppc_load_epr(CPUPPCState *env); + /* * All 64-bit server processors compliant with arch 2.x, ie. 970 and newer, * have PPC_SEGMENT_64B. diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index 4d8faaddee2..f24801a9731 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -26,6 +26,7 @@ #include "fpu/softfloat-helpers.h" #include "mmu-hash64.h" #include "helper_regs.h" +#include "system/memory.h" #include "system/tcg.h" =20 target_ulong cpu_read_xer(const CPUPPCState *env) @@ -105,6 +106,13 @@ void ppc_store_lpcr(PowerPCCPU *cpu, target_ulong val) ppc_maybe_interrupt(env); } =20 +uint64_t ppc_load_epr(CPUPPCState *env) +{ + CPUState *cs =3D env_cpu(env); + + return ldl_phys(cs->as, env->mpic_iack); +} + #if defined(TARGET_PPC64) void ppc_update_ciabr(CPUPPCState *env) { diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index 6d05b865058..3b476c145ab 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_helper.c @@ -1166,9 +1166,8 @@ static void powerpc_excp_booke(PowerPCCPU *cpu, int e= xcp) break; case POWERPC_EXCP_EXTERNAL: /* External input = */ if (env->mpic_proxy) { - CPUState *cs =3D env_cpu(env); /* IACK the IRQ on delivery */ - env->spr[SPR_BOOKE_EPR] =3D ldl_phys(cs->as, env->mpic_iack); + env->spr[SPR_BOOKE_EPR] =3D ppc_load_epr(env); } break; case POWERPC_EXCP_ALIGN: /* Alignment exception = */ diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 41bd03ec2a2..3bff75b7f54 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1692,7 +1692,7 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_run= *run) #endif case KVM_EXIT_EPR: trace_kvm_handle_epr(); - run->epr.epr =3D ldl_phys(cs->as, env->mpic_iack); + run->epr.epr =3D ppc_load_epr(env); ret =3D 0; break; case KVM_EXIT_WATCHDOG: --=20 2.53.0 From nobody Mon Apr 6 10:45:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773919248; cv=none; d=zohomail.com; s=zohoarc; b=Yi9LNRE7D4qDyfZwdvOSMHi7R23hEQGjHUTAKpAyyd33OFl3eKsmljMA7vKCKxkzdGxNI5G2bzfYqNoqjoWV1dZJc2aop53sf6DOkBL9oKfmW8OXqAEBWuxDy6RC5KWAEvGDqpKb23hhjRXsmFVb9XG1hLXWdVIJWbNHROHJ/CM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773919248; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=f8yqnxF8hGCxxNwG0QPtk4/HBFqHIOCwK8FAKwORZgo=; b=SLXm5k1anLBYYrcj0vqRzL4k6vh4zDnwJddLOAqQgLJbMTfR0BQ82h7d1WiqGcL+EocrVQQ2wc86TUSaP9TW3plT3UfUiY5gAxHhrAJgM9MUYC7/Vb5RV1GnwwN6at53E4wBwm/D3vLEVfjFV4+4cY7LwcHEKMTF1J7xTxvMWH0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773919248283955.3775671673988; Thu, 19 Mar 2026 04:20:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3BQL-0007hw-AI; Thu, 19 Mar 2026 07:20:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQ7-0007cq-Tm for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:09 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3BQ5-000549-3T for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:07 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-48538c5956bso7112155e9.0 for ; Thu, 19 Mar 2026 04:20:03 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8b949a5sm56925475e9.11.2026.03.19.04.20.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 04:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773919202; x=1774524002; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f8yqnxF8hGCxxNwG0QPtk4/HBFqHIOCwK8FAKwORZgo=; b=m2SM2pSthHEVGi8yySnqsIXgZ5Ckdi3d7lzRJulcn6VH16Fudx1qbCAowd/xWIddK/ X9CR27TFEJ97g7CtuRa8wbyQaCltqxKffcEe5/jA45kUcU/qFT4OoczWAbdBGeqEVuEu odFzfE9P+EyAnt5i6JVsF5UjS132hUyFwjX2tMKhomhwKWcbfidVOC5oMkuXvMaUo5U+ Qgs+17SySj5XLm3XRcLR/mS0Zmpra09V9i2sKiVVvZMOBCQ03Z6jVXkp3VLMMCY/Geu+ FqPg47w8uJEQptTqFltwkoMTJ7SnT7FxzqKcjLZ6igQbR6rFGTFKETxoj0NBgIvBrET8 JdSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773919202; x=1774524002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f8yqnxF8hGCxxNwG0QPtk4/HBFqHIOCwK8FAKwORZgo=; b=BezgTpuf6RyBYZw1OvUnMnyFM2vfqAEhSuPkHOxun69enVVEjFiueNVFMFHuBdPaSL CCqsDwmDpE+diJhR7RuLPw3gy70esPX41O/rv/Pv5tj9tdW34GLq1wrAyGIikN1x/n8i xK6o/QYRkAETW4xShlOcq5LAyRM+Vrp0R+tkH7QX029vQzlgB/dDsvhXBn+3rvX8hvce Gep4xz3fXv6mU+KDvQkt5eIBUBThuwqXoG02S58lOzaxMr3UH7Cjqrtk84/HrMcZW63w VsYygS2h0w6fxMypzVxA3GpOVWSadp8aeYXCao6KtCOcAry7y4948A3ypq6vCN6Qlw/T FnQQ== X-Gm-Message-State: AOJu0Yxr2sf4jXF7mcZXwDicqJ85835rZkxGTf6UYsMjtKOo4QYIDT9A LJZLxmAsRCi+TfuhjLAJ14X+SWc2TQbRmhb5hf+ZDzQCGQF+4QqaDb11jero1+EqeyANLXrCQ2E 16rYMr1g= X-Gm-Gg: ATEYQzxJiaS/5/KisPsH8Dcr0clinFg7XGSbCQTx1rSy4jg6wcJ6PJ2nhLkaM7u7qT8 81KEf0vgBLS6CbaR7276LoiISo9I74ZMaXg2BtB84TAUmVcXt0QlvWW6cE+wyQU/5+MHzlS9365 eRL0hTWeZvZjYqlhNomr3L8i50zNW9sk5H1Wzn1X2ObkoDNlAkhuB9HJBGTY3CfWVqQ4/s2Sji1 sRvC0+2dN8+I2S9jP9QacwKMcS+QlBBzQJlRJI97RcRWumBg5S73bOM5gpenytdmcq2COhzJEWF /lCpurgPYRZszTss9RznDVG1BpPTaHb8iuSnLSWsZ9ZSNcsE50rrcKnma0YzL5nEPR0k/wUDTCb 7XUClqJxFtDJ2VDE241omEGbuRKc4vm4pw6GEYe4h7/DxaoQr2Zfn4uerECRGvwJcrvdEgyi3FI glG/QUAkOJRtzjSB+H+8EyoG/v9MMMCxamo32bSVzCwvmmZRLS3RyyKULIZMru1BwtXd7hGStx7 XeKfNtlhNc= X-Received: by 2002:a05:600c:6612:b0:46e:59bd:f7e2 with SMTP id 5b1f17b1804b1-486f8b47e70mr46838835e9.11.1773919202026; Thu, 19 Mar 2026 04:20:02 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Paolo Bonzini , Harsh Prateek Bora , BALATON Zoltan , Nicholas Piggin , Glenn Miles , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Pierrick Bouvier , Chinmay Rath , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/8] target/ppc/mmu: Remove unused hash32_store_hpte() helpers Date: Thu, 19 Mar 2026 12:19:31 +0100 Message-ID: <20260319111936.68041-4-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319111936.68041-1-philmd@linaro.org> References: <20260319111936.68041-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773919250376158500 The hash32_store_hpte() helpers are unused since commit 6e8a65abbbd ("ppc/hash32: Rework R and C bit updates"), 7 years ago. Remove them. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/mmu-hash32.h | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/target/ppc/mmu-hash32.h b/target/ppc/mmu-hash32.h index 04c23ea75ed..5705f57935b 100644 --- a/target/ppc/mmu-hash32.h +++ b/target/ppc/mmu-hash32.h @@ -87,22 +87,6 @@ static inline target_ulong ppc_hash32_load_hpte1(PowerPC= CPU *cpu, return ldl_phys(CPU(cpu)->as, base + pte_offset + HASH_PTE_SIZE_32 / 2= ); } =20 -static inline void ppc_hash32_store_hpte0(PowerPCCPU *cpu, - hwaddr pte_offset, target_ulong = pte0) -{ - target_ulong base =3D ppc_hash32_hpt_base(cpu); - - stl_phys(CPU(cpu)->as, base + pte_offset, pte0); -} - -static inline void ppc_hash32_store_hpte1(PowerPCCPU *cpu, - hwaddr pte_offset, target_ulong = pte1) -{ - target_ulong base =3D ppc_hash32_hpt_base(cpu); - - stl_phys(CPU(cpu)->as, base + pte_offset + HASH_PTE_SIZE_32 / 2, pte1); -} - static inline hwaddr get_pteg_offset32(PowerPCCPU *cpu, hwaddr hash) { return (hash * HASH_PTEG_SIZE_32) & ppc_hash32_hpt_mask(cpu); --=20 2.53.0 From nobody Mon Apr 6 10:45:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773919247; cv=none; d=zohomail.com; s=zohoarc; b=NcEiYVrgMUwRtVYKNwZznES8CnLlgAhK/ecHg7+2bzzxfZ1Ji7FXLpsNZEwQA5EXYTOWhf2IZqaqbtEuYUzoSOMp3Wzp7YBRH2whPLsNmbP0DW+ta6EFsHS3q/FX6KKNtX4RH7yBcqvd9m5sDQNkoLQVIbSbIk9Yurnvovzcetc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773919247; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ejOVQiRumOacnIAYVijEgBDEEbKLhlSk8KeBK8nEaas=; b=cpD5Cyicv9Mb+5A+4xWtlg0GGlTI2xWa/zP27n6WMzkNpJBUlE2Aiw7zfVeYNne8hHZ1tfVKYF1w/JPi/jM99rSu6mwHzVVyad4hkZEN0YBdU11SB4RqOymVevQLZaGwBpiBhToFwzeU59T67bxb9z7NG06QrC8QvWMCmq5I0xU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773919247489106.65813082412046; Thu, 19 Mar 2026 04:20:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3BQL-0007i8-Gt; Thu, 19 Mar 2026 07:20:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQI-0007fr-Oq for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:19 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3BQF-0005Vq-JC for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:18 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so7182055e9.2 for ; Thu, 19 Mar 2026 04:20:11 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f5e23874sm70980525e9.6.2026.03.19.04.20.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 04:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773919210; x=1774524010; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ejOVQiRumOacnIAYVijEgBDEEbKLhlSk8KeBK8nEaas=; b=Sx3iuDpG5eXs9OMUeUR42PHbcu6pS2I2tISE23qPHETtj5s9vdlCnEZMq2VNbRySSK hXLicPikDAQkJqysebG+ZBgmhsJC1F07SZH2N0xO0qnc4OOoJkVUDtjWSAwpCuMc6tPo pcYdNjTGAK5XxNQOlN/uKNMWkLJv1JALl3S8dpf/TeHnJYHWtOFD/d8WiJnKBfBLGMlA Hl/cs7s1NehkCMbPNqlPnoF2Y3XKtastnTmNYChNFUiWqZtY7/KG2ALrriAxqf5DxG5n WfT4iSP/HuS9L+u6UgX2tBZS5DkUkklQFjIleZyt/L9CV3uqCLqcu0togNZ1BRr5Uvgs bJWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773919210; x=1774524010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ejOVQiRumOacnIAYVijEgBDEEbKLhlSk8KeBK8nEaas=; b=owluTaHZxcoSFoK2caD2q3jrwu/E6v+ZThXYQ+hYC//AJsuQVvxJxawU8MELxNr3oh /xs+hhMLmxY1cdNdU9427slaQowDKgAhBkMxRCBvi0H4IrtwPC+1amj5lUd14qc/3Zy/ Xn5icnRk2AvBDHmM/+OatsFS+nwWgWPOqvHg9gbNx+Oic73TigZX5uFaatBG3L3i2Smk 0tmzyYUxet5IZ4HecKr2IM5QlHyG59PXzW4yCr3Cfoao13JKnjJeOjqPa6cU2ubxIy8c AIDFwsuFJa+XBFFz3TZbmX7YrgY6C/WnwPmnsEEbKzO1+LL7Z4g538CD7pR40NtQdEHd k0/w== X-Gm-Message-State: AOJu0YzMm0h8XyFoUndDK83yh2dAsOmD44iSUXslk18ucFxptKqoJvNB AcATjTUx6by8Wok/K0kqf3fP+fKtpYIRsHxqaQMt75Gw1j2CkSVCxVjC+zkfKrPx9tVRWR48J+w ZhFpn2ZI= X-Gm-Gg: ATEYQzzebdpSzics2/ihIbzGInCF/Xwdz2K9cb3TAJR7X2DW8lLJCbT9wp3CvDl29nP zIdG9huz113ygtRz4cGu6FCEfJLmMql8ih1MrX6fc9+nBzjz7hlTAYkM+FqMuy34eZdgdpi1LeL xUe+DyHMud40G3eiedkBBwj4mRGCNxqs28ulkdulpUzevH9aAOtgpvalQe1GPYc5J/JaWuchliU qmUqav8cQSHu3+mALcXmTDOPz+225Af5qRuldqciO3Id/6FbfYeoVzOPkxI8Xk+BgFFgwKmFw3u DZIGka4Gy2S1XzvG6OC6sxHMDite6hJ46wzWVjNY5KhQTeFVDp+oD+xOVcfYkrLrtZSVkRvELu5 IBwH/bUD6qkEe6imaZ5FIEh02wMpvjqHmoswucXIzLeCydANmu8uGG7DT9PwZ9J+K39jN/nvQdd DVxQFIhEfBP5U6CMPQVmh0zlQ5NxlJIPiM8KcS8SwUJB4XTcOW17Yj2I8SLV+JfA9g9de5zn3r3 EHDlQmaGBA= X-Received: by 2002:a05:600c:64c5:b0:486:fcdf:c065 with SMTP id 5b1f17b1804b1-486fcdfc16dmr11537745e9.27.1773919209867; Thu, 19 Mar 2026 04:20:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Paolo Bonzini , Harsh Prateek Bora , BALATON Zoltan , Nicholas Piggin , Glenn Miles , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Pierrick Bouvier , Chinmay Rath , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/8] target/ppc/mmu: Restrict hash32_load_hpte() helpers scope Date: Thu, 19 Mar 2026 12:19:32 +0100 Message-ID: <20260319111936.68041-5-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319111936.68041-1-philmd@linaro.org> References: <20260319111936.68041-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773919251103154100 hash32_load_hpte() helpers are only used within mmu-hash32.c, no need to have each file including "mmu-hash32.h" to compile them. Move their definition to this source file. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/mmu-hash32.h | 16 ---------------- target/ppc/mmu-hash32.c | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/target/ppc/mmu-hash32.h b/target/ppc/mmu-hash32.h index 5705f57935b..bfea03ea872 100644 --- a/target/ppc/mmu-hash32.h +++ b/target/ppc/mmu-hash32.h @@ -71,22 +71,6 @@ static inline hwaddr ppc_hash32_hpt_mask(PowerPCCPU *cpu) return ((cpu->env.spr[SPR_SDR1] & SDR_32_HTABMASK) << 16) | 0xFFFF; } =20 -static inline target_ulong ppc_hash32_load_hpte0(PowerPCCPU *cpu, - hwaddr pte_offset) -{ - target_ulong base =3D ppc_hash32_hpt_base(cpu); - - return ldl_phys(CPU(cpu)->as, base + pte_offset); -} - -static inline target_ulong ppc_hash32_load_hpte1(PowerPCCPU *cpu, - hwaddr pte_offset) -{ - target_ulong base =3D ppc_hash32_hpt_base(cpu); - - return ldl_phys(CPU(cpu)->as, base + pte_offset + HASH_PTE_SIZE_32 / 2= ); -} - static inline hwaddr get_pteg_offset32(PowerPCCPU *cpu, hwaddr hash) { return (hash * HASH_PTEG_SIZE_32) & ppc_hash32_hpt_mask(cpu); diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c index 8b980a5aa90..08c9f63a132 100644 --- a/target/ppc/mmu-hash32.c +++ b/target/ppc/mmu-hash32.c @@ -201,6 +201,20 @@ static bool ppc_hash32_direct_store(PowerPCCPU *cpu, t= arget_ulong sr, return false; } =20 +static target_ulong ppc_hash32_load_hpte0(PowerPCCPU *cpu, hwaddr pte_offs= et) +{ + target_ulong base =3D ppc_hash32_hpt_base(cpu); + + return ldl_phys(CPU(cpu)->as, base + pte_offset); +} + +static target_ulong ppc_hash32_load_hpte1(PowerPCCPU *cpu, hwaddr pte_offs= et) +{ + target_ulong base =3D ppc_hash32_hpt_base(cpu); + + return ldl_phys(CPU(cpu)->as, base + pte_offset + HASH_PTE_SIZE_32 / 2= ); +} + static hwaddr ppc_hash32_pteg_search(PowerPCCPU *cpu, hwaddr pteg_off, bool secondary, target_ulong ptem, ppc_hash_pte32_t *pte) --=20 2.53.0 From nobody Mon Apr 6 10:45:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773919287; cv=none; d=zohomail.com; s=zohoarc; b=Yh33BA8CV0ZfBGrMPCpvC0Swo+iMVL3h7KC5DL4XTBNYFIe7Op6WN+Jnto7j2J4i9ycGr+Mqr+n+0zy8tFdsuCkyFtxyJx8mrS2phZqpLRMi9eMGpuR4AjlPuiPMQ35H+pX699GxGWO/Zxrcd8vjkOpKJ0giFNUp386HP8yLmGc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773919287; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kV6UJs6uJ+gJwq/B/WXu0vSWOly3L8qb+FvxJ/ow/Lw=; b=MoKEaXZ4yz0/xXFuUKZMhdgpTqwsGOUod/JNmGdsLufsQSqHQsRoSNZhxTdqWs72psxD1tMx/xWtMgZfu35F13B70Bt660J8LI9JL+nifIyA6FS0j+SxoP8+FoE8hTkzB0GYOTB3UXjsdKaN4wswEmMqde0CrYwlpPw6N9pbGFc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773919287089375.8429667176665; Thu, 19 Mar 2026 04:21:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3BQS-0007lf-M3; Thu, 19 Mar 2026 07:20:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQN-0007jh-Oq for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:25 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3BQJ-0005f1-Eh for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:21 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-486fd5360d4so1800345e9.1 for ; Thu, 19 Mar 2026 04:20:18 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8b949e1sm103571465e9.9.2026.03.19.04.20.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 04:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773919217; x=1774524017; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kV6UJs6uJ+gJwq/B/WXu0vSWOly3L8qb+FvxJ/ow/Lw=; b=ISNRihspwccNObV4MN+G3pVK59G1SkMm52QreQ9sENN1fIiA46teHCKVtTFA4HhigV GV5tMQaOmHbqg+l+4nDggldD6iQatORMpzWtMlZQ63CMTmowJUzSZPpokdqV0EoU5/VA sBGTKlSH0CY0Ql4FVgqBA68dnVNy9xTolg/jGoWnT1oNaxcyyj7zUVmzZLREpe2kKrLI xPGBgEDDzaazGsAWoHKz7WOqVa4VJCxIcyTYKxFi/Oh/rK3wnfZ+8aAUxx7+efzGlIhY cFdk1c8WN77BmNCg3S4s73TujvCaFC2xPpjKQWOC1Le4uBWtnTC1rg+e7NZqT7dR7NUP c82g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773919217; x=1774524017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kV6UJs6uJ+gJwq/B/WXu0vSWOly3L8qb+FvxJ/ow/Lw=; b=Qw04Zego5tOa0RZLbbPwL39A5z+neR0pZFOrJD8DAkWw1DPFrCybzgSB2e+YOAEZVX 1bafqjqWSSMOM5+Jwv+8vEBT6GU8kWKb9ZGovoasN/xUhfZcBnqb2zJ+PE30if0U9IG4 3j2tNE6pn5DvGL1y8HXfXW8q07ILqmLkj66Q4kjRks4nPUvgltmveYBgLeCx20J+PMY+ DnHG5zvqTkNcKXSvc42uL06cJJyO1BiB1zVhv168eUH/w0uCPN6V3AvqJzTfnQH+zaDa vY7dwy9JBIMWkq9QcZbuqLxGlRdem4/tmNhkjO5xT23BzxQvq4rhQ5JG+GpcQ3jIxCxc l0iA== X-Gm-Message-State: AOJu0YzwaXWTkA++oReQ0R6U966dGlzAkIvLkx3F8W3Dwa6eYY7K6Qav tEwFUA/30TeSTPYfc2mmtLwspdevpuyDldznd03uCqq4s6KXfEAUHuvDpq3HaZm6GB3JckozM5I 1298H9Qs= X-Gm-Gg: ATEYQzz2/sH94NVKg3I5EuMgafrRTQUDNmsNBAP+J6QD2rzOHeTt9dQyd0vU3rOGjxh OQ8xNghxsaWZafkZ5YlBwYR/ORAizGp/tX1WiurD9acvnXjI5wSZ3kg07pECjuX6VOEDgCiWWQB wnUlPTAgZ8K0sSKvnnxGBS4JMN5UF3nVL3N9PDwmI6tvJHjJPDNwTBpHMmKNMIA/UqkwWpqLNbb l49YNlsw2q6oC3IH2PvXHtwZ46O85hGaKqBCxFb5QHDIdAyluIVxhPQ9uH5mWTFhzyf/czqUudh IAkaXE24KHTCNkYXIn96sO/+eSSl+SbxASiehIodj1Xf6Y/6UhyO9Bt8lwP0aE5PutT7mb4hbUc GpgUUrkB/PN6RoySrR0RkNlrxSm+CmaGbZ+Mz0P3dvTxMHrFA2fBcfXgRowRd7xdKLf/gPYUu9D 9q8wNFp1lZFVy1yTJP7zmU8vjtTAyVtBTvEk81Uex0G9+C/hAeOTS00L5bQOnxvb4RPbxdusWH X-Received: by 2002:a05:600c:810c:b0:477:b642:9dc1 with SMTP id 5b1f17b1804b1-486f4475342mr112999585e9.20.1773919216971; Thu, 19 Mar 2026 04:20:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Paolo Bonzini , Harsh Prateek Bora , BALATON Zoltan , Nicholas Piggin , Glenn Miles , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Pierrick Bouvier , Chinmay Rath , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 5/8] target/ppc/mmu: Replace legacy ld/st_phys() -> address_space_ld/st() Date: Thu, 19 Mar 2026 12:19:33 +0100 Message-ID: <20260319111936.68041-6-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319111936.68041-1-philmd@linaro.org> References: <20260319111936.68041-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773919289178154100 Prefer the address_space_ld/st API over the legacy ld_phys() because it allow checking for bus access fault. This code however doesn't check for fault, so we simply inline the calls (not specifying any memory transaction attribute nor expecting transation result) per the definition in "system/memory_ldst_phys_endian.h.inc": 27 static inline uint32_t LD_PHYS(l)(ARG1_DECL, hwaddr addr) 28 { 29 return ADDRESS_SPACE_LD(l)(ARG1, addr, MEMTXATTRS_UNSPECIFIED, NULL= ); 30 } 28 static inline void glue(stb_phys, SUFFIX)(ARG1_DECL, hwaddr addr, uint8= _t val) 29 { 30 glue(address_space_stb, SUFFIX)(ARG1, addr, val, 31 MEMTXATTRS_UNSPECIFIED, NULL); 32 } No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/cpu.c | 3 ++- target/ppc/mmu-hash32.c | 14 ++++++++++---- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index f24801a9731..89fad5356b4 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -110,7 +110,8 @@ uint64_t ppc_load_epr(CPUPPCState *env) { CPUState *cs =3D env_cpu(env); =20 - return ldl_phys(cs->as, env->mpic_iack); + return address_space_ldl(cs->as, env->mpic_iack, + MEMTXATTRS_UNSPECIFIED, NULL); } =20 #if defined(TARGET_PPC64) diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c index 08c9f63a132..81fa7336b76 100644 --- a/target/ppc/mmu-hash32.c +++ b/target/ppc/mmu-hash32.c @@ -23,6 +23,7 @@ #include "exec/page-protection.h" #include "exec/target_page.h" #include "system/kvm.h" +#include "system/memory.h" #include "kvm_ppc.h" #include "internal.h" #include "mmu-hash32.h" @@ -205,14 +206,17 @@ static target_ulong ppc_hash32_load_hpte0(PowerPCCPU = *cpu, hwaddr pte_offset) { target_ulong base =3D ppc_hash32_hpt_base(cpu); =20 - return ldl_phys(CPU(cpu)->as, base + pte_offset); + return address_space_ldl(CPU(cpu)->as, base + pte_offset, + MEMTXATTRS_UNSPECIFIED, NULL); } =20 static target_ulong ppc_hash32_load_hpte1(PowerPCCPU *cpu, hwaddr pte_offs= et) { target_ulong base =3D ppc_hash32_hpt_base(cpu); =20 - return ldl_phys(CPU(cpu)->as, base + pte_offset + HASH_PTE_SIZE_32 / 2= ); + return address_space_ldl(CPU(cpu)->as, + base + pte_offset + HASH_PTE_SIZE_32 / 2, + MEMTXATTRS_UNSPECIFIED, NULL); } =20 static hwaddr ppc_hash32_pteg_search(PowerPCCPU *cpu, hwaddr pteg_off, @@ -253,7 +257,8 @@ static void ppc_hash32_set_r(PowerPCCPU *cpu, hwaddr pt= e_offset, uint32_t pte1) hwaddr offset =3D pte_offset + 6; =20 /* The HW performs a non-atomic byte update */ - stb_phys(CPU(cpu)->as, base + offset, ((pte1 >> 8) & 0xff) | 0x01); + address_space_stb(CPU(cpu)->as, base + offset, ((pte1 >> 8) & 0xff) | = 0x01, + MEMTXATTRS_UNSPECIFIED, NULL); } =20 static void ppc_hash32_set_c(PowerPCCPU *cpu, hwaddr pte_offset, uint64_t = pte1) @@ -262,7 +267,8 @@ static void ppc_hash32_set_c(PowerPCCPU *cpu, hwaddr pt= e_offset, uint64_t pte1) hwaddr offset =3D pte_offset + 7; =20 /* The HW performs a non-atomic byte update */ - stb_phys(CPU(cpu)->as, base + offset, (pte1 & 0xff) | 0x80); + address_space_stb(CPU(cpu)->as, base + offset, (pte1 & 0xff) | 0x80, + MEMTXATTRS_UNSPECIFIED, NULL); } =20 static hwaddr ppc_hash32_htab_lookup(PowerPCCPU *cpu, --=20 2.53.0 From nobody Mon Apr 6 10:45:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773919287; cv=none; d=zohomail.com; s=zohoarc; b=dvtvJpe6Dvt6ek4srfSLadXtrWqFkmvnf9fk7LAQFp1/un+CMo6hJrJWttRvUXz/rmqB41K+OzBZ6rSIy+8gw6awaZVERmtiIx4RhCNR2sQ7BftY7gkuEhh7XvTL8PTg+xEefKXHjtHdTS0ZM05uwU7lFMZpDjkRDvc/0Ch+ktE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773919287; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JAiGye3fGjBysGoywQdBfxZN9m2vlKGDWnrT8pe3/go=; b=UEQiurck3iNrH+7vWby5MKOju+xeK4FbR2FCDqUSQi5PfmsBbzDBatU9LuYvvwt3pmeMyALlEVu/HY6rT/DCeGUAJzNCgE7FWxRTigdP5InChnDlDH2LzMQ/qfQKvQpnoRy88xXWa9tTxODc4eRtP9TLduwdWU8dHaRnfrHJjsQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773919287216266.663599372132; Thu, 19 Mar 2026 04:21:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3BQV-0007oL-SC; Thu, 19 Mar 2026 07:20:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQS-0007m0-AB for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:28 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3BQQ-0005rt-C9 for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:28 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-43b467dcf0bso1274629f8f.0 for ; Thu, 19 Mar 2026 04:20:25 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fb6b85f3sm11600845e9.18.2026.03.19.04.20.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 04:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773919224; x=1774524024; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JAiGye3fGjBysGoywQdBfxZN9m2vlKGDWnrT8pe3/go=; b=BvXLvQiIN9KutyTcWmJ9CO8oxqCh2hWb4/u64+KUoC9XWWSg50Gjm2W0hcqLoe0n6u +UO/pjtUKLZH0sMuTvmq23tLk2dxu2Q3eae3EM5VeUJWtPTaTnkgIKKo+FeQ6mB6ma4O FIP7LmpHXlJMMvvhvrzVAhfRnikv1FkHVxJ/f8dg+XuFceh0Ugun8oXU3bVFRqeWKZfN d14nvPsnVuyI1j+6hre6mLJjBUuUirUZ020IxGxbGfTUpuuJaN81uyigoMB95YlmrWof qkiqKen3J+N30/0U1zYVTGa8GB2oqJaYFWtatgW77VYPmWGJwVTs2CdxNCpLyj8mwB5b a29Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773919224; x=1774524024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JAiGye3fGjBysGoywQdBfxZN9m2vlKGDWnrT8pe3/go=; b=f5pF8DCI2L/KZ4x2VOEW8PBKZ6LoGc9eh6he3EkTwE6dVc1TkXU/6gLpVcOU7viyz0 caDdUz5yK7KEObMyjtnkkmTBqkFXKg3C2FNWx4+Cjesra74vg0X2eKq/iNSW/WZwQ6N0 K2vOn+3/W3fR2fB3IHGAtQju5Hq6nbHVh9l7MfAmaoRRG227pvVTlQ4ZzB9MvWeWpm3L jf3Hm+8DjlbfYJaUDq7CgGSpGyvvlb1X0zq1pHfG821ea4bvM4VLvYrGcqlSJw1yAoTs 6nCYRGrroPQlfL3fqnp3sPYi90PLcNxTKmRVOn/pP1MMpOHnjlrJeurJI1wNOH3nbyaU XKZA== X-Gm-Message-State: AOJu0Ywlfe2VysgpAu+axuwc0ExmRWGsXWEfJoDTTvj4k4zeG95kHJpr gXk6Tjr6ix8HlLJ1ALIhXOXXQ3lewAX2L8+GkDkDHkWFmpP8E3DybID8zneCZTSNdLD/j6FkMU6 S8MBC9cI= X-Gm-Gg: ATEYQzxZeRLzKOXZ3UC8jhasxC5342Izb5bi1ApsPoJLFBuOFeKqLblm2rt+Sor2KoD 0+og4zQtxE+FC9vxm28qeC6UfMyOixRo8ENoEczrBgIP4+pMvNIXNQ6p38AG0a50Hcv52BwxbDG ZJiW525HQpMYK2HTizeruG8Dlm9ronhwPEUhpSPj7r8Zr3nwQ1zS3s9dKo3r4EXnwEwT+h9EV2M Tm97i+hziy+6CWA3jkQOas3+JtLwo22Mch1tzsFLbX0Gqt3L9mw2wW6DhXAZhLo0+A5ckBnMfZR LaCU8SNdNDnIi1bzlIkeVuGnUPS5FpCK31fOZpZg/nF0K31VAMH1hCTKmcESlVWCEmQHDuAlYWR /J5e9vZCRRpJ9BeIoSE2xgc2ht8fTNRCU2+HwqRJow/HP/6c+5gHk3p2+4VZqtNPEmh3T9dKHMe JYV8tQIrMhXtZlg9jN0Cy/3eteGT6uAM+OEajJk2u9zcjdL4tDc0D6lgLFk8n9GBLiIZmQfofQT R+GMeSA36c= X-Received: by 2002:a05:600c:c493:b0:47e:e59c:67c5 with SMTP id 5b1f17b1804b1-486f8b32877mr52941045e9.8.1773919224256; Thu, 19 Mar 2026 04:20:24 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Paolo Bonzini , Harsh Prateek Bora , BALATON Zoltan , Nicholas Piggin , Glenn Miles , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Pierrick Bouvier , Chinmay Rath , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 6/8] hw/ppc/pegasos: Introduce rtas_ldl() / rtas_stl() helpers Date: Thu, 19 Mar 2026 12:19:34 +0100 Message-ID: <20260319111936.68041-7-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319111936.68041-1-philmd@linaro.org> References: <20260319111936.68041-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773919287722158500 In preparation of replacing the ldl_be_phys() and stl_be_phys() legacy calls in the next commit, introduce the rtas_ldl() and rtas_stl() helpers. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/ppc/pegasos.c | 66 ++++++++++++++++++++++++++++-------------------- 1 file changed, 38 insertions(+), 28 deletions(-) diff --git a/hw/ppc/pegasos.c b/hw/ppc/pegasos.c index ac9fc5a6542..4217af25807 100644 --- a/hw/ppc/pegasos.c +++ b/hw/ppc/pegasos.c @@ -591,13 +591,23 @@ enum pegasos2_rtas_tokens { RTAS_SYSTEM_REBOOT =3D 20, }; =20 +static uint32_t rtas_ldl(AddressSpace *as, hwaddr addr) +{ + return ldl_be_phys(as, addr); +} + +static void rtas_stl(AddressSpace *as, hwaddr addr, uint32_t value) +{ + stl_be_phys(as, addr, value); +} + static target_ulong pegasos2_rtas(PowerPCCPU *cpu, PegasosMachineState *pm, target_ulong args_real) { AddressSpace *as =3D CPU(cpu)->as; - uint32_t token =3D ldl_be_phys(as, args_real); - uint32_t nargs =3D ldl_be_phys(as, args_real + 4); - uint32_t nrets =3D ldl_be_phys(as, args_real + 8); + uint32_t token =3D rtas_ldl(as, args_real); + uint32_t nargs =3D rtas_ldl(as, args_real + 4); + uint32_t nrets =3D rtas_ldl(as, args_real + 8); uint32_t args =3D args_real + 12; uint32_t rets =3D args_real + 12 + nargs * 4; =20 @@ -613,19 +623,19 @@ static target_ulong pegasos2_rtas(PowerPCCPU *cpu, Pe= gasosMachineState *pm, QDict *qd =3D qobject_to(QDict, qo); =20 if (nargs !=3D 0 || nrets !=3D 8 || !qd) { - stl_be_phys(as, rets, -1); + rtas_stl(as, rets, -1); qobject_unref(qo); return H_PARAMETER; } =20 - stl_be_phys(as, rets, 0); - stl_be_phys(as, rets + 4, qdict_get_int(qd, "tm_year") + 1900); - stl_be_phys(as, rets + 8, qdict_get_int(qd, "tm_mon") + 1); - stl_be_phys(as, rets + 12, qdict_get_int(qd, "tm_mday")); - stl_be_phys(as, rets + 16, qdict_get_int(qd, "tm_hour")); - stl_be_phys(as, rets + 20, qdict_get_int(qd, "tm_min")); - stl_be_phys(as, rets + 24, qdict_get_int(qd, "tm_sec")); - stl_be_phys(as, rets + 28, 0); + rtas_stl(as, rets, 0); + rtas_stl(as, rets + 4, qdict_get_int(qd, "tm_year") + 1900); + rtas_stl(as, rets + 8, qdict_get_int(qd, "tm_mon") + 1); + rtas_stl(as, rets + 12, qdict_get_int(qd, "tm_mday")); + rtas_stl(as, rets + 16, qdict_get_int(qd, "tm_hour")); + rtas_stl(as, rets + 20, qdict_get_int(qd, "tm_min")); + rtas_stl(as, rets + 24, qdict_get_int(qd, "tm_sec")); + rtas_stl(as, rets + 28, 0); qobject_unref(qo); return H_SUCCESS; } @@ -634,15 +644,15 @@ static target_ulong pegasos2_rtas(PowerPCCPU *cpu, Pe= gasosMachineState *pm, uint32_t addr, len, val; =20 if (nargs !=3D 2 || nrets !=3D 2) { - stl_be_phys(as, rets, -1); + rtas_stl(as, rets, -1); return H_PARAMETER; } - addr =3D ldl_be_phys(as, args); - len =3D ldl_be_phys(as, args + 4); + addr =3D rtas_ldl(as, args); + len =3D rtas_ldl(as, args + 4); val =3D pegasos2_pci_config_read(pm, !(addr >> 24), addr & 0x0fffffff, len); - stl_be_phys(as, rets, 0); - stl_be_phys(as, rets + 4, val); + rtas_stl(as, rets, 0); + rtas_stl(as, rets + 4, val); return H_SUCCESS; } case RTAS_WRITE_PCI_CONFIG: @@ -650,39 +660,39 @@ static target_ulong pegasos2_rtas(PowerPCCPU *cpu, Pe= gasosMachineState *pm, uint32_t addr, len, val; =20 if (nargs !=3D 3 || nrets !=3D 1) { - stl_be_phys(as, rets, -1); + rtas_stl(as, rets, -1); return H_PARAMETER; } - addr =3D ldl_be_phys(as, args); - len =3D ldl_be_phys(as, args + 4); - val =3D ldl_be_phys(as, args + 8); + addr =3D rtas_ldl(as, args); + len =3D rtas_ldl(as, args + 4); + val =3D rtas_ldl(as, args + 8); pegasos2_pci_config_write(pm, !(addr >> 24), addr & 0x0fffffff, len, val); - stl_be_phys(as, rets, 0); + rtas_stl(as, rets, 0); return H_SUCCESS; } case RTAS_DISPLAY_CHARACTER: if (nargs !=3D 1 || nrets !=3D 1) { - stl_be_phys(as, rets, -1); + rtas_stl(as, rets, -1); return H_PARAMETER; } - qemu_log_mask(LOG_UNIMP, "%c", ldl_be_phys(as, args)); - stl_be_phys(as, rets, 0); + qemu_log_mask(LOG_UNIMP, "%c", rtas_ldl(as, args)); + rtas_stl(as, rets, 0); return H_SUCCESS; case RTAS_POWER_OFF: { if (nargs !=3D 2 || nrets !=3D 1) { - stl_be_phys(as, rets, -1); + rtas_stl(as, rets, -1); return H_PARAMETER; } qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN); - stl_be_phys(as, rets, 0); + rtas_stl(as, rets, 0); return H_SUCCESS; } default: qemu_log_mask(LOG_UNIMP, "Unknown RTAS token %u (args=3D%u, rets= =3D%u)\n", token, nargs, nrets); - stl_be_phys(as, rets, 0); + rtas_stl(as, rets, 0); return H_SUCCESS; } } --=20 2.53.0 From nobody Mon Apr 6 10:45:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773919296; cv=none; d=zohomail.com; s=zohoarc; b=Tc+4hqPqtyxCUgPZEEk8gogjPCLcg6U4QNQPsJm0SzryWoE5pOHL3B9fX7UF7PRuxB8iz4Sux1Pjh1xl4bH8Fp3rq4Uw0e0hMrNg+HrUVAzTbcqLaKpRwfgImDCYc+W8oHNat6eDehQwSVyj49l7HyjJGz9clnD3RaJeiSVZu2w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773919296; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wofAlcNimL3fKlS85Aya0QNm0cIokcBfl4ew1SrPm3w=; b=AAFw67C6vjdqPxMYsGw7sSIqLB2DSxQWAjICURNsxoaGADQ2lIH5xhKPrZA28xB6IRaUGMR/5nkH+tY6pE8fDHeKZBS1UfQjivJPHJQVARqUBHMMkZeb56L1m70TD8gd9ltgQWVnTwgqJoqEMs31IuoethAHT3amUQgtygAq4zg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773919296164553.9181888830111; Thu, 19 Mar 2026 04:21:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3BQb-0007pb-Ky; Thu, 19 Mar 2026 07:20:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQa-0007pC-2S for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:36 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3BQX-0006Af-IS for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:35 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-43b40fb7f95so720141f8f.3 for ; Thu, 19 Mar 2026 04:20:32 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b5184b8b9sm15749126f8f.1.2026.03.19.04.20.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 04:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773919231; x=1774524031; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wofAlcNimL3fKlS85Aya0QNm0cIokcBfl4ew1SrPm3w=; b=Tiy91+XugcS8WQs9Ekc7/PPWmz7J9lFchfwP190//LBaX85pMoyKDvO5TcfRS4a2qL rIOgeIU7pDZd+qKRnqQ1Oy8HYhWvHQ9d7NXSlg5u3ZhD0BUj6EORhbrgC124uGHcxZ+B TzI4lKJ+K8ArgncGL/FhjQ7YZcjWiuk7/Az1VajUxH49+bGmxardwHeMc+D16l2jptmL FgCL33LFCDk/FX+vHBpUIwgmhK9o1oFLOP3n8wshtMvTXLKfmHG5TNaUbVC0NBMHoYlj 3D8BHbK/+5mfE+S8XHbYstbSBjSH0Wrzq6l90sYYLQXMV28Qj7xp2IMWVmzzndDVsVmr 4/8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773919231; x=1774524031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wofAlcNimL3fKlS85Aya0QNm0cIokcBfl4ew1SrPm3w=; b=PR5rvvfYNg+q7dc4G6PNwvA6muxhCZeNMVdtUorpyVO8VSo3EF7nJnGMlZYszT+Y7H BZbbYfiGnZjH6d3NSoM1/vajB+JuCY/7xmsp3fTrXRSkbcRBF2GviLLcA+bviFJS5z28 wOBPpONYg5a2p1EN+ZYKKRq2tfMnMcsjyW7HBFP3sjmPqsRme/Ox2beh83VnzM4i1qx4 aStzbhJNp1YFlNPf1Sg1FLCOt4f58Om9CdXi/rGFs15+ssNK0y2N1xM5MODE36fwzbVY fB3OmqxbvKc67HL94MkuQvL8rn8wEZbPjDQorGDmz3t0flc8F1FYrDoFBpnQxKSzW9kR 3g9g== X-Gm-Message-State: AOJu0Yy9clS0ZSLmzlFhM6x0IRn4bc9IJbivGKplLB9wiM+95QdoWL3z OcfbeMb6c8hvAJVmyGkPiahgr3jhCidRjyx0RluqtyrjmwSkGcVTDOfA+cB5DhjFg33orICN8/k iIwiEN8c= X-Gm-Gg: ATEYQzwvRMDkcIwAFGkMvoOsRTf25F4E3ABtaLQOVTVH2MbXjTwGCQhMe8KEz+sv1jz lvVi4KytoTF9aSAD5gpBvBlc0nxmmOHr1/SRl/f+/1t2QZIswauAREMZn065YN4SGVgCxrEkFin ojxXYUDLeiJdccMdUVPO3h3QFvAEh6ijMTB826NxneLN32ZmJH7j7IfzVUm7hZDpdWKGz3ZeEAY Cr0sz++CnfTj4+hLn992cpp5hMXp1cB5tDiaFF4HtU9vrabPhq3fjqRPi0eT9Ho7cUOax2ox31X TpZZBE6JRBjElTqidSFWVXI5k61WPbuYoEqOyhuCq9+DnuFBtfs2uPKHq5T4g6vmmdJISRb8Vl4 LwfUucceqt6KAZv8Yka/s7ySXi9G6to6tS6DV4UMdhtzgzdjSzTvjHeayhx2EnjEMc7FS4pnLiz WmsbyZjiGj1aBrW1hFCfeeADsqolDqIRe7M63OnTIfNHprZ/WF6BCeZkzD+Oi8g7R7Fke3ApSM X-Received: by 2002:a5d:5887:0:b0:43b:4d25:959b with SMTP id ffacd0b85a97d-43b527a97a6mr12241121f8f.17.1773919231367; Thu, 19 Mar 2026 04:20:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Paolo Bonzini , Harsh Prateek Bora , BALATON Zoltan , Nicholas Piggin , Glenn Miles , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Pierrick Bouvier , Chinmay Rath , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 7/8] hw/ppc/pegasos: Replace legacy ld/st_phys() -> address_space_ld/st() Date: Thu, 19 Mar 2026 12:19:35 +0100 Message-ID: <20260319111936.68041-8-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319111936.68041-1-philmd@linaro.org> References: <20260319111936.68041-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773919297568158500 Prefer the address_space_ld/st API over the legacy ld_phys() because it allow checking for bus access fault. This code however doesn't check for fault, so we simply inline the calls (not specifying any memory transaction attribute nor expecting transation result) per the definition in "system/memory_ldst_phys_endian.h.inc": 27 static inline uint32_t LD_PHYS(l)(ARG1_DECL, hwaddr addr) 28 { 29 return ADDRESS_SPACE_LD(l)(ARG1, addr, MEMTXATTRS_UNSPECIFIED, NULL= ); 30 } 42 static inline void ST_PHYS(l)(ARG1_DECL, hwaddr addr, uint32_t val) 43 { 44 ADDRESS_SPACE_ST(l)(ARG1, addr, val, MEMTXATTRS_UNSPECIFIED, NULL); 45 } No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/ppc/pegasos.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ppc/pegasos.c b/hw/ppc/pegasos.c index 4217af25807..52e35949cc1 100644 --- a/hw/ppc/pegasos.c +++ b/hw/ppc/pegasos.c @@ -21,6 +21,7 @@ #include "hw/ide/pci.h" #include "hw/i2c/smbus_eeprom.h" #include "hw/core/qdev-properties.h" +#include "system/memory.h" #include "system/reset.h" #include "system/runstate.h" #include "system/qtest.h" @@ -593,12 +594,12 @@ enum pegasos2_rtas_tokens { =20 static uint32_t rtas_ldl(AddressSpace *as, hwaddr addr) { - return ldl_be_phys(as, addr); + return address_space_ldl(as, addr, MEMTXATTRS_UNSPECIFIED, NULL); } =20 static void rtas_stl(AddressSpace *as, hwaddr addr, uint32_t value) { - stl_be_phys(as, addr, value); + address_space_stl(as, addr, value, MEMTXATTRS_UNSPECIFIED, NULL); } =20 static target_ulong pegasos2_rtas(PowerPCCPU *cpu, PegasosMachineState *pm, --=20 2.53.0 From nobody Mon Apr 6 10:45:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773919308; cv=none; d=zohomail.com; s=zohoarc; b=HFGbUTZuiTGIBE+sdUX9oX7B+aJrkyloYCeEuobEeiOPjP8TYBTll22oBGoTxAkn8PMjK0ho1yB55kf8rp0m5pIH3mhODFOHcY/QBEst4JlWsRFlxpOze4MaV1Omo9M4os9YRaD1rYiYzXsZpaRtpKDa/NgTUANrXjcv+0RgVtI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773919308; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ILd32R5A8XKeMpYg01CS957pigNHqjKdgnpyoMw2kbA=; b=bqtjqRhRM/Zjoofk9MlupPg8t9PhZoU+4wSTvhlBnEuRhpfZQ+qVWiw1wH288xsGj5vmXyRFSs0eHlEwWw7/Sf971jOL2kjHGwOHPsCSCMZClNr//gWUeor2dwYKouRx3x2ZtUxXBiHOiFPwruZcj82Dlwvm/oSx1D56Ji1x1lE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773919308378866.625861917671; Thu, 19 Mar 2026 04:21:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3BQh-0007r0-Cc; Thu, 19 Mar 2026 07:20:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQf-0007qO-Nm for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:42 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3BQe-0006Pt-66 for qemu-devel@nongnu.org; Thu, 19 Mar 2026 07:20:41 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-486fd5360d4so1807245e9.1 for ; Thu, 19 Mar 2026 04:20:39 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8b949a5sm56957205e9.11.2026.03.19.04.20.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 04:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773919238; x=1774524038; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ILd32R5A8XKeMpYg01CS957pigNHqjKdgnpyoMw2kbA=; b=wi3WcjX/nsjKLL+xLWCMw2hICs2UGQBhOBnpj8DJyL7+E06bulr36MRGh0jzgvLT5F rhbHKfpJAWAtSUZIe+efqAxiGfv5dshPqjqXyl3R75/XRh6uTUHaSi3fjlT/ZKaxdUdN 6pMqoTmo9S22Un3AAcL3ZRYP8pTADc1uxs3fcqxKavY6gQpQwCMvkXyjiM5N33Zpg1/j T0cVzYqJ1HTYtUHOfrcvR4m89rrKL1hNtTXLW0BOyxHNKQOtT/jwEPkbpHUvc7kPx6dk YBmjzMcrGXgMxBjEeWKMHNMM9OIoyK2Hkhnmtu0pQZtdl5GD6I9eeX5JVcWMQqL5Z8PE 33fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773919238; x=1774524038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ILd32R5A8XKeMpYg01CS957pigNHqjKdgnpyoMw2kbA=; b=J0/FJX+LnImwSGyFb2tYkJ9XNBYeqNWOpC6NiJNE5wDM2UmI/HqFtSedsoAwL8cDP+ FxXUpMA0vFL7oPyBXnaaYweiOVuJJfD0Jw2xrO2REZp1kzXHX51P7o59kBLBnamUKAmm gAeEwOM6pQSCIQUvJ5n5JRtUZvdfltFyxhpzqY/bMfnjdqfXw/jRXsKVUnvKKAjo4IGj XiS/vbo+4lS5kLHY+rXA+iviwRDvLGZHGYrf1HlR6xOcCXS2xhvSjgrZ11wGV9wtk0FL raUCDBkK/ejABhw/YA+1UGsWzoQb3SDv+9UFCAeKy0N9+73wH+OlhX8hdPsfF9JwSNnU 9qEg== X-Gm-Message-State: AOJu0Yyqe4qJvQ8f4xD89ymZNiRN7EV2KcesV9xfJY3z8RaJkUI6k0fS O/DLPhScIoCmXOpjWRimRva3oeYxsHYGhINa0au+nRTFm3KCVv8/Rz194QvzJ0Ybw4oFq4ZGkns pcJnJoXs= X-Gm-Gg: ATEYQzyg3EhvRD6P2AWEK63qduYGWFgtfGFN2hAN0qn2PDebG8Im6DMGu6uYrB3FVib xyIM96KCnPUxVO+/JffM3jxlj4HMhat1RVB7KOsmwzhC+XiL6PUKOe8ceTISpURoJwI3IrSPLee WBRcrEzfwiQBQMhabvQXZEAY7cuQbOCAN15V5LEmQ8ocJZsUWKEwgMxrLRm2UnviLGd6jine6Dz d4ymZ88HrI0iDHwYFwWsbTy4r55RHvyQvXsr3OrR8WkjiaAqgyfUmqjcSlmEeJiANYAheLUlpu8 hIozQXvIE6wMdU+VgzQFDAdDEpbhMJaMhiTilTlpGlybhsljdE0M7F/WtImAN7suJXRrhZORpWY rsakSJ3RQXhCD2u5z8dI6D2oYYZx7t8Y5mOMV12SzFjJWSj6TyteNMOHJN8iTECmLxHTZBalYbw LRd9eoZ3DOufhEk81a2ITXXcBvO3lB/nimFQZkQnGd0L5/v9F9lSKw5QfrK+xNTLsBB50i+LdPS jOkQIJRQY4= X-Received: by 2002:a05:600c:630f:b0:485:3fd1:992c with SMTP id 5b1f17b1804b1-486f443850dmr121722005e9.1.1773919238343; Thu, 19 Mar 2026 04:20:38 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Paolo Bonzini , Harsh Prateek Bora , BALATON Zoltan , Nicholas Piggin , Glenn Miles , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Pierrick Bouvier , Chinmay Rath , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 8/8] configs/targets: Restrict the legacy ldst_phys() API on PPC Date: Thu, 19 Mar 2026 12:19:36 +0100 Message-ID: <20260319111936.68041-9-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319111936.68041-1-philmd@linaro.org> References: <20260319111936.68041-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773919309555158500 The 32-bit PPC target doesn't use the legacy ldst_phys() API anymore. Set the TARGET_NOT_USING_LEGACY_LDST_PHYS_API variable to hide the legacy API to the qemu-system-ppc binary, avoiding further API uses to creep in. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configs/targets/ppc-softmmu.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/targets/ppc-softmmu.mak b/configs/targets/ppc-softmmu.= mak index 867898bd47c..ae7d593bf0d 100644 --- a/configs/targets/ppc-softmmu.mak +++ b/configs/targets/ppc-softmmu.mak @@ -3,3 +3,4 @@ TARGET_BIG_ENDIAN=3Dy TARGET_KVM_HAVE_GUEST_DEBUG=3Dy TARGET_XML_FILES=3D power-core.xml power-fpu.xml power-altivec.xml power-s= pe.xml TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy --=20 2.53.0