From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773829960; cv=none; d=zohomail.com; s=zohoarc; b=bKJAtWsY9RWSzP6SjPYuztSP2bcB1OBnxJGzj2GU1qPGHClnTrgcN1Eq8OSlNlZO0FlzcmlkJU3SfaUJ05ZyF1P9oXAhGKqmEMhP4XKRkxNOjytvFyLumzkAdi5VYT14IDwBrL+cb7xlDfnMYie11ppw6NRbfNoB0iaHGpgCOWs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773829960; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9m3lV3ME2W//2gUlABuyu3FspRWa1EzICjXujSbCOe0=; b=AjcnIFREnJoObPrpcpNNMjCPL+mZk3h+SwEoUA3373oETm6X80ols9qkSW9kc1yobGRT5f/3mno9hTt1l1VGRcXhNyCiTksgecJ3iCuHPHxPqCSlMc8+vmNty4wMFotIuo+2651+hIRd0qHIBU1R6fGJz7IPN4Rr7m9dDPEOerI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177382996094169.28582958468769; Wed, 18 Mar 2026 03:32:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oBp-0001Tj-CB; Wed, 18 Mar 2026 06:31:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oBe-0001QI-Ti for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:31:40 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oBa-0001dn-4f for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:31:37 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so60450055e9.2 for ; Wed, 18 Mar 2026 03:31:33 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856ea8fad1sm236021045e9.1.2026.03.18.03.31.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829892; x=1774434692; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9m3lV3ME2W//2gUlABuyu3FspRWa1EzICjXujSbCOe0=; b=ffNd3l6oxlbluOwjjk1qNv+4gy+aC/be3kuupvXakeC8JM6zrCVzgB0xGyW18luFLo G/8D+uFo982ndiRiviLYFtCB1jqNCbr72AuMoJeoH3e6/QfTF833lsrllqVWTo4uK4qA d/bdc/gpA9Xe19m9V0gA24FGK3mQOSwHlMJgquAnxlDDu0+ID7Q7uH4qk5phJLrTqtHN dFQhY2KBwBQd5Rfpl3uHfxdT160BN9/DeCX5elCcwokaRGykkxRSKfG6Qpihlp8tYP8s +AOG13lH37gh7zFuJkOfx7YStWW2DiUYqpiiqfH/1TmXU7UUxiXtqg7uIei6kdWgx7WS RI0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829892; x=1774434692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9m3lV3ME2W//2gUlABuyu3FspRWa1EzICjXujSbCOe0=; b=NAM5T5Azj+mfw/EHLFtblOXKPzYvGyC8uRejPHCDr4CJyTarYudtbq90u9QBBDkwlC IkpC5OLAvhgreaI4Se6TFlDv3bNLf9W+wtkKI1MQzO1bTLk3q3amgj82WKreq2AU0AtM IvpsZS80Wmc83iAG/lYRKGyL4jZPvMd38zPbVBh9OvIXMy/vPuOv6FwJu6h8L9SSFW7F mEoyYP/eKDilElChsSXx393uOa5L0Upulo8nh5HPC7OLmNftO1JI/j9xQaThZ/xJBcXD AeJ8loP6wVNwVjdZ3vDc/P9l7zg5zumjSSiecYiYBz1QoUb7VRLubuvBkLf/phLKm7ue Agkg== X-Gm-Message-State: AOJu0YybUQhDOyZbTtzS5UuBnP15Yhls6cCWb065G4bvhxP+K4q4ewFg n6YB6MS57Opr/SV7v6OTlqmZNmxTHWdWEE7LGAUkvTs1aoySgqiJXcBEgzphoTlOgl8IK6x0ZZg 4fpEzqE8= X-Gm-Gg: ATEYQzwqxxHIpYiFCfqdlu2TIfdXpoBSNpr5ymYjG0gfZRrefOkfYCwYMH2VnJQWUiu VjzJMboTYu5lK+Sbb6Uyp8b15GGziiDU7E4Aixo3WL9cqyucZpiLsx+TEQ05TxVqYNsgQBfTZ7q z5h4dCiVb7LHv9LHdtRWWk0RT4gatPGIizKGT/kGqFO298z+vV+bau2eGa0M9v0xM2HFCXD9/L9 rsca5b9WuS4p95+2bZMSLT8byUX7MxRvptaXa1VX2XGNugvSDdY931N0DoySQVVsbWcxL1/WTpz gCEEc1s15seZs++e7mkusvYZqU9N/GaTYHrFXiZ1t9z/36LFnIDwVGcaaCFkT1paZKa+kRbpTc7 AzTMBwgdTAMbJf9+JiAdgwahn3c8eGgR30aRg697ugYWDIFKJK29cU5hd92oOsqCjxzVSorhTx1 264SRqlAXqDp50URxTG1NkBCJAyqfLGrxC/AkBZVENGBc2E6zpkVReDzFfuOykegbNy3WilZzw X-Received: by 2002:a05:600c:4e49:b0:485:4136:99a8 with SMTP id 5b1f17b1804b1-486f4441072mr40432815e9.22.1773829892293; Wed, 18 Mar 2026 03:31:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , "Edgar E. Iglesias" , qemu-arm@nongnu.org Subject: [PATCH-for-11.1 01/16] hw/riscv: Mark RISC-V specific peripherals as little-endian Date: Wed, 18 Mar 2026 11:31:06 +0100 Message-ID: <20260318103122.97244-2-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773829962693154100 These devices are only used by the RISC-V targets, which are only built as little-endian. Therefore the DEVICE_NATIVE_ENDIAN definition expand to DEVICE_LITTLE_ENDIAN (besides, the DEVICE_BIG_ENDIAN case isn't tested). Simplify directly using DEVICE_LITTLE_ENDIAN. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/char/ibex_uart.c | 2 +- hw/char/shakti_uart.c | 2 +- hw/char/sifive_uart.c | 2 +- hw/misc/sifive_e_aon.c | 2 +- hw/misc/sifive_e_prci.c | 2 +- hw/misc/sifive_u_otp.c | 2 +- hw/misc/sifive_u_prci.c | 2 +- hw/riscv/riscv-iommu.c | 2 +- hw/sd/cadence_sdhci.c | 2 +- hw/timer/ibex_timer.c | 2 +- hw/timer/sifive_pwm.c | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c index 127d219df3c..26ed1aea140 100644 --- a/hw/char/ibex_uart.c +++ b/hw/char/ibex_uart.c @@ -470,7 +470,7 @@ static void fifo_trigger_update(void *opaque) static const MemoryRegionOps ibex_uart_ops =3D { .read =3D ibex_uart_read, .write =3D ibex_uart_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .impl.min_access_size =3D 4, .impl.max_access_size =3D 4, }; diff --git a/hw/char/shakti_uart.c b/hw/char/shakti_uart.c index 2d1bc9cb8e2..d38920a03a0 100644 --- a/hw/char/shakti_uart.c +++ b/hw/char/shakti_uart.c @@ -103,7 +103,7 @@ static void shakti_uart_write(void *opaque, hwaddr addr, static const MemoryRegionOps shakti_uart_ops =3D { .read =3D shakti_uart_read, .write =3D shakti_uart_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .impl =3D {.min_access_size =3D 1, .max_access_size =3D 4}, .valid =3D {.min_access_size =3D 1, .max_access_size =3D 4}, }; diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index af17cf9a6ce..4e31842df5c 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -206,7 +206,7 @@ static void fifo_trigger_update(void *opaque) static const MemoryRegionOps sifive_uart_ops =3D { .read =3D sifive_uart_read, .write =3D sifive_uart_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4 diff --git a/hw/misc/sifive_e_aon.c b/hw/misc/sifive_e_aon.c index e78f4f56725..ff2a7c18235 100644 --- a/hw/misc/sifive_e_aon.c +++ b/hw/misc/sifive_e_aon.c @@ -250,7 +250,7 @@ sifive_e_aon_write(void *opaque, hwaddr addr, static const MemoryRegionOps sifive_e_aon_ops =3D { .read =3D sifive_e_aon_read, .write =3D sifive_e_aon_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .impl =3D { .min_access_size =3D 4, .max_access_size =3D 4 diff --git a/hw/misc/sifive_e_prci.c b/hw/misc/sifive_e_prci.c index 400664aabae..a4a60e7b406 100644 --- a/hw/misc/sifive_e_prci.c +++ b/hw/misc/sifive_e_prci.c @@ -75,7 +75,7 @@ static void sifive_e_prci_write(void *opaque, hwaddr addr, static const MemoryRegionOps sifive_e_prci_ops =3D { .read =3D sifive_e_prci_read, .write =3D sifive_e_prci_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4 diff --git a/hw/misc/sifive_u_otp.c b/hw/misc/sifive_u_otp.c index 7205374bc39..cececd4f7a8 100644 --- a/hw/misc/sifive_u_otp.c +++ b/hw/misc/sifive_u_otp.c @@ -187,7 +187,7 @@ static void sifive_u_otp_write(void *opaque, hwaddr add= r, static const MemoryRegionOps sifive_u_otp_ops =3D { .read =3D sifive_u_otp_read, .write =3D sifive_u_otp_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4 diff --git a/hw/misc/sifive_u_prci.c b/hw/misc/sifive_u_prci.c index f51588623ab..4674d5925ea 100644 --- a/hw/misc/sifive_u_prci.c +++ b/hw/misc/sifive_u_prci.c @@ -112,7 +112,7 @@ static void sifive_u_prci_write(void *opaque, hwaddr ad= dr, static const MemoryRegionOps sifive_u_prci_ops =3D { .read =3D sifive_u_prci_read, .write =3D sifive_u_prci_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4 diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c index 98345b1280b..ef5d7df2385 100644 --- a/hw/riscv/riscv-iommu.c +++ b/hw/riscv/riscv-iommu.c @@ -2375,7 +2375,7 @@ static MemTxResult riscv_iommu_mmio_read(void *opaque= , hwaddr addr, static const MemoryRegionOps riscv_iommu_mmio_ops =3D { .read_with_attrs =3D riscv_iommu_mmio_read, .write_with_attrs =3D riscv_iommu_mmio_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .impl =3D { .min_access_size =3D 4, .max_access_size =3D 8, diff --git a/hw/sd/cadence_sdhci.c b/hw/sd/cadence_sdhci.c index d576855a1a8..8476baf67fb 100644 --- a/hw/sd/cadence_sdhci.c +++ b/hw/sd/cadence_sdhci.c @@ -122,7 +122,7 @@ static void cadence_sdhci_write(void *opaque, hwaddr ad= dr, uint64_t val, static const MemoryRegionOps cadence_sdhci_ops =3D { .read =3D cadence_sdhci_read, .write =3D cadence_sdhci_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .impl =3D { .min_access_size =3D 4, .max_access_size =3D 4, diff --git a/hw/timer/ibex_timer.c b/hw/timer/ibex_timer.c index ee186521893..0f12531934d 100644 --- a/hw/timer/ibex_timer.c +++ b/hw/timer/ibex_timer.c @@ -234,7 +234,7 @@ static void ibex_timer_write(void *opaque, hwaddr addr, static const MemoryRegionOps ibex_timer_ops =3D { .read =3D ibex_timer_read, .write =3D ibex_timer_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .impl.min_access_size =3D 4, .impl.max_access_size =3D 4, }; diff --git a/hw/timer/sifive_pwm.c b/hw/timer/sifive_pwm.c index 780eaa50799..4f4f566cd4b 100644 --- a/hw/timer/sifive_pwm.c +++ b/hw/timer/sifive_pwm.c @@ -388,7 +388,7 @@ static void sifive_pwm_reset(DeviceState *dev) static const MemoryRegionOps sifive_pwm_ops =3D { .read =3D sifive_pwm_read, .write =3D sifive_pwm_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 static const VMStateDescription vmstate_sifive_pwm =3D { --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773829977; cv=none; d=zohomail.com; s=zohoarc; b=VLD38wFIFXTHDwIGT1sBFmNJnJYg4VTAvdBGjnjv8lBLGF7zw+qrzdeyYM23Tlfk1NRXmeLbNVE2XT7idgPEi5oD3l8BnfRjdbD3UZ1b4Zg852eTI7mVtouqRqPqbHcCCKvGkIcmnak2TjOnc4x4vFevYV3GTVSMexopU56K9Vc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773829977; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7Yr8oa0KZPJED/ap4UIxqQ/hv0GrjFZS5ezJZG5FycQ=; b=aRl2CFmhWOBPTdSKV98fhLxG8J52SFWPs/OybLsSCm1bCG1DHCopLSsOvIEOLjydHFMMFaKDXPsEAVrOR1adqSG5FdrRvExh1P21atRwHc+4W8uMj8uyZVZLk/PSX/Xo3pTnYHMDVKpxzVHJFXpDODvBeTesfHw58xjiQwzK6p8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177382997700363.60700176542184; Wed, 18 Mar 2026 03:32:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oBn-0001T3-R2; Wed, 18 Mar 2026 06:31:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oBj-0001RR-5D for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:31:43 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oBh-0001sQ-MZ for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:31:42 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-439b9cf8cb5so7576067f8f.0 for ; Wed, 18 Mar 2026 03:31:41 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51892228sm7677849f8f.17.2026.03.18.03.31.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829900; x=1774434700; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7Yr8oa0KZPJED/ap4UIxqQ/hv0GrjFZS5ezJZG5FycQ=; b=owV1Jq9l7qun5V03ufkFpNy04SCqHhq/aaeqOrExjQTS0l3QVC+KBTCmJt8PUfDthu aw4Tj0dYtaqkK8fjJEM/8wFS/AOHT60hFWBCaBlX0KjybwWF6lclN8hX4zOjz2iFSj42 edA9L5a9mk3pH5G0s58XtXSjdlS6fRLxMP7Tp0aYM0R35ceLHVwkqliuVujzWEQ9KJHg 80XdWihg6HWcp0sjsXJT/qGncKaypoK/UcM1SYWO44PELoL3+PDAJfmkbdS14aUcpaz4 Y7PXROOqF30UH8Pv0ZZZjdZKpDvEUS0KabcgzBHhHh2GF3ZC6IHCSleoZFfb61hxzdm2 YiGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829900; x=1774434700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7Yr8oa0KZPJED/ap4UIxqQ/hv0GrjFZS5ezJZG5FycQ=; b=sx4YEiyPqCC0xsCFZqNJJHK9FYMwjk8aqZzifAXW+JfDRptGX2+l0htS21h2I4fpoC GHOCLBLpYzON7FpWCAe33ezR1jbaBzvD6IOjiCWV6+vXvTRnpWjcbgPxh+9jp2i55C8Q DRx4ooDUwjSimx5w40T4ECgVW7Q2OP+LPbjkovfygSXXnbXpdXb8bgL+5IUVzwwVbztE unqaXZ9aEGBuRaSh5C7eULVJfTzmbqO41jp9ANMa3uAZgAz6kRRHyR/ZECOOh+1wwpsF /n5DEFOnyo6MlhUJac/0mz4zaeXMNy67AHDdsAvNqqeffTKKNOIw/8JeNSReSYTCpGud rVDw== X-Gm-Message-State: AOJu0YzgPaKh2xSxdUDzXE8Ni6oarSvV35PHjv98wuMpz27E+vw+84WA mH1/w1ct3TnyGePQfs9dJ1coyZFe+2PEF0ycpRdgvuhZzLuA2xIos3I8R8cNz1t2j4b5PbRCib0 Hb7p8WAo= X-Gm-Gg: ATEYQzwnk88Vkwsq7RGHbsdDv/KQlFFNaXMOEdlhYpqZ0smTdOtPc5SxehGtY38qd4B n6+GHONMGtcqGSNR97sgM6vrORITUIXmOMln0VjRllTJ5ElNjCJYGqp3ILEBnNecGpk7TXjCoYI OIiz1/YItK8HUhp1jf5ZfSskArpngHVkK68bK3w9D8qGT8if/lzeVPhp2QB2ix/aPSnyhm8FRSO HrtLpKo9n8vepQqFOQAEHgESiydmXMM/O5ooHrt74kkWQF2I9kDnw90JlwSV23sw4AXWJDTpt7y +XHPWtiSqNnfIAxoQuvPfkJPSps3tCQThv0QYlAK3aJfrau7ZQhCc9ppbcege2uO+LeHgHqWfGG Yu/FEJJSxvfjQcQb0fKBz2GKGW12MDPlheDetaNYJ2xXEqTUYFkr8Gu+VueLiH03tZZzdCumHO3 6grEvUQGL4d3QkK6X3r2HFsuuhWp+ne99J3qy/D7O7/Sa3DoqTOCmILna3YrtDrNdkHlSSIRmn X-Received: by 2002:a5d:5f86:0:b0:439:beb9:5a96 with SMTP id ffacd0b85a97d-43b527c4291mr4954019f8f.31.1773829899779; Wed, 18 Mar 2026 03:31:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 02/16] target/riscv: Use explicit little-endian LD/ST API Date: Wed, 18 Mar 2026 11:31:07 +0100 Message-ID: <20260318103122.97244-3-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830002752158501 We only build our RISC-V targets as little-endian, therefore the LD/ST API expands to its little-endian variant. Directly use the latter. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_le_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' target/riscv); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/cpu_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index dd6c861a90e..c28832e0e39 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -1365,9 +1365,9 @@ static int get_physical_address(CPURISCVState *env, h= waddr *physical, } =20 if (riscv_cpu_mxl(env) =3D=3D MXL_RV32) { - pte =3D address_space_ldl(cs->as, pte_addr, attrs, &res); + pte =3D address_space_ldl_le(cs->as, pte_addr, attrs, &res); } else { - pte =3D address_space_ldq(cs->as, pte_addr, attrs, &res); + pte =3D address_space_ldq_le(cs->as, pte_addr, attrs, &res); } =20 if (res !=3D MEMTX_OK) { --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830003; cv=none; d=zohomail.com; s=zohoarc; b=EvnoPPc+rn8oazjGDiIKM5w+gut9RaPJgCBUus2QjiLsIHR+YIvdId1NX6QQq7EotUV7zqr9nx2JqQ74Wuk2w7jkQyqQ/nAi2IWDAdqHwFPOQXmr5kLwe+I+eNVZ7uB77tZMf6EMTunz+YPnMNHXKAtOTng+4cWxj/7fdvd2VUQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iQ3zUzJ2FjK4yIIVfR4qK+5n7J5Lr2pGjFB5SIZiZ7w=; b=h7q/+1mzUmxzRRH7s62YUvV00A8I84Lf+6QyKs6Uc9cJ/aSkRSEmYV0WelX5KlGCtqBDUYg8eZonRJlw/phjnI9osxFRgaynE2Dt1kp1D4Ma6TbtQKU6AzViJ4kqhax75tNLRY94pKCyyU4zAD4KyLcNBMLvVQVkm294K7tVggM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830003400106.8716839099319; Wed, 18 Mar 2026 03:33:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oBx-0001X8-IO; Wed, 18 Mar 2026 06:31:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oBt-0001Vu-Qw for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:31:54 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oBp-0002IC-T9 for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:31:52 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-48539cbb7b1so40271975e9.3 for ; Wed, 18 Mar 2026 03:31:48 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b5184b7f7sm6663962f8f.4.2026.03.18.03.31.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829907; x=1774434707; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iQ3zUzJ2FjK4yIIVfR4qK+5n7J5Lr2pGjFB5SIZiZ7w=; b=X18wNVTyITY+KkxiNeXDVH5HOUm5Fw3bYvUgSj4YY4/cpWYvz+PC7VHqVEtVW5MIHE VdkuwszeQ6g2UYDTI2cKUCDi13D+NXQsUQiSBwXyNqxidA91vP+scrdt4ZLfCn8NumLh nvE8DjqN8DgHTkkfeXar+vf146W4NxPSSH/XoxvxtZES9g0zoYiRa8kKIzqzK/WPXD3J 298Er9V1vMnM6Thr661mS0hpNdNzH0doqmb0tFmQBk7pd+psAqNpkoI5zUDO50hCOVe7 Fe1vSK0coij8tKiRb/g1Fc84EmJSiA+gyGMPr1K1tps9DW++mEFHBdbQuqoSr4zt+GZH Rtog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829907; x=1774434707; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iQ3zUzJ2FjK4yIIVfR4qK+5n7J5Lr2pGjFB5SIZiZ7w=; b=aUOOCs60gGMzMC4fordNuODqvJTiTjFv1wscf2D1A3hq0EE31iErsYtMHc6kkSku4p cvoZ0Tcx3IezVnocXZccCb5C876EWX+OXMKvnMNcxR/FRSewkpWh47uCahI89CelNI0C fxkqNYr+QavQYhik4VG99eg30ZwKXdit32JvI3IA32TUwyFs7yWe4Ats36McG/v3vvjm 3+7MHFUX00s9X4m/VUhwkew1bhjE8Zoic/6wDu0iAjElSVPtUz7JdT71RyyshX+2tDRr CkjbBQd8eeH0U8ShxdrLSRN/qfpWhqwsSPHT3ic5qtwXB86jfkjPFYZ21OGEqett7L45 v97A== X-Gm-Message-State: AOJu0Yzqz4rv/DM+XJtajAWr904iQ4Fuc1HGNgY/0lUfgJWwzKRxaIFd Y0vR4/DdFbqqpRCYPjcdTZlaQVHJjifz0tpUg5ePXqufmxA9Dwqzj8yMQYfdjbcrNGvr5Xo5+QO TpnqbaLs= X-Gm-Gg: ATEYQzwrMa2a9XxGG9f/kOfH5v9Ld6kKq80snGT4YBfah3pzGzXc0ib8AVAYVc3aXJs mx/Fkf+cBVWK+oDj2F26pkPPHD65OIPbQ9HU064NCWmvon8gpn+tT4q8rD+9DCuZUlANGyY054c fjxPUfZZBmcJg1eD/tOUhar0HySzI5Kj+TjEo9OQ/crIwGRJuwWhrP6BLD8KXf3T1pTpssA/U6Z i2yYOw/K6/dAmbHR0xzUIpMA/7y/W/IsX6rw+11QF0RoYW2epWe/IynVYWe6PTTHhcrdKEMaefT JI6H731PTK6xvFXr2YyDN5wFHLaXTddcxiD+M0ycY7wbYAeJsMTwvcug1O8fYMe8gXzgZUMsO39 BabgCPUhddFyfW80ZpmEUrrogwInD35IdwW/5fJPPA6Jg5OqjQWpmNNUNs3Wki/UqWIG1+OMq9d lKMpn+hmKoKQjwM2P1JNumhy/uK+5eZGrcM3A8nxsnLyL83QmdQH6g80qwkC7ekp51bUmXUgZs X-Received: by 2002:a05:600c:8b45:b0:480:3ad0:93c0 with SMTP id 5b1f17b1804b1-486f457970bmr39907745e9.23.1773829907104; Wed, 18 Mar 2026 03:31:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic , Richard Henderson Subject: [PATCH-for-11.1 03/16] target/riscv: Make LQ and SQ use 128-bit ld/st Date: Wed, 18 Mar 2026 11:31:08 +0100 Message-ID: <20260318103122.97244-4-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830003949158500 From: Fr=C3=A9d=C3=A9ric P=C3=A9trot The lq and sq helpers for the experimental rv128 architecture currently use direct memory accesses. Replace these direct accesses with the standard tcg_gen_qemu_{ld,st}_i128 TCG helpers that handle endianness issues. Reported-by: Philippe Mathieu-Daud=C3=A9 Suggested-by: Richard Henderson Signed-off-by: Fr=C3=A9d=C3=A9ric P=C3=A9trot Message-ID: <20260101181442.2489496-2-frederic.petrot@univ-grenoble-alpes.f= r> Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/insn_trans/trans_rvi.c.inc | 32 ++++++++++++++++++------- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvi.c.inc b/target/riscv/insn_tr= ans/trans_rvi.c.inc index 54b9b4f2413..2c82ae41a77 100644 --- a/target/riscv/insn_trans/trans_rvi.c.inc +++ b/target/riscv/insn_trans/trans_rvi.c.inc @@ -377,6 +377,9 @@ static bool gen_load_i128(DisasContext *ctx, arg_lb *a,= MemOp memop) TCGv destl =3D dest_gpr(ctx, a->rd); TCGv desth =3D dest_gprh(ctx, a->rd); TCGv addrl =3D tcg_temp_new(); + TCGv_i128 t16 =3D tcg_temp_new_i128(); + TCGv_i64 tl =3D tcg_temp_new_i64(); + TCGv_i64 th =3D tcg_temp_new_i64(); =20 tcg_gen_addi_tl(addrl, src1l, a->imm); =20 @@ -388,10 +391,14 @@ static bool gen_load_i128(DisasContext *ctx, arg_lb *= a, MemOp memop) tcg_gen_movi_tl(desth, 0); } } else { - /* assume little-endian memory access for now */ - tcg_gen_qemu_ld_tl(destl, addrl, ctx->mem_idx, MO_TEUQ); - tcg_gen_addi_tl(addrl, addrl, 8); - tcg_gen_qemu_ld_tl(desth, addrl, ctx->mem_idx, MO_TEUQ); + tcg_gen_qemu_ld_i128(t16, addrl, ctx->mem_idx, memop); + if (mo_endian(ctx) =3D=3D MO_LE) { + tcg_gen_extr_i128_i64(tl, th, t16); + } else { + tcg_gen_extr_i128_i64(th, tl, t16); + } + tcg_gen_trunc_i64_tl(destl, tl); + tcg_gen_trunc_i64_tl(desth, th); } =20 gen_set_gpr128(ctx, a->rd, destl, desth); @@ -488,16 +495,25 @@ static bool gen_store_i128(DisasContext *ctx, arg_sb = *a, MemOp memop) TCGv src2l =3D get_gpr(ctx, a->rs2, EXT_NONE); TCGv src2h =3D get_gprh(ctx, a->rs2); TCGv addrl =3D tcg_temp_new(); + TCGv_i128 t16 =3D tcg_temp_new_i128(); + TCGv_i64 tl =3D tcg_temp_new_i64(); + TCGv_i64 th =3D tcg_temp_new_i64(); =20 tcg_gen_addi_tl(addrl, src1l, a->imm); =20 if ((memop & MO_SIZE) <=3D MO_64) { tcg_gen_qemu_st_tl(src2l, addrl, ctx->mem_idx, memop); } else { - /* little-endian memory access assumed for now */ - tcg_gen_qemu_st_tl(src2l, addrl, ctx->mem_idx, MO_TEUQ); - tcg_gen_addi_tl(addrl, addrl, 8); - tcg_gen_qemu_st_tl(src2h, addrl, ctx->mem_idx, MO_TEUQ); + + tcg_gen_ext_tl_i64(tl, src2l); + tcg_gen_ext_tl_i64(th, src2h); + + if (mo_endian(ctx) =3D=3D MO_LE) { + tcg_gen_concat_i64_i128(t16, tl, th); + } else { + tcg_gen_concat_i64_i128(t16, th, tl); + } + tcg_gen_qemu_st_i128(t16, addrl, ctx->mem_idx, memop); } return true; } --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773829979; cv=none; d=zohomail.com; s=zohoarc; b=JLvrG5TqODxcjdjwV5CUV+aAKzsDD8tp+QAueEr6oB2ycsxVzlu4orDfFb6j1fLaPI3bXQY1IAr3AfBaKOGcAQd/D3Uu576duEge5f0Tb19yhSedLIcQ6toH6m9W5fZiFHcmB0j9Y7NFJJ5mHFdRj3vVDmjTCVgrogmlQXekIk0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773829979; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FMfrcT4w/8JaS+GLgLEbdAlqvnuBLRTQjJxeUizycR8=; b=HwtH3AmYSWPN5i73s75O9ZPOilg4JtmLRMbMyPYTXnPDEHGB4zxnQFeuXOJpKasoV4NKOulXQ2VvpFtgD7m+Gx7qK5KJ/kwrwdVnnQbqhT9d0BLwGya33wqzPcUTZ0GqP3VFxtF5uZQkOl32R2P4zb9eQWyVMxer3K7Xot7RCJM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773829979290714.1748851455857; Wed, 18 Mar 2026 03:32:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oCO-0001aU-VK; Wed, 18 Mar 2026 06:32:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oC3-0001Yg-BZ for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:04 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oBw-0002Ok-Ti for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:31:58 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-485410a0a8aso60403555e9.2 for ; Wed, 18 Mar 2026 03:31:55 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51852aa8sm6046099f8f.15.2026.03.18.03.31.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829914; x=1774434714; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FMfrcT4w/8JaS+GLgLEbdAlqvnuBLRTQjJxeUizycR8=; b=rwstKfZfr0o5psUtzwW19y9UWmlWm9Mm+bIx68I6nNu6V9jYrSx1+GoPcDp4JuwXs+ GhVwyWNjAzUKBOB3IsxJRZCHXxyEb0iXhlTMRagTrw/SApEMHNGQ+f5z4ZrJRZeYrPDL DGJF0853ZyN3u6FBnvOy/uu9FOjqJq1BZKhqrHEsYh77f1wWBlPv4KU7rfsxn5uxs1Z7 58TbyaAjmHKZL9RoVyn3YE52isjP2a/eo1syzJc0gHYPX0FVUGfWkFSKzrBO7PN3h3Eu 4LZTfoFfYkWKU7sG4H0OdmK7nQyzLz5T9nJUmAlp2WoWYrpEQmiwaoEqNELOff/WbXnK 1ouA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829914; x=1774434714; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FMfrcT4w/8JaS+GLgLEbdAlqvnuBLRTQjJxeUizycR8=; b=pTTBNJQVHqDfbMwHHC3LgvGlM0PBR9uVxHnEJxk/tRSzICZdzUaR97hle4L2J5BJNo p5HWjiGNQT3inEMVZ6yaM5bW3GaLeF64orr01cLwW3uA2puvrbiO0ZuTMinZ76tR6/t2 +WXh1y09+zPTgRGcG2ngKN+3kf7q41SF6sIyNnaneMl5D0TcEHIWyA8PaEzSVqUdpOgM NVHzfjRtX7Fn79WFW5SFQ1KrUq1iEdxpoNqZV6onD0KbaZKD3zjeLnobOou/mKP2PNZQ ZdL87vfoMrSuxdpBVN+Exs3ri7PcKI8+Q/9jJQoRU6ueDjX1Yyz+dr806smA327weih7 hP6A== X-Gm-Message-State: AOJu0YyPZYeQ3g7nGpDygq2DBzujI74ckG1zsXU7Bby4QbzyoH3u+Qik iI0dnJ9uedwa5PZvoPoinAp5ipy4PGBatTIPil99NA+0UdB/3FMHyRMHvY3MFFqPsWA5MtAT6fi ecgCnXfg= X-Gm-Gg: ATEYQzwQsA1cem5ucw1gjdvDz+CB9BvdIO+zawGaFXhazudXoOSE9bAhg5ls2eoKlKK cYQgU9ePwmnrXCD40CFv+w8k8DUWu/VUelY4hEdQRcTkP/k9GEAoEQlji8ah9p/UDoCukLChrnw Dr1aiZ4/xSH8KDtCEuy5o8ylZ3qWdNE24ucCh4ZUxkE0is7tN2D2RqlS9No7oJ+5NRIEYmZVFdH I8jL1FBjmghEBJ5NFTWpAWYYRePHKq8PF+wh0XSJZFJlyE7cq8xUhuGQBq8+oBRmC/MJg3qVaDE 1GBGNVbEKiDSB3hqTns2JzVEcTFZBEUkFgu5d7LBlVCi+NvHlwE7+Sy/KuYxwOpdCreiuOPufor XNdfKchVKO2xd+4cdKo5pb5yk6J1t+MY9f5uQoe64ejsnoBg9wtzMR2+f+CncCvR6WH4IzFGSHR f5xruvaetcNrtyyZDDjB/BEKxfkf0+XKiHglVNXIaksHwClolcxcu3pZI7B3qSfsHHmxerHRc+ X-Received: by 2002:a05:600c:8b0a:b0:485:3193:6ddb with SMTP id 5b1f17b1804b1-486f442207amr45600085e9.3.1773829914488; Wed, 18 Mar 2026 03:31:54 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 04/16] target/riscv: Remove MTTCG check for x-rv128 CPU model Date: Wed, 18 Mar 2026 11:31:09 +0100 Message-ID: <20260318103122.97244-5-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773829980488154100 From: Fr=C3=A9d=C3=A9ric P=C3=A9trot We had to check that mttcg was not used when executing QEMU with -cpu x-rv128 as a single 128-bit access was done as two distinct 64-bit accesses. Now that we use the 128-bit ld/st that access the data atomically, this check is no longer necessary. Signed-off-by: Fr=C3=A9d=C3=A9ric P=C3=A9trot Message-ID: <20260101181442.2489496-3-frederic.petrot@univ-grenoble-alpes.f= r> Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/tcg/tcg-cpu.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/target/riscv/tcg/tcg-cpu.c b/target/riscv/tcg/tcg-cpu.c index 988b2d905f5..3407191c224 100644 --- a/target/riscv/tcg/tcg-cpu.c +++ b/target/riscv/tcg/tcg-cpu.c @@ -1305,16 +1305,6 @@ static bool riscv_tcg_cpu_realize(CPUState *cs, Erro= r **errp) } =20 #ifndef CONFIG_USER_ONLY - RISCVCPUClass *mcc =3D RISCV_CPU_GET_CLASS(cpu); - - if (mcc->def->misa_mxl_max >=3D MXL_RV128 && qemu_tcg_mttcg_enabled())= { - /* Missing 128-bit aligned atomics */ - error_setg(errp, - "128-bit RISC-V currently does not work with Multi " - "Threaded TCG. Please use: -accel tcg,thread=3Dsingle"); - return false; - } - CPURISCVState *env =3D &cpu->env; =20 tcg_cflags_set(CPU(cs), CF_PCREL); --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830003; cv=none; d=zohomail.com; s=zohoarc; b=FMWDpcg0pufk1vhO7B1Dtat/Hbk8TQ9wgu6gfxAJqvcSq89mn30rxmOwBrx/RxwSeIq+8nPA2Ps/djbf2fNzaQES+xLOClp6EIMMpjRfF9oAPm5lL1whz6FyO2SREqVSP7eoO1lNy2lweLKiRR79Rpa+X1HGYcDjVcRmA0b5qK0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OnDCTRCky1piZxyLRpsMcdQHH/JXGmpFXuBfJy0DyaU=; b=DnD0gmcPDr9YA3bz6Og+16symm0rvIQeFoNIY/5C04ATib0fHIiTZAL6Hfn/tiuXkbiQDEyN1jFPCmJbLgNmIeEL4eJ7LJL8kXHk2sO4rSs3REP73RFmtl+ijpjb7N+vzYc3xw3uC1b/sA+zssIeccr5TPo7bNZOAuS9VB5CDuI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830003334467.0720120649753; Wed, 18 Mar 2026 03:33:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oCV-0001p5-QZ; Wed, 18 Mar 2026 06:32:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oC8-0001ZR-UY for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:10 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oC5-0002PD-7l for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:07 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-439b2965d4bso4744992f8f.2 for ; Wed, 18 Mar 2026 03:32:03 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b518588a0sm10615947f8f.16.2026.03.18.03.32.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829922; x=1774434722; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OnDCTRCky1piZxyLRpsMcdQHH/JXGmpFXuBfJy0DyaU=; b=ms+7MurmhZm+4KNeRLBUwWmIYK6OPYtAfrbKVg5D8wknd+n2En5MfbdnZH3U6AR1Gs 4pc4D/iWBo4f9YPkMOEISHw6t8t7xSvlx71G3iFby4BQ5Yql0vnk8j/YLSx/WmsCDbuQ Po4U78AafZlSBXHmgUuWIhE/z1eG+2hRCFdQDqI7LRzRVdX8wMyQSJynUieQf9htXjYd 5cRm/AG4bn7DN4Y+9s5lNYjv+n4ci0zc2L/mM6HOWzLg8kb6OQomDVWwlBNEnj7igunQ hQ0Mu7kmp2/ttSlvgR7Q7pGsRV24ayytkKpBP2kikDIg4eG/CtmnsMYy8SGJaT6p7bBG J2NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829922; x=1774434722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OnDCTRCky1piZxyLRpsMcdQHH/JXGmpFXuBfJy0DyaU=; b=dSglo6TM4wqhQ39dMdbQV2VeqmWcgRqHrEHm3vea37kPm3/gVeQOaFBTMteJRcZS65 +XNCUybF6XvQilGED0upWfRXyZyYryZmxA1/eA0gSkoU4dmtOLhTv4/QGPPR2b3/Twcg 2/r76iIg+ifH7UKRqznw5dCogpSvhuTDs5saa3jPGokuSpnvgJM3pr89HjVDPYmFnvdx iqzpOIlPrGpU8TqIIp4IgoM+rg9NPaWcoTcTpLPLfKL71oxwE90u358IuHQ3MpfltHtV itqx3YJegBOJKyyFi6WumhuJFu+qQZRKCtNMQ/2g9tNVzO7nlyXlGCoqIZyvmm0AgMSu uEgQ== X-Gm-Message-State: AOJu0YxnPLq0oIleDdWNlLa2Uw/D2fRS3Yzs+03Ky90V6StzHg3020eh tW5+ZcvRZRs4kdGtwpyBhXhtOP3UH7nVyYanbVw2wy5UTEWysBvZrJ6avzyit6RSV0F2t9YuktY WPhcjicI= X-Gm-Gg: ATEYQzzU2PFQVYEYgP8Mh0DQdghgPBExhArekcLcd83EWZ+55rSZEwVScDHBATcwQPv YYKDG9BC/siwFeiVVMqO2kvdyABEIh1ZZD1Cca/Qa9VegVp/ieCUzmQr+a0nx2gUNo4v/P+7eBZ 8qZLu9kUembT5pxbr50BA3vUNFb0GfepGE+zTU0Ay42/OSe6NOCBkeOqJ9pEdbtMLSIjPVn0A2T GuDupXossO/NidpVvBqxN+92dYOy4OZdAg3pXhgDBrmhlibeDfHMyR+7OfMZGo+KmTT9nO0hP+s KgVcUGZgrpWailxaZYjKLI3w49NFjBAnjxM2Fw0BTMBRWc8sQeBdHRZ8MEu8fQBy9TmoGM4ENeE 04TBbOeJujy4U4GFkvetSa42sZF+DqbBm1qSfgywK39fpk+XQorPmQriP8D9e3+SmCIHPC+4E0M 9MM6wqPVIHTYvkG1oqJIDpc6kDOUSbQJjbvljhcaEyVUQd2WN7fBMaehU2rYiXyEY4mfQUbpj0 X-Received: by 2002:a05:6000:24c5:b0:43a:378:b48b with SMTP id ffacd0b85a97d-43b527c9af9mr4421697f8f.37.1773829921710; Wed, 18 Mar 2026 03:32:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 05/16] target/riscv: Explode MO_TExx -> MO_TE | MO_xx (again) Date: Wed, 18 Mar 2026 11:31:10 +0100 Message-ID: <20260318103122.97244-6-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830004971154100 Following commit 73ae67fd4e6, extract the implicit MO_TE definition in order to replace it. Mechanical change using: $ for n in UW UL UQ UO SW SL SQ; do \ sed -i -e "s/MO_TE$n/MO_TE | MO_$n/" \ $(git grep -l MO_TE$n target/riscv); \ done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/insn_trans/trans_rvzalasr.c.inc | 12 ++++++------ target/riscv/insn_trans/trans_xmips.c.inc | 16 ++++++++-------- target/riscv/insn_trans/trans_zilsd.c.inc | 4 ++-- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvzalasr.c.inc b/target/riscv/in= sn_trans/trans_rvzalasr.c.inc index bf86805cef6..525f01ca347 100644 --- a/target/riscv/insn_trans/trans_rvzalasr.c.inc +++ b/target/riscv/insn_trans/trans_rvzalasr.c.inc @@ -49,20 +49,20 @@ static bool trans_lb_aqrl(DisasContext *ctx, arg_lb_aqr= l *a) static bool trans_lh_aqrl(DisasContext *ctx, arg_lh_aqrl *a) { REQUIRE_ZALASR(ctx); - return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TESW)); + return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TE | MO_SW)); } =20 static bool trans_lw_aqrl(DisasContext *ctx, arg_lw_aqrl *a) { REQUIRE_ZALASR(ctx); - return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TESL)); + return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TE | MO_SL)); } =20 static bool trans_ld_aqrl(DisasContext *ctx, arg_ld_aqrl *a) { REQUIRE_64BIT(ctx); REQUIRE_ZALASR(ctx); - return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TEUQ)); + return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TE | MO_UQ)); } =20 static bool gen_store_release(DisasContext *ctx, arg_sb_aqrl *a, MemOp mem= op) @@ -96,18 +96,18 @@ static bool trans_sb_aqrl(DisasContext *ctx, arg_sb_aqr= l *a) static bool trans_sh_aqrl(DisasContext *ctx, arg_sh_aqrl *a) { REQUIRE_ZALASR(ctx); - return gen_store_release(ctx, a, (MO_ALIGN | MO_TESW)); + return gen_store_release(ctx, a, (MO_ALIGN | MO_TE | MO_SW)); } =20 static bool trans_sw_aqrl(DisasContext *ctx, arg_sw_aqrl *a) { REQUIRE_ZALASR(ctx); - return gen_store_release(ctx, a, (MO_ALIGN | MO_TESL)); + return gen_store_release(ctx, a, (MO_ALIGN | MO_TE | MO_SL)); } =20 static bool trans_sd_aqrl(DisasContext *ctx, arg_sd_aqrl *a) { REQUIRE_64BIT(ctx); REQUIRE_ZALASR(ctx); - return gen_store_release(ctx, a, (MO_ALIGN | MO_TEUQ)); + return gen_store_release(ctx, a, (MO_ALIGN | MO_TE | MO_UQ)); } diff --git a/target/riscv/insn_trans/trans_xmips.c.inc b/target/riscv/insn_= trans/trans_xmips.c.inc index 9a72f3392f1..37572563ae9 100644 --- a/target/riscv/insn_trans/trans_xmips.c.inc +++ b/target/riscv/insn_trans/trans_xmips.c.inc @@ -56,11 +56,11 @@ static bool trans_ldp(DisasContext *ctx, arg_ldp *a) TCGv addr =3D tcg_temp_new(); =20 tcg_gen_addi_tl(addr, src, a->imm_y); - tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, MO_TESQ); + tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, MO_TE | MO_SQ); gen_set_gpr(ctx, a->rd, dest0); =20 tcg_gen_addi_tl(addr, addr, 8); - tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, MO_TESQ); + tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, MO_TE | MO_SQ); gen_set_gpr(ctx, a->rs3, dest1); =20 return true; @@ -77,11 +77,11 @@ static bool trans_lwp(DisasContext *ctx, arg_lwp *a) TCGv addr =3D tcg_temp_new(); =20 tcg_gen_addi_tl(addr, src, a->imm_x); - tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, MO_TESL); + tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, MO_TE | MO_SL); gen_set_gpr(ctx, a->rd, dest0); =20 tcg_gen_addi_tl(addr, addr, 4); - tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, MO_TESL); + tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, MO_TE | MO_SL); gen_set_gpr(ctx, a->rs3, dest1); =20 return true; @@ -99,10 +99,10 @@ static bool trans_sdp(DisasContext *ctx, arg_sdp *a) TCGv addr =3D tcg_temp_new(); =20 tcg_gen_addi_tl(addr, src, a->imm_w); - tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, MO_TEUQ); + tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, MO_TE | MO_UQ); =20 tcg_gen_addi_tl(addr, addr, 8); - tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, MO_TEUQ); + tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, MO_TE | MO_UQ); =20 return true; } @@ -118,10 +118,10 @@ static bool trans_swp(DisasContext *ctx, arg_swp *a) TCGv addr =3D tcg_temp_new(); =20 tcg_gen_addi_tl(addr, src, a->imm_v); - tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, MO_TESL); + tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, MO_TE | MO_SL); =20 tcg_gen_addi_tl(addr, addr, 4); - tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, MO_TESL); + tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, MO_TE | MO_SL); =20 return true; } diff --git a/target/riscv/insn_trans/trans_zilsd.c.inc b/target/riscv/insn_= trans/trans_zilsd.c.inc index 369c33004b6..445406cf015 100644 --- a/target/riscv/insn_trans/trans_zilsd.c.inc +++ b/target/riscv/insn_trans/trans_zilsd.c.inc @@ -30,7 +30,7 @@ static bool gen_load_i64(DisasContext *ctx, arg_ld *a) TCGv addr =3D get_address(ctx, a->rs1, a->imm); TCGv_i64 tmp =3D tcg_temp_new_i64(); =20 - tcg_gen_qemu_ld_i64(tmp, addr, ctx->mem_idx, MO_TESQ); + tcg_gen_qemu_ld_i64(tmp, addr, ctx->mem_idx, MO_TE | MO_SQ); =20 if (a->rd =3D=3D 0) { return true; @@ -85,7 +85,7 @@ static bool gen_store_i64(DisasContext *ctx, arg_sd *a) } else { tcg_gen_concat_tl_i64(tmp, data_low, data_high); } - tcg_gen_qemu_st_i64(tmp, addr, ctx->mem_idx, MO_TESQ); + tcg_gen_qemu_st_i64(tmp, addr, ctx->mem_idx, MO_TE | MO_SQ); =20 return true; } --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830090; cv=none; d=zohomail.com; s=zohoarc; b=BYobzKBquN02BhDHVJRjD/q37Z6tVV3gnoYvM7Uu8ntPiW9EOXaam3ucB7MQWIo7R9GtWYWiP8af0+RibRkBWwsWtwU+Ff60BugbMOW0RzNku50fqXg/3hqrlQSh0Dg5eBMz3Dr7F90JjGHcs55qmt3418A622xqhwqn18fzY2c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830090; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NIB2jgD4xNIjEX+GJ6lU/gnIpJ4tgCJCIcB8p5M/dOE=; b=BUSWHXaYIci77lNum5QDqEQilzjAjvP+xePo1+mZjSTLkS2K6LPPUP1tzKpARFUOSNpFl+BzuUHHp08fljT+fKBNKnZwq50zTcv0shaaghyUcfifJ44K3rMZfx/wEd1T1Ws7CfnYCy3DT9RJt5PuS/8PPT7TyE0uL7thysj2Rdo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830090839300.7963095513751; Wed, 18 Mar 2026 03:34:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oCu-0002MO-0f; Wed, 18 Mar 2026 06:32:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oCD-0001aV-Da for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:17 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oCA-0002Qm-T8 for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:13 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-48557c8ad47so43328105e9.0 for ; Wed, 18 Mar 2026 03:32:10 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f4b810c7sm21678975e9.12.2026.03.18.03.32.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829929; x=1774434729; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NIB2jgD4xNIjEX+GJ6lU/gnIpJ4tgCJCIcB8p5M/dOE=; b=Q8w1VLZjBH3tlOaCYfA5ImwfmaxV0cyY4vJUTFzbomUmEhBr7rM0NOrwqJXXWg0EWx w4UK+QFNCItgMnvqbbzzGZfxozbpkxOSwWFi3Sh8dcynfHd+eOvf1q4qoRFrpOWJNs6c A/p/pnnWbgrT5Ow9QWtddPoTeGZJcPVnSrYdlHzjnpIzL+t15fJEPWVvdqxK0MtcUBkJ N7pMgHsSEL60a7fFiwL/pln4BTXCGj9P9TFR+CzUaiOBdZR8F1D8CyZkVuNyynW8AuqS pT86PtZx4iOM4RwgufeO55wnO89WMXsbxjE9W+5XQ23ji4rf8yG1XkQwgpW3wejZ3YnE 38wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829929; x=1774434729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NIB2jgD4xNIjEX+GJ6lU/gnIpJ4tgCJCIcB8p5M/dOE=; b=tNMO/mMuW25ztAMVGEwmwaBMI8QKR0IHdMP917B1ZJmvnAlBTOJmISq8Md+40CyQkn YZ9Ivt2sgxWwwuonY/ozqRZWaeVQgUMvvnXaGTGtqdrdMPcTUZ6zx1jcVUGtNYJ8rSNU OKLzaQwqcnsdHdYti4b5IYa/7w7RMr2xrI7sFQSszTvOqsmmBmmdfzUl+wsTZcYb1pTk y5RmFNikNSP8otqmvY5f9UusTI4DS/sC0Km5xnXg+mZaUS1SxAi3A7atEGI/wr3hh1Ud ZdqgiSsYZl0BNEGpYO0C+IKdeDxIlo3LKcSLI9ivvOMpwW/Jwd0tahqXH8TSdzGdfFNt J3lg== X-Gm-Message-State: AOJu0YwvI3k+MD2PSm7AgvI+sqEWZfyg2U4n8A4Xr3hcklkjK2JwKV8O SN71Z4HutGlVdfKl9ePsvyD6bGlwd20HppNOqocTgxay6cwKdY4+PPqjYoNOIXFUv9fbS3koCHL xCMBtxkU= X-Gm-Gg: ATEYQzxpWvG/LWG0hPUTSm/na4iMwET0AgTJ6rs2Htp7nhWNGwsYCT25bVjBVt0pBul umivXk2XnnB6VP0ZnY6jiqi3kzA6kB81t2OFcj5DI2IX6ONvn1N3vMQgPGjUkNeZ5z11/4aw6B8 mUo2p9pThMmjdJSzJ2f6VjnCd9NmWRS7cat86nsMnKE1hgFeTWcCAEi/VHpLHIAePXyHpPRKfCC 5zojBnlXZbBpLg2hsl4I4/fAXTZgts0EKHMqD6oN8f4yTILIa36iWIOHLzQ2KB1ZMoWLJlfpnED AKgsZaASfwRC3w4wOFk6tSYR5FWdEYAVsaQcWEtWbta83wWe4A6TcW50jiT2e+2ziRnj0GyXHoc voRv8rL7y8Z1NVtGL01Iyk/+7PrQ4n0CwhGiFGM0B1w+I9f2g95WmaYHJSn5F0WiHbwFxyLBYRj MUNXkekTwqQOi8mpo0CGSGesP3idiO6dB4OIpXApU/nC8TuoxkrgZW5uL4GdhQgVuZw9pKJKmLX bR/Ehhi1gQ= X-Received: by 2002:a05:600c:620c:b0:485:40ed:2d1 with SMTP id 5b1f17b1804b1-486f4475049mr46242905e9.17.1773829929046; Wed, 18 Mar 2026 03:32:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 06/16] target/riscv: Conceal MO_ALIGN|MO_TE within load_acquire / store_release Date: Wed, 18 Mar 2026 11:31:11 +0100 Message-ID: <20260318103122.97244-7-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830092481158500 All callers of gen_load_acquire() and gen_store_release() set both the MO_ALIGN|MO_TE flags. Set them once in each callee. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/insn_trans/trans_rvzalasr.c.inc | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvzalasr.c.inc b/target/riscv/in= sn_trans/trans_rvzalasr.c.inc index 525f01ca347..2b1f73f650b 100644 --- a/target/riscv/insn_trans/trans_rvzalasr.c.inc +++ b/target/riscv/insn_trans/trans_rvzalasr.c.inc @@ -29,6 +29,7 @@ static bool gen_load_acquire(DisasContext *ctx, arg_lb_aq= rl *a, MemOp memop) return false; } =20 + memop |=3D MO_ALIGN | MO_TE; memop |=3D (ctx->cfg_ptr->ext_zama16b) ? MO_ATOM_WITHIN16 : 0; =20 tcg_gen_qemu_ld_tl(dest, addr, ctx->mem_idx, memop); @@ -43,26 +44,26 @@ static bool gen_load_acquire(DisasContext *ctx, arg_lb_= aqrl *a, MemOp memop) static bool trans_lb_aqrl(DisasContext *ctx, arg_lb_aqrl *a) { REQUIRE_ZALASR(ctx); - return gen_load_acquire(ctx, a, (MO_ALIGN | MO_SB)); + return gen_load_acquire(ctx, a, MO_SB); } =20 static bool trans_lh_aqrl(DisasContext *ctx, arg_lh_aqrl *a) { REQUIRE_ZALASR(ctx); - return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TE | MO_SW)); + return gen_load_acquire(ctx, a, MO_SW); } =20 static bool trans_lw_aqrl(DisasContext *ctx, arg_lw_aqrl *a) { REQUIRE_ZALASR(ctx); - return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TE | MO_SL)); + return gen_load_acquire(ctx, a, MO_SL); } =20 static bool trans_ld_aqrl(DisasContext *ctx, arg_ld_aqrl *a) { REQUIRE_64BIT(ctx); REQUIRE_ZALASR(ctx); - return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TE | MO_UQ)); + return gen_load_acquire(ctx, a, MO_UQ); } =20 static bool gen_store_release(DisasContext *ctx, arg_sb_aqrl *a, MemOp mem= op) @@ -78,6 +79,7 @@ static bool gen_store_release(DisasContext *ctx, arg_sb_a= qrl *a, MemOp memop) return false; } =20 + memop |=3D MO_ALIGN | MO_TE; memop |=3D (ctx->cfg_ptr->ext_zama16b) ? MO_ATOM_WITHIN16 : 0; =20 /* Add a memory barrier implied by RL (mandatory) and AQ (optional) */ @@ -90,24 +92,24 @@ static bool gen_store_release(DisasContext *ctx, arg_sb= _aqrl *a, MemOp memop) static bool trans_sb_aqrl(DisasContext *ctx, arg_sb_aqrl *a) { REQUIRE_ZALASR(ctx); - return gen_store_release(ctx, a, (MO_ALIGN | MO_SB)); + return gen_store_release(ctx, a, MO_SB); } =20 static bool trans_sh_aqrl(DisasContext *ctx, arg_sh_aqrl *a) { REQUIRE_ZALASR(ctx); - return gen_store_release(ctx, a, (MO_ALIGN | MO_TE | MO_SW)); + return gen_store_release(ctx, a, MO_SW); } =20 static bool trans_sw_aqrl(DisasContext *ctx, arg_sw_aqrl *a) { REQUIRE_ZALASR(ctx); - return gen_store_release(ctx, a, (MO_ALIGN | MO_TE | MO_SL)); + return gen_store_release(ctx, a, MO_SL); } =20 static bool trans_sd_aqrl(DisasContext *ctx, arg_sd_aqrl *a) { REQUIRE_64BIT(ctx); REQUIRE_ZALASR(ctx); - return gen_store_release(ctx, a, (MO_ALIGN | MO_TE | MO_UQ)); + return gen_store_release(ctx, a, MO_UQ); } --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830040; cv=none; d=zohomail.com; s=zohoarc; b=FEUgW5tddD/jnxBzzIJmFU7JYdkndzKldHXEnbtcJNrkDoEZRQm3P8+b3dw4xLn7/iFP+ET9jZJePhjA0uhceqeV134IS09HFRClVB4380vEwVacL7wYUgYAnP1Uu35dPYO/67Usdu38zGA4eVWGno5sdkRXsmEo3Oq1j4Va+qs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830040; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0F4+3o4I9l18fj/6/8RkkCyZU1iNgv6pX2nauez16PY=; b=gaC+nXvCS2WR46jy05PV+q0fGAYUu8+UDoqjmVhbvXRcTNuEFj/FLsp8KbuNDn200DguQJPVqCP+2mabznHXe7erOW8fz/FWAqHpbPvSpXZtEUloWkNqYFMXkyZAPdeLSFGYKfjfTk+VbOnnW1zJkx3+PxdNchev2junsQbqKTg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830040094166.69270242955736; Wed, 18 Mar 2026 03:34:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oCa-0001vC-IN; Wed, 18 Mar 2026 06:32:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oCK-0001bN-8v for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:24 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oCI-0002RX-8a for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:19 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4856cd3f1ffso6008265e9.3 for ; Wed, 18 Mar 2026 03:32:17 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f5e1ab8esm12510945e9.35.2026.03.18.03.32.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829936; x=1774434736; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0F4+3o4I9l18fj/6/8RkkCyZU1iNgv6pX2nauez16PY=; b=Z4Rzlmr79GoTuvA2SgVsrVlTRO+EM+/gwLMbxIQT5kv+kpy2SdPCGKobGQutvwSC5a rBSfZ9meE5PiBYmO3U73q/YLE7npuea0mFeN1gOWXZ2X2e74xlhK+kowfscx5Jdxe9KN wzdLg6yhzPpAbvHEo21fj45sj6DD3LaLVP5Odz7WidSVYEK8rxq9JuxQB8+HnJ0GJVqh 4j92+09PO388A6uhfKIF3JIG7lQjWdMdaTzDaGCaOcll1voQR0xp7yVtntFiDqOh0lg/ RtpORhMgeP6IN8KUBpOFZhfmxd5hBtpj3AD0+UbB/eYrzfNb8lUBsdJLWsehNcUx1DPE 313g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829936; x=1774434736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0F4+3o4I9l18fj/6/8RkkCyZU1iNgv6pX2nauez16PY=; b=gimvmy1bH1v6Y/gbO2B+Lw86UJTIRDrvZjePMTAcRxGFIoV49ziUQDImxNZmA7eN+O wp19t2WKYe96E8L0vOSh6LjWLTmgUTvswJVlg7SIHr3T2NqZ3lDRjr6p5cg0z0FOjV0Q l2qYp/01i+uYQmiK2ri8Pk5o3aK0K2EDklto6c4mExcqyhmjNMqcNZzSaFtHzZN/2hkt r8n0G9D+bbgQXprG/Ks4KfazdnI7c8nTjHOsUtWT+wSqvtD81teH3s31axkN9lLCk7ZL HEElyEoZ6Wt7UzLjLyEqpJJ1NP7YM2d0Wo8QJzIl+A9r6dFq1YIlQUCN8vPr1k8atO2/ +qQQ== X-Gm-Message-State: AOJu0YzqFhoVj+sE9u4MPGMKv0wI2eo9EOo1OAzt34y7zZXrX6bClESa 2cYstcmCJZo3yt9g5GBGW8C+PG4vkh3XAOatvbGSM0Y1s295iqZaXKkJcYgEHvZd5uEAB80whYM q4/iJKIA= X-Gm-Gg: ATEYQzxKe2Vy+6P5YtAJR9hzPvz7woZNvoFRwqEuMqI/Z4R7WJhsUbJBEkZd/BU8yZz bxX+2Om4+nejs/xIUG42F+xfw2EuTaCtY+EE/XNf03VyL0tlGT8b47JdgpFjva0oojuJhdtuwzM 4nIcZQeg0YyZUFznSBf0ALfPkLEu+OKECjEhqoWsf/OerO2pxCn3YdZ6K6bm408CbAZ/WV4PFv2 +8QK+OtyeAzeIrUB4OEbfJsYAjgKseehNSnQZ20X9QKlmmWS6+0X6rwZwOLNE34Huu9pWkwCLFO z2XwGkPmi3DjpZLiJoW2CJ7nP7mtwNOZ8xn9kBu2vHxQ3QLSd2Cn8MXEgeaizhc75jd/d8+6sq7 wgAcTdBIYOe1pA2UiTItaJMFahFlWfChthjjodp/a97hdCT1/evMwHgAqJuBguPBvbm8BmoRNjV KBwUypqGaGQCWVGqJY5RljGPQcdy+/YFAST28JY2ViHV1EU2ZSQQNL7BmUTl/bD4qoPZVVfufE X-Received: by 2002:a05:600c:1d10:b0:47e:e2eb:bc22 with SMTP id 5b1f17b1804b1-486f4421c84mr41737495e9.5.1773829936151; Wed, 18 Mar 2026 03:32:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 07/16] target/riscv: Factor tiny ldn() helper in gdbstub Date: Wed, 18 Mar 2026 11:31:12 +0100 Message-ID: <20260318103122.97244-8-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830042199158500 In preparation of having this helper handle CPU runtime endianness changes, factor the ldn() helper out. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/gdbstub.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/target/riscv/gdbstub.c b/target/riscv/gdbstub.c index 6a5b7a82fd4..be42566bcc8 100644 --- a/target/riscv/gdbstub.c +++ b/target/riscv/gdbstub.c @@ -47,6 +47,11 @@ static const struct TypeSize vec_lanes[] =3D { { "uint8", "bytes", 8, 'b' }, }; =20 +static uint64_t ldn(CPURISCVState *env, uint8_t *mem_buf, size_t regsz) +{ + return ldn_p(mem_buf, regsz); +} + int riscv_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n) { RISCVCPUClass *mcc =3D RISCV_CPU_GET_CLASS(cs); @@ -84,15 +89,15 @@ int riscv_cpu_gdb_write_register(CPUState *cs, uint8_t = *mem_buf, int n) =20 switch (mcc->def->misa_mxl_max) { case MXL_RV32: - tmp =3D (int32_t)ldl_p(mem_buf); + tmp =3D (int32_t)ldn(env, mem_buf, 4); length =3D 4; break; case MXL_RV64: case MXL_RV128: if (env->xl < MXL_RV64) { - tmp =3D (int32_t)ldq_p(mem_buf); + tmp =3D (int32_t)ldn(env, mem_buf, 8); } else { - tmp =3D ldq_p(mem_buf); + tmp =3D ldn(env, mem_buf, 8); } length =3D 8; break; @@ -130,7 +135,7 @@ static int riscv_gdb_set_fpu(CPUState *cs, uint8_t *mem= _buf, int n) CPURISCVState *env =3D &cpu->env; =20 if (n < 32) { - env->fpr[n] =3D ldq_p(mem_buf); /* always 64-bit */ + env->fpr[n] =3D ldn(env, mem_buf, 8); /* always 64-bit */ return sizeof(uint64_t); } return 0; @@ -162,7 +167,7 @@ static int riscv_gdb_set_vector(CPUState *cs, uint8_t *= mem_buf, int n) if (n < 32) { int i; for (i =3D 0; i < vlenb; i +=3D 8) { - env->vreg[(n * vlenb + i) / 8] =3D ldq_p(mem_buf + i); + env->vreg[(n * vlenb + i) / 8] =3D ldn(env, mem_buf + i, 8); } return vlenb; } @@ -194,7 +199,7 @@ static int riscv_gdb_set_csr(CPUState *cs, uint8_t *mem= _buf, int n) const unsigned regsz =3D riscv_cpu_is_32bit(cpu) ? 4 : 8; =20 if (n < CSR_TABLE_SIZE) { - uint64_t val =3D ldn_p(mem_buf, regsz); + uint64_t val =3D ldn(env, mem_buf, regsz); int result; =20 result =3D riscv_csrrw_debug(env, n, NULL, val, -1); @@ -230,8 +235,7 @@ static int riscv_gdb_set_virtual(CPUState *cs, uint8_t = *mem_buf, int n) const unsigned regsz =3D riscv_cpu_is_32bit(cpu) ? 4 : 8; #ifndef CONFIG_USER_ONLY CPURISCVState *env =3D &cpu->env; - - target_ulong new_priv =3D ldn_p(mem_buf, regsz) & 0x3; + uint64_t new_priv =3D ldn(env, mem_buf, regsz) & 0x3; bool new_virt =3D 0; =20 if (new_priv =3D=3D PRV_RESERVED) { @@ -239,7 +243,7 @@ static int riscv_gdb_set_virtual(CPUState *cs, uint8_t = *mem_buf, int n) } =20 if (new_priv !=3D PRV_M) { - new_virt =3D (ldn_p(mem_buf, regsz) & BIT(2)) >> 2; + new_virt =3D (ldn(env, mem_buf, regsz) & BIT(2)) >> 2; } =20 if (riscv_has_ext(env, RVH) && new_virt !=3D env->virt_enabled) { --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773829982; cv=none; d=zohomail.com; s=zohoarc; b=VfXo7DeZtGB0zhoR+tiJknv0n0USOgU1J+xfX4xZXnCDAwOtZEUpFbrUqjCvFTXOSCY7qPkse+9x5acrtxBff8dBPoJf0IVB0EVNuZvGZVCZWSbUQ+VO494Z6esT5jDMnBZFsBlctnjIFuowteW/0mkli9gsOUjPS7rv499rWjE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773829982; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4X8QUwZ5Pf3fdspvylPT4Qw/iKJaj1fEYrwcUzYJwqY=; b=nxCOcHXTMw/EpNKstvfAuzbKqmymXF5I8ow8ZKgIT3iD+MH2hZDwQCYwE3jLh3Cfv6mQqgphUm2+NzT0ebcAO6MZSrBDOe31AqZtLBl552yVIF3LHjhN82bRv1Cakm9bX+r+Is+W1zZq8zjJDkKYG/v20P1Y2X0o5T+yl0iBrfg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177382998204442.86896999956275; Wed, 18 Mar 2026 03:33:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oCt-0002Hu-Ji; Wed, 18 Mar 2026 06:32:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oCR-0001mL-BP for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:27 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oCP-0002S8-NX for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:27 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-48534237460so71648395e9.3 for ; Wed, 18 Mar 2026 03:32:25 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b518a3e3csm6259754f8f.35.2026.03.18.03.32.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829943; x=1774434743; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4X8QUwZ5Pf3fdspvylPT4Qw/iKJaj1fEYrwcUzYJwqY=; b=FTZjA0GFcu66bdx2hNkfPyFGy/SAuChcxMPn/vA34jATnhBMypPjErg/l8p4jEFdKs hNbqWlReaVXxlY9uabLKC5p7nhy4EtL5wb413U9uYzdWPGis2eA3YrL08oyNK4mvToN2 FUUVGcesxWV2XELhutIZB26cJaVU6xdprt3JbhToMTIU6HmhV6X0jVXCs/mPKcLzI/IE 0AqjfrQtE1rJ0KZ/WqwOev3aLuKi6r+mXZ58iteytkwmbv9YeSCREyvFW8uJVeTZNCzx 4eAw/VDULE9uZD9rmhebrsiwtK3LgDszMs6DSU6NYIcdjuzNbnbZoQldEITxlktCYSIA sXCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829943; x=1774434743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4X8QUwZ5Pf3fdspvylPT4Qw/iKJaj1fEYrwcUzYJwqY=; b=HTMwFx+3vQE5okCskNQRNbGeTwe14mnHn8A8Aw+FBaBGq1gl9bt3easkHOtZeAGbCu Q1Fvq270DkRdukGotkKDqa+OwDTWNBZuyz/xFviL3H7SxxUt3WlJeO8M4sxjCop3PzMX VbOnibTzhMOg2RvivPGFnxDksA6MQ1yUEWFRgqjqYi+Jf4upRkrB59dB194olXfohkHw WAvY1JEkUf4Bpr8ygQUPPg35JHQoudDBpiLnePVDy8zlKl5T9YGlKRvhX4uMbEHNF5LJ Aa5wJZrWNYMKUKd6mDL4vLwzRM7vlkDD0cuhlAZrypEzwzlWe41OXp7xd+MOm9po5bNZ X1fA== X-Gm-Message-State: AOJu0YxdsUYFRqoNP6vsKZUv887f+xoa7TcCZQeHcPpjdS9IHswROniz d+JhDlmj7cDYSLSl4FQ9B/z3x4lBJDDtZDY2VTpDRFjqViB4oQAcJE3dA4Sh5RjeXbgvpgNZdv7 KaUlI3iY= X-Gm-Gg: ATEYQzyI6PW8X5IM3WOChf0TC6BurxET99QGGbx/NAXFazGPyuxmcFTw5Fh0APxJeLT hgNFT8MNiM1zYfaqagAiwEfESnOpgVKmPWksRhWPAgtoewmwH/a0p8ubLntLTo0SqQtmmt3NiTY p5pDgVhayjq68HOCdgv2IQRbfzjtLOU/bPtt/T2vQf//szmTPxma6hBwxu+rcgaqwp+vDaKKmFr yzAZZwDpjrxXepxxyhp6tbXPuUQgdIaCHOOaktCWfIasgxl79P0LDAA1Pzfv59Cfw4L8va01DVp /gZ69frhVq6Zxv/IN5u+a+Gaqo3NbUAoXPJRayyvfdtCWVAd0FBFuLTB5g2r8ikmE75TNeHmnq3 kZs2uDPNGqvCiEH4+xAVpeHyi7+G00ru7bbu7OUpWTSG69OikzOP7tEpu0Dnc2+5akKR94GkHsi lc/T+b6PTwGg3FxKpVT+FqQq1teNeX+EjH0HC7jfsHkJyEalGOH3U5xLdUsA0nv2ohehgQAujc X-Received: by 2002:a05:600c:450c:b0:486:c4f0:1a37 with SMTP id 5b1f17b1804b1-486f4457a6fmr47173145e9.24.1773829943293; Wed, 18 Mar 2026 03:32:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 08/16] target/riscv: Simplify riscv_cpu_gdb_write_register() Date: Wed, 18 Mar 2026 11:31:13 +0100 Message-ID: <20260318103122.97244-9-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773829984086158500 Use a single ldn() call, sign-extend once. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- Note I'm skeptical about 128-bit registers path, but this would be a pre-existing issue. --- target/riscv/gdbstub.c | 25 ++++++------------------- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/target/riscv/gdbstub.c b/target/riscv/gdbstub.c index be42566bcc8..a5c12638782 100644 --- a/target/riscv/gdbstub.c +++ b/target/riscv/gdbstub.c @@ -84,33 +84,20 @@ int riscv_cpu_gdb_write_register(CPUState *cs, uint8_t = *mem_buf, int n) RISCVCPUClass *mcc =3D RISCV_CPU_GET_CLASS(cs); RISCVCPU *cpu =3D RISCV_CPU(cs); CPURISCVState *env =3D &cpu->env; - int length =3D 0; - uint64_t tmp; + const size_t regsize =3D mcc->def->misa_mxl_max =3D=3D MXL_RV32 ? 4 : = 8; + uint64_t tmp =3D ldn(env, mem_buf, regsize); =20 - switch (mcc->def->misa_mxl_max) { - case MXL_RV32: - tmp =3D (int32_t)ldn(env, mem_buf, 4); - length =3D 4; - break; - case MXL_RV64: - case MXL_RV128: - if (env->xl < MXL_RV64) { - tmp =3D (int32_t)ldn(env, mem_buf, 8); - } else { - tmp =3D ldn(env, mem_buf, 8); - } - length =3D 8; - break; - default: - g_assert_not_reached(); + if (env->xl < MXL_RV64) { + tmp =3D (int32_t)tmp; } + if (n > 0 && n < 32) { env->gpr[n] =3D tmp; } else if (n =3D=3D 32) { env->pc =3D tmp; } =20 - return length; + return regsize; } =20 static int riscv_gdb_get_fpu(CPUState *cs, GByteArray *buf, int n) --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830113; cv=none; d=zohomail.com; s=zohoarc; b=D+S7tP5lTz2gw6sMe1H8iiiYGZ7bo61krRG4d/fhoaemEnbADZ15wBrACj+NylkOV4nNsm1EvPbb5IjrpfPdL4YiltJ3VwwUWdAqfRR4K8d3Bv/rXxlGCuXfPhsF19r6fXf+5D8nQPUud+82MISHHw0nsYtx8mCxaR6XQQDnSkY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830113; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ReDHWdpP5TDEHnNFL6nm8aWwnpncRYGom7vG/728ciA=; b=jxTE/wx344/3qkrYsuQoDAS9uHxyJFBU+0WsyTJ6ozGeasgZvSSmQLfDdrDiz5VirVDpML9mcKJN1EsvU82BwBICor9/aVLoeHnfz4fun2UmywVWpTaK3g0xbP0gIsVXz+n8LNTYyoee/TH+gZgYqltGhZtlmIdlt1YinzXclMA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830113791705.9849256130856; Wed, 18 Mar 2026 03:35:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oCy-0002dM-P0; Wed, 18 Mar 2026 06:33:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oCZ-0001vB-03 for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:36 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oCX-0002T7-At for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:34 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-43b47b95a77so2232978f8f.0 for ; Wed, 18 Mar 2026 03:32:32 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51892244sm7053489f8f.22.2026.03.18.03.32.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829950; x=1774434750; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ReDHWdpP5TDEHnNFL6nm8aWwnpncRYGom7vG/728ciA=; b=VHwkCwPvuhOlO8sTDExHJgX3S2/kOM2PR4LTFo3754VyCdXz9Omi8ves6vdm98FkiN +pGHV7/zi4acxw5SB5J9D6hMmOGHPWog0Bg6A1Umwq6S//LFUS+JOgN+iaJCN7gK5B9t jGenZ8FKJEgm7Jok0oEkflJZiGPNhnpnvDIdGoaPeu086iGWIY8YDXmDlDVLRsRovOgP DUuZJbisGJYXjk94ErP/qN99zo90OoyWn51CM+99KwYEBvqrZSeHeJVBP6KHPnSIzdm5 QiC02LYuzPG7kUoCCZv2ZJt7VQ90W9FLj1K53emPAjGSRyakrIXeh8vh+iksfxniMFsa IaBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829950; x=1774434750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ReDHWdpP5TDEHnNFL6nm8aWwnpncRYGom7vG/728ciA=; b=mbo0WDSRqfKA3Cu4RFdHxizFqKHSalTtHTXRXEdjB96tlP7fZT0BLjBdIDz89CvRPl 3mO5PwLm8jDa4PED/cnYpCC4ZFq4+z/dW9P4kxVxG7lBK20suhlZTiBwvBkNSWVcToxc uERW/dbcOn2D/xK63m3HT8ASuuoQkz2NjWSbDxu5HBO6pSDQSv3izhXa6hcnUttR5zSe 0LNP+2HVrgxVGaRUObyzUeNtTudvdtnXjlZXU5D/X/uuB/HgxTogUlGWscTGR+LVPT3p SMlTgwcXjjhuoOUXSU0+dM7U3cucHERbHIy86dat+1QxT9A8mX4nJkozon9gIHsW5rLA Fz4A== X-Gm-Message-State: AOJu0YxhLoJ/gTH73A2KRv6nWL9fbfcoQKAWk5bjnSQD6/ffNG475QGM 6Aec/+t+EmW0HAVjrFAIrP5tb4zrlWbLLj0bMNLf+BPADsTiBsZ4/G5C003F3qcJ37NNShpuLbW 5llgQ3VQ= X-Gm-Gg: ATEYQzy/fA0EKTs4iSSuPcg/qkpVP46MkT3Ym+53nZsRq618nvzUtcAlBhrevclhMzh 3kTCfis8z4nwzzLA84z1JfHQ5VuhRFCW+gEKDs1DefvV0f80wStA78x6yuXDqV4etyTUwMmgVMq AfUo56LhLms4DbKC+Rd7au7MAklY7AwDkFMoN10/zFC8vIYeuD6bZbBRvgvQX/PSL/DwfDugGXs eQm4GzOC31oPENJFPchTpmQ5R7KXADRiv7Llbq5pfMt6/0OR0WDaITZxOlm7bnGdlP/Xf16bnh6 Ti1GOWwjPoVVb0N4nnHMT0vdvLB0tKw2ktSClrXCxgTHUUtPpvEf2b+3dgcYcFyLTnPral3QoOn 0HQJJmAiqxziw0Tqh5aWgvt2Ni1Ql14bWozjePhSSiK5/HP6aNc996unk5Q1xtnXhVeLSg7Cn/O U4hv5iacmrMZQVhiGUUbHMA+WPE6CCtOTWGEWG+c4ZQqFq5Iv6I8ToWH6+Bm/uPwJ/dJVdL6qM X-Received: by 2002:a05:6000:381:b0:439:c4f9:31f5 with SMTP id ffacd0b85a97d-43b527c4033mr4621654f8f.28.1773829950415; Wed, 18 Mar 2026 03:32:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 09/16] target/riscv: Expose mo_endian_env() Date: Wed, 18 Mar 2026 11:31:14 +0100 Message-ID: <20260318103122.97244-10-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830116635154100 Move mo_endian_env() definition to "internals.h" for re-use. Do not restrict to system emulation only because this will also be used by user emulation code. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/internals.h | 12 ++++++++++++ target/riscv/op_helper.c | 14 -------------- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/target/riscv/internals.h b/target/riscv/internals.h index 35b923c4bf5..860c47732b6 100644 --- a/target/riscv/internals.h +++ b/target/riscv/internals.h @@ -62,6 +62,18 @@ static inline bool mmuidx_2stage(int mmu_idx) return mmu_idx & MMU_2STAGE_BIT; } =20 +static inline MemOp mo_endian_env(CPURISCVState *env) +{ + /* + * A couple of bits in MSTATUS set the endianness: + * - MSTATUS_UBE (User-mode), + * - MSTATUS_SBE (Supervisor-mode), + * - MSTATUS_MBE (Machine-mode) + * but we don't implement that yet. + */ + return MO_TE; +} + /* share data between vector helpers and decode code */ FIELD(VDATA, VM, 0, 1) FIELD(VDATA, LMUL, 1, 3) diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c index 6ccc127c304..dde40a55493 100644 --- a/target/riscv/op_helper.c +++ b/target/riscv/op_helper.c @@ -28,20 +28,6 @@ #include "exec/tlb-flags.h" #include "trace.h" =20 -#ifndef CONFIG_USER_ONLY -static inline MemOp mo_endian_env(CPURISCVState *env) -{ - /* - * A couple of bits in MSTATUS set the endianness: - * - MSTATUS_UBE (User-mode), - * - MSTATUS_SBE (Supervisor-mode), - * - MSTATUS_MBE (Machine-mode) - * but we don't implement that yet. - */ - return MO_TE; -} -#endif - /* Exceptions processing helpers */ G_NORETURN void riscv_raise_exception(CPURISCVState *env, RISCVException exception, --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830029; cv=none; d=zohomail.com; s=zohoarc; b=ZneQgthEH6PWQSwuPdf9J63eaVdSI+vOZF93g+kLyO5+H2EjEY3uYxHm9S46w/ctPiLEo1wf6Bi31x8sr/pAKxiBDtahy7AJSPGFXTEfB+7eXa8MCEzg16L4GG5LKslfT1pHimXjaL10bENGID+pgkht75+E0FpETRX8oL+VMDg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830029; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=r41gSn9IQzUi/B0YjBqSsas/EGTz5z1g/Cnn0SOFGP0=; b=NGQBS81RdLJ1VHTy/0EzVzNI8b/XMeiMJG61CyZn560YniDtm2jMwpCpVHRhUkIHYb6Wdg1s166pDBJQqQfJTKGGgl1Jr+xShhRpPxhz3vH66YbQx8kDC7Hy81xjxXZNohyEeFaCDYSFxvXaLCvrUIfoeLhAUR29W5X4DGwBnM8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830029860295.9787812936014; Wed, 18 Mar 2026 03:33:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oCy-0002Zm-88; Wed, 18 Mar 2026 06:33:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oCg-00024D-CY for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:42 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oCd-0002UR-D0 for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:41 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4852f8ac7e9so79030175e9.1 for ; Wed, 18 Mar 2026 03:32:39 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f421a6f2sm50883915e9.8.2026.03.18.03.32.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829958; x=1774434758; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r41gSn9IQzUi/B0YjBqSsas/EGTz5z1g/Cnn0SOFGP0=; b=k0aeAkX2TdTLuYkWSCYpoKBDL8LFT9BJ+tZ/WbRFTHC7x30N21o5rH9FZwmIbsbJUT SxU77ztn5AIXM2N/gEix+YHFiRiA73ikVauuf4nrx1HWHcQqj7nv6mYF28s1ZvIUxer2 TB1MmeMKvzdPT81GEoBIPmNmo18CdBZ+PCO3uHqr9A/UerFt4BrOBEIpQxg/E7O3x/Ry aUbYS9lceQUq5+fxueO8f9BcQDtU7z0buRrPwTGqcaZUcJPFv9g/KceNb2Z4AGNdo7+F GS1hSt+iRSdiGY8wbof5HXCjFyaxHsJFRvrWjg/TNKQdWgPIDH0wh5QrIdhR1pFj9fy3 4G5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829958; x=1774434758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r41gSn9IQzUi/B0YjBqSsas/EGTz5z1g/Cnn0SOFGP0=; b=U+ytZ15FR4L9gDttpao8eV81UJQgD4zOb0KfVI3fLirhLE5u5jVGeXAygs9uEtUwyz JGD1FMlPTWfkJe9JohRtrCamizHi70VYyG3+rsfhOKvBeqn0btV73ucUYGv8gZgwjZIS st0qF/+/MgNnjan+ko2av9iEh3tJDFBhYAezdcga5Ii3gGWuCroFSK8VxrjRt1kqK1M+ W7NiaVQvQ2pN48TPjh3dKo+Ntd3Fhb7Cx3spVmsNsBIQa2xbH0Vg6eSja43OH9mB5p7V ImiUttXCgEKFWZD+8UYGkgKpkt6rgoGnXIX1e9xxhwtDJRziUP5pEJ+CTnjsoW6yCibd hUsQ== X-Gm-Message-State: AOJu0Yw/ds7GMRt9n4YSS7ahuF+tLHUR5bvE7UkojJP+yspHSkWSGkM0 3mzwTeTF+bR34J3G2rZA977Y2Ezt2eQOeQMHbcz7gDZUHkERon3wsP7edVKTBuUyVavgNmfCRzw IrpiNjJg= X-Gm-Gg: ATEYQzxBo20Jl4WbnHWr9wrWDDT49/skQEWrfarcyiTTJzlEkqmCzRiX8jtCm9ujhFl G7dTpAq5q8ZpfwNtA1buPvxlGIm3CWkp0wWwxmv+lPEuGbdke0EKwnmtWmW+ajhtSBndILDamDo 2vy1sEWqys8pLGI5L8zEEW5WsgkphV4lqQPAkq9r/pnK9u0pJnMAPMh75tDRv6X+0U+A0Ihabk/ 1o1DJgsIMyt3LXt0MZ3WjynEFF1qJDu6/cj9zw8YooYKkhgYBZDpG7GSDo3fiONxqAIQqZUdS/l NNZm3bxDsBCoM63P8hBlh/w+vwqexa7YCNqBzSWU4mDIvlEyVsFnQ8NhXYuLnTwmJB4PFYKjUXg 5X26LbjmPmIE9dEvQIHYTVogHaRsZdYlVxVVRnOLsIgfbhdIFd9E6pMzml6dFYxwf6TwIzF2Ixy yjlwYUCJM50NZFIp7bVEZ6DLZWPTFfcBghpNxCPj6ApHKbUCU2KONPkWqZVc9Aq/UlAmV5Vx6z8 FBSg9l+z5Q= X-Received: by 2002:a05:600c:8b09:b0:485:3a27:a960 with SMTP id 5b1f17b1804b1-486f420c141mr50647895e9.0.1773829957536; Wed, 18 Mar 2026 03:32:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 10/16] target/riscv: Have gdbstub consider CPU endianness Date: Wed, 18 Mar 2026 11:31:15 +0100 Message-ID: <20260318103122.97244-11-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830030163158500 Consider CPU endianness when accessing registers. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/gdbstub.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/riscv/gdbstub.c b/target/riscv/gdbstub.c index a5c12638782..2c6ccd4761c 100644 --- a/target/riscv/gdbstub.c +++ b/target/riscv/gdbstub.c @@ -20,6 +20,7 @@ #include "exec/gdbstub.h" #include "gdbstub/helpers.h" #include "cpu.h" +#include "internals.h" =20 struct TypeSize { const char *gdb_type; @@ -49,7 +50,7 @@ static const struct TypeSize vec_lanes[] =3D { =20 static uint64_t ldn(CPURISCVState *env, uint8_t *mem_buf, size_t regsz) { - return ldn_p(mem_buf, regsz); + return (mo_endian_env(env) =3D=3D MO_LE ? ldn_le_p : ldn_be_p)(mem_buf= , regsz); } =20 int riscv_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n) --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830012; cv=none; d=zohomail.com; s=zohoarc; b=FxnTwCWy3/rDrJ1Tk14L9UK8wRnY8L1lhxO3/b7hiuy6mJhbc+dEx5TTHNhGZ1/gYLlwQhLySjKboaFt1kq+rSJzroiEvZhXbcK2J3zEhAD5U89+SxnI1LBVm3DnCv+zTC5seBKnpmOeTcs/tD2ohKHXZHgv3X207UJ8nuBLCpA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830012; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cD08L7/tS/M0HJDnqHwQDjmjsjdzePAzezbZLq5ovR8=; b=gU2XIJNCIMYbu4g9q5NADKTyNG0DCSJVCw42gkBgi2pcy3hxeUNQ/AgSF7+87qL7+RTEhob0VghO3lUn7ragPdwcxuxpyVr99gG4N6wTf3zv6llGBD0AOAIwSm1X7WBfieNCPm1LZa4LScbf0pFESNliZuRjKq3SMimGhjrj5pc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830012429554.9899754942811; Wed, 18 Mar 2026 03:33:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oD0-0002gd-HA; Wed, 18 Mar 2026 06:33:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oCn-0002DY-Mh for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:51 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oCk-0002VM-Su for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:49 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-48374014a77so73925965e9.3 for ; Wed, 18 Mar 2026 03:32:46 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856eae3037sm131128035e9.11.2026.03.18.03.32.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829965; x=1774434765; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cD08L7/tS/M0HJDnqHwQDjmjsjdzePAzezbZLq5ovR8=; b=hTjmWCiaNHbT3I5KPARzOobVj/DGVQGRwn23U8KXFQr5JoLNr4krbL/bB3rK0uFEPr FI1hz6nfCSUSsGlusrJocVlJMj332WtT/OxUvr5BtlD+CdfIbI31WVVtthkrbbtmydN3 uyu35N8UajCMeC6vnCb4YqkHP1z5V5zFTsArkzkZYtYX9HOO2iRDgf//lhBMPxaDlhGF z2uFZ53yYT1zSS1TLB7jnMZz1yUB8IviRyi18YBMoC03YNKCEL0Sxx0zZBEuvPjZwId9 svBoWvhhphed6AGjrbj0SSzycVzfXKC2OausDb7oWgJCj+74oYQz7AvyuDpbxhZXt7Ls Q0FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829965; x=1774434765; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cD08L7/tS/M0HJDnqHwQDjmjsjdzePAzezbZLq5ovR8=; b=nHkxahmLerVU5/MllQB8b6zKHzYhSxC04l7F2Uf2jXNj27vc4zXZUuvZfFnORKzUWd sbc592PVao+a1E1DWCjhzLbZZfETKGBmpu6XnzkH+U0gbAMwC9AjPjveKCX7XgcUPonp 0ftbkBboZIYBNPy/nu67dALq0PG1STXOGbH/wyXdXLxTGkNfI21VNNaD6WyJMLueLkku +cyuYQqBPdMY+zb+WrNCDNUd6WmWFibbwJF8wpLt9oE49Z81zKDPhP5mfwN4BMdYcLbB pAWtR3tnwpik/tMvUKyFtNY9BpaCdUeND1ToV/tK6Ve2ycMI3Rpjf+qDQtnqzyeNsVot ARsA== X-Gm-Message-State: AOJu0YwBCk88tOjVycfibV3D01rGlH5uuaijNgXFYWajFrt2dsqEEeZ/ 3Y1TwmoogG9zSTV0luzlYK/O9cw3LQjTNtC7drrGYk99ILI9ZBIx/jwLBOz/4LvvIbtL7zIUz4R +4ED6dHU= X-Gm-Gg: ATEYQzy4u1wIYcaDBJHhsKE/5dzIb/CP+1T689THwbtW+/QGwOeVtZMbzEclyxNN4SG 6pmswonxge6JSdWOavtZPddH+apkAIOCy65PHf80BmhVqWbs16XkN8pa1ZlMi3JQduBXgaFVZaC YyvsQv7RqUyKVhiTUY5HlFOYgWJmuMLk4Jy99wYcnoQmHIkbIPVjqWjWEQiQkXMPYlUSJRNAFBX TkFR2AUCLGYTl3ejwGLV1J2LjnbJpm0TPujlptdFBT+XV/LlOb48QM+dIpa344DS4rolbwFpb/6 vXnSeOoAqCGT3jLM0c+TTxmJnDrK4qr+jNWyj90QM3KZhJb/C9B8WgIZWwfq8WrVX62L3sTe0Ua Taaodkd4UDesRJ/JKZqb/aA995E0f2ahOeMRzPoOS3Y53kEwSInNroOlO69KyYXWHyilg/H9HKx nFgqja+mME7q2ARPPOL1aQEdzksFuvp5oebBCphIwyJQxSX7FwFOEynh6Rczc4HQKlW2PC3m0h X-Received: by 2002:a05:600c:4753:b0:485:3f1c:d8a4 with SMTP id 5b1f17b1804b1-486f443799bmr49292545e9.9.1773829964712; Wed, 18 Mar 2026 03:32:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 11/16] target/riscv: Replace MO_TE by mo_endian (MIPS extension) Date: Wed, 18 Mar 2026 11:31:16 +0100 Message-ID: <20260318103122.97244-12-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830032765158501 Replace compile-time MO_TE evaluation by runtime mo_endian() one, which expand target endianness from DisasContext. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/insn_trans/trans_xmips.c.inc | 24 +++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/target/riscv/insn_trans/trans_xmips.c.inc b/target/riscv/insn_= trans/trans_xmips.c.inc index 37572563ae9..c1a30156d36 100644 --- a/target/riscv/insn_trans/trans_xmips.c.inc +++ b/target/riscv/insn_trans/trans_xmips.c.inc @@ -47,6 +47,8 @@ static bool trans_ccmov(DisasContext *ctx, arg_ccmov *a) /* Load Doubleword Pair. */ static bool trans_ldp(DisasContext *ctx, arg_ldp *a) { + MemOp memop =3D MO_SQ | mo_endian(ctx); + REQUIRE_XMIPSLSP(ctx); REQUIRE_64_OR_128BIT(ctx); =20 @@ -56,11 +58,11 @@ static bool trans_ldp(DisasContext *ctx, arg_ldp *a) TCGv addr =3D tcg_temp_new(); =20 tcg_gen_addi_tl(addr, src, a->imm_y); - tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, MO_TE | MO_SQ); + tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, memop); gen_set_gpr(ctx, a->rd, dest0); =20 tcg_gen_addi_tl(addr, addr, 8); - tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, MO_TE | MO_SQ); + tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, memop); gen_set_gpr(ctx, a->rs3, dest1); =20 return true; @@ -69,6 +71,8 @@ static bool trans_ldp(DisasContext *ctx, arg_ldp *a) /* Load Word Pair. */ static bool trans_lwp(DisasContext *ctx, arg_lwp *a) { + MemOp memop =3D MO_SL | mo_endian(ctx); + REQUIRE_XMIPSLSP(ctx); =20 TCGv src =3D get_gpr(ctx, a->rs1, EXT_NONE); @@ -77,11 +81,11 @@ static bool trans_lwp(DisasContext *ctx, arg_lwp *a) TCGv addr =3D tcg_temp_new(); =20 tcg_gen_addi_tl(addr, src, a->imm_x); - tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, MO_TE | MO_SL); + tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, memop); gen_set_gpr(ctx, a->rd, dest0); =20 tcg_gen_addi_tl(addr, addr, 4); - tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, MO_TE | MO_SL); + tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, memop); gen_set_gpr(ctx, a->rs3, dest1); =20 return true; @@ -90,6 +94,8 @@ static bool trans_lwp(DisasContext *ctx, arg_lwp *a) /* Store Doubleword Pair. */ static bool trans_sdp(DisasContext *ctx, arg_sdp *a) { + MemOp memop =3D MO_UQ | mo_endian(ctx); + REQUIRE_XMIPSLSP(ctx); REQUIRE_64_OR_128BIT(ctx); =20 @@ -99,10 +105,10 @@ static bool trans_sdp(DisasContext *ctx, arg_sdp *a) TCGv addr =3D tcg_temp_new(); =20 tcg_gen_addi_tl(addr, src, a->imm_w); - tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, MO_TE | MO_UQ); + tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, memop); =20 tcg_gen_addi_tl(addr, addr, 8); - tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, MO_TE | MO_UQ); + tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, memop); =20 return true; } @@ -110,6 +116,8 @@ static bool trans_sdp(DisasContext *ctx, arg_sdp *a) /* Store Word Pair. */ static bool trans_swp(DisasContext *ctx, arg_swp *a) { + MemOp memop =3D MO_SL | mo_endian(ctx); + REQUIRE_XMIPSLSP(ctx); =20 TCGv src =3D get_gpr(ctx, a->rs1, EXT_NONE); @@ -118,10 +126,10 @@ static bool trans_swp(DisasContext *ctx, arg_swp *a) TCGv addr =3D tcg_temp_new(); =20 tcg_gen_addi_tl(addr, src, a->imm_v); - tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, MO_TE | MO_SL); + tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, memop); =20 tcg_gen_addi_tl(addr, addr, 4); - tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, MO_TE | MO_SL); + tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, memop); =20 return true; } --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830108; cv=none; d=zohomail.com; s=zohoarc; b=UBa5ffT0ABK0rGckLDYXpdXQaeZW0QKp6ZxqV+IYuHMSHQVIMXKJ/CZaljZf3gFG7ShRYlnHOge6Basp5HGdwCZ6Vlg+H5xvRNPJ21QGba0sNuWjAecRFc+bwfQmQ31CdRl8oOPE38fY+9hmmO/rpODRTBF12sAMlNhzRvjlFrc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830108; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GeF7zrqVpIAN2M1XENsNrdt0KqgGLN7xQ23+VAFB6Aw=; b=SpC0hl1jgj/iCPtrJ+LNDdQwURr0LjGrI9OHjayz0bmjmSHGNPlsTVi/mufLZ+mJytMcXqAd5hbu0sSm4GZBCXg4MmqObS2oEQuxr8WHeiv7wwackFbKsQMSH7ClqSUyiWKjggEIXGuBhZiTp13h2b17dFhbOen4rxnNiCTuWHM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830108891559.3720267570811; Wed, 18 Mar 2026 03:35:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oD5-00036b-UO; Wed, 18 Mar 2026 06:33:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oCw-0002Vu-DC for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:33:00 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oCu-0002WE-0e for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:32:58 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-439b2965d4bso4745694f8f.2 for ; Wed, 18 Mar 2026 03:32:55 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f5e1ab83sm12169645e9.36.2026.03.18.03.32.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829974; x=1774434774; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GeF7zrqVpIAN2M1XENsNrdt0KqgGLN7xQ23+VAFB6Aw=; b=CBww7RuUOBTsnVP0WWQNqaG7zwMzBsqm82EMilNCYQUUZNuRcUfQke9LpZEThee7gk m23Fkw7yOMHyjx0EO2xbSL2E6xSs4dPyNb6rme7kta3h14haaf12aRjWDfDrui/7vzFD YWJvsXmdxxXguLK1uHLPzi8+sSyS21PjjJUVCodeze6uwJoTbNMmXdRWZSiPmvmdb0QU z1LyXylZd9vQvxWfmdSt94bt/4cOb1Cxq3pjzGDHBkv7/mumF6oIKF634V6xhxgjnEz3 Hqk7O4Aquj8ryp6xmT62mnRqJT76nhCUPI/bBYAcOVatj9HPA6d+i/hhuwMl4/G8+tV1 YS9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829974; x=1774434774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GeF7zrqVpIAN2M1XENsNrdt0KqgGLN7xQ23+VAFB6Aw=; b=W5XZDzHnHmOgsk7Xv8XCUVGjWypvfDUUe16Uo+ILAG38KNOxmwD1FQ4rae+x0K2I/a kHprk35cWh5sKujg6vjMRLbYjiXFM50xIJ08tagvWSYJVNV9bMt0LImSRuxmXblidHxU qgHuiuHtnowtjodQwgv2BoMZZ1wv+sWigQ/pdfbQHbPv7MYA4yxiAvqcTRA66EPNCfUe 3ud8188rzXFj326PfeTbOqQOV3jhlhxeQGMCDteB2eN/ZY9aiHHBduyZ5YUGlw2Oj8x2 jqe3VGzX5Lki/CorEhomzqhypThWz/s6yP63oYH5Qf/cBo2gfyrekJZk1fun0v2PYOQ+ 4KHw== X-Gm-Message-State: AOJu0YwNZAD+rOAu2FPoHJhs8ESJcwwsE4C+OAoAVsIFa49EyV8ioNlr hGcLLr9Z/+Amvko8s1NRqPn/OPPnAT9/tf+nsSvu4cBmoOjzne46BG9A9L8GtF/BGTveq06+v8p WYk9abmw= X-Gm-Gg: ATEYQzw/HcEdlWKeNTLMoQ7oU9eFKw1MOjUUq75znYSvxXcc4usQ25QkQ2Pm7cKjJH2 UIxW69hTzGMeqotKFpkfr5i9i6/iHwYnfO7J0e8yqM6vUbcPIKA22cJ/VbIee8p0mbypyYUVl1t s+ayuyhJF2bNZEFnkxY8uSpWWHp6jq2/iqc74ke557M8ee3G68aiNfam+Aw26goU+pnIfsqq+z8 wbjLpJNkUQ+EGPzi/035D2/nhXFNLvpl1iJ0t8aVP+hCAD9A0MBKz2jmlmeRf+mCB6pCBfJZ3nT YQZ9XlzFxCSOPVJvztwT2Ckx5F71WUvYkEkHhV6GpKaOQj4OjqZqZyepSgaaO7r5RCfSvhDcsuu wLhz8VsvioeIUiHrFoWy02ztClR5o8l57E2nDYdQctmCEzC6yQtT5dWA4VTv8WLIOvFh2ZO12VO 0CdGC9rI5SlbCqsdiNsEqGlir5JvyY7yrCpg86sJ+kHmu34Sk8AaxrMp/CBVOPNS9dpW5EY15l X-Received: by 2002:a05:600c:3b07:b0:485:3026:2b8b with SMTP id 5b1f17b1804b1-486f446fab2mr47314795e9.29.1773829972642; Wed, 18 Mar 2026 03:32:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 12/16] target/riscv: Replace MO_TE by mo_endian (Zilsd extension) Date: Wed, 18 Mar 2026 11:31:17 +0100 Message-ID: <20260318103122.97244-13-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830110592154100 Replace compile-time MO_TE evaluation by runtime mo_endian() one, which expand target endianness from DisasContext. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/insn_trans/trans_zilsd.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/insn_trans/trans_zilsd.c.inc b/target/riscv/insn_= trans/trans_zilsd.c.inc index 445406cf015..f50c52f22c9 100644 --- a/target/riscv/insn_trans/trans_zilsd.c.inc +++ b/target/riscv/insn_trans/trans_zilsd.c.inc @@ -30,7 +30,7 @@ static bool gen_load_i64(DisasContext *ctx, arg_ld *a) TCGv addr =3D get_address(ctx, a->rs1, a->imm); TCGv_i64 tmp =3D tcg_temp_new_i64(); =20 - tcg_gen_qemu_ld_i64(tmp, addr, ctx->mem_idx, MO_TE | MO_SQ); + tcg_gen_qemu_ld_i64(tmp, addr, ctx->mem_idx, MO_SQ | mo_endian(ctx)); =20 if (a->rd =3D=3D 0) { return true; @@ -85,7 +85,7 @@ static bool gen_store_i64(DisasContext *ctx, arg_sd *a) } else { tcg_gen_concat_tl_i64(tmp, data_low, data_high); } - tcg_gen_qemu_st_i64(tmp, addr, ctx->mem_idx, MO_TE | MO_SQ); + tcg_gen_qemu_st_i64(tmp, addr, ctx->mem_idx, MO_SQ | mo_endian(ctx)); =20 return true; } --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830049; cv=none; d=zohomail.com; s=zohoarc; b=FQmt4ys5/SRmAIYlruDp8vUARP6hqAM9j2g4+jbHU0KYU6v1pAniA+51ytNtw37R4cXp1LFVPkEwbZDI1q/QQQMnP5zZxjN+gMtFOgmI/xNq7kLYk53/KWrRry/j9DZkssDLLOT+z4nNlXZgwo2lArejjDyNMVVk43OnAIiDnek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830049; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=m/1EOyUUME4DZlQmM1UtNcy0WikBgHhHG/J2iZX+i+A=; b=eAuNFB1C7HHJBrY5tO6k+7C5fR130Aba+fbY0is+LA/C01cK9WIM6bcn8SyfdDEMb+O44kBgRDfe6s4NNPLLWy3CtkYpb4+7BwtS4BV63c+SX2p0iqmITEFS9OgAOGxV51KbkLvpmGYMG4Hp8g0jB8GgAkA5M8wEduuOJ6wFZMM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830049189393.60632134940136; Wed, 18 Mar 2026 03:34:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oD4-00031h-Q6; Wed, 18 Mar 2026 06:33:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oD1-0002rM-9F for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:33:04 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oCz-0002Wq-Nz for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:33:02 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so55828245e9.0 for ; Wed, 18 Mar 2026 03:33:01 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f442d5c5sm52249305e9.10.2026.03.18.03.32.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829980; x=1774434780; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m/1EOyUUME4DZlQmM1UtNcy0WikBgHhHG/J2iZX+i+A=; b=wI0J9fkZmyFkbFC+ip5AYOoHqO0S4Aaw7GCh7WitJP3V/d+l/9cNyS3wswwwTUQ86p wLdhhAdGJBpyAW1MwVa1E+z4TzO8JmYp4mDN8iG8N0obZ0NvWkVWkRJ+j6up+4u1E2fd IsDo73fVK4bJ3cqCu2TwkzHoC6/awEMQKDCCFya9jDlgkoYS4BDwiCnloAVFYNbfQBAy TBOvpk6FncP9AXDahkBY4cseB3h76TIZpnXh55zUoOr9KNRsehx/QwofxH/cNSZsYIAW HxeddZNsBL4XPF4LEV7bYcj5/4GWWASuOKjdUf2LVflh76ZL3ydAN/RSLrPxT86PLxUt sahQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829980; x=1774434780; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=m/1EOyUUME4DZlQmM1UtNcy0WikBgHhHG/J2iZX+i+A=; b=BkU74ElqjOiVI1IKIsfftJNIt/GBazrNQRcltEBquiZFAR3z4qegJRH70m30gM2W3x qwwhJvMzKSbTTWHGUwfoz4TcRYC18gkd9sOvWmig5RLbMk1AB9xCiFH7hO4sMLBdUQ6k uXBYldVNcgH8gPjoHPzy96YPFY254tYc96WaJF/D3wNXOXKk0DpieNQdoiCkOuIWBeYm AWidO5uW/9svwrANSLPGTZzISl/4/rMIq95I2aGRsdE/RNp623kYKDoDinu0Bx5xu4bL NLJV/QSTwTXY00WxPioGLO+s4TBy8mjZ/cj1vNSkRZF67UMNCiQkm7AvZQwijW1jonmW shkQ== X-Gm-Message-State: AOJu0YzW+dG5hLQt8oJOvvT1+/mG8bId7ZS3mkGJkS+m8AizcEk/w5Sg Dx4/V1XqcuBrSd7KC8IhSScedrtx7mPaQvT0EeQ4+kh/vQJOf8ktmz14/yF6wt/65vX8rBr3wCi mZf6E/k0= X-Gm-Gg: ATEYQzwq+OtkHOTiLa16fvR4Xh2iaFazXAvX1ngXgl71cWV8u6LlSCwMM+9Sti/tdt6 WnsiR+hLV7J3D6LU7Wpd0WJDF8fiXtQnhwdMtwrzgrPZBDg0Aiq1t22HrzqKlO16UuMB0Nudaxo nk35JYIYOWzw8jcd8FK0ihCnlaWXU/A6YAwlBOSLc3CHiUEfTz1tdEQKAg5EwvU4LWbCt4ae498 4eQzfG/s8ONEMITAlFLyAGxTgZk/4GTrLETzVKSw20F5qTpXY5z9+6hjIiN2rvkn5kLcj1juX13 U+BoOt3pw0VaXwBT2Ap857nsplUmrSVxbxRBNcE5OqxJj0r1D1yVwVaubLF5uOW7Pt4pCmfZe31 2Nf/Q9WG9fRFSatQpd4Nueef2Lmt9cR/xRaw0SIaWDCsyWM+oBkrraxWTMFDRNywd1jNR5gCk0q QerNa8N6VAZJtg4GW0Fc5nQLruwfLISD9iWCef6I+bhofi25HZR70KIVP0X3aOQc+l2HuNAQpi X-Received: by 2002:a05:600c:1551:b0:485:439b:683f with SMTP id 5b1f17b1804b1-486f4441190mr47497685e9.20.1773829979792; Wed, 18 Mar 2026 03:32:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 13/16] target/riscv: Replace MO_TE by mo_endian (Zalasr extension) Date: Wed, 18 Mar 2026 11:31:18 +0100 Message-ID: <20260318103122.97244-14-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830051771154100 Replace compile-time MO_TE evaluation by runtime mo_endian() one, which expand target endianness from DisasContext. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/insn_trans/trans_rvzalasr.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvzalasr.c.inc b/target/riscv/in= sn_trans/trans_rvzalasr.c.inc index 2b1f73f650b..0f307affecf 100644 --- a/target/riscv/insn_trans/trans_rvzalasr.c.inc +++ b/target/riscv/insn_trans/trans_rvzalasr.c.inc @@ -29,7 +29,7 @@ static bool gen_load_acquire(DisasContext *ctx, arg_lb_aq= rl *a, MemOp memop) return false; } =20 - memop |=3D MO_ALIGN | MO_TE; + memop |=3D MO_ALIGN | mo_endian(ctx); memop |=3D (ctx->cfg_ptr->ext_zama16b) ? MO_ATOM_WITHIN16 : 0; =20 tcg_gen_qemu_ld_tl(dest, addr, ctx->mem_idx, memop); @@ -79,7 +79,7 @@ static bool gen_store_release(DisasContext *ctx, arg_sb_a= qrl *a, MemOp memop) return false; } =20 - memop |=3D MO_ALIGN | MO_TE; + memop |=3D MO_ALIGN | mo_endian(ctx); memop |=3D (ctx->cfg_ptr->ext_zama16b) ? MO_ATOM_WITHIN16 : 0; =20 /* Add a memory barrier implied by RL (mandatory) and AQ (optional) */ --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830071; cv=none; d=zohomail.com; s=zohoarc; b=DLkm8eEji5mWlvKKgCotzkfFr3UWzXywuBezOhKQH/JAauGHwRLtMivYAluXJro5M+H9JLWK9gZgec8oPK3m0V37OYbPb5YqASlCvUuoB8cMx6hYICxKEjARD7Ru36CNX0H8T2UR25WHAVNefVvrk8vDK4sPwSpBIfxh+mqIadk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830071; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=31YJoguDTECg29DDzAK2HWxAHgXIKCQcZk0EpeWDAXA=; b=XDsIj7I8ubmjxBaj0qIRFN7mP30J/2Siyz4O6T24vGkuyHVVqKsppZQ7Tn6GouGY0sOFO+oR2xCNQ8lYHKb1AlQ0CkiQ71RYwKl09ocPZzQrGQDSiC95eI0YZS6oIlftpfNiJvfiapqqSVOma4Ufzq74z1FP3283u0q0mxKLgbk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177383007171923.62074484747484; Wed, 18 Mar 2026 03:34:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oDD-0003Wg-6v; Wed, 18 Mar 2026 06:33:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oD8-0003F9-NP for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:33:10 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oD7-0002Xy-1i for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:33:10 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-43b4915161fso2243663f8f.2 for ; Wed, 18 Mar 2026 03:33:08 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b518a2cd3sm5591005f8f.32.2026.03.18.03.33.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829987; x=1774434787; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=31YJoguDTECg29DDzAK2HWxAHgXIKCQcZk0EpeWDAXA=; b=DYZP426ev9sisz8BDHNT3Gy1r+jnZLB4udSH5mdTWK5OC8vzJHLPHpdEUL62IDXMcc dncWOkc9GnLQqgj68RCrM0Gu0FEbJrus4AlNgUPq3EUnzOyZSpMrLdMyY5ece9UHX1Y/ GhYPoD01O0MEoY4WzX3+PSQ3jTl/3/ZFOCzCzf0nbeHp7GkHYlU7SkL4iDQAtfdWKB3b v19iLrADXd/Rk+o10YcYtL2DMnbIgvWPeqiv7t7EpkyQlJtc8ckgHBAKLSpg3cXR2UW5 sF3DckGrR6LAeWRWPoziq3tKLsZiDuZdUd02j2oP2U3mBqG3JcsJj42SIUIoyfifqHMU BURg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829987; x=1774434787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=31YJoguDTECg29DDzAK2HWxAHgXIKCQcZk0EpeWDAXA=; b=MJy9SwNR9R5sCVttsTGqDQs8p7DHAJe+oohOlpEtaZlW/15uS+Qyco3q2piEwLrAhJ dGK66fdQGNpnd9chx8f9vI2VwBKuymS9MlbyuUBNRFvVazHGmfq9xQIqtTqXp5X/Rg6w 1Don9LuN3t1uhfk035d8v4gagLdHKvz53NPP5Y0n4mZs0cvb9Tv4ypQUxFtp2x2OZVVn ErsugIcLuoHlpDBCLfzRgzAKICUthKImwsL3fPpq30rRRI76NtiHo0MnqAWklLQ7e1m4 AwFUXU3sNuMz9ZhPiJdUFJuDDiPYJqYNVPoMKHfAev5i//cMOHaWKAODajZMxrhfhm+6 rxbw== X-Gm-Message-State: AOJu0Yy6Nn0G6KwmS3O0ghTvXQk/h3PaYfvucwbfcCU35NSqwjXVg2BJ ZlvH2LXJKkERo6XW9kcZX1267J7Cvc0WChvk0KQtuAKnTNEWttZWKctidB86/VPBhhp8Tjy8K2s iJBLc4zA= X-Gm-Gg: ATEYQzw7MSE9HC1k9DEOg6w821xp3IPbdWeT86U5ALgOSB0i6ELbNuuidOt4qCMnWMs cvcBRpCmgwBEvWSmbw/bcFZnhxjNWXCFBFoc/o2Q3zzFN4xv91D2UKLXqQ4CFVgdwjMb7kJSDfI efZ2tt7oULgv3U0+7g0C9gp5EZnHCFzpSOEtfZbbGbzz8h461dKTG+q+pfib+7HIdPcC9Zi9BWL KsWwyLPkxeeKhCdvAW43ZqtvhAQjLFzokJV7KvCbkdAO8rv1amHnK1bXf8xwG8sH+kPMpLzVXIw UKXw/LxjbvZRtyJ9K7DfVZo0z6iM/0r0GG9WkiUneMPQMj/tLViQoRZN1OrF2T+rVhUvmDxjh3v LMzMuG895UMS/x5aI9blVt9fGh/S3w8a/pepFGuxapoOenNWI9zrY0MF7aXszMs+CPEsVHuHfcc zWxqQ3YdDqKH6dtTo61o95TE6hlnVI4ynZSOyE3mDxY5I0eCq4r76nKbBL0lyGCp2qu2/hb7Co X-Received: by 2002:a5d:5f86:0:b0:439:fd78:188d with SMTP id ffacd0b85a97d-43b527aaa6bmr4766771f8f.17.1773829987021; Wed, 18 Mar 2026 03:33:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 14/16] target/riscv: Replace MO_TE -> MO_LE Date: Wed, 18 Mar 2026 11:31:19 +0100 Message-ID: <20260318103122.97244-15-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830073921154100 We only build the RISC-V target using little endianness order, therefore the MO_TE definitions expand to the little endian one. Use the latter which is more explicit. Mechanical change running: $ sed -i -e s/MO_TE/MO_LE/ \ $(git grep -wl MO_TE target/riscv/) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/internals.h | 2 +- target/riscv/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/internals.h b/target/riscv/internals.h index 860c47732b6..460346dd6de 100644 --- a/target/riscv/internals.h +++ b/target/riscv/internals.h @@ -71,7 +71,7 @@ static inline MemOp mo_endian_env(CPURISCVState *env) * - MSTATUS_MBE (Machine-mode) * but we don't implement that yet. */ - return MO_TE; + return MO_LE; } =20 /* share data between vector helpers and decode code */ diff --git a/target/riscv/translate.c b/target/riscv/translate.c index cb4f4436018..6f8b8e9d19a 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -135,7 +135,7 @@ static inline MemOp mo_endian(DisasContext *ctx) * - MSTATUS_MBE (Machine-mode) * but we don't implement that yet. */ - return MO_TE; + return MO_LE; } =20 #ifdef TARGET_RISCV32 --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830053; cv=none; d=zohomail.com; s=zohoarc; b=nf381LXaZqRHTTfZE4r5Hqem1fWvMd/sHMNUOMImxU7YDEWSbIFPMr7nlNgkQI8p/Pva7a8nzdDxc+ZeAbOJKbSBMRAuekMwY487WVwYaIDCPPhpBMSkcw9E6Sf+PnBt8z9tsYtzMkyp/VJASbwN2a8C+43FJH8l+Fs2zTzJCZ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830053; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=n2Sgkb6N71I15zCHePybcfBnW8R6vfuIZgllQvpx1Uc=; b=YaHFRUtG1CrMBBqf2CfUl2OL805dFC+W+pV1CrP4su6fwfnppD0Oi2XjLgKwg8m/Yqbu2XNXG0AXkMzNjiF4j/Puz4c3RnKpq3bYuuZezudb+tGSLsqX0uHvAU/BbHoSx+QkXPPoH07v4H6vXxdJCzrrwNgYvRKS9aY2nVUvUjs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830053440657.209796018257; Wed, 18 Mar 2026 03:34:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oDH-0003lX-O2; Wed, 18 Mar 2026 06:33:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oDF-0003gI-I3 for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:33:17 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oDE-0002YW-18 for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:33:17 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-43b4fd681c2so1250513f8f.3 for ; Wed, 18 Mar 2026 03:33:15 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b5189971asm6778525f8f.30.2026.03.18.03.33.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773829994; x=1774434794; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n2Sgkb6N71I15zCHePybcfBnW8R6vfuIZgllQvpx1Uc=; b=GkkJ4TDnF9A87W6rNQdnATqlDm3l5jlXP6PMIH2+xqzgEdHtKLQH3S0OyDGfG9qa91 aPjzfKrxECWCoOXoLluhAT3HhI1qHB4BFYAxSPFbRMS1eqBnX8b8ATwsmnIy2ZPVatyM A5zssta5AIw0LLzXco/Jn2Fl0fvyrr3Z7hAIna8jKJB/2BwjJmJy2yRHDJ/mqWSRbUHZ we1L3Xd3NbvPHi/ocAtJQO1CiJv2MLzLc8LE5H0djaQRVb0HjCcZB6AH5RYguGFKwt2I mAy8GfGvEnQBfKpWQV9u0l8Fz21gngrAjOcOqEeNJVloOJoCYqDrK9k/++5Y/F+3zGgy YCfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829994; x=1774434794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=n2Sgkb6N71I15zCHePybcfBnW8R6vfuIZgllQvpx1Uc=; b=lSmgj+N4tlhKnlX67NwGoEzKgxVlAKjv0bYmJSPMLb7vopQeNDJ9f3PJ8baYjhbX85 jWPXilEKONJEeDUTv25tv5rgqtSxTp4Zns+n+dTM3fe1Wp1VAIVefZs2uNUDwtZDsbRk zl7LGixhZOBAmZUmQ5mo4LmKcGKvVp0mj3kBG+eF/bmVxwAKtE+KxOBLQiV46MTIOUVx Lf9v8kP0tqNUmD6/d9NsyYqpoExKgA9OiAC1HBrHFmHRsPsJQAWWanBzr1/Dw8TtajKO nXoriSGS215AeMUPvodPK+ajrMWW5SedTeGrPRv1CgbBppN0pL2jsXxr8SmBXBnidFu1 TBZw== X-Gm-Message-State: AOJu0YzvkU8J1gzgKNEoMK04ZkNLl0RJEdrsfykPx/m+S2t47YCUxJ7N Ismf/OmsvCesdBqC7PVpi6bnGaGL7j/v0iZ+BE04qFtC0YH4XxbPeRH0NJc7El2hr0/Emz7sez+ UM4ATbVA= X-Gm-Gg: ATEYQzxy2yo9rfOgoamAhkOAbqL/RCMNsXts2PCh/xiLoWZvqEV9vEOeEQ0EWCnYWTI roH8pP1ISMyL0LCr3eBag6Dpi6SrHPeu8V4VGYHC9QTKDuPftYstniSBOAKu4qNrkyCEa+f/2Ar u3Bzir3JrI+J81KPh3xrGrbXkeH7OzwFUL8iQUJKk4Vqe6a/w0GpNIrTaOB6RL9rtw5iyxKiSQy gP0kEYztWiODq80V4UMXam1boyd2qz4WRvN5ZEbJwyfrC2XQbbfEiZPqd0kGEYjn4RAGQusItUn VNZg8ZdXLnLAAXPF/Dxekt5i36HJAUZvaAF/8Oc5vg8pybTQS3IzFZIFYFLjUQPrgl6IiKQW7im zBK1Iv12YeNXqNAeImpLFXqLw/kuOKEUU87JsHT8RfwMMZCzFNt/PoYo6J2Ooj4yc3BPxS4g9u4 Dds4E1324ENab+D5ckrFEgFJ2MKCx7YDT3oGFP5kmNS5nlqyy6AxqQ31Vu25VFhG2sLGJGGRrm X-Received: by 2002:a05:6000:24c3:b0:439:b55d:b0e5 with SMTP id ffacd0b85a97d-43b527c4301mr4406646f8f.28.1773829994167; Wed, 18 Mar 2026 03:33:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic Subject: [PATCH-for-11.1 15/16] target/riscv: Use MO_LE for instruction fetch Date: Wed, 18 Mar 2026 11:31:20 +0100 Message-ID: <20260318103122.97244-16-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830054165158500 From: Djordje Todorovic RISC-V instructions are always little-endian regardless of the data endianness mode configured via mstatus SBE/MBE/UBE bits. Currently, instruction fetches in decode_opc() and the page boundary check use mo_endian(ctx), which returns MO_TE. This happens to work today because RISC-V targets are little-endian only, but is semantically incorrect and will break once mo_endian() is updated to respect runtime data endianness for big-endian support. Use MO_LE explicitly for all instruction fetch paths. Data memory operations (AMOs, loads/stores via mxl_memop) continue to use mo_endian(ctx) as they should respect the configured data endianness. Not-Signed-off-by: Djordje Todorovic Reviewed-by: Alistair Francis Message-ID: <20260311115910.564481-3-djordje.todorovic@htecgroup.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/riscv/translate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 6f8b8e9d19a..5df5b738495 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1255,7 +1255,7 @@ static void decode_opc(CPURISCVState *env, DisasConte= xt *ctx) * additional page fault. */ opcode =3D translator_ldl_end(env, &ctx->base, ctx->base.pc_next, - mo_endian(ctx)); + MO_LE); } else { /* * For unaligned pc, instruction preload may trigger additional @@ -1263,7 +1263,7 @@ static void decode_opc(CPURISCVState *env, DisasConte= xt *ctx) */ opcode =3D (uint32_t) translator_lduw_end(env, &ctx->base, ctx->base.pc_next, - mo_endian(ctx)); + MO_LE); } ctx->ol =3D ctx->xl; =20 @@ -1285,7 +1285,7 @@ static void decode_opc(CPURISCVState *env, DisasConte= xt *ctx) opcode =3D deposit32(opcode, 16, 16, translator_lduw_end(env, &ctx->base, ctx->base.pc_next + 2, - mo_endian(ctx))); + MO_LE)); } ctx->opcode =3D opcode; =20 @@ -1401,7 +1401,7 @@ static void riscv_tr_translate_insn(DisasContextBase = *dcbase, CPUState *cpu) if (page_ofs > TARGET_PAGE_SIZE - MAX_INSN_LEN) { uint16_t next_insn =3D translator_lduw_end(env, &ctx->base, ctx->base.pc_next, - mo_endian(ctx)); + MO_LE); int len =3D insn_len(next_insn); =20 if (!translator_is_same_page(&ctx->base, ctx->base.pc_next= + len - 1)) { --=20 2.53.0 From nobody Mon Apr 6 18:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773830073; cv=none; d=zohomail.com; s=zohoarc; b=m/2ho9+o9EuUVdqEBGBiZQb+o0HT5Hm5dZam90PAW87p7pSOZYshhlOcEv8SnWED/spDW0+d60a4r7q6jynIhZcVXrj0Jydk61K4gH/7a4q7yiTLCzlIQumOwjoqE+lU04gwQXHPZBKXbTEebYzJpevFyJsu3+5HVGk6FKfzLck= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773830073; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eb9ND8Ru+1r4jviscKaZSR5cTPKG7MGtBYqAB3umF08=; b=YyS33l1i75WhMaHa1QUJpKDfYimIAb9RwPDuBrCn+PEplYlJi+garWKFDVAuD+FeBpCoZ7GspIt3zSZeN+JjX33sSqFWqwXZlkmvEEAueE12hfLsRPR3bnMFP85dOQSu7LZrdoAir6s05gwewjGhaS7jfzO2pQAks1WD1KMBZcQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773830073733982.6667761467787; Wed, 18 Mar 2026 03:34:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2oDl-0004UY-Ol; Wed, 18 Mar 2026 06:33:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2oDV-0004Db-3G for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:33:34 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2oDP-0002Zd-Bt for qemu-devel@nongnu.org; Wed, 18 Mar 2026 06:33:31 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-439c56e822eso6932459f8f.2 for ; Wed, 18 Mar 2026 03:33:22 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51849636sm6967863f8f.8.2026.03.18.03.33.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Mar 2026 03:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773830001; x=1774434801; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eb9ND8Ru+1r4jviscKaZSR5cTPKG7MGtBYqAB3umF08=; b=yoJEIyZCpfyUSN92drcAdB9HpLKoKVHjLD0C91128k7FpawuS3Q2Q9ULm3cRpG9hGv GIMQDBHVEmoOcDh1H2CK7jFJJh9H9tbWMA4qxCNfGyUFEgnicoD++AN8Ul2R/dyanp70 LhqGpNbNoOxUSb2aJ0n4EZwYQsnErXNms/Oz2onijOUbX8PuUmU4aqyPBARRP9RbRc4A GGf++AYIs4kOoZR4EiqXX2uI33TCAnUxk3/B82Lpeue1skE69CbCg0WBvE8zGND7IpNh brdmKG/f4HRvkww+GjmHll/imm8F2I+LZsueAZcaIhKot+sH8vp5jSFoT9OPL7lNxwD4 RbcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773830001; x=1774434801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eb9ND8Ru+1r4jviscKaZSR5cTPKG7MGtBYqAB3umF08=; b=cpvpXzv+i5oDRrEaqUNUrWa8o0vABWuHpMDLuphiTiXceWB06b/4RtjZC1548VWBg+ O+aJYGxXWWHJ5xDUy5XWI8ClrzM072fWHWcA3Rh/lV28mp44Ck0tCMYi/yW9bBVj4C5Y FyQ3A+ohYsU00cr7PlWUpev45n5oF+QLfO9ZzP9iRRAkv55YXdSbISvcRDWutenEXRNy kDt1c0HQpyuAS8mkhVSjv7CjWGN4mskAgHHblVdIrD46h042IbJLR5kSlnCXNJWmSVvH DfNeD3Zz4xO4UnZ2V/5lR15MnIFsPigLV/f6Y06gjRmLC/CYnnIUiwxxPX2WTofzPfzK j7Ow== X-Gm-Message-State: AOJu0YyhHLyBT6BA9xEM1hdRac5XxKj1BjLMzbyJuskytKPHJ8nL1MQE EkInEz2y59r8rJsxJzl/5x3oBt2OvmOkWv1BU+f20fZmap4pmYuumrQ9sDYnyoGvgZIA8rCi3/q 7vyXB/dM= X-Gm-Gg: ATEYQzzLIxzyqOHJG4YGuztFZW+TIEqhpfiwxMv1uZb1juCOFNICfX4Idw/ok1Pbjcs YY5/KSqN655ZiFCVCj0RInnrUiQf1hX3VZxLFxCO1svoYmpwGcBK/YDcI3SvEvfKQFxAGiDV0rx IhbFc7/3mTcCmIfOF2zKTda7WSMEL9MzzXiXQoefXSoDLsU6O+XJsxjMearweGJbNTmcfzeZWa2 BYska0ORwRlKtW79GRD/uJJRW2uWecJr0Hu5+WAsQR0t1WdhCPkOkc2HEbTX49CSlYrcqfhER0f 0V6G1l9QkPynt3ld0uE59+Ny42o+g1zkBcCiRC3f8mxYgVIbVo1cFfQH2u4Elpi78vSXycm1CHv Y9HWpP/3+N/VMrkF8nKUIMZvR3de4ojHuwCm5XKxHawpC7VjsLEqCMDb/qCZrwzjHtgtlOCC6uE 9eaTZVP5/TtoMlzbP47W6f3pNXxDB22ni0RKF66b1G7ZI9XXPA2kIlVV4NNMOk9HSBIZ8OocQ/ X-Received: by 2002:a05:6000:40df:b0:439:dfae:8083 with SMTP id ffacd0b85a97d-43b527c8185mr4689471f8f.38.1773830001342; Wed, 18 Mar 2026 03:33:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Weiwei Li , Pierrick Bouvier , Warner Losh , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9trot?= , Vijai Kumar K , Anton Johansson , Daniel Henrique Barboza , qemu-riscv@nongnu.org, Alistair Francis , Palmer Dabbelt , Jiaxun Yang , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Djordje Todorovic , Laurent Vivier , Kyle Evans Subject: [PATCH-for-11.1 16/16] configs/targets: Forbid RISC-V to use legacy native endianness APIs Date: Wed, 18 Mar 2026 11:31:21 +0100 Message-ID: <20260318103122.97244-17-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318103122.97244-1-philmd@linaro.org> References: <20260318103122.97244-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773830076096154100 All RISC-V related binaries are buildable without a single use of the legacy "native endian" API. Set the transitional TARGET_USE_LEGACY_NATIVE_ENDIAN_API definition to forbid further uses of the legacy API. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- configs/targets/riscv32-linux-user.mak | 1 + configs/targets/riscv32-softmmu.mak | 1 + configs/targets/riscv64-bsd-user.mak | 1 + configs/targets/riscv64-linux-user.mak | 1 + configs/targets/riscv64-softmmu.mak | 1 + 5 files changed, 5 insertions(+) diff --git a/configs/targets/riscv32-linux-user.mak b/configs/targets/riscv= 32-linux-user.mak index f069ab9a0f9..d88fdf5e1b2 100644 --- a/configs/targets/riscv32-linux-user.mak +++ b/configs/targets/riscv32-linux-user.mak @@ -8,3 +8,4 @@ TARGET_SYSTBL_ABI=3D32 TARGET_SYSTBL_ABI=3Dcommon,32,riscv,memfd_secret TARGET_SYSTBL=3Dsyscall.tbl TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/riscv32-softmmu.mak b/configs/targets/riscv32-= softmmu.mak index 26080599be7..5d5016d0083 100644 --- a/configs/targets/riscv32-softmmu.mak +++ b/configs/targets/riscv32-softmmu.mak @@ -5,3 +5,4 @@ TARGET_XML_FILES=3D riscv-32bit-cpu.xml riscv-32bit-fpu.xml= riscv-64bit-fpu.xml ri TARGET_NEED_FDT=3Dy TARGET_LONG_BITS=3D32 TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/riscv64-bsd-user.mak b/configs/targets/riscv64= -bsd-user.mak index bc85d9ed04e..5b4e138099f 100644 --- a/configs/targets/riscv64-bsd-user.mak +++ b/configs/targets/riscv64-bsd-user.mak @@ -3,3 +3,4 @@ TARGET_BASE_ARCH=3Driscv TARGET_ABI_DIR=3Driscv TARGET_XML_FILES=3D riscv-64bit-cpu.xml riscv-32bit-fpu.xml riscv-64bit-fp= u.xml riscv-64bit-virtual.xml TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/riscv64-linux-user.mak b/configs/targets/riscv= 64-linux-user.mak index bca08645124..35621520c56 100644 --- a/configs/targets/riscv64-linux-user.mak +++ b/configs/targets/riscv64-linux-user.mak @@ -8,3 +8,4 @@ TARGET_SYSTBL_ABI=3D64 TARGET_SYSTBL_ABI=3Dcommon,64,riscv,rlimit,memfd_secret TARGET_SYSTBL=3Dsyscall.tbl TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/riscv64-softmmu.mak b/configs/targets/riscv64-= softmmu.mak index 5059c550480..a10dc03c04c 100644 --- a/configs/targets/riscv64-softmmu.mak +++ b/configs/targets/riscv64-softmmu.mak @@ -6,3 +6,4 @@ TARGET_XML_FILES=3D riscv-64bit-cpu.xml riscv-32bit-fpu.xml= riscv-64bit-fpu.xml ri TARGET_NEED_FDT=3Dy TARGET_LONG_BITS=3D64 TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy --=20 2.53.0