From nobody Mon Apr 6 20:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773788326; cv=none; d=zohomail.com; s=zohoarc; b=HBkaAsBL9TFyZEC37q4kuu7TMnO3OXNUB0ZiLxa8XK7rYjwa3o80/MdulrAK470g3nc+q0YIOyE0qHrSI7jXLMBp0KtDXILkYW+9ZiUwyLbI+I9Q36I54ZdYd3RNEbKBMhB8QlBv7OhDqvuj2Q1S5x/PrP4baKopK5ifW3Yj93o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773788326; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5LwK4ZMpbwdwMoTORwTLtilm1v7SeNlN63Ch/P1NRjs=; b=g/fvKYm7HArgzD4lsyGFuppjpICIkmHydcUYFZOu+U7cGSiJl7ra+lsYmpIiEsx0wPUY31xPf3+q54VoAg5bJBS1oqQ5oQIKXtzWWm0a5ScOZDab4CIe107ATnQ+rntUibmn0UgIFw6/XCkz/Ld5RBD4TkLbk8SxVrXCI4cpvgI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773788326715539.9862727611892; Tue, 17 Mar 2026 15:58:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2dMS-0007Qp-Tx; Tue, 17 Mar 2026 18:58:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2dMS-0007Pt-3Z for qemu-devel@nongnu.org; Tue, 17 Mar 2026 18:58:04 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2dMQ-0001oI-IF for qemu-devel@nongnu.org; Tue, 17 Mar 2026 18:58:03 -0400 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-82735a41920so2382429b3a.2 for ; Tue, 17 Mar 2026 15:58:02 -0700 (PDT) Received: from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net. [216.71.219.44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6bbe7cc9sm484825b3a.48.2026.03.17.15.57.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 15:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773788281; x=1774393081; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5LwK4ZMpbwdwMoTORwTLtilm1v7SeNlN63Ch/P1NRjs=; b=F3kl4EmrPW/Ub1RS8Mx/LEqQqnhI0fdj0LYDAWyHm6kSfoyt4fcVAOMJTrGk6Bh62X 4BflqVsUGNxvgsBd9687bgjTBzaDAlepNz53vyDGOm+ZO/LZ6f8x3NthkGjrScp9PR/b 9tYN8jQ8RMgoqJIl9Fbp+FlYQQb8I9Qa+hU8wyRq03rk5FoQP18QcYguUlswK4SllA7j ktnhJ2GVbCRwfo3HmO2wR6knuPeFhEllcqlVFcl9tTBuepL8k/H0xduqZTXi3tixc4OA z6b+7/+WGfk1EZQbuzKvAqbucsbs5UoccO1bRZccUTBumzlmMdBMBG4xsu8RhvKzekih 8EAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773788281; x=1774393081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5LwK4ZMpbwdwMoTORwTLtilm1v7SeNlN63Ch/P1NRjs=; b=TqS0uxgm+TLGdi3tETooeJ+tuAtbjYCGIpO7kfsmrCx+XbgXgCOad3jfKzdtq7U+qY WPzbAXraAcMHBOY/k8RKE05NLhtVPnD8xaVukq8cwxk0OS5dnhjmko2IJUWP7SmaoILU njo+CphkAo1n6MgyU5fNR5U73uguiypCRKmFb3PcllqL6FigUpBjnowZV4YtZaGX9C3Y ERIMIgQGXnFaxXkQQjR1ETrAOBlSByz1XbNsQVR1K/opG5W/fmCjnpJsMQwqO9IOS5Lo HHSJqlcpUXt8rUWltjv49lpw2Z5PBirVN3S7Q0B/3R5hsOMiZ06nuCz/h4YxN02F4EjN NkMQ== X-Gm-Message-State: AOJu0YzFikQs9qKLrP78UzsuDGBOn8cRC/nD/UlDfEXLeVrQWWvjaqHE e9va/kSpNzSfxDTCE15qQZab62qs4XV8n+xygpAkTz6XMdMgFdiD60jATXuVB5MUS3WjbI7aBlS 2Gek+Tv4= X-Gm-Gg: ATEYQzyvxRhoBS4ECesyVQb2jl91v+G7N+eCLC3dxop5BL3tHtjgF/MUzS0VE13MWfT /oQyIL4HENzDDrrakhSNoS0k0BbqhaED66jaVC8XJCYLC+zkIObi//er/w6zDEiCosQUq8ztQ2i ruky7uYJR4YDqjqHIm5iQlxFQNL68AdfohlH0TJyYxRvf1rHCVOG2Vp/W/wBRBaquhdwcTqfgv5 HP0iBtHHgfK+VCYxOH49dQXSj5QSJXbsUeIPTm01qrOOG1biduwPlRk4znxtyi4sZpln5s4fv5e IG3TkLcumwFI/8tTyyaOjGN8xgCzcl+QMWTN2tSgAnWYx8QvlmBZKahYU187xdD7SHR1VGvPoru 3+8uIZ7DmBLMBlG/EfEwCZOjsMEq5tKE9CBzGRP+UNIwDkuTmEuMkf0XBEmxVD0570nMUL4Zsen UO0V8VdFhEOimueX/vK+VgOghh7wIsqiHPSJo3zziNJUiP1UunN6evUJuZkS2L5iYWdC+w8AMnm LL0 X-Received: by 2002:a05:6a00:4c0a:b0:827:3b1b:43e6 with SMTP id d2e1a72fcca58-82a6ae0d880mr793412b3a.21.1773788281012; Tue, 17 Mar 2026 15:58:01 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Zhenzhong Duan , Yi Liu , Alex Williamson , Eric Auger , philmd@linaro.org, Pierrick Bouvier Subject: [PATCH 1/2] backends/iommufd.c: report error when /dev/iommu is not available Date: Tue, 17 Mar 2026 15:57:50 -0700 Message-ID: <20260317225751.1325098-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260317225751.1325098-1-pierrick.bouvier@linaro.org> References: <20260317225751.1325098-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773788327716154100 Content-Type: text/plain; charset="utf-8" In case current kernel does not support /dev/iommu, qemu will probably fail first because /sys/bus/pci/devices/*/vfio-dev/ is not present, since QEMU opens it before /dev/iommu. Instead, report an error directly when initializing iommufd object, to inform user that kernel does not support it, with a hint about missing CONFIG_IOMMUFD. Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- backends/iommufd.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/backends/iommufd.c b/backends/iommufd.c index acfab907c03..c4eb3de1307 100644 --- a/backends/iommufd.c +++ b/backends/iommufd.c @@ -32,6 +32,11 @@ static void iommufd_backend_init(Object *obj) { IOMMUFDBackend *be =3D IOMMUFD_BACKEND(obj); =20 + if (!g_file_test("/dev/iommu", G_FILE_TEST_EXISTS)) { + error_setg(&error_fatal, "/dev/iommu does not exist" + " (is your kernel config missing CONFIG_I= OMMUFD?)"); + } + be->fd =3D -1; be->users =3D 0; be->owned =3D true; --=20 2.47.3 From nobody Mon Apr 6 20:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773788322; cv=none; d=zohomail.com; s=zohoarc; b=MLdvr7WL97ERF/vjq+MpyZJ0l1hPp/2PbAm4XDZ8y/hKSKNgrAHuKsrXdUiQpCpYPd4ETTj7KKl9VYM8HN5yL3pDJzkrruOUHPs+tMqVYkABzKUv2HWP+tijjmXjGi/pza9rGpOVe7YdJAGdFuREAwR0c6GdqLVhLJsRl3cFQxk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773788322; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3adXOulV1dTwRwi3VaDDPIxHsr/yRTuhhOa3Gu78OXA=; b=Z+DwZouCLdcK7FnskDH12Ub4DrPsgLO+/4z94OmYMVVkeL9Yom09m+El36vRGfdbMXAXz70XlTvgjhn34AoFalFuiZt+FWZDTVQD0I/U6sZSMcmds7gO/pGtFAY8kWNm6Oyulrxk6UJrRJHZAjpgsbIyN2KK7k+yrSPLn2tlhXw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773788322451184.4684737931957; Tue, 17 Mar 2026 15:58:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2dMU-0007TV-JN; Tue, 17 Mar 2026 18:58:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2dMT-0007RK-5P for qemu-devel@nongnu.org; Tue, 17 Mar 2026 18:58:05 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2dMR-0001oM-Hf for qemu-devel@nongnu.org; Tue, 17 Mar 2026 18:58:04 -0400 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-82a07738118so3641007b3a.0 for ; Tue, 17 Mar 2026 15:58:03 -0700 (PDT) Received: from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net. [216.71.219.44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6bbe7cc9sm484825b3a.48.2026.03.17.15.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 15:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773788282; x=1774393082; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3adXOulV1dTwRwi3VaDDPIxHsr/yRTuhhOa3Gu78OXA=; b=pttTTNqaQ6XjwHAKfRfWbFMD/SoK1LeLKar1IGe8tT6LVErEYg+2JS9hZ/Uok5I0mC J3GIl8gm66ECCaLF3XBXkp79mqYJMfNTbV7osrHk2T/Grl3dRUJRKFWKoU4yuC8ca7LL YfZM7UVvKN0LcOz8bJhkOWP+TnXA2CZfT7lx+oSNCLnK+kHND7wXshLnNoOqwVxcI+Ud aB1gKJQ6NLaeoCTmHRfe/fqeyq/97+SvIcCEQqvpd+R9i/xSEC2ft8H49vzEurmmsaSv EIOBEEZ8dDL0Q3FNHgJhyunULI+jyzrPmrZrq7UsIIYDsEFaOuYf5F8uIt6cvhJcVTX/ IFXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773788282; x=1774393082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3adXOulV1dTwRwi3VaDDPIxHsr/yRTuhhOa3Gu78OXA=; b=F9HFLc8IcFHT61Oex0Zw4WY8Ym6USeYxU0HLIk2S4NOwaflTLPCsH1CJsb86rixy1b NIhsOmeUP5vQ0J2giu0aWv4eIC+pv3jumeO+QR24i48fEpwuB7bPANA9KAB5k0uNfeE3 QyvhPpH3Sl9Uk2Td0Bj3UfHqt4xgJmScOEJrOiAtxV/XHLJmFK1RYF5YzHi5WssBDIIt Jm6xDK4CUtBt7KF4sQb1dmTDPMuhh0aW9aPYTMLasZ/kV7dy7ingAhadSfDP6u6GpMC5 3fg1HI7hEgVktFRxP1HYtWpn46IQcQKB2Bn4jL69nb+ON+TrUmWU79kFmeg8nH7Z1bXh dy9A== X-Gm-Message-State: AOJu0YwMXZqG5VxWEIAWPnpET3GlLK3p9CDonaFmyWqFIlXQBmLjI7Db FB/vbFsV4TEghwQ1ATkThPP6EhZH/YeIlrJlvNmk3op6ctFiqpYpKpfEIBliwlfmWc7JCyOkzcD 9MKq6UHg= X-Gm-Gg: ATEYQzzZjXDXsPhRGiYWvUhJwnxgWBkJanN7iwsR5iGArlVdHBvWOp3env4MHCVf8jm svS3htskSFMDUDLGAWfuY/TiI1nVuXdxw0Ix30zGyOwfC7Y3OWLjm4PoLET+3c4eBoT+qFGGXqA ja9qiIRAQWJpSx3g18hzDGocS3rL1WlMo1Ut1xALOphg4o4ko1i/1VKij5pc4j2giVMzdtFa45C S4Y4geYPI/RiJnvSpY/mU6ubNte1YiHqXwnmVw7MYnXtsHACEF70JYpKlT3by/5pW2LmgfTjX9L HCkClKyAKC/2ZLW4hp+nt/aOrjYYaFnL2a3DWc8sdOPMKZv1EA3QWJTIsVQ5/uR1AbTyyB3pWhk Ci+My6ZY29WkTZNGTMABnrf8FlQTmbDaeb/AAwOYzIYVNtkhTx/3Ntj0ZApZuqphVMPexrLpNu2 /pMKvLqBPQC7RGlO4M89ZdyJlum/EBvkBNr3lAUeLto09Um/0jBaigQXlifPflcj2QztK0bn+dZ 0t1 X-Received: by 2002:a05:6a00:10c2:b0:821:807a:e427 with SMTP id d2e1a72fcca58-82a6acbd7f6mr832457b3a.21.1773788281798; Tue, 17 Mar 2026 15:58:01 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Zhenzhong Duan , Yi Liu , Alex Williamson , Eric Auger , philmd@linaro.org, Pierrick Bouvier Subject: [PATCH 2/2] hw/vfio/iommufd.c: report hint to user when vfio-dev/vfio*/dev is missing Date: Tue, 17 Mar 2026 15:57:51 -0700 Message-ID: <20260317225751.1325098-3-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260317225751.1325098-1-pierrick.bouvier@linaro.org> References: <20260317225751.1325098-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773788324273154100 Content-Type: text/plain; charset="utf-8" Give a hint about missing kernel config CONFIG_VFIO_DEVICE_CDEV. Signed-off-by: Pierrick Bouvier Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Yi Liu Reviewed-by: Zhenzhong Duan --- hw/vfio/iommufd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/vfio/iommufd.c b/hw/vfio/iommufd.c index 131612eb836..3e33dfbb356 100644 --- a/hw/vfio/iommufd.c +++ b/hw/vfio/iommufd.c @@ -274,7 +274,10 @@ static int iommufd_cdev_getfd(const char *sysfs_path, = Error **errp) } =20 if (!g_file_get_contents(vfio_dev_path, &contents, &length, NULL)) { - error_setg(errp, "failed to load \"%s\"", vfio_dev_path); + error_setg(errp, + "failed to load \"%s\"" + " (is your kernel config missing CONFIG_VFIO_DEVICE_CDE= V?)", + vfio_dev_path); goto out_close_dir; } =20 --=20 2.47.3