From nobody Mon Apr 6 23:10:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1773770365; cv=none; d=zohomail.com; s=zohoarc; b=JxN/CQLmIlL7xCRwqY/OKwHh4Wi57y6kgsZgEE3OFP1Bby92Ik9/M6KuQBxRISArUu26Nfxh5Oej7dVZ0sD+8dXkh2nck9pXIhDuH0tb/6ydEeTuJGn72QZ2T70qY6CFUxjvlmamMKnX32Yrcy/fJ+JXgv2SQfoANkVufBIYTUY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773770365; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Okui3+LoiEw6Ead0/iU3+dwFPXpVpxuXn0Pb9e4RdJE=; b=O3fVLX1xgm4RRGqhltflkRerUVn677VhXhTnnqrwqxrcA8hi6B42NckmaNiXu1BqOfJ15jHFmgudVvy3FcZLeglkDX6T5ZVlDLDUVPD7YrTJk4W9WIWi7pw27pQEBm+CFHVUgkO7yGMLS6zZdxTewucis8NYwyQ/9rtCi48Fr4k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773770365745123.32554123251896; Tue, 17 Mar 2026 10:59:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2YgQ-0004Xx-Dx; Tue, 17 Mar 2026 13:58:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2Yg4-0004W1-Sq for qemu-devel@nongnu.org; Tue, 17 Mar 2026 13:58:08 -0400 Received: from mail-dy1-x132f.google.com ([2607:f8b0:4864:20::132f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2Yg1-0000iu-Fx for qemu-devel@nongnu.org; Tue, 17 Mar 2026 13:57:59 -0400 Received: by mail-dy1-x132f.google.com with SMTP id 5a478bee46e88-2c0bdf1988cso4582515eec.1 for ; Tue, 17 Mar 2026 10:57:57 -0700 (PDT) Received: from localhost.localdomain ([143.54.78.51]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e55a2be4sm237884eec.22.2026.03.17.10.57.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 17 Mar 2026 10:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773770276; x=1774375076; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Okui3+LoiEw6Ead0/iU3+dwFPXpVpxuXn0Pb9e4RdJE=; b=bVp+36gg9J82r3DIc8E3e+ce4fTiXUXIKxGSn04SuRrw42eRiMNnEDfamRNei2f07k fekZRVEjK49sFJMOGzmVdZmJNxrYymQwi5ddZAf6cu5l0KpB60pFavgSTMcHEMSPmGNQ KvR0g5nvGen00//SmsU3aFRirWvzjQyXR4KaLFSPNAD7MLYxNv8nybt3yeWRl7ps9MKk Z40QSu3qe3/kZKizu9JhS/ru4RF+3DLBPLeakBXwBZglIHRtVsFDV/bRbfjq14mfCAJX mXqwUn1lZqvRDtXS11MqYiGc3T3e8PdpGqxCVGESir31HDwk+bJNKHQTWIlwXQieivZc bEXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773770276; x=1774375076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Okui3+LoiEw6Ead0/iU3+dwFPXpVpxuXn0Pb9e4RdJE=; b=cgrMHfvJxPLvw1qtkiUnmZ/RRZClmVbdUb3PGRJgKCSxg6hop89iTlrCVPHwzRkLXi Bxo05mgmAB/l8I/vvsBdlLAAL8vNJungTplVrZ4vIwldvhGPgK2wcRUBR9bvoAtskIQD 2umqQZhxTf6+K3VmlhD/3jjZ/0t0if1IWDHD4++OYVfjuFNhO3NSDw3tUMMT1++UAxzw p2ow+v3/s5q3+ogqUH9zzkwq18Mk9dWB4BO9ra7+ulIM8rvqlBIiGR/EzI04wHXI4jzp 9+sJ4Bj4yQdcxMI2A3XeduKNqnfB7OPgitkfk32Vkpl3rIe66+SvQgc0kkC/ywChF0Xz Vgow== X-Gm-Message-State: AOJu0YzoDNAz18rCRaWTXthdrQZboE9b5app7zekgbtFc/5LTWty/nve Oi4Y26cMjXV/jAhQ3Xr/RJBOOyvP4IM1DMhAmt2RNB9uSbjRE7nUnF4qtcpvuFkH X-Gm-Gg: ATEYQzwWuWHwY0XTV6bPnnnjgBo5jwS/5gd7yg+tEgHfzsA36vbqJXfgmprnyfwu4Aa UNs4MwrkUAHRwAMOloKFKDc82Sg+i8HBZiyQY22mSU3tFs3PP5I/sPtUt6twDA4SuEkx918oXbQ yEeqY6dLbXd48KsQz1/jhE75vbP6g4jKeElKrHe/GSgtmGD0HDBKxRmU715g0hnw8lTeC2E7EwY CQRZr+kV5ohiqMfD76fQ+UKNq9GlF7sFPTE82WqZc7zNu5EPm+uiZngUU+nEc8QlgXfcqCD/gxY OdH7PPh0sbE8fOoDU/iaE3q93YfgK6d9w852pIwEXABUSsfVJoJAlSO1YQUu2afvZfgu0Un/HS8 JDQueN14WWvkyNYgNBxMLn/QkLkoXLyP5ZSA3NaCqIu+CpUfYYp2vMjvag1fb4lmBwKI54KXg5u 6kVcCWcDweZkV78s8nd24xBOaB7Clr0/rV5a/z2fAYGPEn9QsJrhSh X-Received: by 2002:a05:7300:7491:b0:2be:c4a:d31b with SMTP id 5a478bee46e88-2c0e50a919dmr148331eec.18.1773770275514; Tue, 17 Mar 2026 10:57:55 -0700 (PDT) From: Lucas Amaral To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, agraf@csgraf.de, peter.maydell@linaro.org, mohamed@unpredictable.fr, Lucas Amaral Subject: [PATCH v4 1/3] virtio-gpu: validate host page alignment for MAP_FIXED blobs Date: Tue, 17 Mar 2026 14:57:42 -0300 Message-ID: <20260317175744.32469-2-lucaaamaral@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260317175744.32469-1-lucaaamaral@gmail.com> References: <20260317175744.32469-1-lucaaamaral@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::132f; envelope-from=lucaaamaral@gmail.com; helo=mail-dy1-x132f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1773770366881158500 Content-Type: text/plain; charset="utf-8" Commit 4eb0aace ("virtio-gpu: Support mapping hostmem blobs with map_fixed") uses mmap(MAP_FIXED) to map blob resources into a pre-allocated hostmem region. Both the offset and size passed to mmap must be aligned to the host page size, but the code does not validate this. On hosts where qemu_real_host_page_size() exceeds the guest's page size (e.g. ARM64 with 16KB or 64KB pages, macOS ARM64), the guest may provide blob offsets aligned to its own page size (4KB) but not to the host's. This causes mmap(MAP_FIXED) to fail with EINVAL, and the subsequent unmap (which also uses mmap MAP_FIXED) fails the same way, producing: virtio_gpu_virgl_unmap_resource_blob: failed to unmap(fixed) virgl resource: Invalid argument Add an alignment check before attempting MAP_FIXED. When the offset or blob size is not host-page-aligned, skip the MAP_FIXED path and fall through to the existing subregion method, which handles any alignment. Fixes: 4eb0aace ("virtio-gpu: Support mapping hostmem blobs with map_fixed") Signed-off-by: Lucas Amaral --- hw/display/virtio-gpu-virgl.c | 45 +++++++++++++++++++++-------------- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index b7a2d160..f6583b48 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -185,25 +185,34 @@ virtio_gpu_virgl_map_resource_blob(VirtIOGPU *g, return -EBUSY; } =20 - ret =3D virgl_renderer_resource_map_fixed(res->base.resource_id, - gl->hostmem_mmap + offset); - switch (ret) { - case 0: - res->map_fixed =3D gl->hostmem_mmap + offset; - return 0; - - case -EOPNOTSUPP: - /* - * MAP_FIXED is unsupported by this resource. - * Mapping falls back to a blob subregion method in that case. - */ - break; + /* + * MAP_FIXED requires host-page-aligned offset and size. Hosts with + * page sizes larger than the guest's (e.g. 16KB on ARM64) may receive + * non-aligned blob offsets. Fall through to the subregion method when + * alignment requirements are not met. + */ + if (QEMU_IS_ALIGNED(offset, qemu_real_host_page_size()) && + QEMU_IS_ALIGNED(res->base.blob_size, qemu_real_host_page_size())) { + ret =3D virgl_renderer_resource_map_fixed(res->base.resource_id, + gl->hostmem_mmap + offset); + switch (ret) { + case 0: + res->map_fixed =3D gl->hostmem_mmap + offset; + return 0; + + case -EOPNOTSUPP: + /* + * MAP_FIXED is unsupported by this resource. + * Mapping falls back to a blob subregion method in that case. + */ + break; =20 - default: - qemu_log_mask(LOG_GUEST_ERROR, - "%s: failed to map(fixed) virgl resource: %s\n", - __func__, strerror(-ret)); - return ret; + default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: failed to map(fixed) virgl resource: %s\n", + __func__, strerror(-ret)); + return ret; + } } #endif =20 --=20 2.52.0