From nobody Mon Apr 6 23:47:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773768089; cv=none; d=zohomail.com; s=zohoarc; b=Aw0YAWB/NIkkAtEmIi3Amc+1HVoIquXRzQUiJnbEWL4mKEDHFmY+XU061oJloLWQCdv0jXbmQKmort1jUjq8o05mRzxlRWQ0Npl+mhx9rk4tFpkni4X4etZBvokzlpSYERtKf6ArRyzv0ODndinu53p5SEEs+XoHNBQTAdRMjhk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773768089; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KtJP/jguIFKde9rRUJ0UbrChrFZ64Us15Ltb92pQXtM=; b=f9tM+HjN3xQlUvnVxmCPSvxivblZBopz2st6Q19LGbsqiOXok+H+bqF8NEGSS703dz7jgMseTK1T/g87RRsUPCwD9xfRs8Y0wKFgkHclD10k/fHlUMPpeKBRUPjrMxLm21X1AnsfNnj8QKD7pO8I26FuIoNDODjWr5SENKS91/g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773768089577966.9119067866394; Tue, 17 Mar 2026 10:21:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2Y5n-0002D7-2m; Tue, 17 Mar 2026 13:20:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2Y5a-00026l-Tx for qemu-devel@nongnu.org; Tue, 17 Mar 2026 13:20:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2Y5Y-0005Zy-TC for qemu-devel@nongnu.org; Tue, 17 Mar 2026 13:20:18 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-c0E0R4mfOt6dkVMVAhA66Q-1; Tue, 17 Mar 2026 13:20:12 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3842F18002CD; Tue, 17 Mar 2026 17:20:11 +0000 (UTC) Received: from localhost (unknown [10.44.22.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 77162180075D; Tue, 17 Mar 2026 17:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773768016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KtJP/jguIFKde9rRUJ0UbrChrFZ64Us15Ltb92pQXtM=; b=YIBKG6XOaF3jTfMRSTcssw6TqDowkehqYdgQDxZ/ceeUbfzEta5+OPh/YWSu7zept0PjRt Vw5+lGWvQhkYWFWhAieqxGkH20IXQZgWRQbDdd3VNBEtBPYjIJNmZJOGpdZEAqLlFhji+g jy9b5WEI8GtUvPbR5Dil6RTi9P1WkHk= X-MC-Unique: c0E0R4mfOt6dkVMVAhA66Q-1 X-Mimecast-MFC-AGG-ID: c0E0R4mfOt6dkVMVAhA66Q_1773768011 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Dmitry Osipenko , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Christian Schoenebeck , Ani Sinha , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Zhao Liu , Marcel Apfelbaum , Yanan Wang , Akihiko Odaki Subject: [PULL 07/16] ui/dbus-listener: remove dbus_filter on connection close Date: Tue, 17 Mar 2026 21:19:07 +0400 Message-ID: <20260317171916.438575-8-marcandre.lureau@redhat.com> In-Reply-To: <20260317171916.438575-1-marcandre.lureau@redhat.com> References: <20260317171916.438575-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773768091014158500 From: Marc-Andr=C3=A9 Lureau The dbus filter holds a strong reference to the DBusDisplayListener (via GDestroyNotify) to ensure the listener remains alive while the filter may still be running in another thread. This creates a reference cycle (ddl -> conn -> filter -> ddl) that prevents the listener from being freed. Break the cycle by connecting to the connection's "closed" signal and removing the filter when the connection closes. Fixes: commit fa88b85dea96 ("ui/dbus: filter out pending messages when scan= out") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/dbus-listener.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index fff7cf83274..37945236e11 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@ -1181,6 +1181,20 @@ static void dbus_display_listener_setup_scanout_dmab= uf_v2(DBusDisplayListener *d #endif } =20 +static void +dbus_conn_closed(GDBusConnection *conn, + gboolean remote_peer_vanished, + GError *error, + gpointer user_data) +{ + DBusDisplayListener *ddl =3D DBUS_DISPLAY_LISTENER(user_data); + + if (ddl->dbus_filter) { + g_dbus_connection_remove_filter(ddl->conn, ddl->dbus_filter); + ddl->dbus_filter =3D 0; + } +} + static GDBusMessage * dbus_filter(GDBusConnection *connection, GDBusMessage *message, @@ -1262,6 +1276,7 @@ dbus_display_listener_new(const char *bus_name, } =20 ddl->dbus_filter =3D g_dbus_connection_add_filter(conn, dbus_filter, g= _object_ref(ddl), g_object_unref); + g_signal_connect(conn, "closed", G_CALLBACK(dbus_conn_closed), ddl); ddl->bus_name =3D g_strdup(bus_name); ddl->conn =3D conn; ddl->console =3D console; --=20 2.53.0