From nobody Tue Apr 7 00:01:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773768039; cv=none; d=zohomail.com; s=zohoarc; b=gVl0jpvM6WBPgaaE+IbHiJkLfybJ76L5KElw6mxwgJ0TvfzE9QWie0Y3iDU+lOvoikPN8z8oacAiAO0B0z63ZsSnTJFiJAlNXrwDFE3c5m/0L5erFXfiiIF47KZdjkkbjRH36TVW67FhbW24khk6cCECTI3WXeHa1x87GCGANEo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773768039; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=t8u602C9Q/wNZVt3luVyi3m3X/+imtMU6KMp7n4fBEI=; b=loorIXsbsOP/179yZvGEypIcUJG+P/CLEIGgxqj/sqx2WXMYGsUajZWK+Ib9ugxAQydsKT3bIdJxJCUXMZCb9U4i8xISAeNT4Q1kdfqln5ILEYbA8u7xSU4hPWyqAxBUpyreiFxrE8u3694GQyG5aIk1DU+Rgs1kIZqNH95Q/ZU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773768039865315.6266190307333; Tue, 17 Mar 2026 10:20:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2Y5i-00026z-GI; Tue, 17 Mar 2026 13:20:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2Y5Y-00026X-Pb for qemu-devel@nongnu.org; Tue, 17 Mar 2026 13:20:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2Y5T-0005OX-4Q for qemu-devel@nongnu.org; Tue, 17 Mar 2026 13:20:12 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-EaFiaUvRMEik3He9zj8DYg-1; Tue, 17 Mar 2026 13:20:06 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E4582195608E; Tue, 17 Mar 2026 17:20:04 +0000 (UTC) Received: from localhost (unknown [10.44.22.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 16DC11955F19; Tue, 17 Mar 2026 17:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773768010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t8u602C9Q/wNZVt3luVyi3m3X/+imtMU6KMp7n4fBEI=; b=I5+roBM+8Iy6Izau8uToMh8BMxLf9ZOpnBxPBv3fKltIix/BmHf/dexb5m3M3FP8yd1mqS 9TdKW+VYMHejKGGDfd7eMMknxj9BF3VGVmis1il7esLfr4UPe2HEs25IR8kQoO2KmqoNNM fi3wikhh2J3BTAxgwZdwqrkdfcYm9KY= X-MC-Unique: EaFiaUvRMEik3He9zj8DYg-1 X-Mimecast-MFC-AGG-ID: EaFiaUvRMEik3He9zj8DYg_1773768005 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Dmitry Osipenko , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Christian Schoenebeck , Ani Sinha , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Zhao Liu , Marcel Apfelbaum , Yanan Wang , Akihiko Odaki Subject: [PULL 06/16] ui/dbus-listener: Fix FBO leak in dbus_cursor_dmabuf Date: Tue, 17 Mar 2026 21:19:06 +0400 Message-ID: <20260317171916.438575-7-marcandre.lureau@redhat.com> In-Reply-To: <20260317171916.438575-1-marcandre.lureau@redhat.com> References: <20260317171916.438575-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773768042068154100 From: Marc-Andr=C3=A9 Lureau cursor_fb is a local egl_fb that gets an FBO allocated via egl_fb_setup_for_tex but is never destroyed, leaking the framebuffer object on every cursor update. Add egl_fb_destroy() after the cursor data has been read. Fixes: commit 142ca628a7 ("ui: add a D-Bus display backend") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/dbus-listener.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 3e2b4adf41f..fff7cf83274 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@ -660,6 +660,7 @@ static void dbus_cursor_dmabuf(DisplayChangeListener *d= cl, egl_fb_setup_for_tex(&cursor_fb, width, height, texture, false); ds =3D qemu_create_displaysurface(width, height); egl_fb_read(ds, &cursor_fb); + egl_fb_destroy(&cursor_fb); =20 v_data =3D g_variant_new_from_data( G_VARIANT_TYPE("ay"), --=20 2.53.0