From nobody Mon Apr 6 23:16:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.dev ARC-Seal: i=1; a=rsa-sha256; t=1773750401; cv=none; d=zohomail.com; s=zohoarc; b=Xd9hcNEVAkWU3KCPJ1IUzhRQEz0t72HI3dn3LlzgagZIB27wPvapLbB7UcNVYrrNQWXlk7UKW+xB7pmyqPr0+c47PPAZ3qsay8fYbgIRZtKBIBPWXE4xhkszasGd6SnxK3gIgKVQYgO2uBekEg9nvcX0zXwDyE1h3CiLRlr0d5A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773750401; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qpEVBLVJvLEzYxRBXuSyl2gSz2UWFsNCTMhIh9Gzv8I=; b=InffZKX5tKEsYsNHJBNmdKOBRM2E9z6RJ7yFAteCN1PSHtAYIe2y8uA74foC+FkmxXYFmvIATx4lgHhY6RxeeG0sGXet0N/Fs0+tEYtWqiGZ9Q6caKMOYoG13YuiauaXSb33oQHw1nK2BHFSPSD5qIhPuUYHv6UkzYUpnGRnDYg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773750400731777.1841313864176; Tue, 17 Mar 2026 05:26:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2TUd-0000Sp-EC; Tue, 17 Mar 2026 08:25:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2TUX-0000SR-RS for qemu-devel@nongnu.org; Tue, 17 Mar 2026 08:25:47 -0400 Received: from out-178.mta1.migadu.com ([95.215.58.178]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2TUU-0000Dx-Ay for qemu-devel@nongnu.org; Tue, 17 Mar 2026 08:25:45 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1773750336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=qpEVBLVJvLEzYxRBXuSyl2gSz2UWFsNCTMhIh9Gzv8I=; b=N3ukACLjEl4DU7LtcHu026SQVwzmcImLqikwDnmoMjS3cpkPyIOaTl988iHV82p2RXhPGk tkwMDY1lEdFApMA7EvnVDnbkqYLOItq8DsVLGlIJJiKwvb9IWUKSahfB9OeFpSuGmocTtI l4Pc1soVjlE7UrNfBuQD4S3f7Zz17Zk= From: Zenghui Yu To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, richard.henderson@linaro.org, Zenghui Yu Subject: [PATCH] target/arm: Don't skip access flag fault for AccessType_AT Date: Tue, 17 Mar 2026 20:25:17 +0800 Message-ID: <20260317122517.47627-1-zenghui.yu@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=95.215.58.178; envelope-from=zenghui.yu@linux.dev; helo=out-178.mta1.migadu.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.dev) X-ZM-MESSAGEID: 1773750402664158500 Content-Type: text/plain; charset="utf-8" As per the pseudo code from DDI0487 M.a.a (on J1-16021) AArch64.S1Walk(): // Check descriptor AF bit elsif (descriptor<10> =3D=3D '0' && walkparams.ha =3D=3D '0' && (!accdesc.acctype IN {AccessType_DC, AccessType_IC} || boolean IMPLEMENTATION_DEFINED "Generate access flag fault on IC= /DC operations")) then fault.statuscode =3D Fault_AccessFlag; an access flag fault should be generated for AccessType_AT, if the AF bit is 0 and !param.ha. Fixes: efebeec13d07 ("target/arm: Skip AF and DB updates for AccessType_AT") Signed-off-by: Zenghui Yu --- target/arm/ptw.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 8b8dc09e72..572048d560 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -2118,6 +2118,12 @@ static bool get_phys_addr_lpae(CPUARMState *env, S1T= ranslate *ptw, descaddr &=3D ~(hwaddr)(page_size - 1); descaddr |=3D (address & (page_size - 1)); =20 + /* Check descriptor AF bit */ + if (!(descriptor & (1 << 10)) && !param.ha) { + fi->type =3D ARMFault_AccessFlag; + goto do_fault; + } + /* * For AccessType_AT, DB is not updated (AArch64.SetDirtyFlag), * and it is IMPLEMENTATION DEFINED whether AF is updated @@ -2127,15 +2133,9 @@ static bool get_phys_addr_lpae(CPUARMState *env, S1T= ranslate *ptw, /* * Access flag. * If HA is enabled, prepare to update the descriptor below. - * Otherwise, pass the access fault on to software. */ - if (!(descriptor & (1 << 10))) { - if (param.ha) { - new_descriptor |=3D 1 << 10; /* AF */ - } else { - fi->type =3D ARMFault_AccessFlag; - goto do_fault; - } + if (!(descriptor & (1 << 10)) && param.ha) { + new_descriptor |=3D 1 << 10; /* AF */ } =20 /* --=20 2.53.0