From nobody Mon Apr 6 23:29:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773745937; cv=none; d=zohomail.com; s=zohoarc; b=kSCEbtktMD2PL+37TSJCLPMcbPsXHQ7hZg18ejsZWsMMS2j0ZGpnXUBE3da/SW4JjbuUsX6pGxSzzQU8Ywt43rBn4uXWgE3i1FMWS5wsruAQlb4Yi9r0Dik41fm4VaWrkPW3v+BQFsk7ZX16mwM7HLh2/SkJIj7oae6CXqDk0Yc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773745937; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GZF9kn1GifXuriiiuFYGF1LFBi6if1Y7iHvqUJJdTkM=; b=U5K9HrkjTWkG2qhhYnwQ9CC6HKbz+UYGMUG7KUxZk4IXuBnLSx7vx90Sp12Y7AR2pyDMG2wlZkTibaCrP4Yj49frFmVdV3LxgDuKisJqyoIj8Rq+EVWDH2ApxI6WYmwkmDFhc7M+yfqdHkloSjvHo1bQVQxGHV1B2HKG0rVH7+M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773745936991726.9286728236088; Tue, 17 Mar 2026 04:12:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2SKg-0006pe-Mr; Tue, 17 Mar 2026 07:11:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2SKe-0006p0-IH for qemu-devel@nongnu.org; Tue, 17 Mar 2026 07:11:28 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2SKc-00012b-PN for qemu-devel@nongnu.org; Tue, 17 Mar 2026 07:11:28 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso64703555e9.0 for ; Tue, 17 Mar 2026 04:11:25 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48557c7c514sm116579885e9.32.2026.03.17.04.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 04:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773745883; x=1774350683; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GZF9kn1GifXuriiiuFYGF1LFBi6if1Y7iHvqUJJdTkM=; b=pUzAeKrbWP/KXa8rMO4k36n/VrlGfBBBXhA6unSGWH8hegF/oJFyAM8H2bS1Xlolks JmAwWFE8g+xEdJ1jRaCrKV246jLEL/zmkjIrQ0dayeXPl92H+UEVJ3gkvx5NSVh2wsLU 9qUvsQdQsoK2zvXheXdv6oXYy11ojO83KVEalY5bPkauC4pfDJjCoKJdauF5guUswNZm 0VZt1oG1pRE+52U/ZBMPyxn31sEn0IqxdNxuNwukkBwLJHdaiRQIDT5Ki/l8MvAl0zWB lOa6kvaF3jAoe5MdS2q5LiweDzdWVT281nnkAVfdXCPhnFbbYEfK3CKh85N73cpOqe0t cAdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773745883; x=1774350683; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GZF9kn1GifXuriiiuFYGF1LFBi6if1Y7iHvqUJJdTkM=; b=gwyoxja8eJ+B1VvDN6SqM7BnoSvSMIORn6rF32/eAFR2+u5U0ghosaZm0p+f5Y5AYO bSgfzpFll3C8b9qVI1LOSk68mRafO/K1MC+AMo8W3LMnM+NHpmCNTfGtDunGRzsdF4Ba cgwRpiWuRrziTe/mjmFRpR0Q6QB3DxQgS2dI/hPAlOr8fBBVkmkHJV4bi5LIHH41gH46 Kn1FSZSmAKfGnb7VF2Y0S+9ZofO284hhegPPH8A7MiTEHTwjbS2VLttRk/Rap5is1wyB QbYfcgX0zM4Doy6nyw5DJsTWI662aHOzqJN1GYVczKHbbm50bK0ym5oS4gNzpL+ysPth Wyvg== X-Forwarded-Encrypted: i=1; AJvYcCWAAIPWItcEof7D3AJowym5c8oICTxmHe3z6icdwdcDfr8f/KYsM/gELCjgU4vmW5pLaVe30uIKfo9U@nongnu.org X-Gm-Message-State: AOJu0YwYQUlj/05BE4HDYqJrffqY0+FsYHC8BM6koK18m/VfbKA14BzN pfjRO94N7CvBYupwzT0ijI9UfE3bi7sRc/POhbohvwg0avZI5FRinv2PCInj4g4vBvE= X-Gm-Gg: ATEYQzw5eGyXqv0vMjLel5pT8aCuIcYpczKgJ0LAsKoToZCut3t+mDlDSoK+mlpZMR+ 65zlr/Ty8pjbCjftoNLMjtsc17RNBVMXRQeC/glCk49+nJe4VbZ9X4NqqZY+b+kuRnWHQ0e55s6 quNArXpZt3ahOta9ZbZPNlf7ZXNmmFIaPLzoGWOpVZbB2B8goUFYPheupVe6FKW3agpo72oO9Gt on9f61L8M0ezNDppXkzVw/9/NARPZNIsgSZUpSSjedThGQkopZYnbtXOP1yyBt7E4cGZSjP+WIV 0FohxzmAS8Uub7nIk5XxxG48YCIRe0AcBDB2pjY1ar+cw5Psq/nRmPkFwGNlZuc9Vua3vsxJc+5 bDaPBu+SDPOT2o1IZq0riro9BP8363BkNadnppu0Py8iX5qJkPOQT3lvFzYinCly5PdIvJDxfNA F9eEEmIZI5ELxvHeVkGy+On4QteleNjjHG0XXo4N4Qoy/GCTvFtI+t3tW/cyxeCzfzcV9uPTKf/ KrzR/VBNth/i8cSWRgEhrS2yMwtQmQ= X-Received: by 2002:a05:600c:a46:b0:485:358b:e80c with SMTP id 5b1f17b1804b1-4855649971bmr295742285e9.0.1773745883097; Tue, 17 Mar 2026 04:11:23 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] tests/qtest/arm-cpu-features: Fix thinko in g_strdup_printf() call Date: Tue, 17 Mar 2026 11:11:21 +0000 Message-ID: <20260317111121.2062455-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773745938756158500 Content-Type: text/plain; charset="utf-8" In commit 62272f9f8891 we changed some uses of fixed char arrays to call g_strdup_printf() instead. In one place I made a silly error where in changing sprintf(name, "fmt string", ...) to name =3D g_strdup_printf("fmt string", ...) I forgot to delete "name" from the argument list. Luckily Coverity spotted this (as CID 1645771) because at this point "name" is NULL and passing g_strdup_printf() a NULL first argument is not valid. We didn't notice the mistake in testing or CI because this bit of code is only run if on an AArch64 host with KVM and SVE available. Correct the error by removing the stray function argument. Fixes: 62272f9f8891 ("tests/qtest/arm-cpu-features: Use g_strdup_printf() i= nstead of char arrays") Signed-off-by: Peter Maydell Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/arm-cpu-features.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c index 5444e4d40b..bbdd89a81d 100644 --- a/tests/qtest/arm-cpu-features.c +++ b/tests/qtest/arm-cpu-features.c @@ -612,7 +612,7 @@ static void test_query_cpu_model_expansion_kvm(const vo= id *data) * we need at least one vector length enabled. */ vq =3D __builtin_ffsll(vls); - name =3D g_strdup_printf(name, "sve%u", vq * 128); + name =3D g_strdup_printf("sve%u", vq * 128); error =3D g_strdup_printf("cannot disable %s", name); assert_error(qts, "host", error, "{ %s: false }", name); g_free(error); --=20 2.43.0