From nobody Tue Apr 7 01:02:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773737184; cv=none; d=zohomail.com; s=zohoarc; b=baaWWCSeg3rZQ+Q7dkJ9tKs46d5r09nhHwuFzf0CZ96TxzAcdNaCzqZ6SgJDnwWFVxdIFdPU00Rt7J93dlBDSlVPt+lK7oUpltVT+kyAHaQqu/7Zz+yuXewEIONh4/slHRaKGn4fTK5MMxwJp6Wjs8nQfSx9kwfWnkuMedCwG54= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773737184; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dEq4X9T6yCRaKmIFJPq0DhelAUM9JLiKworzCLmRo54=; b=RgEbjkTW02oSAGdAm6JMF9VCVAe933RJtUgr+D4QmCMVCuJKvDKY4G4Hzw5kFngBqA5N/7R8H0MhnbCzRS+EmuTt5/30l3DtkCF4uwrM69/uvr9nXUdKHBvhoTUTbR9GFcARNAvNHm+WQ77Nzcv7CZr3E7vsUMjhTyWMGD62x5g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773737184276373.3560121489546; Tue, 17 Mar 2026 01:46:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2Q3N-0003u2-9Q; Tue, 17 Mar 2026 04:45:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2Q3I-0003tO-5Z for qemu-devel@nongnu.org; Tue, 17 Mar 2026 04:45:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2Q3F-0006vd-Mt for qemu-devel@nongnu.org; Tue, 17 Mar 2026 04:45:23 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-mPKiyZb9O66XwYf7g77PbQ-1; Tue, 17 Mar 2026 04:45:16 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E98831800620; Tue, 17 Mar 2026 08:45:14 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.32.37]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E1D941955E84; Tue, 17 Mar 2026 08:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773737120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=dEq4X9T6yCRaKmIFJPq0DhelAUM9JLiKworzCLmRo54=; b=HYjTfLWbjGQOeKgWqoVhdXwPpDptUDZ0ginpxnEZ9fV1T6bWU4+ZpEN1fsw54ldLaKtIhx P8+VRBDzas1vPjllqrLe02tVMv9Zkfhwp3aC64LYBsxUqlhWAVQqxRbY0uueIO3oHr38AU ypekDVmgvtHBp4wSr7nSA59DeaGmGGE= X-MC-Unique: mPKiyZb9O66XwYf7g77PbQ-1 X-Mimecast-MFC-AGG-ID: mPKiyZb9O66XwYf7g77PbQ_1773737115 From: Thomas Huth To: Mark Cave-Ayland , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, BALATON Zoltan , Markus Armbruster , Artyom Tarasenko Subject: [PATCH] hw/sparc/sun4m_iommu: Fix crash when introspecting sun4m-iommu from the CLI Date: Tue, 17 Mar 2026 09:44:50 +0100 Message-ID: <20260317084450.442071-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773737187283154100 Content-Type: text/plain; charset="utf-8" From: Thomas Huth QEMU currently crashes when introspecting the sun4m-iommu device from the command line interface: $ ./qemu-system-sparc -display none -device sun4m-iommu,help qemu-system-sparc: ../../devel/qemu/system/physmem.c:1401: register_multipage: Assertion `num_pages' failed. Aborted (core dumped) There does not seem to be a compelling reason for initializing the memory regions from the instance_init function, so let's simply move the code into a realize() function instead to fix this issue. Signed-off-by: Thomas Huth Reported-by: Markus Armbruster Tested-by: Markus Armbruster --- hw/sparc/sun4m_iommu.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/sparc/sun4m_iommu.c b/hw/sparc/sun4m_iommu.c index ab5eb67072a..1534445992b 100644 --- a/hw/sparc/sun4m_iommu.c +++ b/hw/sparc/sun4m_iommu.c @@ -351,13 +351,14 @@ static void iommu_reset(DeviceState *d) s->regs[IOMMU_MASK_ID] =3D IOMMU_TS_MASK; } =20 -static void iommu_init(Object *obj) +static void iommu_realize(DeviceState *ds, Error **errp) { - IOMMUState *s =3D SUN4M_IOMMU(obj); - SysBusDevice *dev =3D SYS_BUS_DEVICE(obj); + IOMMUState *s =3D SUN4M_IOMMU(ds); + SysBusDevice *dev =3D SYS_BUS_DEVICE(ds); + Object *obj =3D OBJECT(ds); =20 memory_region_init_iommu(&s->iommu, sizeof(s->iommu), - TYPE_SUN4M_IOMMU_MEMORY_REGION, OBJECT(dev), + TYPE_SUN4M_IOMMU_MEMORY_REGION, obj, "iommu-sun4m", UINT64_MAX); address_space_init(&s->iommu_as, MEMORY_REGION(&s->iommu), "iommu-as"); =20 @@ -377,6 +378,7 @@ static void iommu_class_init(ObjectClass *klass, const = void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 device_class_set_legacy_reset(dc, iommu_reset); + dc->realize =3D iommu_realize; dc->vmsd =3D &vmstate_iommu; device_class_set_props(dc, iommu_properties); } @@ -385,7 +387,6 @@ static const TypeInfo iommu_info =3D { .name =3D TYPE_SUN4M_IOMMU, .parent =3D TYPE_SYS_BUS_DEVICE, .instance_size =3D sizeof(IOMMUState), - .instance_init =3D iommu_init, .class_init =3D iommu_class_init, }; =20 --=20 2.53.0