From nobody Tue Apr 7 06:15:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1773645095; cv=none; d=zohomail.com; s=zohoarc; b=liniuT0dqfQTO//20RX10cVyTCOCIJQ9S2NZMrRk2nSCC5/hEv4c6BkvuiGzpjifToT+Vmv6X2h6Wf0rwCPsk8jTrCjbOFZxYH7BbAtGhrQzIAzQg305dW1Qh5O4ObF6iLbvB/YirgBWnJ33TSeVWNFkYW1MJjbAIFUoGrG6E6Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773645095; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=y/myh9ANRvyOT+0hU3pgdvC+7ks9adxwfaZ8oi9VqAw=; b=kB1dJq8bdTGM4qcXVNgqANJfYzw0u20PrbGDotk1uOWclgQ1pqsYFLj/8/Esc4aHzS7ZWegoKIWai9S/DE1FGm5kc7MLHPoFps20LS8dm8WDLU2YWNN4I2fjANu9/Z3G5X9nRYODU2cZkIRNXeTr2g/mQRL+P0JoiZ7h0ROeLmQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773645094024400.59461110417396; Mon, 16 Mar 2026 00:11:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w226V-0007zL-Mk; Mon, 16 Mar 2026 03:11:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w225n-0007VY-LD; Mon, 16 Mar 2026 03:10:27 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w225m-0007lZ-2C; Mon, 16 Mar 2026 03:10:23 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id BE14B193C27; Mon, 16 Mar 2026 10:10:02 +0300 (MSK) Received: from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146]) by tsrv.corpit.ru (Postfix) with ESMTP id BC4F738004F; Mon, 16 Mar 2026 10:10:05 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1773645002; bh=jVK/qfgVEH5cnnXZl16F3o/kjCyYnwZdxeWXTPL7H1c=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aGUrQMbJTZhpJ6dqM33ZKVb43Tx9HJ3YgZLySPYWiC++2avDEMEX2QerC3RxALOHg GtT1giz/dsMYhBsMH71F0z97XePlpyKyNr2N73UqQ5Xf+sggIa4ll25ECQf9N0StAh dS5xutmVfTubKMYDZUNqlRajaZoWLwnCaFd6nzI24q4q/9P82hF1lNmmLHorlv2V/I OMW1+IubOGsmuukY/UrHS8WTBh1WXkM77s1R07tOQRBsk7K0Ka7hF2P/jgj6KpsnNB zTX2J/A33+CzyA/D3oG9b26ktkAIpHhm+e+W21uNo5l/3JKIsBn+3LPU4aCcbPZsMl DfkPDjhmLYilw== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Sergei Heifetz , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 05/14] hw/usb/core.c: reorder usage and assertion of p->ep Date: Mon, 16 Mar 2026 10:09:53 +0300 Message-ID: <20260316071005.91624-6-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260316071005.91624-1-mjt@tls.msk.ru> References: <20260316071005.91624-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1773645098977154100 Content-Type: text/plain; charset="utf-8" From: Sergei Heifetz Reorder the code so the assertion of p->ep occurs before it is used in the subsequent lines. Signed-off-by: Sergei Heifetz Reviewed-by: Laurent Vivier Reviewed-by: Peter Xu Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/usb/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/core.c b/hw/usb/core.c index b3f811c513..9572a870cc 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -423,10 +423,10 @@ void usb_handle_packet(USBDevice *dev, USBPacket *p) p->status =3D USB_RET_NODEV; return; } + assert(p->ep); assert(dev =3D=3D p->ep->dev); assert(dev->state =3D=3D USB_STATE_DEFAULT); usb_packet_check_state(p, USB_PACKET_SETUP); - assert(p->ep !=3D NULL); =20 /* Submitting a new packet clears halt */ if (p->ep->halted) { --=20 2.47.3