From nobody Tue Apr 7 09:19:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1773426654; cv=none; d=zohomail.com; s=zohoarc; b=RuayXXLadYRhB1rXrUVjgErOfvJhMxSjkXO7gStpACQEl+cfzk5/J9fs7rjYnwsUWijSQPDIAE4UxTQme6kZ9ii738s/0KzME+sh+2SjNbJtIpWtobgyoYKRfCrqi8tbJE43U50oe4m1qH5Apie0mctxY2T4a0YcXT7n9bMxjoc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773426654; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=X8aYV04d69RttlCMB/HC3lEliNn1OaKMSDKDMroUX6g=; b=K54GbKG7DnXGowsBeZPcDOIFjd5FLgkerhxP7rdJ9mDv5JfJ485hfQMSwElr443x60DxCgGpnzilxio9eRcaP7U4LbwxjeLaB6DdyMW4Osd9BWaeW+wRopNHCe1OAqfCAVkYnsWl7NKpjW56XEtnkk9PY76CT1V6kDw29LcFt2o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773426654726437.7908293298623; Fri, 13 Mar 2026 11:30:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w17HH-0007cH-Sh; Fri, 13 Mar 2026 14:30:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w17Gy-0007bA-VE for qemu-devel@nongnu.org; Fri, 13 Mar 2026 14:30:12 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w17Gu-0005MI-Qt for qemu-devel@nongnu.org; Fri, 13 Mar 2026 14:30:07 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 363594D5C0; Fri, 13 Mar 2026 18:30:03 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 24FA440678; Fri, 13 Mar 2026 18:30:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YMn0NqhXtGn9MwAAD6G6ig (envelope-from ); Fri, 13 Mar 2026 18:30:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773426603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X8aYV04d69RttlCMB/HC3lEliNn1OaKMSDKDMroUX6g=; b=U4S0zcjYhi6iec1a2x/JQSzq2KL4Hluihjm3oh7Pi9vYg7RpK6rAMWmWVoHU+R9N9H2phS eAsqAkI33b0QjSs/h1xhimPC/w74lI/eCPiNWbme9mLcgejihlVaVOUfCcNEwUdbVQ4h3H F5BB6CeIiE/gu6Cff3s0mBxmogpwPag= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773426603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X8aYV04d69RttlCMB/HC3lEliNn1OaKMSDKDMroUX6g=; b=sHrX6LI6etNnZE6DvRmqRsqQu3SKC7HXJsnwpRH02Nb+cWLfzssEfgMMINBsz3yckEP2nE MuuGasxQV14RZIDg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=U4S0zcjY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=sHrX6LI6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773426603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X8aYV04d69RttlCMB/HC3lEliNn1OaKMSDKDMroUX6g=; b=U4S0zcjYhi6iec1a2x/JQSzq2KL4Hluihjm3oh7Pi9vYg7RpK6rAMWmWVoHU+R9N9H2phS eAsqAkI33b0QjSs/h1xhimPC/w74lI/eCPiNWbme9mLcgejihlVaVOUfCcNEwUdbVQ4h3H F5BB6CeIiE/gu6Cff3s0mBxmogpwPag= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773426603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X8aYV04d69RttlCMB/HC3lEliNn1OaKMSDKDMroUX6g=; b=sHrX6LI6etNnZE6DvRmqRsqQu3SKC7HXJsnwpRH02Nb+cWLfzssEfgMMINBsz3yckEP2nE MuuGasxQV14RZIDg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Maydell , Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , "Dr. David Alan Gilbert" Subject: [PATCH v1 1/4] tests/qtest: Don't dup machine name in qtest_cb_for_every_machine callbacks Date: Fri, 13 Mar 2026 15:29:53 -0300 Message-ID: <20260313182957.28432-2-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260313182957.28432-1-farosas@suse.de> References: <20260313182957.28432-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[7]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 363594D5C0 X-Spam-Score: -3.01 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1773426657593158500 Content-Type: text/plain; charset="utf-8" The qtest_get_machines function caches the list of machines in a static variable. Dup'ing the machine->name string only serves to leak that memory when a single test is executed. Signed-off-by: Fabiano Rosas Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/cpu-plug-test.c | 11 +++++------ tests/qtest/qom-test.c | 3 +-- tests/qtest/test-hmp.c | 3 +-- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/tests/qtest/cpu-plug-test.c b/tests/qtest/cpu-plug-test.c index 0aa4ccc5b6..e68f39cf56 100644 --- a/tests/qtest/cpu-plug-test.c +++ b/tests/qtest/cpu-plug-test.c @@ -14,7 +14,7 @@ #include "qobject/qlist.h" =20 struct PlugTestData { - char *machine; + const char *machine; const char *cpu_model; char *device_model; unsigned sockets; @@ -73,7 +73,6 @@ static void test_data_free(gpointer data) { PlugTestData *pc =3D data; =20 - g_free(pc->machine); g_free(pc->device_model); g_free(pc); } @@ -87,7 +86,7 @@ static void add_pc_test_case(const char *mname) return; } data =3D g_new(PlugTestData, 1); - data->machine =3D g_strdup(mname); + data->machine =3D mname; data->cpu_model =3D "Haswell"; /* 1.3+ theoretically */ data->device_model =3D g_strdup_printf("%s-%s-cpu", data->cpu_model, qtest_get_arch()); @@ -114,7 +113,7 @@ static void add_pseries_test_case(const char *mname) return; } data =3D g_new(PlugTestData, 1); - data->machine =3D g_strdup(mname); + data->machine =3D mname; data->cpu_model =3D "power8_v2.0"; data->device_model =3D g_strdup("power8_v2.0-spapr-cpu-core"); data->sockets =3D 2; @@ -140,7 +139,7 @@ static void add_s390x_test_case(const char *mname) } =20 data =3D g_new(PlugTestData, 1); - data->machine =3D g_strdup(mname); + data->machine =3D mname; data->cpu_model =3D "qemu"; data->device_model =3D g_strdup("qemu-s390x-cpu"); data->sockets =3D 1; @@ -162,7 +161,7 @@ static void add_loongarch_test_case(const char *mname) PlugTestData *data; =20 data =3D g_new(PlugTestData, 1); - data->machine =3D g_strdup(mname); + data->machine =3D mname; data->cpu_model =3D "la464"; data->device_model =3D g_strdup("la464-loongarch-cpu"); data->sockets =3D 1; diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index 2da9918e16..6421f2d9d9 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -216,7 +216,6 @@ static void test_machine(gconstpointer data) test_list_get_value(qts); =20 qtest_quit(qts); - g_free((void *)machine); } =20 static void add_machine_test_case(const char *mname) @@ -224,7 +223,7 @@ static void add_machine_test_case(const char *mname) char *path; =20 path =3D g_strdup_printf("qom/%s", mname); - qtest_add_data_func(path, g_strdup(mname), test_machine); + qtest_add_data_func(path, mname, test_machine); g_free(path); } =20 diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c index 1b2e07522f..60f742e83f 100644 --- a/tests/qtest/test-hmp.c +++ b/tests/qtest/test-hmp.c @@ -135,7 +135,6 @@ static void test_machine(gconstpointer data) =20 qtest_quit(qts); g_free(args); - g_free((void *)data); } =20 static void add_machine_test_case(const char *mname) @@ -143,7 +142,7 @@ static void add_machine_test_case(const char *mname) char *path; =20 path =3D g_strdup_printf("hmp/%s", mname); - qtest_add_data_func(path, g_strdup(mname), test_machine); + qtest_add_data_func(path, mname, test_machine); g_free(path); } =20 --=20 2.51.0 From nobody Tue Apr 7 09:19:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1773426657; cv=none; d=zohomail.com; s=zohoarc; b=Omh2RYZoxS8MhYHNkLOBg9Mi2L6OgGg37is+2a0E59ebjDd60XjyJViKSaOL6lt5hPFJMzYcIrCtj87KwVs8AxKUZGPf00/zdiwPbRn40r3bPYCruwBgP2is8iACC0Iq0sJPJllkxQZ3sH1an67WXTGxeT89/xXZvOP1R4deCmY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773426657; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QWMRVf4BgzxBajaVWqXMyyXSDR/mpSxJU2lItS5lr7c=; b=mx7n67tO3CkcLP3pBKrD8qoAys7lWwXMTIjDJm0su6ziRtQ4eJoT1/GUgAjr2rrfyDcksNq3ilcsqlY1inaK2I85sHnFsXjAHv3vCOuLWzAEfF5cPDG5yh4ebXmHCCH7+30R4P68n0894qzzh745GFMJaVGlBcqTunLes/i7wd0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773426657968547.5309837752835; Fri, 13 Mar 2026 11:30:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w17HQ-0007dS-Sq; Fri, 13 Mar 2026 14:30:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w17H3-0007bT-KR for qemu-devel@nongnu.org; Fri, 13 Mar 2026 14:30:14 -0400 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w17H1-0005Ra-CY for qemu-devel@nongnu.org; Fri, 13 Mar 2026 14:30:13 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4B1655C04D; Fri, 13 Mar 2026 18:30:05 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A989F40678; Fri, 13 Mar 2026 18:30:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wBzLG6tXtGn9MwAAD6G6ig (envelope-from ); Fri, 13 Mar 2026 18:30:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773426605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QWMRVf4BgzxBajaVWqXMyyXSDR/mpSxJU2lItS5lr7c=; b=bCtiJpVoR6EatU1rqN2359J3JKTi8VqI3vbapmGH+eYmCzakcYLwtUpNvEycKcw/HAX4ib Y+RGsv8SIvL4BByErzqsrmTDr+btcCiUURMau+a6L7+M9Ba5MYbdf7JvzBNq3kEajeckhE r8HpkcuqY7w7OhWu3EHA+c2mO4L8y7s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773426605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QWMRVf4BgzxBajaVWqXMyyXSDR/mpSxJU2lItS5lr7c=; b=wChpXs8pHQ6fJ2YDBZg9WKm8big6UIai28uE8DyOuKQT2xlm79vanz/mVDiLfNWOKMgqud f8fBJ5K1KrFi/nBA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bCtiJpVo; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wChpXs8p DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773426605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QWMRVf4BgzxBajaVWqXMyyXSDR/mpSxJU2lItS5lr7c=; b=bCtiJpVoR6EatU1rqN2359J3JKTi8VqI3vbapmGH+eYmCzakcYLwtUpNvEycKcw/HAX4ib Y+RGsv8SIvL4BByErzqsrmTDr+btcCiUURMau+a6L7+M9Ba5MYbdf7JvzBNq3kEajeckhE r8HpkcuqY7w7OhWu3EHA+c2mO4L8y7s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773426605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QWMRVf4BgzxBajaVWqXMyyXSDR/mpSxJU2lItS5lr7c=; b=wChpXs8pHQ6fJ2YDBZg9WKm8big6UIai28uE8DyOuKQT2xlm79vanz/mVDiLfNWOKMgqud f8fBJ5K1KrFi/nBA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Maydell , "Dr. David Alan Gilbert" , Laurent Vivier , Paolo Bonzini Subject: [PATCH v1 2/4] tests/qtest/test-hmp: Free machine options Date: Fri, 13 Mar 2026 15:29:54 -0300 Message-ID: <20260313182957.28432-3-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260313182957.28432-1-farosas@suse.de> References: <20260313182957.28432-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Score: -3.01 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 4B1655C04D Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1773426659409158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Fabiano Rosas Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/test-hmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c index 60f742e83f..a523dbb446 100644 --- a/tests/qtest/test-hmp.c +++ b/tests/qtest/test-hmp.c @@ -149,6 +149,7 @@ static void add_machine_test_case(const char *mname) int main(int argc, char **argv) { char *v_env =3D getenv("V"); + g_autofree char *machine_opts =3D g_strdup("none -m 2"); =20 if (v_env && atoi(v_env) >=3D 2) { verbose =3D true; @@ -159,7 +160,7 @@ int main(int argc, char **argv) qtest_cb_for_every_machine(add_machine_test_case, g_test_quick()); =20 /* as none machine has no memory by default, add a test case with memo= ry */ - qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machin= e); + qtest_add_data_func("hmp/none+2MB", machine_opts, test_machine); =20 return g_test_run(); } --=20 2.51.0 From nobody Tue Apr 7 09:19:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1773426707; cv=none; d=zohomail.com; s=zohoarc; b=YSfQl9itmR4mDoIsYFjk2Gjz5dNPEwqEHgXL0LBnJvPGi6Tl2iKtYVSiBARJWEMlt/RJ/QWrm85EY/bug9w/HjRLDyRpqpvXkIuWO0MITNp/6l3KFdVUldOQuhvu2/w8luxU0M1jBimGj5Cb7VZEvE7nvgiqHrwT/DPXr9vTtkA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773426707; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MncAG3t5Y1v2exCQafgl4tCgcp9DxaNWVxRhlbJmQpw=; b=brsoTWhiZ8nUcr8mgI0zlnRI6KhdLt4ndtav5wK13aN/lmyzms3i3EqK8KiklZ1dlB4VBryIq6e1Og1cWPVy3NH52tfrjHtUWOKR/o7zwm7XIxO6b6IUzyWkvXUX3KhM4C1eexfkqYDJLxZa4mmyD6xiKN94MyMsULxaJEEWb8A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177342670748877.81665553022685; Fri, 13 Mar 2026 11:31:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w17IK-0008W4-U1; Fri, 13 Mar 2026 14:31:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w17HA-0007cG-Ca for qemu-devel@nongnu.org; Fri, 13 Mar 2026 14:30:23 -0400 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w17H8-0005Sb-9F for qemu-devel@nongnu.org; Fri, 13 Mar 2026 14:30:19 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CF5665BFA0; Fri, 13 Mar 2026 18:30:07 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BE9A340678; Fri, 13 Mar 2026 18:30:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QCj0IK1XtGn9MwAAD6G6ig (envelope-from ); Fri, 13 Mar 2026 18:30:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773426607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MncAG3t5Y1v2exCQafgl4tCgcp9DxaNWVxRhlbJmQpw=; b=Fa10+IZ1j/w1gE6SABzqugP72VohqyvT/WIc07vWtHjR1shyE6X0a1czBBlpmZPQNArS2r pFXlWmZ3Prs/w9325UYQTkh6w6fGn7d45sAgz59Y/tiGf3TEldIu20w2DeNoNSs5mbqbjT lOqDfu579I7MOfIoKp4UHZeIHEgHCjU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773426607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MncAG3t5Y1v2exCQafgl4tCgcp9DxaNWVxRhlbJmQpw=; b=U2tM/DK23GIpSz06EEy+aZVwe0jNbppmOY7D5Lhnjb9O29gT3nVGv+mc5d/RjB8Cp1kPkw iXE4wdAon+vPtwCw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773426607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MncAG3t5Y1v2exCQafgl4tCgcp9DxaNWVxRhlbJmQpw=; b=Fa10+IZ1j/w1gE6SABzqugP72VohqyvT/WIc07vWtHjR1shyE6X0a1czBBlpmZPQNArS2r pFXlWmZ3Prs/w9325UYQTkh6w6fGn7d45sAgz59Y/tiGf3TEldIu20w2DeNoNSs5mbqbjT lOqDfu579I7MOfIoKp4UHZeIHEgHCjU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773426607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MncAG3t5Y1v2exCQafgl4tCgcp9DxaNWVxRhlbJmQpw=; b=U2tM/DK23GIpSz06EEy+aZVwe0jNbppmOY7D5Lhnjb9O29gT3nVGv+mc5d/RjB8Cp1kPkw iXE4wdAon+vPtwCw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Maydell , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei Subject: [PATCH v1 3/4] target/riscv: Don't leak general_user_opts Date: Fri, 13 Mar 2026 15:29:55 -0300 Message-ID: <20260313182957.28432-4-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260313182957.28432-1-farosas@suse.de> References: <20260313182957.28432-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.79 X-Spamd-Result: default: False [-2.79 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.19)[-0.951]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[linaro.org,dabbelt.com,wdc.com,gmail.com,ventanamicro.com,linux.alibaba.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com] Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1773426709254154100 Content-Type: text/plain; charset="utf-8" The global variable general_user_opts is being assigned twice, losing the reference to the previously allocated g_hash_table. Signed-off-by: Fabiano Rosas Reviewed-by: Daniel Henrique Barboza --- target/riscv/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index e56470a374..afccfc2935 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -1099,8 +1099,6 @@ static void riscv_cpu_init(Object *obj) "riscv.cpu.rnmi", RNMI_MAX); #endif /* CONFIG_USER_ONLY */ =20 - general_user_opts =3D g_hash_table_new(g_str_hash, g_str_equal); - /* * The timer and performance counters extensions were supported * in QEMU before they were added as discrete extensions in the @@ -2751,6 +2749,7 @@ static void riscv_cpu_common_class_init(ObjectClass *= c, const void *data) cc->tcg_ops =3D &riscv_tcg_ops; #endif /* CONFIG_TCG */ =20 + general_user_opts =3D g_hash_table_new(g_str_hash, g_str_equal); device_class_set_props(dc, riscv_cpu_properties); } =20 --=20 2.51.0 From nobody Tue Apr 7 09:19:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1773426715; cv=none; d=zohomail.com; s=zohoarc; b=KKBjil2cy0jDj6uXBHJsCkJzON92AHIw7ztUuk/vdLMSt31vhFHgmUHvhdw8J9ls27kSoHEbkgoIt2CGUwQNtnX5zfMbKEWQr7BGcM5TjSHNx3mik/Rt3Ej6ItGk+Deti3Tp1KgHKhtwHgWylMbHMPATCHrDJv2lmHO0Jh7XkpE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773426715; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=497Hr2PA0ZA5bBeneuBb6p0JaBKn273FnDt2WbD9jdI=; b=L+8WQoARCSciSwb9U6OfcXt5+pUpEPTiGQMDFADuHbbmDrCYFS4DB5sjlV72ANNVCh1eVbpbaiHdfq8p7ZvdzylMW3cojj/f5NZz5n+5Snm33LZm2Vi3M9CkjKsPA/+4lL7HkQXu3I61i+yNQHMzUGD4CqjEYTf0K+jKj80kawc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773426715969445.54484897747557; Fri, 13 Mar 2026 11:31:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w17IL-00008H-ON; Fri, 13 Mar 2026 14:31:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w17HG-0007d4-Lk for qemu-devel@nongnu.org; Fri, 13 Mar 2026 14:30:27 -0400 Received: from smtp-out2.suse.de ([195.135.223.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w17HE-0005TK-K1 for qemu-devel@nongnu.org; Fri, 13 Mar 2026 14:30:26 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5EF1F5BFA1; Fri, 13 Mar 2026 18:30:10 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4D9A340678; Fri, 13 Mar 2026 18:30:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gFZbBbBXtGn9MwAAD6G6ig (envelope-from ); Fri, 13 Mar 2026 18:30:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773426611; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=497Hr2PA0ZA5bBeneuBb6p0JaBKn273FnDt2WbD9jdI=; b=BgNp5WoPPuaURLil2xQgPD1eRt+oI8/BLbGIxKwBSrc5PKyzSat+PbKeI10q/r+5CYVkdQ Q1PrF2Y27hXWYTellObLkUo56Ji0TkBw4MVJ4cHo1aX5jxlyRLcFX/JTAGD7vo5EjQICBr LMBhZIYwM46X5CDz7d734yJYQ3ULaT4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773426611; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=497Hr2PA0ZA5bBeneuBb6p0JaBKn273FnDt2WbD9jdI=; b=64JRMCwjM3t+/TD17SMHw0k6Q4QgjAHYTFBCEB+XTinWmNXcmnWPaxrem71eFPt9rLVqzS TwJzh+xIsnz7CXCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Dr0R93LG; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4U34EWTR DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773426610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=497Hr2PA0ZA5bBeneuBb6p0JaBKn273FnDt2WbD9jdI=; b=Dr0R93LGR/p1doECe0fV9OiicKhVXbBHE7+FGtgNLPPtRpWbQKdH622GFlMm9Lsh6Q3axu VTqsNaIMgBF550l6HqN71enoaUNWYDdyUX2aYIzY8BIlRfB7VAbXpoEaNWQnmMpZOI9D3W ExJ7hxg5VPqxYG/w58s+7Sb4IxogCaQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773426610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=497Hr2PA0ZA5bBeneuBb6p0JaBKn273FnDt2WbD9jdI=; b=4U34EWTRUFcuz4iPfsM+XtC/vfNlBboiOCCtuBEtG3RGLCHgTIyO8y64nNGL30KXey1QSz dUIPWCUQGXw5dlCg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Maydell , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei Subject: [PATCH v1 4/4] hw/riscv: Free resources allocated at riscv_iommu_instance_init Date: Fri, 13 Mar 2026 15:29:56 -0300 Message-ID: <20260313182957.28432-5-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260313182957.28432-1-farosas@suse.de> References: <20260313182957.28432-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_CC(0.00)[linaro.org,dabbelt.com,wdc.com,gmail.com,ventanamicro.com,linux.alibaba.com]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[7]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-Rspamd-Queue-Id: 5EF1F5BFA1 X-Spam-Score: -3.01 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.223.131; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) (identity @suse.de) X-ZM-MESSAGEID: 1773426717051154100 Content-Type: text/plain; charset="utf-8" Add a riscv_iommu_instance_finalize() routine and move there the unref of the iot_cache and ctx_cache hash tables from riscv_iommu_unrealize. Also start freeing the register state masks, also allocated at the _init function. Signed-off-by: Fabiano Rosas Reviewed-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/riscv/riscv-iommu.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c index 98345b1280..a9cd891039 100644 --- a/hw/riscv/riscv-iommu.c +++ b/hw/riscv/riscv-iommu.c @@ -2446,6 +2446,18 @@ void riscv_iommu_set_cap_igs(RISCVIOMMUState *s, ris= cv_iommu_igs_mode mode) s->cap =3D set_field(s->cap, RISCV_IOMMU_CAP_IGS, mode); } =20 +static void riscv_iommu_instance_finalize(Object *obj) +{ + RISCVIOMMUState *s =3D RISCV_IOMMU(obj); + + g_hash_table_unref(s->iot_cache); + g_hash_table_unref(s->ctx_cache); + + g_free(s->regs_rw); + g_free(s->regs_ro); + g_free(s->regs_wc); +} + static void riscv_iommu_instance_init(Object *obj) { RISCVIOMMUState *s =3D RISCV_IOMMU(obj); @@ -2597,9 +2609,6 @@ static void riscv_iommu_unrealize(DeviceState *dev) { RISCVIOMMUState *s =3D RISCV_IOMMU(dev); =20 - g_hash_table_unref(s->iot_cache); - g_hash_table_unref(s->ctx_cache); - if (s->cap & RISCV_IOMMU_CAP_HPM) { g_hash_table_unref(s->hpm_event_ctr_map); timer_free(s->hpm_timer); @@ -2675,6 +2684,7 @@ static const TypeInfo riscv_iommu_info =3D { .parent =3D TYPE_DEVICE, .instance_size =3D sizeof(RISCVIOMMUState), .instance_init =3D riscv_iommu_instance_init, + .instance_finalize =3D riscv_iommu_instance_finalize, .class_init =3D riscv_iommu_class_init, }; =20 --=20 2.51.0