From nobody Tue Apr 7 19:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773263859; cv=none; d=zohomail.com; s=zohoarc; b=YrEUpZ00E0SkSoGIH4oG4+sX0an+Ji1+b/o0C1V0CIFY5Shuti7eoxx5bFB/xdAmsg1aa/ZkGvuN9xi+kNxsBKTgXn9tKLdBZy4LEOuFO+vPdPXT7n0PRr2aml+kpGo1f8vSrscZOiO51V5t3QwMTKGcFGcwtqpecfy+pw8o5MI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773263859; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0H6unT8VEZNo3CiJ+IQ8BYcYvkyYdKqtJtk19LAOfnU=; b=MR9BgCaZ3iGo1WcwRaRYE2obVEVwLgtjd+YYurp8hcjedPmNOo3svmKXJWrBuPCfz6m4kysH7aMAt7iN8sR4jRfEgC/sGXzgSLq5Haxb955TtzyZTJlMhNMb1PCPriLboEXxynFA0Cwer5t49qjDg/W8keAbc6oqjxD6DpOO6Y4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773263859518401.6539411392057; Wed, 11 Mar 2026 14:17:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0Qv8-0008Ef-MG; Wed, 11 Mar 2026 17:16:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0Qv6-0008EE-RF for qemu-devel@nongnu.org; Wed, 11 Mar 2026 17:16:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0Qv5-0006ns-18 for qemu-devel@nongnu.org; Wed, 11 Mar 2026 17:16:44 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-kD4KKEPCO0KKgjhUpHrCzQ-1; Wed, 11 Mar 2026 17:16:37 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D99DC1956094; Wed, 11 Mar 2026 21:16:35 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.35.99]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C973C1800361; Wed, 11 Mar 2026 21:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773263801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0H6unT8VEZNo3CiJ+IQ8BYcYvkyYdKqtJtk19LAOfnU=; b=VKry6gOBq0Vk65AGob5FaD9oVrFWYslQINJajYNx27e5K+tzOXTYqfVg1tWz9RUbjj4nYB Ynsb4yiXErs8hdyegu6Xoa9cg5d0ZCu3Au4TOYSJxH7unEvjjbUMcN/jUa+iRhi6cM2fgP al11Ojdqo2ZbEpoW5T8MXwBBRvElWCE= X-MC-Unique: kD4KKEPCO0KKgjhUpHrCzQ-1 X-Mimecast-MFC-AGG-ID: kD4KKEPCO0KKgjhUpHrCzQ_1773263796 From: Thomas Huth To: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo , Markus Armbruster Subject: [PATCH] target/mips/cpu: Move initialization of memory region to realize function Date: Wed, 11 Mar 2026 22:16:29 +0100 Message-ID: <20260311211629.118608-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773263863596154100 Content-Type: text/plain; charset="utf-8" From: Thomas Huth When introspecting the Loongson-3A4000 CPUs from the command line, QEMU currently crashes: $ ./qemu-system-mips64el -device Loongson-3A4000-mips64-cpu,help qemu-system-mips64el: ../../devel/qemu/system/physmem.c:1401: register_multipage: Assertion `num_pages' failed. Aborted (core dumped) Move the initialization of the memory regions to the realize function to fix this problem. Reported-by: Markus Armbruster Signed-off-by: Thomas Huth Tested-by: Markus Armbruster --- target/mips/cpu.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index e424d115018..5f88c077dbf 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -460,6 +460,14 @@ static void mips_cpu_realizefn(DeviceState *dev, Error= **errp) MIPSCPUClass *mcc =3D MIPS_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 +#ifndef CONFIG_USER_ONLY + if (mcc->cpu_def->lcsr_cpucfg2 & (1 << CPUCFG2_LCSRP)) { + memory_region_init_io(&env->iocsr.mr, OBJECT(cpu), NULL, + env, "iocsr", UINT64_MAX); + address_space_init(&env->iocsr.as, &env->iocsr.mr, "IOCSR"); + } +#endif + if (!clock_get(cpu->clock)) { #ifndef CONFIG_USER_ONLY if (!qtest_enabled()) { @@ -504,14 +512,6 @@ static void mips_cpu_initfn(Object *obj) cpu->count_div =3D clock_new(OBJECT(obj), "clk-div-count"); env->count_clock =3D clock_new(OBJECT(obj), "clk-count"); env->cpu_model =3D mcc->cpu_def; -#ifndef CONFIG_USER_ONLY - if (mcc->cpu_def->lcsr_cpucfg2 & (1 << CPUCFG2_LCSRP)) { - memory_region_init_io(&env->iocsr.mr, OBJECT(cpu), NULL, - env, "iocsr", UINT64_MAX); - address_space_init(&env->iocsr.as, - &env->iocsr.mr, "IOCSR"); - } -#endif } =20 static char *mips_cpu_type_name(const char *cpu_model) --=20 2.53.0