From nobody Tue Apr 7 21:45:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1773241814; cv=none; d=zohomail.com; s=zohoarc; b=G+VkZ3YXKGuaw+ANbKxgSNjXMCPkdwTpFUTU87XOni1qVZcbjC5YGAvGWvMPll7FqqvQq1lSCzrpsd47H8Gb+MPqvlcMMUYf6pd0zAC2gbGlgL19RGDkhdlbZjQTw0t6TQEhGPYUWROYByJMCMI8clHOxiaq8B2kEcVMBzDERLU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773241814; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wha4kEnhBwijLqq93bxpQGpMzcFQ2CBwCdz/BVvpZKc=; b=mp1lOCtzulQiERBc+U2ro1BS6bkaqBlvyk3yRRkAdFdU40Ik3qGSGI9+dl0Wbg7fcpkoPDVwesYOw6W0gW/ctVonb2EtiBRCfnH14WQprXVfkoBthE/yW7BnouNKAHaE2d5BPP0p71sm6UkgQJEGy6+Dl0v+5OGkyZO08zm383g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773241814712836.272202336865; Wed, 11 Mar 2026 08:10:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0LC1-0002Ch-Uo; Wed, 11 Mar 2026 11:09:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0LAu-0006rP-5W; Wed, 11 Mar 2026 11:08:41 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0LAq-0005ce-CD; Wed, 11 Mar 2026 11:08:38 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 7B131191E98; Wed, 11 Mar 2026 18:04:42 +0300 (MSK) Received: from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146]) by tsrv.corpit.ru (Postfix) with ESMTP id 64C4B37C2D9; Wed, 11 Mar 2026 18:05:20 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1773241482; bh=OQyjN3JiNQKujPfiQykMp7epgbhDBXLON+2RERmtywM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XJY+9ZnGIaSjg5t+u5+6+H5Om/gTiM36vFOvM/TiiJmBGsnQ5YRpbjo8Zt/WwzD25 nyFQ+h7AcAAcho9s5bsbzR+e7737MS9a8FK3a6nB22+0EX01RyXlkPalm1msom+vYC n62pxTeOBGnrK38vRRs74EpOx/q6JlWxXdXoJQ6Zn1/3lHEjH7tUsOUlM3f6KpUNmZ Ephgkj3HKmUaWp6fhEn94Knc19ZO0mTFPw0BtGrBN4pSj8K+SfZIhtstbg7UYw+uin dHG182groP6H0xSmnxoDxGKJjHYICyuHJhFUE+teIjvs30sUz2xNoWMeE61PMZflbT /jeqVrWwBCMxg== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Weixie Cui , Thomas Huth , Alistair Francis , Richard Henderson , Peter Maydell , Michael Tokarev Subject: [Stable-10.1.5 21/46] hw/ssi/xilinx_spips: Reset TX FIFO in reset Date: Wed, 11 Mar 2026 18:02:57 +0300 Message-ID: <20260311150327.1084669-21-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1773241839225158500 Content-Type: text/plain; charset="utf-8" From: Weixie Cui In xilinx_spips_reset() and xlnx_zynqmp_qspips_reset() a cut and paste error meant we reset the RX FIFO twice and the TX FIFO not at all. Correct this to reset both FIFOs. Cc: qemu-stable@nongnu.org Signed-off-by: Weixie Cui Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Message-id: 20260223095905.67709-1-cuiweixie@gmail.com [Rewrote commit message] Signed-off-by: Peter Maydell (cherry picked from commit 669683cf1414ce442d2faea160dbc69747aef007) Signed-off-by: Michael Tokarev diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index a79f3b8e49..9c5b58a9ec 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -369,7 +369,7 @@ static void xilinx_spips_reset(DeviceState *d) memset(s->regs, 0, sizeof(s->regs)); =20 fifo8_reset(&s->rx_fifo); - fifo8_reset(&s->rx_fifo); + fifo8_reset(&s->tx_fifo); /* non zero resets */ s->regs[R_CONFIG] |=3D MODEFAIL_GEN_EN; s->regs[R_SLAVE_IDLE_COUNT] =3D 0xFF; @@ -397,7 +397,7 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d) memset(s->regs, 0, sizeof(s->regs)); =20 fifo8_reset(&s->rx_fifo_g); - fifo8_reset(&s->rx_fifo_g); + fifo8_reset(&s->tx_fifo_g); fifo32_reset(&s->fifo_g); s->regs[R_INTR_STATUS] =3D R_INTR_STATUS_RESET; s->regs[R_GPIO] =3D 1; --=20 2.47.3