From nobody Tue Apr 7 21:44:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1773241926; cv=none; d=zohomail.com; s=zohoarc; b=UDV3G6BNDcf0ZRLuQxA4KnHOo3XodyFenhmz3to1bQWfFLAFYAzYQ9wvwxD/XTB1jd+Xl0o8g3dyf0FJhX7J8aCsaU6Ww12pQxzdYrLGpvs902N9PTzaZ5HgtOmxixXoAdBZaO2cVQO8khaAkjKgGUXjN6mpgjGjjAlm8jU7Lhs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773241926; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EidjrLkykcg7DTP36jkbFLnnmwzZRYdu81nS1G0BLb4=; b=IXeqDOCaYzXCwEVbMUIfVWxmQyIygtiHhQf7Tr9dPI0MIBiMnAETxpsRb60wT6DnBRljOkxdB8mUSOlMWmkaZKTFF8wJB7wN7tRPlUtaUihZB2ZNUwm4a/RtdnC7AtZ/oZeSwwiyXJPekH9NEWYPqGnA8WqbOoG+d8oi8XL94gw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773241926969491.169276363231; Wed, 11 Mar 2026 08:12:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0LCI-0002dD-3N; Wed, 11 Mar 2026 11:10:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0LAq-0006lT-7A; Wed, 11 Mar 2026 11:08:38 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0LAn-0005cH-Eu; Wed, 11 Mar 2026 11:08:35 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 66AB5191E97; Wed, 11 Mar 2026 18:04:42 +0300 (MSK) Received: from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146]) by tsrv.corpit.ru (Postfix) with ESMTP id 4B75637C2D8; Wed, 11 Mar 2026 18:05:20 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1773241482; bh=N0GMzjC3W7RYbcpelKlOxpYSyS8lFWCXR90eEAeuy70=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=caRHpBDGqRJ8JN1hbgYhl5vlmmFAhKrYdhQuwzYG6jATNqN3CjlimTSETn1nIBKmi H35mkAlBvzjP3Df7RAu6V0mgtNJOV0daXQ25L084TWq0q3MAo0qEIzudRyrTVugMD7 9drHVam8vm1erE1qDKJxbbA7eegaUR0AZYVk8YrgAfvdKgBEisP22+N+HewZkVZHGM JYjgfsY/Pi7KyYNL/zX7P1QAt2cjX0QnXunDTFKiUcdChnI3wx5nrVAjGl76jyOz2e Dvk9Fimg4SwkbHs9/shLfSAzeYS0Xd2b8UF8s/NwlAguGD1gRyV7AHImlovYHlcPvV b9hFTKqEzwyJQ== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Kuan-Wei Chiu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Tokarev Subject: [Stable-10.1.5 20/46] hw/misc/virt_ctrl: Fix incorrect trace event in read operation Date: Wed, 11 Mar 2026 18:02:56 +0300 Message-ID: <20260311150327.1084669-20-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1773241928589154100 From: Kuan-Wei Chiu The virt_ctrl_read() function currently invokes trace_virt_ctrl_write() instead of trace_virt_ctrl_read(). This results in read operations appearing as write operations in the trace output, which is misleading during debugging and analysis. Replace the incorrect trace call with the proper read-specific trace event to accurately reflect the hardware behavior. Fixes: 0791bc02b8fb ("m68k: add a system controller") Signed-off-by: Kuan-Wei Chiu Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260111184915.1363318-1-visitorckw@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 (cherry picked from commit 8608ed356ef90815cc5bcf04fcdbde987fd24bca) Signed-off-by: Michael Tokarev diff --git a/hw/misc/virt_ctrl.c b/hw/misc/virt_ctrl.c index 9f16093ca2..7dc2fe4f94 100644 --- a/hw/misc/virt_ctrl.c +++ b/hw/misc/virt_ctrl.c @@ -43,7 +43,7 @@ static uint64_t virt_ctrl_read(void *opaque, hwaddr addr,= unsigned size) break; } =20 - trace_virt_ctrl_write(s, addr, size, value); + trace_virt_ctrl_read(s, addr, size, value); =20 return value; } --=20 2.47.3