From nobody Tue Apr 7 22:03:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1773239813; cv=none; d=zohomail.com; s=zohoarc; b=Ts5PoHgvxctFx7J3GzLmx6SIwLKvl+nhxpQMJD51WBXEGixTBBoYmGUPl2zf4vpOoPZgPAV/e1dXBdbYbt8nWjXLFXrcdhlc7EP+EHWgqv4OjzDRVa5vbh/YzkDjk99KYbHcPFKJq9ePl6m684Os0evLptfFQed+VzXbl+COrpo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773239813; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+ikecbBlDzjkHpOTUJk9pHX4nWlJUfWsO9zaA38o3kQ=; b=NjgclGLqaLPIkZSeGPwvCjz/IMJ0hwRVuLwYc8/non9o1rk38itKV04Fs2LgIhnNonilbY+hNetzsvY/GGxdeTf1amItKlBqbgdhuOvKgoAik815ZJYNLjB/2Uhv05O8wN2JzRAVaTeD79myxW0qJTbkSq8nbhvybnY5I8nDnC8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773239813649268.1904159361944; Wed, 11 Mar 2026 07:36:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0Kfe-0002Qv-S7; Wed, 11 Mar 2026 10:36:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0Kfc-0002QL-HO; Wed, 11 Mar 2026 10:36:20 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0KfZ-0005a9-Mv; Wed, 11 Mar 2026 10:36:20 -0400 Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BDllxg1278613; Wed, 11 Mar 2026 14:36:12 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4crcunfuch-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Mar 2026 14:36:12 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 62BBUBeB015653; Wed, 11 Mar 2026 14:36:11 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4crybndty1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Mar 2026 14:36:11 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 62BEa7cu35062142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Mar 2026 14:36:07 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 575DF2004D; Wed, 11 Mar 2026 14:36:07 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33CC12004B; Wed, 11 Mar 2026 14:36:05 +0000 (GMT) Received: from shivang.com (unknown [9.39.21.199]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 11 Mar 2026 14:36:04 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=+ikecbBlDzjkHpOTUJk9pHX4nWlJUfWsO9zaA38o3 kQ=; b=iJFLphMR9qyHKBnK0evP/e4t/mSv1QoB6wrnjKcHvdzcbt+Gju37Lib38 qnE18i9LqCN31J3URJaOn1VKFgRsHwGkmHjPuGtXwN9cwbr6K++FLUbDkocRdQsn Lsv2vRD8dNodQL2Rqf5gVGDoGrRfGZNAUz5SHfpXZbxEH8h+dPXNg4j9SztH4RBq VZeHWvT+m2q8lox0PmuunZbj+C+qc4OkbcyRb6LleBKVci1UpFUYTyfKFYMkNZSC gYV/TAYGZQKon41hWSi64QVZi8Usvoca0IZ56Hz0tozGhlKkkHRxhuBJ7xZ12n9S RXNV4xgPrOIMkfSL4FnTX+F1fjg9g== From: Shivang Upadhyay To: qemu-ppc@nongnu.org, qemu-devel@nongnu.org Cc: npiggin@gmail.com, milesg@linux.ibm.com, Shivang Upadhyay , Aditya Gupta , Harsh Prateek Bora , Peter Maydell , BALATON Zoltan , qemu-stable@nongnu.org Subject: [PATCH v2] ppc/pnv: fix dumpdtb option Date: Wed, 11 Mar 2026 20:05:49 +0530 Message-ID: <20260311143549.118720-1-shivangu@linux.ibm.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: ClNy8cQFDK3Ep3JD8btJD5IzDwiiOVe9 X-Authority-Analysis: v=2.4 cv=Hp172kTS c=1 sm=1 tr=0 ts=69b17ddc cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=VnNF1IyMAAAA:8 a=69wJf7TsAAAA:8 a=QjnmHpCl0YB2qDOJ94UA:9 a=cvBusfyB2V15izCimMoJ:22 a=Fg1AiH1G6rFz08G2ETeA:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDEyMyBTYWx0ZWRfX0o4h/6wrIHpw f4ezdORMeProc7wlmkR4D5na44eldaVJEvCk+xUx0PO3IP2NlltkBhFrvimkYccSTa+F4QWKTqJ rWP09DIO3bh8WQF8H7IWwm7uSw0zlEIgOrA2x63vhC0QxgE+jII2IRA9sBJyVCE90OZEQcYHayz CDaAN2AtjrsfvepKy0dkoLc9nA3+1GV/La+UU4PRA3t36OJNv/Il1lAT0MpoELXdWDqSb7z99kR ymvRpwPHIZx0/RJ4uN5sHKQ3Mj4YYVxKh0mlkwNR52+9v0fURRinPMOHIypcfXGry+tr27Br1VF nxhwUmiZmT9gzdNqiaVy+saEb/OtyqHSPWXPNmrsfqczNU59Y719bG2c8wgnYPSCpypySfR+Rap gacVFPYAgKSnceEcCt0/UGr9yYGJAWZJa75gS0EB3fy+ZJCk4HNpNzA80pTtKEpxjei5MaUzWlu FUQcASVBvz9EhpptYvg== X-Proofpoint-ORIG-GUID: n9j1c27V22nZ7QiBClrtwirKqApeBahc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 phishscore=0 clxscore=1011 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110123 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=shivangu@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1773239816688154101 Content-Type: text/plain; charset="utf-8" The '-machine dumpdtb' command line option stopped working on PowerPC/pnv systems after recent design change [1]. Fixing this by generating fdt blob in `pnv_init`. [1] https://lore.kernel.org/qemu-devel/20250206151214.2947842-1-peter.mayde= ll@linaro.org/ Cc: Aditya Gupta Cc: Harsh Prateek Bora Cc: Peter Maydell Cc: BALATON Zoltan Cc: qemu-stable@nongnu.org Fixes: 8fd2518ef2f8d34 ("hw: Centralize handling of -machine dumpdtb option= ") Signed-off-by: Shivang Upadhyay Reviewed-by: Aditya Gupta Reviewed-by: Peter Maydell --- Changes V2: * added fdt_pack to newly generated fdt in pnv_init * cleared the fdt generation code from pnv_reset V1: * https://lore.kernel.org/all/20260225081037.21990-1-shivangu@linux.ibm= .com/ --- hw/ppc/pnv.c | 25 ++++++------------------- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 1513575b8f..7e54b6bc60 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -773,26 +773,8 @@ static void pnv_reset(MachineState *machine, ResetType= type) } } =20 - if (machine->fdt) { - fdt =3D machine->fdt; - } else { - fdt =3D pnv_dt_create(machine); - /* Pack resulting tree */ - _FDT((fdt_pack(fdt))); - } - + fdt =3D machine->fdt; cpu_physical_memory_write(PNV_FDT_ADDR, fdt, fdt_totalsize(fdt)); - - /* Update machine->fdt with latest fdt */ - if (machine->fdt !=3D fdt) { - /* - * Set machine->fdt for 'dumpdtb' QMP/HMP command. Free - * the existing machine->fdt to avoid leaking it during - * a reset. - */ - g_free(machine->fdt); - machine->fdt =3D fdt; - } } =20 static ISABus *pnv_chip_power8_isa_create(PnvChip *chip, Error **errp) @@ -1261,6 +1243,11 @@ static void pnv_init(MachineState *machine) if (pmc->i2c_init) { pmc->i2c_init(pnv); } + + if (!machine->fdt) { + machine->fdt =3D pnv_dt_create(machine); + _FDT((fdt_pack(machine->fdt))); + } } =20 /* --=20 2.53.0