From nobody Tue Apr 7 23:44:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.com ARC-Seal: i=1; a=rsa-sha256; t=1773234965; cv=none; d=zohomail.com; s=zohoarc; b=ai8Dd3sZ9W3q42a5olzZyHzihnEk5DQgCh3wvOuncoCqmIBRk41iJk7arzz9w9s9hJarGmdPW3EyFQEpoGhRkmMjw3B23VmEhHecwUXGUQfPdH2+VVGPCuutBbqQ3Gr8uwQNV06mF+IIKb2HNR0Su3I5VUtRdwuNw2J7KF+A2w8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773234965; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tzPB6fjysN2r3rjRlnKTgZ2tmMc0GDYMM+Hwo4GReow=; b=WrZGxQLRdpSQaF+rm1PNDxem09VU4ySpvveS41iERycisai6cuVjpPOkI4JJO61aScHG5ucp8K/EinyZLRL3Qx3qPzGtlVpTGo2hKsnm2DoDDXzXzhwwrUHeLnyE78IbNEsTzwV7r2Pse8gJhUIHD67SU/5iwcCP7uiMJ5x244U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773234965652982.862573157597; Wed, 11 Mar 2026 06:16:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0JPW-0000oF-MG; Wed, 11 Mar 2026 09:15:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0JPR-0000mq-Bm; Wed, 11 Mar 2026 09:15:33 -0400 Received: from forwardcorp1d.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0JPN-0000Mu-I4; Wed, 11 Mar 2026 09:15:33 -0400 Received: from mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:bf1f:0:640:c739:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id EEA3D8062A; Wed, 11 Mar 2026 16:15:27 +0300 (MSK) Received: from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:d28::1:5]) by mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id MFGaO30AdeA0-YDaVl7co; Wed, 11 Mar 2026 16:15:27 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1773234927; bh=tzPB6fjysN2r3rjRlnKTgZ2tmMc0GDYMM+Hwo4GReow=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=E5T7HrTXts1T37eZB7F797F26v9igZitn8mA7PVQhD+P7hhXoB0ahmqUnIyCplk2A waX8Car8zPvh4Hv0jHqfMrm9g7gVK2gILFYUojkjKNI78q595I9F9EYsZpFCCAs7Dz InNLvmlEUHLXyBN+uQu7/XmLxzJKFOxeyMgiLgts= Authentication-Results: mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.com From: Sergei Heifetz To: qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Xu , Ani Sinha , qemu-trivial@nongnu.org, Laurent Vivier Subject: [PATCH v4 4/4] hw/usb/core.c: reorder usage and assertion of p->ep Date: Wed, 11 Mar 2026 18:15:22 +0500 Message-Id: <20260311131522.58600-5-heifetz@yandex-team.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260311131522.58600-1-heifetz@yandex-team.com> References: <20260311131522.58600-1-heifetz@yandex-team.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.200; envelope-from=heifetz@yandex-team.com; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.com) X-ZM-MESSAGEID: 1773234969286154100 Content-Type: text/plain; charset="utf-8" Reorder the code so the assertion of p->ep occurs before it is used in the subsequent lines. Signed-off-by: Sergei Heifetz Reviewed-by: Laurent Vivier --- hw/usb/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/core.c b/hw/usb/core.c index b3f811c513b..9572a870cc0 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -423,10 +423,10 @@ void usb_handle_packet(USBDevice *dev, USBPacket *p) p->status =3D USB_RET_NODEV; return; } + assert(p->ep); assert(dev =3D=3D p->ep->dev); assert(dev->state =3D=3D USB_STATE_DEFAULT); usb_packet_check_state(p, USB_PACKET_SETUP); - assert(p->ep !=3D NULL); =20 /* Submitting a new packet clears halt */ if (p->ep->halted) { --=20 2.34.1