From nobody Thu Apr 9 12:08:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1773228963; cv=none; d=zohomail.com; s=zohoarc; b=NREmpimiQ8KhiyQKLEXbZN0qPOWQ74g12zbGTxj5Sg3Os7PyMMEopQBqn3tch4yEwjUSFKChg9JeuBHm0IGRPfdpn5gn7/SDWoOlRkb08a99CJvgoA2SMnzJhl1eOcxQJOatwbL+QFqcfs6W7HSd1w9m28OMogL0HghNPfxiOAo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773228963; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yH//92yEE/RfpcyMnJP346FPLTO4pOz0FQlMYOR+8A8=; b=NHd2VIVzYhPTLs92+1Vsc+lySBVjhzMykFdMSIQ8mG63gUoDST6iun9fyxmwQzRVd6zzfeTQ5sq3U6/ZkBlsnYrIkMfr0l9Wt/W+g3hxc2NoS/5lFB7WA11fDQkdxuCMGYzYWRwEKl8CjzGyKpejkXknQsiFdTnc/8fUwpsAvmw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773228963629758.1718615838075; Wed, 11 Mar 2026 04:36:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0Hqa-0006cA-65; Wed, 11 Mar 2026 07:35:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0HqY-0006b3-KO for qemu-devel@nongnu.org; Wed, 11 Mar 2026 07:35:26 -0400 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0HqX-0006Fe-1C for qemu-devel@nongnu.org; Wed, 11 Mar 2026 07:35:26 -0400 Received: from DESKTOP-TUU1E5L.localdomain (unknown [167.220.208.53]) by linux.microsoft.com (Postfix) with ESMTPSA id 6EA1E20B7128; Wed, 11 Mar 2026 04:35:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6EA1E20B7128 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1773228924; bh=yH//92yEE/RfpcyMnJP346FPLTO4pOz0FQlMYOR+8A8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OR30jzYtDt2tZDi0HGh9Y576no94El9ejM9Gi4rv23D/iAtAXaWwdCcGqt8aUU/1W k2R/pH64eNuV+ciYZi8Bjv+pwFn5M9Hv+VJW6l4xNh9lnfSshQG1kZjDrvkdu6HOHm YEqwHtlzO9Wf7/nBN65LWT2mbbGE5y6E40o777tQ= From: Magnus Kulke To: qemu-devel@nongnu.org Cc: Zhao Liu , Magnus Kulke , Paolo Bonzini , Wei Liu , Magnus Kulke , Wei Liu Subject: [PATCH v2 4/9] target/i386/mshv: change cpuid mask to UINT32_MAX Date: Wed, 11 Mar 2026 12:35:00 +0100 Message-Id: <20260311113505.1177878-5-magnuskulke@linux.microsoft.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260311113505.1177878-1-magnuskulke@linux.microsoft.com> References: <20260311113505.1177878-1-magnuskulke@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=13.77.154.182; envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.microsoft.com) X-ZM-MESSAGEID: 1773228966300154100 Content-Type: text/plain; charset="utf-8" The current implementation would only override the feature bits that are enabled, however we also want to consider disabled features, hence all bits are set on the masks in the hypercall argument. Signed-off-by: Magnus Kulke Acked-by: Wei Liu --- target/i386/mshv/mshv-cpu.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 4183727a86..e42b5a614d 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -538,22 +538,17 @@ static int register_intercept_result_cpuid_entry(cons= t CPUState *cpu, .input.always_override =3D always_override, .input.padding =3D 0, /* - * With regard to masks - these are to specify bits to be overwrit= ten - * The current CpuidEntry structure wouldn't allow to carry the ma= sks - * in addition to the actual register values. For this reason, the - * masks are set to the exact values of the corresponding register= bits - * to be registered for an overwrite. To view resulting values the - * hypervisor would return, HvCallGetVpCpuidValues hypercall can be - * used. + * Masks specify which bits to override. Set to 0xFFFFFFFF to + * override all bits with the values from the QEMU CPU model. */ .result.eax =3D entry->eax, - .result.eax_mask =3D entry->eax, + .result.eax_mask =3D 0xFFFFFFFF, .result.ebx =3D entry->ebx, - .result.ebx_mask =3D entry->ebx, + .result.ebx_mask =3D 0xFFFFFFFF, .result.ecx =3D entry->ecx, - .result.ecx_mask =3D entry->ecx, + .result.ecx_mask =3D 0xFFFFFFFF, .result.edx =3D entry->edx, - .result.edx_mask =3D entry->edx, + .result.edx_mask =3D 0xFFFFFFFF, }; union hv_register_intercept_result_parameters parameters =3D { .cpuid =3D cpuid_params, --=20 2.34.1