From nobody Sat Apr 11 21:30:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1773214079; cv=pass; d=zohomail.com; s=zohoarc; b=P3pljxx/AqqaCKchOOwjssQnz/Fi7AhMk8I9HoWWBFo3WveeRl6xYv0cYBszQTlH0TG4PsTIGD2XcjeRqHwqYNCYx99hHNnfUJ8KHWNjHqRQpzAL9Rm5BQai9bgF56cBdH7AArY/2aqtSEaEUjCpWzDSw4kcMdH1YTkClaM24lQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773214079; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YkNfTZcIrGWgh1D3atFjdHIVT8xSoWDqUyuONMPDrZk=; b=jEbAZHUswfMgCi7fnPqb0+cuWW34gMJ5jtJMG+pd/RlUAESQtabNrDD+YFMHx6YZ/rHFsMJav34sBu0FD012AfAve/MxEtjxKj9SHX9cTb4HCK/nCYWOu7IzqcRllkD2acbFXsqozUrFKQtj5Zhh7hTmJv8gyyw+KowpJBMSy5Y= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773214079142619.6379413404139; Wed, 11 Mar 2026 00:27:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0Dy8-0003Cs-Al; Wed, 11 Mar 2026 03:27:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0Dxn-00031Y-22; Wed, 11 Mar 2026 03:26:40 -0400 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0Dxk-00052z-Bj; Wed, 11 Mar 2026 03:26:38 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by SEYPR06MB6082.apcprd06.prod.outlook.com (2603:1096:101:d7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.11; Wed, 11 Mar 2026 07:26:26 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9700.010; Wed, 11 Mar 2026 07:26:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AP7P0Y4S3AOKqJaZk9BZaF6+RuMmt8h2PO2B/vSUYslKp9oBnyHFlDmTilTUisPB19ChIOEbCAlyJuSMffJG7ngQUIyR/sMG1IVkMmJ8zfFN7L018GcFxoYD8O6wJutnF7u8o9eb4zNPYkq77pMuEwUOL5WsESkJlm9Uh5erW1X3bVpZm84Jzdp+j7wrSLLUpU1mnAguXGdPAnJnLJKSn+vIm7UQHhyBw6UwRd5Qgz8jz65+7/Q/8J+BjGzTEHhvkTzJaKg8RuFywWFjMkKU3O0qQaThlURFtH4qNHUVr1LDxJnZqSmQ3CsKpMbivPxrAQsZlphFQB8h9hhdApFNcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YkNfTZcIrGWgh1D3atFjdHIVT8xSoWDqUyuONMPDrZk=; b=TJ1YTh0Waau8K4vFQQev031sTtY7dqQp5bhZkaJTchXbDiIeYdi5RvjwJg2GCMAPzA5O1Mfzw0EbUdJ4KIqo0hqxgdWUo2TOtXZFudx70BfL2t171VvHFVoUaX9229OKzcdR/SKCGgTGF9imWQ5WJZehKfgtMZNIcvO98Mr93IKwQiF4YJ5shNupyrp0OConXTC7/l/WzAb3kpCo5FGKt0IyUxznjEH356BUGi13/UEHmcU58rsabUdc6n+r70aNN59/qxR6GMN2Xc8fRfpQfIhRjUgij6Vv34wNA82q7YfH36O9tFpBAXMcpJ4cQp8PqP548idjGBdILK/GeReQgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YkNfTZcIrGWgh1D3atFjdHIVT8xSoWDqUyuONMPDrZk=; b=cBWXfAZPbb16fn98dt6TWEd3joUxru0mqKyBIva+nqWQg2CBlCiAMCS+q5k/+v4IcrBVCjvnRpFNej45/YEOgVahmXmDL28vmThWHUvoTZWe/qYicSwVcv9ObxerCAtFHuYwpJ3uT1c9tmLN82NuHA/QlRTe0yfjEA6EEEbR2AgmkjhzwcmFer6n1O/l0CW7L/eMu09GEOBZWcv7+UqNfGdlPvNk5YZy6RAlgYQTvaxyYdNjwHl5LDD40gURW/C0S5eZLvV+ZgTnsV1VkhAwU+qw5ZCDxElPoTMebbO8dzuauZ6IK47zKqpN9Fi6X+MP7FiBNdGq8AC6jIovqmewjg== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v1 09/13] hw/usb/hcd-ehci: Implement 64-bit iTD descriptor addressing Thread-Topic: [PATCH v1 09/13] hw/usb/hcd-ehci: Implement 64-bit iTD descriptor addressing Thread-Index: AQHcsShfZeJMlRPRYkimFt6DLcf0vw== Date: Wed, 11 Mar 2026 07:26:26 +0000 Message-ID: <20260311072614.1095587-10-jamin_lin@aspeedtech.com> References: <20260311072614.1095587-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260311072614.1095587-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|SEYPR06MB6082:EE_ x-ms-office365-filtering-correlation-id: e1704b6a-1cdd-485f-fd1b-08de7f3f8194 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700021|22082099003|18002099003|56012099003; x-microsoft-antispam-message-info: ujxxVfxjPqUH/qSVkob9xOelzm7tlAroG1sPxVgZ/GBgeRnvr+xCM7nqw0puHF5BXHYIT4bjpDBL3pjG9OwLbuEoepn6ozXTD9/+ujbT28OmBo35cev6T6SsMN7vreFWmPZ6xlFB/mwwHS2V/ZXQvIlmy+brf1LZFEpe1yAbh8+QEeUGxZVzeX2kyZK4tH1K9mV1bpgrb4pynsu3azmVb4P3TYhbPLgI/qekCdxiU3ReUMo6GbcIbvzgCE83vLXhl+n+aMUiGOGUPWE2On/eJRUQjo1yp1kij9gGW3877FBi9VF7G+pP31/3pH0lBGWDigwSJLwLmab0QK/ObHQhSkn44vgsCLgtMu86eFeTSZ5OKTXDuZ/pFaWcPjFZGW+aHN6WpiynsOtIibc9ljxv3O6mkoahzuQ4RngN3mobyPJrF1LrOzMgD4w5NVOCY4DzszyYp4Oxfj39roC4IT/XGCGMRHtvvEo9bA/LRovKT1/z4s4AaU7rwmMrYs8xb+xMpYMNHvXzQfTNQJGGga1rtWg+5b8if7uUxsBDYxbXdDvysLHN+Fzf1hmXyHEhY3n4fxMQbzIEaxVOX0VC2DI6xYpaNrodh3cGwM17XZtnvN9/xDqLdINhFxttv1xXSQKaUdZrE5eYlBsVNbewH0F5okd/Hssh+5cyTddsxFlXgNL9M/7xtiBNdUE5Vu2JJXgTPcCv6pGWbCzetKkjot/SBz59ee3iCJlHdZUIygiY9sucBQT42sQEMbvUaEr2QCdoyzM8y7pVMbzo8A34U/WOzN8oQWmaBDUQYMUE2l9KODc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(18002099003)(56012099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?l7V7PVWcOhSfXdHwZzbgBWWoF6mXIqUiUBwNRlhno/JiQbj/6EojE7W4Xp?= =?iso-8859-1?Q?DfChRhedfr1//5dL2M8ReWumOTFWuLIZFSJaYsPsLfKaVRbQsbp4nw4pc6?= =?iso-8859-1?Q?UovmXY9Rf1x5S3aaAQaRzB7Gl7qzJLWMsSf1BjkrgswakRacdQmdTDeacU?= =?iso-8859-1?Q?3wcWtTeoKlnWPlCskw+iqy8hQMqggEtAb+VuyaNBeyWzYadX+7QsI0moIx?= =?iso-8859-1?Q?BwN8AVt28AUUnMf/m+lLZ7H2y6Ol1TSTDZJCxHs4w8El63tlVcEu6rXyZk?= =?iso-8859-1?Q?XZ0Q0WNewTB5Kp49YfrEC7hydfIRLDf0uqiZsruMxhCWywMiRpLWMKn99T?= =?iso-8859-1?Q?9b9+x6lOUd3qHwZo4Ta2LmHJRzdk+unzmpfI1XfE9Jn944I1lmrXVs1ZgY?= =?iso-8859-1?Q?MmN/PruZnP+YtJDIMLzvks1uA03+YDr00Bn3EPoRSzw0chpZsSN7bibCLU?= =?iso-8859-1?Q?es7AkI5hVT5FeQP2AD/gr+aA7cutx48J2wV62Su8gn0A/CEjyzpaf3G+b9?= =?iso-8859-1?Q?2UQVRxgEc/aggGFw4OB0BLkCQ/00CNpFwfEmhA0RDcoVMTnNfIJpcipkVJ?= =?iso-8859-1?Q?KSc676XHYtD1xO8iyfow9qrJHCL0FUK5gogwm+ahF9gpDnxPFlNrC24RiQ?= =?iso-8859-1?Q?JJ6CVEmcwt/F/fF7JKHkP+O1BfVpBJZngdZF9zzfuqPhMtdrYI8p6m7Lui?= =?iso-8859-1?Q?qCuebUcaRSOn+D1l9QXZjcSdm6ag/wilBD98QyhgY2s4kfvHBw4QW+vGCu?= =?iso-8859-1?Q?pUY8ZjqxWiJ2QP0NWmFU25p1jwlMxHVBl6WmXoJEcicA9jfi0+FpWHr6dT?= =?iso-8859-1?Q?3RtzZLu4MvHNkXv5YAVi9g3XC/qPMn0ZBWRVhv33URCxvys4PVvd/lnYwR?= =?iso-8859-1?Q?rBQGezhO+ueVvOJ/nRT6aK630cmb654GfiW82I/RqyYwy0Edlwxkp+R/Lj?= =?iso-8859-1?Q?JlNcfTGR3eW8/Rbvd3zoLCsAGmGZF4GaDplJEBvUc+UgU/J95+ZDPsSqs7?= =?iso-8859-1?Q?gHHnJ2hy27qxfXvRmbw0QTYCTh6xWAtMDhsKr1u1n2nuGaVTULLjF59lqn?= =?iso-8859-1?Q?+E898lEWf9ZjLwCuOR6NUBfy7DY8b7IoGWcutV16g/rIB1TpIIieI2R058?= =?iso-8859-1?Q?nDo9ag/VMuJWiST4w6nRWcNo10lL0u4dcQCp4w1LNbE64vF0NeILIsrRNv?= =?iso-8859-1?Q?GqeQTbrr+xe8NS4jvnpOMcsdrsRNr5JhbveIdsE4xemAN7ozi0orzrSjGF?= =?iso-8859-1?Q?UFudiSRC78D273wLUL5eumW2NzKlaGqrf/A9VvCVEurVpZe8uW841zJsgv?= =?iso-8859-1?Q?9Y+2UTYXrxef8CdPQsypRcdzKoWqS1g+B9e3yP2yztKL1xwvI7kiNHgNqk?= =?iso-8859-1?Q?K9I0rT2+vy55y8lslkwK8IdVM3O2SbUCjWp16dXoRIq6miCOcQ/NcVMu0h?= =?iso-8859-1?Q?5RPJARbknNuUIMtX6n3R3ec56kICG6aukVHxF5jzZTAaMXF/8zPXd4hIyU?= =?iso-8859-1?Q?e4GTQkvPyA9qu5eQ4LLgZE99oWXyZIRlIyGLDG0N5zTP7nZ5jVtZaZobUr?= =?iso-8859-1?Q?hdoTmPML5MKoqJPbFhM3qmhEVytmLONbmE+Sdg3PEmm30t/cDYuNPQBKRW?= =?iso-8859-1?Q?vh4DAYPp4zFVgX9Gb+jPve1zS25VeziEdisuq7LbKId1FpooEUKYKWSHQW?= =?iso-8859-1?Q?DwCed5qdrYlh7ziv5z9qhrei5b0BpZ6Ul7ZAKpdfmJMPOiYxl0GNThJGaZ?= =?iso-8859-1?Q?h7BAB15Td1BePIix/mWqjCNF244OqB99REP1QpvXB/YQESTl5I3GfXMu/h?= =?iso-8859-1?Q?XcYy2Pw2yA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: BL7i2wd/OSvE3lJt4mcPKro18y+6tFGzA3Dhv8S/vStiPMe+3JvOxQn5jA3kGy9cECmOL2CHv/sot4EmnDNAB3nlY6XJPjzfjzPTScyceuJ0w4RGFpCEAz89dZSlI0suEMhsb44CJKKeby3HvWqD1orjQw06CbhBWme8T+I9PCHGZ3MSLEvCeLO6Id9Eo7w3XVfT7grCxqPZhBxoPpNWvGzlgtKe9XCCNHP+rHcvlBSLWMfJIXwvHNqZ4SKC5RDkaOhl6FiI126+rk4rKpxp3vT/S1dzLPxz8NL0DKFNrWdKs9cVFyz5Yl9s2yv/xCF7la9EbySvYrxf+PX/exstow== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1704b6a-1cdd-485f-fd1b-08de7f3f8194 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2026 07:26:26.6589 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zpkFqRXLui64skOdalzEeovdCeeVgWuQZwFFzzm5ZiJx06D/gDNSm6ivXkA66qkgQnfFOGo5f5xm4dX4nlYIgMoFktXYuXPntW2Y+rBA6u0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6082 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1773214080341154100 Content-Type: text/plain; charset="utf-8" EHCI supports 64-bit control data structure addressing when the 64-bit Addressing Capability bit in HCCPARAMS is set. In that mode, the CTRLDSSEGMENT register provides the upper 32 bits that are concatenated with 32-bit link pointer values to form full 64-bit descriptor addresses (EHCI 1.0, section 2.3.5 and Appendix B). iTD link pointers are stored as 32-bit values and must be expanded to full 64-bit descriptor addresses when 64-bit mode is enabled. Update the iTD traversal path to use ehci_get_desc_addr() when following link pointers. Appendix B also defines high dword fields for iTD buffer pointers. Add bufptr_hi[7] to EHCIitd and use ehci_get_buf_addr() to construct full 64-bit buffer addresses from bufptr[] and bufptr_hi[] fields when processing isochronous transfers. This allows buffers above 4GB to be handled correctly. When 64-bit capability is disabled, descriptor and buffer addresses remain 32-bit and existing behaviour is unchanged. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.h | 1 + hw/usb/hcd-ehci.c | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index df16426f76..f0cb50ba45 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -73,6 +73,7 @@ typedef struct EHCIitd { #define ITD_BUFPTR_MAXPKT_SH 0 #define ITD_BUFPTR_MULT_MASK 0x00000003 #define ITD_BUFPTR_MULT_SH 0 + uint32_t bufptr_hi[7]; } EHCIitd; =20 /* diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 5964ede05b..a4a45c7601 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1471,7 +1471,8 @@ static int ehci_process_itd(EHCIState *ehci, return -1; } =20 - ptr1 =3D (itd->bufptr[pg] & ITD_BUFPTR_MASK); + ptr1 =3D ehci_get_buf_addr(ehci, itd->bufptr_hi[pg], + itd->bufptr[pg], ITD_BUFPTR_MASK); qemu_sglist_init(&ehci->isgl, ehci->device, 2, ehci->as); if (off + len > 4096) { /* transfer crosses page border */ @@ -1479,7 +1480,9 @@ static int ehci_process_itd(EHCIState *ehci, qemu_sglist_destroy(&ehci->isgl); return -1; /* avoid page pg + 1 */ } - ptr2 =3D (itd->bufptr[pg + 1] & ITD_BUFPTR_MASK); + ptr2 =3D ehci_get_buf_addr(ehci, itd->bufptr_hi[pg + 1], + itd->bufptr[pg + 1], + ITD_BUFPTR_MASK); uint32_t len2 =3D off + len - 4096; uint32_t len1 =3D len - len2; qemu_sglist_add(&ehci->isgl, ptr1 + off, len1); @@ -1768,7 +1771,7 @@ static int ehci_state_fetchitd(EHCIState *ehci, int a= sync) =20 put_dwords(ehci, NLPTR_GET(entry), (uint32_t *) &itd, sizeof(EHCIitd) >> 2); - ehci_set_fetch_addr(ehci, async, itd.next); + ehci_set_fetch_addr(ehci, async, ehci_get_desc_addr(ehci, itd.next)); ehci_set_state(ehci, async, EST_FETCHENTRY); =20 return 1; --=20 2.43.0